[Bug 1426465] Review Request: libiio - Library for Industrial IO
https://bugzilla.redhat.com/show_bug.cgi?id=1426465 --- Comment #10 from Eric Smith --- In reply to Mamoru TASAKA from comment 8: I most certainly CAN choose not to review a package for any arbitrary reason, including that I can't build it locally. IF I don't want to review packages that have the letter "w" in the the package name, that's my prerogative. I am under no obligation to review any package. I can't REJECT a package that I review for an arbitrary reason. That's an entirely different matter than choosing not to review the package. > Your current comment is not valid for making this review request block > dead-review, lefting. You misunderstand why I restored the block of dead-review. It had nothing to do with the fact that I couldn't build it locally. The review is dead because the packager has not responded to any of the issues that were brought up by the previous reviewer. Even with your taking over the review, at the moment the package review is still dead because the packager still has not responded to the reviewer's comments from 2017-03-26. The review should remain blocking dead-review until the packager responds in a substantive way, rather than only stating that the review is not dead. However, since you've taken over the review task, it's up to you to follow the review rules. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1463492] Review Request: koko - container connector
https://bugzilla.redhat.com/show_bug.cgi?id=1463492 srakitnican changed: What|Removed |Added Flags|needinfo?(samuel.rakitnican | |@gmail.com) | --- Comment #13 from srakitnican --- (In reply to Dan Williams from comment #12) > Samuel, any chance you could look at the latest files? Is there anything > left to do on this review? Thanks! In my opinion format of the spec file looks good now, it is waiting for someone who knows a bit more about go to review that part, as I am not sure how this should be done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1093500] Review Request: clasp - A conflict-driven nogood learning answer set solver
https://bugzilla.redhat.com/show_bug.cgi?id=1093500 Ben Rosser changed: What|Removed |Added CC||log...@cottsay.net Flags|needinfo?(i...@cicku.me) |needinfo?(log...@cottsay.ne ||t) --- Comment #11 from Ben Rosser --- Ping. aspcud is the recommended external depsolver for opam, the OCaml package manager. I've been taking over work on packaging opam (that got stalled back in 2015), and it would be nice to be able to get aspcud and its dependency stack into Fedora too. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews, please respond soon if you're still interested in these reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478210] Review Request: openas2 - Java implementation of EDIINT AS2
https://bugzilla.redhat.com/show_bug.cgi?id=1478210 --- Comment #9 from Stuart D Gathman --- Spec URL: https://gathman.org/linux/SPECS/openas2.spec SRPM URL: https://gathman.org/linux/f25/src/openas2-2.3.1-1.fc25.src.rpm Updated to new upstream release. Moved data (spool files) to /var/spool/openas2 - again with a symlink so upstream config still works. Fix some rpmlint issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #13 from Yunying Sun --- Thanks Robert-Andre for the review and approve. I updated SPEC with the source0 url in your comment. * Wed Aug 16 2017 Sun Yunying - 1.1.0-5 - Updated source0 URL to fix rpmlint warnings Spec URL: https://raw.githubusercontent.com/yunyings/share/master/tpm2-abrmd.spec SRPM URL: https://github.com/yunyings/share/raw/master/tpm2-abrmd-1.1.0-5.el7.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21253304 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481913] Review Request: ocaml-zed - Abstract engine for text edition in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1481913 --- Comment #1 from Ben Rosser --- zed requires jbuilder to build (see https://bugzilla.redhat.com/show_bug.cgi?id=1481912). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481913] Review Request: ocaml-zed - Abstract engine for text edition in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1481913 Ben Rosser changed: What|Removed |Added Depends On||1481912 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1481912 [Bug 1481912] Review Request: jbuilder - A composable build system for OCaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481913] New: Review Request: ocaml-zed - Abstract engine for text edition in OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1481913 Bug ID: 1481913 Summary: Review Request: ocaml-zed - Abstract engine for text edition in OCaml Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rosser@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://tc01.fedorapeople.org/ocaml/utop/ocaml-zed.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/utop/ocaml-zed-1.5-2.fc26.src.rpm Description: Zed is an abstract engine for text edition. It can be used to write text editors, edition widgets, readlines, ... You just have to connect an engine to your inputs and rendering functions to get an editor. Zed provides: edition state management, multiple cursor support, key-binding helpers, and general purpose unicode rope manipulation functions. Fedora Account System Username: tc01 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1481912 Ben Rosser changed: What|Removed |Added Blocks||1481913 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1481913 [Bug 1481913] Review Request: ocaml-zed - Abstract engine for text edition in OCaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481912] New: Review Request: jbuilder - A composable build system for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1481912 Bug ID: 1481912 Summary: Review Request: jbuilder - A composable build system for OCaml Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rosser@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://tc01.fedorapeople.org/ocaml/jbuilder/jbuilder.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/jbuilder/jbuilder-1.0-0.2.beta11.fc26.src.rpm Description: Jbuilder is a build system designed for OCaml/Reason projects only. It focuses on providing the user with a consistent experience and takes care of most of the low-level details of OCaml compilation. All you have to do is provide a description of your project and Jbuilder will do the rest. The scheme it implements is inspired from the one used inside Jane Street and adapted to the open source world. It has matured over a long time and is used daily by hundred of developpers, which means that it is highly tested and productive. Fedora Account System Username: tc01 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431235] Review Request: python3-virtualenv - Tool to create isolated Python environments
https://bugzilla.redhat.com/show_bug.cgi?id=1431235 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python3-virtualenv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431235] Review Request: python3-virtualenv - Tool to create isolated Python environments
https://bugzilla.redhat.com/show_bug.cgi?id=1431235 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python3-virtualenv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476489] Review Request: xfce4-statusnotifier-plugin - Panel area status notifier plugin for Xfce4
https://bugzilla.redhat.com/show_bug.cgi?id=1476489 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- xfce4-statusnotifier-plugin-0.1.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ec2d397fa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478461] Review Request: PyDrive - A wrapper library of google-api-python-client that simplifies many common Google Drive API tasks
https://bugzilla.redhat.com/show_bug.cgi?id=1478461 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- PyDrive-1.3.1-2.fc26, duplicity-0.7.13.1-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8ebb30441c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1427634] Review Request: syncthing - Continuous File Synchronization
https://bugzilla.redhat.com/show_bug.cgi?id=1427634 --- Comment #35 from Fedora Update System --- syncthing-0.14.36-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-af8b6b4204 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468454] Review Request: php-pecl-timecop - Time travel and freezing extension
https://bugzilla.redhat.com/show_bug.cgi?id=1468454 --- Comment #11 from Fedora Update System --- php-pecl-timecop-1.2.8-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e7544403ce -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431235] Review Request: python3-virtualenv - Tool to create isolated Python environments
https://bugzilla.redhat.com/show_bug.cgi?id=1431235 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Neal Gompa --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431235] Review Request: python3-virtualenv - Tool to create isolated Python environments
https://bugzilla.redhat.com/show_bug.cgi?id=1431235 --- Comment #3 from Neal Gompa --- Review notes: * Package is named appropriately (source and binary for EPEL) * Package follows Fedora packaging guidelines and extended EPEL ones * Package follows Python 3 packaging guidelines for EPEL * Package builds and installs correctly * Some rpmlint errors, see below: rpmlint errors: python34-virtualenv.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/virtualenv_support/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-virtualenv.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/virtualenv_support/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-virtualenv.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/__pycache__/virtualenv.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-virtualenv.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/__pycache__/virtualenv.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) I don't think these are real errors, and are probably something wrong with rpmlint. Other than this, it looks good! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431235] Review Request: python3-virtualenv - Tool to create isolated Python environments
https://bugzilla.redhat.com/show_bug.cgi?id=1431235 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #2 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481876] New: Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1481876 Bug ID: 1481876 Summary: Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ke...@scrye.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://www.scrye.com/~kevin/fedora/review/python-pytest-shutil/python-pytest-shutil.spec SRPM URL: http://www.scrye.com/~kevin/fedora/review/python-pytest-shutil/python-pytest-shutil-1.2.6-1.fc27.src.rpm Description: This library is a goodie-bag of Unix shell and environment management tools for automated tests. Fedora Account System Username: kevin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1427634] Review Request: syncthing - Continuous File Synchronization
https://bugzilla.redhat.com/show_bug.cgi?id=1427634 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #34 from Fedora Update System --- syncthing-0.14.36-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-407a2d92db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468454] Review Request: php-pecl-timecop - Time travel and freezing extension
https://bugzilla.redhat.com/show_bug.cgi?id=1468454 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- php-pecl-timecop-1.2.8-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc6482c5c9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher
https://bugzilla.redhat.com/show_bug.cgi?id=1431868 Bug 1431868 depends on bug 1427634, which changed state. Bug 1427634 Summary: Review Request: syncthing - Continuous File Synchronization https://bugzilla.redhat.com/show_bug.cgi?id=1427634 What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481237] Review Request: cmu-ipc: message passing between local processes or over TCP
https://bugzilla.redhat.com/show_bug.cgi?id=1481237 --- Comment #2 from Ye Cheng <18969068...@163.com> --- Thank you very much for your comments, I will try to address these issues in the next build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1479027
--- Comment #11 from Athos Ribeiro ---
(In reply to Fabio Valentini from comment #10)
> 1) There are some minor typos / spelling errors which you might want to
> correct (line 44: provite->provide, line 275: skiping-> skipping).
>
Fixed
> 2) Since you are packaging this go library for two import paths, I guess
> that both are used by dependencies. In this case, using two -devel
> subpackages seems reasonable.
OK
>
> 3) There are some empty conditionals leftover from the gofed template. You
> can leave them in with comments that they might be needed one day, or just
> remove them.
>
I learned it is better to keep those to reduce the diff if I ever need to
re-generate the spec with gofed
> 4) "%global devel_prefix x" this isn't needed anywhere.
>
Fixed: removed the global.
> 5) It looks like most/all of the testdata is listed in %files sections
> multiple times ("warning: File listed twice:" warnings in the koji build
> logs). You might want to look at the %install script to find out how this
> happens.
Fixed, thanks for catching that!
Spec URL:
https://athoscr.fedorapeople.org/packaging/golang-github-golang-image.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/golang-github-golang-image-0-0.1.20170514.git426cfd8.fc26.src.rpm
Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21250259
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library
https://bugzilla.redhat.com/show_bug.cgi?id=1462443 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #17 from Fedora Update System --- libaec-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fb600d5f60 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481682] Review Request: platform-python - A Python interpreter for basic system tools
https://bugzilla.redhat.com/show_bug.cgi?id=1481682 --- Comment #7 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/platform-python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481682] Review Request: platform-python - A Python interpreter for basic system tools
https://bugzilla.redhat.com/show_bug.cgi?id=1481682 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/platform-python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #1 from Raphael Groner --- Hi Dridi, are you interested in a review swap, maybe you can look into bug #1462467? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480960] Review Request: golang-github-BurntSushi-xgb - XGB is the X protocol Go language Binding
https://bugzilla.redhat.com/show_bug.cgi?id=1480960 --- Comment #7 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-BurntSushi-xgb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480967] Review Request: golang-github-alecthomas-units - Helpful unit multipliers and functions for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480967 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-units -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480967] Review Request: golang-github-alecthomas-units - Helpful unit multipliers and functions for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480967 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-units -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480960] Review Request: golang-github-BurntSushi-xgb - XGB is the X protocol Go language Binding
https://bugzilla.redhat.com/show_bug.cgi?id=1480960 --- Comment #8 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-BurntSushi-xgb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480970] Review Request: golang-github-alecthomas-colour - Quake-style colour formatting for Unix terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1480970 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-colour -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1463492] Review Request: koko - container connector
https://bugzilla.redhat.com/show_bug.cgi?id=1463492 Dan Williams changed: What|Removed |Added Flags||needinfo?(samuel.rakitnican ||@gmail.com) --- Comment #12 from Dan Williams --- Samuel, any chance you could look at the latest files? Is there anything left to do on this review? Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481046] Review Request: python-html5-parser - A fast, standards compliant, C based, HTML 5 parser for python
https://bugzilla.redhat.com/show_bug.cgi?id=1481046 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #1 from Raphael Groner --- Hi Kevin, are you interested in a review swap, maybe you can look into bug #1481775? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480970] Review Request: golang-github-alecthomas-colour - Quake-style colour formatting for Unix terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1480970 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-colour -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481237] Review Request: cmu-ipc: message passing between local processes or over TCP
https://bugzilla.redhat.com/show_bug.cgi?id=1481237 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #1 from Raphael Groner --- Some general comments to your spec file: - Have you tried to send the patches to upstream? If yes, please note in a comment and you should add comments what those patches do. - According to the python guidelines, the subpackage must be called python2-cmu-ipc instead of cmu-ipc-python2. - Is it possible to build for python3, too? - Descriptions must split into several lines with line feeds. - Please use BR: java-devel instead of explicitly enforce java version 1.8 . - According to our java guidelines, add to the java subpackage: Require: java-headless - In %build you can use one line '%make_build install -S -C src' instead of additional cd . - Why is there no install script provided by upstream? Did you ask for some? - Changelog format is wrong. Must remove the single dash at the end and add a leading dash before the comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958 --- Comment #13 from Christoph Junghans --- (In reply to Antonio Trande from comment #12) > $ mock --no-clean -r fedora-rawhide-x86_64 --shell 'rpmlint lammps-mpich; > ldd /usr/lib64/mpich/bin/lmp' > INFO: mock.py version 1.4.3 starting (python version = 3.6.2)... > lammps-mpich.x86_64: W: spelling-error %description -l en_US biomolecules -> > bio molecules, bio-molecules, molecules > lammps-mpich.x86_64: W: spelling-error %description -l en_US mesoscopic -> > microscopic > lammps-mpich.x86_64: W: spelling-error %description -l en_US meso -> mes, > meson, mess > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Allgather > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Cart_create > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Bcast > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Op_create > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Send > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_sync > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Isend > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Initialized > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Scatterv > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Cart_shift > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_set_size > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Type_contiguous > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Scatter > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_open > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Type_free > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Barrier > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_read_at > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Group_incl > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Sendrecv > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Finalize > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Request_free > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Gather > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Rsend > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Recv > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Comm_group > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Comm_create > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Cart_get > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_get_size > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Abort > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_write_at > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Get_version > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Scan > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Get_processor_name > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Comm_size > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Waitall > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Reduce_scatter > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Error_string > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Allreduce > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Allgatherv > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Type_commit > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Wtime > lammps-mpich.x86_64: W: undefined-non-weak-symbol > /usr/lib64/mpich/lib/liblammps.so.0 MPI_Type_size >
[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1469331 --- Comment #47 from Fedora Update System --- fedrepo-req-1.3.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2bf593c298 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958 --- Comment #12 from Antonio Trande --- $ mock --no-clean -r fedora-rawhide-x86_64 --shell 'rpmlint lammps-mpich; ldd /usr/lib64/mpich/bin/lmp' INFO: mock.py version 1.4.3 starting (python version = 3.6.2)... lammps-mpich.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-mpich.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-mpich.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Allgather lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Cart_create lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Bcast lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Op_create lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Send lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_sync lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Isend lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Initialized lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Scatterv lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Cart_shift lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_set_size lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Type_contiguous lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Scatter lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_open lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Type_free lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Barrier lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_read_at lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Group_incl lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Sendrecv lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Finalize lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Request_free lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Gather lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Rsend lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Recv lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Comm_group lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Comm_create lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Cart_get lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_get_size lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Abort lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_write_at lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Get_version lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Scan lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Get_processor_name lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Comm_size lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Waitall lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Reduce_scatter lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Error_string lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Allreduce lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Allgatherv lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Type_commit lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Wtime lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Type_size lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_Reduce lammps-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/liblammps.so.0 MPI_File_write_at_all lammps-mpich.x86_64: W: undefine
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958
--- Comment #11 from Christoph Junghans ---
(In reply to Antonio Trande from comment #10)
> (In reply to Christoph Junghans from comment #9)
> > (In reply to Antonio Trande from comment #8)
> > > Okay.
> > >
> > > - Another issue: MPI libraries and binary files are not compiled with
> > > related MPI compilers. Use
> > >
> > > export CC=mpicc
> > > export CXX=mpicxx
> > > export FC=mpif90
> > > export F77=mpif77
> > >
> > > before running '%cmake ...' commands; so
> > >
> > > cd openmpi
> > > %{_openmpi_load}
> > > export CC=mpicc
> > > export CXX=mpicxx
> > > export FC=mpif90
> > > export F77=mpif77
> > > %{cmake3} \
> > > %{defopts} \
> > > -DENABLE_MPI=ON \
> > > -DENABLE_MPIIO=ON \
> > > -DCMAKE_INSTALL_BINDIR=$MPI_BIN \
> > > -DCMAKE_INSTALL_LIBDIR=$MPI_LIB \
> > > ../cmake
> > > %make_build
> > > %{_openmpi_unload}
> > > cd ..
> > I think that is not needed, LAMMPS's cmake uses find_package(MPI) and then
> > injects the MPI include dir (e.g. -I/usr/include/openmpi-x86_64) and the MPI
> > library (e.g. /usr/lib64/openmpi/lib/libmpi_cxx.so) automatically.
> >
> > >
>
> Yes, instead.
> Check, for example, the MPIs 'lmp' dependencies and you'll see that they're
> not correctly linked to the MPI libraries.
Where do you see that?
In build.log (from
https://kojipkgs.fedoraproject.org//work/tasks/5046/21245046/build.log), it
says:
[100%] Linking CXX executable lmp
/usr/bin/cmake -E cmake_link_script CMakeFiles/lmp.dir/link.txt --verbose=1
/usr/bin/c++ -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic
-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -rdynamic
CMakeFiles/lmp.dir/builddir/build/BUILD/lammps-patch_11Aug2017/src/main.cpp.o
-o lmp
-Wl,-rpath,/builddir/build/BUILD/lammps-patch_11Aug2017/openmpi:/usr/lib64/openmpi/lib:
liblammps.so.0 /usr/lib64/openmpi/lib/libmpi_cxx.so
/usr/lib64/openmpi/lib/libmpi.so -lfftw3 -lpython3.6m -ljpeg -lpng -lz -lm
(for openmpi)
[100%] Linking CXX executable lmp
/usr/bin/cmake -E cmake_link_script CMakeFiles/lmp.dir/link.txt --verbose=1
/usr/bin/c++ -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic
-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -rdynamic
CMakeFiles/lmp.dir/builddir/build/BUILD/lammps-patch_11Aug2017/src/main.cpp.o
-o lmp
-Wl,-rpath,/builddir/build/BUILD/lammps-patch_11Aug2017/mpich:/usr/lib64/mpich/lib:
liblammps.so.0 /usr/lib64/mpich/lib/libmpicxx.so /usr/lib64/mpich/lib/libmpi.so
-lfftw3 -lpython3.6m -ljpeg -lpng -lz -lm
(for mpich)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 --- Comment #51 from jiri vanek --- hmm. atch was needed for new rpmbuild in f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=21249544 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958
--- Comment #10 from Antonio Trande ---
(In reply to Christoph Junghans from comment #9)
> (In reply to Antonio Trande from comment #8)
> > Okay.
> >
> > - Another issue: MPI libraries and binary files are not compiled with
> > related MPI compilers. Use
> >
> > export CC=mpicc
> > export CXX=mpicxx
> > export FC=mpif90
> > export F77=mpif77
> >
> > before running '%cmake ...' commands; so
> >
> > cd openmpi
> > %{_openmpi_load}
> > export CC=mpicc
> > export CXX=mpicxx
> > export FC=mpif90
> > export F77=mpif77
> > %{cmake3} \
> > %{defopts} \
> > -DENABLE_MPI=ON \
> > -DENABLE_MPIIO=ON \
> > -DCMAKE_INSTALL_BINDIR=$MPI_BIN \
> > -DCMAKE_INSTALL_LIBDIR=$MPI_LIB \
> > ../cmake
> > %make_build
> > %{_openmpi_unload}
> > cd ..
> I think that is not needed, LAMMPS's cmake uses find_package(MPI) and then
> injects the MPI include dir (e.g. -I/usr/include/openmpi-x86_64) and the MPI
> library (e.g. /usr/lib64/openmpi/lib/libmpi_cxx.so) automatically.
>
> >
Yes, instead.
Check, for example, the MPIs 'lmp' dependencies and you'll see that they're not
correctly linked to the MPI libraries.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958
--- Comment #9 from Christoph Junghans ---
(In reply to Antonio Trande from comment #8)
> Okay.
>
> - Another issue: MPI libraries and binary files are not compiled with
> related MPI compilers. Use
>
> export CC=mpicc
> export CXX=mpicxx
> export FC=mpif90
> export F77=mpif77
>
> before running '%cmake ...' commands; so
>
> cd openmpi
> %{_openmpi_load}
> export CC=mpicc
> export CXX=mpicxx
> export FC=mpif90
> export F77=mpif77
> %{cmake3} \
> %{defopts} \
> -DENABLE_MPI=ON \
> -DENABLE_MPIIO=ON \
> -DCMAKE_INSTALL_BINDIR=$MPI_BIN \
> -DCMAKE_INSTALL_LIBDIR=$MPI_LIB \
> ../cmake
> %make_build
> %{_openmpi_unload}
> cd ..
I think that is not needed, LAMMPS's cmake uses find_package(MPI) and then
injects the MPI include dir (e.g. -I/usr/include/openmpi-x86_64) and the MPI
library (e.g. /usr/lib64/openmpi/lib/libmpi_cxx.so) automatically.
>
> - Use 'Requires: openmpi' and 'Requires: mpich' for related lammps-*mpi*
> packages.
Will do.
>
> - Add python_provide macro to the Python sub-package
> https://fedoraproject.org/wiki/Packaging:Python#Provides
Will do.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1479027
--- Comment #10 from Fabio Valentini ---
Initial comments:
1) There are some minor typos / spelling errors which you might want to correct
(line 44: provite->provide, line 275: skiping-> skipping).
2) Since you are packaging this go library for two import paths, I guess that
both are used by dependencies. In this case, using two -devel subpackages seems
reasonable.
3) There are some empty conditionals leftover from the gofed template. You can
leave them in with comments that they might be needed one day, or just remove
them.
4) "%global devel_prefix x" this isn't needed anywhere.
5) It looks like most/all of the testdata is listed in %files sections multiple
times ("warning: File listed twice:" warnings in the koji build logs). You
might want to look at the %install script to find out how this happens.
By the way, you don't have to bump the Release tag for me if you fix minor
things I pointed out above.
I will provide a more comprehensive review (with fedora-review's help) once the
golang-googlecode-text package update will hit the rawhide repo mirrors.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958
--- Comment #8 from Antonio Trande ---
Okay.
- Another issue: MPI libraries and binary files are not compiled with related
MPI compilers. Use
export CC=mpicc
export CXX=mpicxx
export FC=mpif90
export F77=mpif77
before running '%cmake ...' commands; so
cd openmpi
%{_openmpi_load}
export CC=mpicc
export CXX=mpicxx
export FC=mpif90
export F77=mpif77
%{cmake3} \
%{defopts} \
-DENABLE_MPI=ON \
-DENABLE_MPIIO=ON \
-DCMAKE_INSTALL_BINDIR=$MPI_BIN \
-DCMAKE_INSTALL_LIBDIR=$MPI_LIB \
../cmake
%make_build
%{_openmpi_unload}
cd ..
- Use 'Requires: openmpi' and 'Requires: mpich' for related lammps-*mpi*
packages.
- Add python_provide macro to the Python sub-package
https://fedoraproject.org/wiki/Packaging:Python#Provides
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 --- Comment #50 from jiri vanek --- https://koji.fedoraproject.org/koji/taskinfo?taskID=21249016 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 Athos Ribeiro changed: What|Removed |Added Depends On||1479027 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1479027 [Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 Bug 1465889 depends on bug 1480969, which changed state. Bug 1480969 Summary: Review Request: golang-googlecode-image - Supplementary Go image libraries https://bugzilla.redhat.com/show_bug.cgi?id=1480969 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480969] Review Request: golang-googlecode-image - Supplementary Go image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1480969 Athos Ribeiro changed: What|Removed |Added Status|NEW |CLOSED CC||athoscribe...@gmail.com Resolution|--- |DUPLICATE Last Closed||2017-08-15 15:45:38 --- Comment #3 from Athos Ribeiro --- Hello guys, I believe this is a duplicate of BZ#1479027. I am closing this as such. Feel free to reopen in case I am mistaken. Also, any help in the other bug is welcome! :) *** This bug has been marked as a duplicate of bug 1479027 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Athos Ribeiro changed: What|Removed |Added Blocks||1465889 ||(DeepinDEPackageReview) CC||sensor@gmail.com --- Comment #9 from Athos Ribeiro --- *** Bug 1480969 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #8 from Fabio Valentini --- I'll look at it again right now! By the way, is this (https://bugzilla.redhat.com/show_bug.cgi?id=1480969) a review request for the same go library? If so, you might tell them that your request has been opened earlier and should take precendence. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #7 from Athos Ribeiro --- I opened an issue upstream [1] and am skipping the failing tests for now. Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-golang-image.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-golang-image-0-0.2.20170514.git426cfd8.fc26.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21248420 [1] https://github.com/golang/go/issues/21460 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480971] Review Request: golang-github-alecthomas-assert - Fork of stretchr/testify/ assert that uses FailNow
https://bugzilla.redhat.com/show_bug.cgi?id=1480971 --- Comment #2 from sensor@gmail.com --- Diff: https://github.com/FZUG/repo/commit/a49fef8526fee8f8c27048bf48d94508d2e658da Thanks, i fixed it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480969] Review Request: golang-googlecode-image - Supplementary Go image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1480969 --- Comment #2 from sensor@gmail.com --- I refer to the golang-googlecode-text package and it splits. I think both ways can be work. https://src.fedoraproject.org/rpms/golang-googlecode-text/blob/master/f/golang-googlecode-text.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 --- Comment #49 from jiri vanek --- https://koji.fedoraproject.org/koji/taskinfo?taskID=21248379 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480279] Review Request: python-avocado-lts - Framework with tools and libraries for Automated Testing (LTS branch)
https://bugzilla.redhat.com/show_bug.cgi?id=1480279 Stephen Gallagher changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #2 from Stephen Gallagher --- Sorry, set that flag by mistake. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480279] Review Request: python-avocado-lts - Framework with tools and libraries for Automated Testing (LTS branch)
https://bugzilla.redhat.com/show_bug.cgi?id=1480279 Stephen Gallagher changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481682] Review Request: platform-python - A Python interpreter for basic system tools
https://bugzilla.redhat.com/show_bug.cgi?id=1481682 Stephen Gallagher changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Stephen Gallagher --- OK, I reviewed this by inspection (because fedora-review can't handle it). In brief: things look fine to me, all licenses and legalities appear to be in order and the diff from the python3 package looks completely sane. I'm comfortable approving this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library
https://bugzilla.redhat.com/show_bug.cgi?id=1174036
Ben Rosser changed:
What|Removed |Added
CC||rosser@gmail.com
--- Comment #11 from Ben Rosser ---
Since the package review was approved, it was proposed on the devel list that
this just get imported.
However, the spec and SRPM are no longer available from the links above, and
there have been several new releases of ocaml-re since 2015. (Also, I needed a
build of ocaml-re to start looking at ocaml-dose, another opam dependency).
I grabbed a copy of the spec from Jon's copr repository:
http://copr-dist-git.fedorainfracloud.org/cgit/jonludlam/opam/ocaml-re.git/plain/ocaml-re.spec?h=f23,
and updated the version to 1.7.1.
I had to make a minor modification or two to get it to build from that version
of the spec; there's (now?) a configure script upstream, which I just invoked
directly. However the documentation gets put in the wrong place
(%{buildroot}%{_docdir}/re rather than .../ocaml-re), so I remove it in
%install and install it manually.
Otherwise, I made no changes to Jon's package.
Spec URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-re.spec
SRPM URL:
https://tc01.fedorapeople.org/ocaml/opam/ocaml-re-1.7.1-1.fc26.src.rpm
I can open a new review, if you'd prefer.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476438] Review Request: clustersos - collect multiple sosreports simultaneously
https://bugzilla.redhat.com/show_bug.cgi?id=1476438 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476438] Review Request: clustersos - collect multiple sosreports simultaneously
https://bugzilla.redhat.com/show_bug.cgi?id=1476438 --- Comment #11 from Fedora Update System --- clustersos-1.1.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-38dd117277 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1454951] Review Request: python-bitcoin - Python Bitcoin Tools
https://bugzilla.redhat.com/show_bug.cgi?id=1454951 --- Comment #2 from Jonny Heggheim --- (In reply to František Zatloukal from comment #1) > I see multiple "non-executable-script" Errors in rpmlint. Mark files as > executable (chmod a+x) or follow > https://fedoraproject.org/wiki/ > Packaging_tricks#Remove_shebang_from_Python_libraries (depends on nature of > file). Thanks, updated the spec file: Spec URL: https://jonny.fedorapeople.org/python-bitcoin.spec SRPM URL: https://jonny.fedorapeople.org/python-bitcoin-1.1.42-1.fc26.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21248194 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480279] Review Request: python-avocado-lts - Framework with tools and libraries for Automated Testing (LTS branch)
https://bugzilla.redhat.com/show_bug.cgi?id=1480279 --- Comment #1 from Stephen Gallagher --- I discussed this issue with Merlin on IRC. This package conflicts with the main python-avocado SRPM in unfortunate ways. In addition, given the rate of change in that package, it may be a better idea to simply package *ONLY* the LTS release as python-avocado and drop this package entirely. If it is important to have both, then one or the other needs to be completely namespaced such that they can be installed in parallel. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481682] Review Request: platform-python - A Python interpreter for basic system tools
https://bugzilla.redhat.com/show_bug.cgi?id=1481682 --- Comment #4 from Stephen Gallagher --- Spec URL: https://raw.githubusercontent.com/fedora-python/python3/platform_python/platform-python.spec SRPM URL: https://raw.githubusercontent.com/torsava/python3-1/platform_python_srpm/platform-python-3.6.2-10.fc27.src.rpm Apparently fedora-review drops the arguments. So here's the paths to the actual raw content. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481682] Review Request: platform-python - A Python interpreter for basic system tools
https://bugzilla.redhat.com/show_bug.cgi?id=1481682 --- Comment #3 from Stephen Gallagher --- Spec URL: https://github.com/fedora-python/python3/blob/platform_python/platform-python.spec?raw=true SRPM URL: https://github.com/torsava/python3-1/blob/platform_python_srpm/platform-python-3.6.2-10.fc27.src.rpm?raw=true Adding 'raw=true' to the URL so `fedora-review` will work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465130] Review Request: nuvola-app-8tracks - 8tracks for Nuvola Player 3
https://bugzilla.redhat.com/show_bug.cgi?id=1465130 mgans...@alice.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2017-08-15 14:42:51 --- Comment #8 from mgans...@alice.de --- package has been built successfully on f25, f26 and rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 jiri vanek changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #48 from jiri vanek --- ...and building... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478358] Review Request: php-sebastian-diff2 - Diff implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1478358 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478358] Review Request: php-sebastian-diff2 - Diff implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1478358 --- Comment #8 from Fedora Update System --- php-sebastian-comparator2-2.0.2-1.fc26 phpunit6-6.3.0-1.fc26 php-sebastian-diff2-2.0.1-1.fc26 php-phpunit-diff-1.4.3-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2b910cc8ad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481775] Review Request: python-jep - Embed Python in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1481775 Raphael Groner changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1477362] Review Request: ocaml-opam-file-format - Parser and printer for the opam file syntax
https://bugzilla.redhat.com/show_bug.cgi?id=1477362 --- Comment #1 from Ben Rosser --- Modernized the package with the comments from the cmdliner review: - Modernize ocaml packaging, use macro for testing native compiler. - Remove manual invocation of ocaml dependency generator. - Add -g to ocamlc, ocamlopt invocations, but this still doesn't make debuginfo. - Use global instead of define for libname macro. Spec URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-opam-file-format.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-opam-file-format-2.0.0-0.2.beta3.fc26.src.rpm Unfortunately despite passing -g to ocamlc and ocamlopt, debuginfo doesn't get generated here, either. (The opam-file-format build is a lot simpler, it just invokes ocamlc and ocamlopt by hand). I'm not sure why. I did confirm that the .o files have debuginfo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480967] Review Request: golang-github-alecthomas-units - Helpful unit multipliers and functions for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480967
Robert-André Mauchin (afk until next Thu) changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin (afk until next Thu)
---
Everything's ok, package accepted.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 6 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/golang-github-alecthomas-units/review-
golang-github-alecthomas-units/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/alecthomas(golang-github-alecthomas-
repr-devel, golang-github-alecthomas-colour-devel, golang-github-
alecthomas-units-devel, golang-github-alecthomas-template-devel,
golang-github-alecthomas-assert-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in
[Bug 1480972] Review Request: golang-github-BurntSushi-xgbutil - XGB is the X protocol Go language Binding
https://bugzilla.redhat.com/show_bug.cgi?id=1480972 --- Comment #2 from sensor@gmail.com --- Diff: https://github.com/FZUG/repo/commit/6fc22dad1d732901c0e762511562f8fbc4c9603c Thanks, github-BurntSushi-freetype-go and github-BurntSushi-graphics-go were approved. I will submit spec alter. https://bugzilla.redhat.com/show_bug.cgi?id=1480958 https://bugzilla.redhat.com/show_bug.cgi?id=1480959 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958
--- Comment #7 from Christoph Junghans ---
(In reply to Antonio Trande from comment #6)
> BuildRequires: python-devel ??
Done
>
> Processing files: python3-lammps-20170811-1.fc27.x86_64
> RPM build errors:
> error: File must begin with "/": %{python3_sitelib}/lammps.py*
> error: File must begin with "/": %{python3_sitelib}/__pycache__/lammps.*
> File must begin with "/": %{python3_sitelib}/lammps.py*
> File must begin with "/": %{python3_sitelib}/__pycache__/lammps.*
>
>
> You need python3-devel and, please, rebuild your src package with mock or
> koji before commit a new packaging release.
My mistake:
Spec URL: https://fedorapeople.org/~junghans/lammps.spec
SRPM URL: https://fedorapeople.org/~junghans/lammps-20170811-2.fc25.src.rpm
Build on f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21245043
Build on epel7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21244974
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404895] Review Request: partclone - File System Clone Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1404895 --- Comment #15 from Robert-André Mauchin (afk until next Thu) --- > if we have to rip thecode from the source tarball I don't think this is necessary. > we could build the "binary" in question ourself and ship it as %SOURCE1 ourself Honestly I'm not certain what is the correct procedure in this case, maybe you should ask on fedora-devel for opinions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481775] Review Request: python-jep - Embed Python in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1481775 --- Comment #1 from Raphael Groner --- Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=21245207 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481775] New: Review Request: python-jep - Embed Python in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1481775 Bug ID: 1481775 Summary: Review Request: python-jep - Embed Python in Java Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: projects...@smart.ms QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://raphgro.fedorapeople.org//python-jep.spec SRPM URL: http://raphgro.fedorapeople.org//python-jep-3.7.0-1.fc26.src.rpm Description: Java Embedded Python JEP embeds CPython in Java through JNI and is safe to use in a heavily threaded environment. Some benefits of embedding CPython in a JVM: Using the native Python interpreter may be much faster than alternatives. Python is mature, well supported, and well documented. Access to high quality Python modules, both native CPython extensions and Python-based. Compilers and assorted Python tools are as mature as the language. Python is an interpreted language, enabling scripting of established Java code without requiring recompilation. Both Java and Python are cross platform, enabling deployment to different operating system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #9 from Ben Rosser --- > The final link doesn't include -g so that's one problem: I've fixed this by passing -lflag -g to ocamlbuild, which does add -g to the link step (though as far as I can see, this shouldn't be necessary...), e.g. according to the build log: ocamlfind ocamlopt -a -g -package bytes src/cmdliner_suggest.cmx src/cmdliner_trie.cmx src/cmdliner_base.cmx src/cmdliner_manpage.cmx src/cmdliner_info.cmx src/cmdliner_docgen.cmx src/cmdliner_msg.cmx src/cmdliner_cline.cmx src/cmdliner_term.cmx src/cmdliner_arg.cmx src/cmdliner.cmx -o src/cmdliner.cmxa However... this still did not solve the problem. But then I, on a weird hunch, removed the "chmod -x" line from the install step and, magically, debuginfo was found... So I've made the chmod more granular to only set -x on the files RPM was actually complaining about and now everything seems to work! > As long as MIT is compatible with the license, then that's fine. Uh, my bad. :) For some reason I thought ISC == MIT (and indeed, they are very similar) but looking at our guidelines the "ISC" tag should be used here. So I'll just use License: ISC instead. Here's the new version: Spec URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-cmdliner.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-cmdliner-1.0.2-3.fc26.src.rpm - Fix debuginfo generation by not blindly chmod -x all the files. - Pass -g to the link step of ocamlbuild as well as the compilation step. - Use ocaml_natdynlink macro to determine when to compile the *.cmxs files. - Modify the makefile to use install -p instead of just install. - Switch License tag to the more correct ISC license. - Added parallel build macro to make invocation. - Made libname macro a global rather than a define. Should the natdylink library be in the -devel package instead of the main package? Currently it gets included in the main package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480960] Review Request: golang-github-BurntSushi-xgb - XGB is the X protocol Go language Binding
https://bugzilla.redhat.com/show_bug.cgi?id=1480960 Robert-André Mauchin (afk until next Thu) changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Robert-André Mauchin (afk until next Thu) --- Sorry one last thing, there one directory under WTFPL: do What The Fuck you want to Public License (v2) xgb-27f122750802c950b2c869a5b63dafcf590ced95/xgbgen/COPYING You should add it in the license tag with a comment explaining which license covers what: # Everything under BSD except xgbgen Licence: BSD and WTFPL Otherwise everything is good. Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475961] Review Request: cmrt - C for Media Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1475961 --- Comment #8 from Fedora Update System --- cmrt-1.0.6-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e727a51e23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475961] Review Request: cmrt - C for Media Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1475961 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479073] Review Request: tcl-tclnagios - Library to simplify writing Nagios plugins in Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1479073 --- Comment #8 from Fedora Update System --- tcl-tclnagios-1.3-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a3c6361bc6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 --- Comment #47 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/java-9-openjdk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 --- Comment #46 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/java-9-openjdk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1259416] Review Request: pipewire - Share cameras and other multimedia streams
https://bugzilla.redhat.com/show_bug.cgi?id=1259416 --- Comment #14 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pipewire -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1259416] Review Request: pipewire - Share cameras and other multimedia streams
https://bugzilla.redhat.com/show_bug.cgi?id=1259416 --- Comment #13 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pipewire -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480960] Review Request: golang-github-BurntSushi-xgb - XGB is the X protocol Go language Binding
https://bugzilla.redhat.com/show_bug.cgi?id=1480960 --- Comment #5 from sensor@gmail.com --- Diff: https://github.com/FZUG/repo/commit/56174a271cfa86b1817de4a7e71567c2927b6907 SPEC: https://raw.githubusercontent.com/FZUG/repo/56174a271cfa86b1817de4a7e71567c2927b6907/rpms/deepin_project/golang-github-BurntSushi-xgb.spec Thanks~ i fix it again. Other spec may be same problem, i will check again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 --- Comment #45 from jiri vanek --- (In reply to Severin Gehwolf from comment #44) > I'm approving this request. Jiri will make the javadoc-zips an archful > package to account for the jaot differences which is an x86_64 only Linux > feature upstream at this point. Ty. + move configs to /etc once Ihave it fully tested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481682] Review Request: platform-python - A Python interpreter for basic system tools
https://bugzilla.redhat.com/show_bug.cgi?id=1481682 Miro Hrončok changed: What|Removed |Added Blocks||1479272 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1479272 [Bug 1479272] Platform Python Stack -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1426465] Review Request: libiio - Library for Industrial IO
https://bugzilla.redhat.com/show_bug.cgi?id=1426465 Mamoru TASAKA changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 Severin Gehwolf changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #44 from Severin Gehwolf --- I'm approving this request. Jiri will make the javadoc-zips an archful package to account for the jaot differences which is an x86_64 only Linux feature upstream at this point. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1426465] Review Request: libiio - Library for Industrial IO
https://bugzilla.redhat.com/show_bug.cgi?id=1426465
Mamoru TASAKA changed:
What|Removed |Added
CC||mtas...@fedoraproject.org
--- Comment #9 from Mamoru TASAKA ---
By the way:
* Latest version
- 0.10 is now available.
* License tag
- Although "README.md" says this is under LGPLv2+,
"mainpage.dox" says this is under LGPLv2.
While this needs clarification, currently the rpm
license tag must be "LGPLv2", which is safer.
* Forbidden code
https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code
- I think the license terms in bindings/matlab/*.m
(e.g. bindings/matlab/iio_sys_obj.m):
-
% - Use of the software either in source or binary form or filter designs
%resulting from the use of this software, must be connected to, run
%on or loaded to an Analog Devices Inc. component.
-
is non-free license limitation and unacceptable for Fedora.
If these files are not actually used, remove these files
from source rpm (not only from binary rpm) and repackage
tarball.
* Compiler
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
- When using C compiler, "BuildRequires: gcc" (or something) is now *MUST*.
* _noarch_ package dependency
- Currently build fails:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21239042
-
BuildError: The following noarch package built differently on different
architectures: python3-iio-0.9-1.fc27.noarch.rpm
rpmdiff output was:
removed REQUIRES libiio(x86-64) = 0.9-1.fc27
added REQUIRES libiio(ppc-64) = 0.9-1.fc27
-
_noarch_ package must not have arch-specific dependency.
This means that python3-iio subpackage must not have
%{?_isa} specific Requires, which introduces arch-specific
Requires dependency.
* Directory ownership
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
- /usr/lib/python3.6/site-packages/__pycache__ is already owned by
system-python-libs.
python3-iio must not own this directory.
* Documentation installation
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
- Quote:
-
use of %doc with relative paths and installation of files directly into
%_pkgdocdir in the same source package is forbidden.
-
This means that you must not use
%doc README.md (this is relative)
and
%doc %{_docdir}/%{name}/html (actually using %_pkgdocdir, this is absolute)
in the same source rpm, because actually this has caused many troubles in
the
past and now packaging guideline explicitly forbit this usage.
You must choose either of the below:
1. cp README.md into %{buildroot}%{_pkgdocdir} at %install manually
2. rm -rf %{buildroot}%{_pkgdocdir} at %install, and use
%doc html/ (relative).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 Severin Gehwolf changed: What|Removed |Added CC||jerb...@gmail.com Assignee|sgehw...@redhat.com |jerb...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478705] Review Request: deepin-calendar - Calendar for Deepin Desktop Environment
https://bugzilla.redhat.com/show_bug.cgi?id=1478705 Zamir SUN changed: What|Removed |Added Status|MODIFIED|POST --- Comment #9 from Zamir SUN --- I submitted to a wrong bodhi... Change back. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476489] Review Request: xfce4-statusnotifier-plugin - Panel area status notifier plugin for Xfce4
https://bugzilla.redhat.com/show_bug.cgi?id=1476489 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476489] Review Request: xfce4-statusnotifier-plugin - Panel area status notifier plugin for Xfce4
https://bugzilla.redhat.com/show_bug.cgi?id=1476489 --- Comment #10 from Fedora Update System --- xfce4-statusnotifier-plugin-0.1.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ec2d397fa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480969] Review Request: golang-googlecode-image - Supplementary Go image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1480969
Robert-André Mauchin (afk until next Thu) changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin (afk until next Thu)
---
Hello,
You should not split the package in two different devel: unify everything under
one -devel, but with the two lists of Provides. Then symlink:
%{gopath}/src/%{provider}.%{provider_tld}/%{project} to the other one:
%{gopath}/src/%{x_provider}.%{x_provider_tld}/%{project}
And don't forget to add those %dir in the %files section.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404895] Review Request: partclone - File System Clone Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1404895 --- Comment #14 from Robert Scheck --- (In reply to Robert-André Mauchin (afk until next Thu) from comment #13) > You already said it, we can't ship exfat-utils, so we can't activate support > for it. I am sorry for being unprecise: My thoughts were about if we have to rip the code from the source tarball, thus if we have to create a custom tarball, e.g. like the openssl package. > >fail-mbr.bin.orig > As far as I know, we can't ship prepackaged binaries, so we must built it in > the SPEC. If it's only available on i386/x86_64, use the appropriate %ifarch > macro. Well, we could build the "binary" in question ourself and ship it as %SOURCE1 ourself (that's what Debian does); in the end it's a simple small binary with mostly NULL bytes (< 450 bytes in total), thus more or less easy to verify. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
