[Bug 1478064] Review Request: nuvola-app-logitech-media-server - Logitech Media Server for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478064

Vít Ondruch  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Vít Ondruch  ---
It seems that all the issues mentioned in nuvola-app-jupiter-broadcasting
review [1] applies to this package as well. But these are just minor nits =>
APPROVED. Please fix the issues prior importing into Fedora.


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1483963#c1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478064] Review Request: nuvola-app-logitech-media-server - Logitech Media Server for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478064

Vít Ondruch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|vondr...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Vít Ondruch  ---
I'll take this for a review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426896] Review Request: ghc-file-embed - Use Template Haskell to embed file contents directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426896

Elliott Sales de Andrade  changed:

   What|Removed |Added

  Alias||ghc-file-embed



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 662281] Review Request: ghc-file-embed - Use Template Haskell to embed file contents directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=662281

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com
  Alias|ghc-file-embed  |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
greenwave-0.1.1-1.02795e8.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2aed05b3c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426896] Review Request: ghc-file-embed - Use Template Haskell to embed file contents directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426896

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Elliott Sales de Andrade  ---
rpmlint does note that haskell should be Haskell, but otherwise this looks good
and is APPROVED.

fedora-review output below:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "Unknown or generated". 8 files have unknown
 license. Detailed output of licensecheck in
 1426896-ghc-file-embed/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 102400 bytes in 14 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.

[Bug 1476438] Review Request: clustersos - collect multiple sosreports simultaneously

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476438

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-23 23:51:11



--- Comment #13 from Fedora Update System  ---
clustersos-1.1.1-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483499] Review Request: gnome-remote-desktop - Remote desktop server for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483499



--- Comment #10 from Jonas Ådahl  ---
With fixed date in spec changelog:

srpm:
https://copr-be.cloud.fedoraproject.org/results/jadahl/gnome-remote-desktop/fedora-rawhide-x86_64/00593478-gnome-remote-desktop/gnome-remote-desktop-0.1.2-2.fc28.src.rpm
spec:
https://copr-be.cloud.fedoraproject.org/results/jadahl/gnome-remote-desktop/fedora-rawhide-x86_64/00593478-gnome-remote-desktop/gnome-remote-desktop.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166



--- Comment #14 from Fedora Update System  ---
fstransform-0.9.3-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8d38c5b2e6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166



--- Comment #13 from Fedora Update System  ---
fstransform-0.9.3-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9f1825da7f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480825] Review Request: python-pytest-forked - py.test plugin for running tests in isolated forked subprocesses

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480825

Scott Talbert  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-08-23 23:16:57



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #4 from Scott Talbert  ---
(In reply to Kevin Fenzi from comment #3)
> Yeah it builds fine in koji here: 
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=21332425
> 
> Were you building locally or in mock? 
> I don't think I am missing any buildrequires or it wouldnt work in koji
> either...

Building in mock via fedora-review.  It does seem to build fine now, must have
been some transient bad state in rawhide or something.  Now, though, when
fedora-review tries to install the package, it puts dnf into some sort of 100%
CPU loop.  Don't know exactly what's going on there.  :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477



--- Comment #5 from Fedora Update System  ---
greenwave-0.1.1-1.02795e8.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2aed05b3c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 925993] Review Request: ghc-yesod-core - Yesod core library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=925993

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #6 from Elliott Sales de Andrade  ---
I can take this review when clientsession is available. The spec is for an
outdated version though.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256051] Review Request: ghc-sandi - Data encoding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256051



--- Comment #6 from Elliott Sales de Andrade  ---
Spec is also for an outdated version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256086] Review Request: ghc-tls - TLS/ SSL protocol native implementation (Server and Client)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256086

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #3 from Elliott Sales de Andrade  ---
Still 404 and package is outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483499] Review Request: gnome-remote-desktop - Remote desktop server for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483499



--- Comment #9 from Jonas Ådahl  ---
New srpm:
https://copr-be.cloud.fedoraproject.org/results/jadahl/gnome-remote-desktop/fedora-rawhide-x86_64/00593476-gnome-remote-desktop/gnome-remote-desktop-0.1.2-2.fc28.src.rpm

New spec:
https://copr-be.cloud.fedoraproject.org/results/jadahl/gnome-remote-desktop/fedora-rawhide-x86_64/00593476-gnome-remote-desktop/gnome-remote-desktop.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256090] Review Request: ghc-http-client-tls - Http-client backend using the connection package and tls library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256090

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #3 from Elliott Sales de Andrade  ---
Still 404 and also is outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256076] Review Request: ghc-asn1-types - ASN.1 types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256076

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #3 from Elliott Sales de Andrade  ---
Spec is still 404 and is also outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484336] Review Request: libx86emu - x86 emulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484336

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com



--- Comment #2 from Neal Gompa  ---
Lubomir: Hey, you beat me to it! :)

You might want to incorporate some of what I did for libx86emu[1] and hwinfo[2]
into your specs, and I ask you consider building for EPEL7 along with Fedora
branches (so that my python-kiwi package can build EL7 images with kiwi initrd
for oemboot stuff).

I'd also be happy to be co-maintainer if it's okay with you. :)

[1]:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00593473-libx86emu/libx86emu.spec

[2]:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00593474-hwinfo/hwinfo.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256073] Review Request: ghc-http-client - An HTTP client engine, intended as a base layer for more user-friendly packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256073

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #4 from Elliott Sales de Andrade  ---
Spec is still 404 and is also outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256091] Review Request: ghc-http-conduit - HTTP client package with conduit interface and HTTPS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256091



--- Comment #4 from Elliott Sales de Andrade  ---
Spec is outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256083] Review Request: ghc-x509 - X509 reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256083

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404 and outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256085] Review Request: ghc-x509-validation - X.509 Certificate and CRL validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256085

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404 and outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256087] Review Request: ghc-x509-system - Handle per-operating-system X.509 accessors and storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256087

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404 and outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256084] Review Request: ghc-x509-store - X.509 collection accessing and storing methods

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256084

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404 and outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256080] Review Request: ghc-pem - Privacy Enhanced Mail (PEM) format reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256080

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256088] Review Request: ghc-socks - Socks proxy (version 5) implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256088

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404 and outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256056] Review Request: ghc-memory - Memory and related abstraction functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256056

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #3 from Elliott Sales de Andrade  ---
Spec is 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256075] Review Request: ghc-hourglass - Simple performant time related library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256075

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256089] Review Request: ghc-connection - Simple and easy network connections API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256089

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404 and outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256059] Review Request: ghc-feed - Interfacing with RSS (v 0.9x, 2.x , 1.0) + Atom feeds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256059

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #3 from Elliott Sales de Andrade  ---
Spec is 404 and outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256055] Review Request: ghc-cryptonite - Cryptography Primitives sink

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256055

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #3 from Elliott Sales de Andrade  ---
Spec is 404 and very outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 630276] Review Request: ghc-clientsession - Store session data in a cookie

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=630276

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #9 from Elliott Sales de Andrade  ---
Spec is 404; also an outdated version.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1329834] Review Request: ghc-cipher-aes - Fast AES cipher implementation with advanced mode of operations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329834

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #1 from Elliott Sales de Andrade  ---
Spec is 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256079] Review Request: ghc-asn1-parse - Simple monadic parser for ASN1 stream types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256079

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256077] Review Request: ghc-asn1-encoding - ASN1 data reader and writer in RAW, BER and DER forms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256077

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Spec is 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1236364] Review Request: ghc-comonad - Comonads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1236364

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com



--- Comment #5 from Elliott Sales de Andrade  ---
Version is outdated; can you update?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1236364] Review Request: ghc-comonad - Comonads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1236364

Elliott Sales de Andrade  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481237] Review Request: cmu-ipc: message passing between local processes or over TCP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481237



--- Comment #4 from Ye Cheng <18969068...@163.com> ---
(In reply to Ye Cheng from comment #3)

New spec URL:
https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-i386/00593461-cmu-ipc/cmu-ipc.spec

New srpm URL:
https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-i386/00593461-cmu-ipc/cmu-ipc-3.9.1a-1.fc28.src.rpm

> The java-cmu-ipc package provides and requires
> lib/Linux-4.11/libipcjava.so.3.9()(64bit) at the same time, and the location
> indicated by rpmbuild is its location at builddir instead of its installed
> location indicated in the install and file section. This seems to be
> erroneous, but I don't know what happened.
Sorry the wrong “path" is because of my malformed soname but java-cmu-ipc still
require and provides libipcjava.so.3.9 at the same time.
python2 or python3 package do not have similar issue.
Log is available at
https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-i386/00593461-cmu-ipc/build.log.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471885] Review Request: oci-umount - OCI umount hook for docker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471885



--- Comment #10 from Fedora Update System  ---
oci-umount-2.0.0-2.gitf90b64c.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-94e852e79d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166



--- Comment #12 from Fedora Update System  ---
fstransform-0.9.3-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-872be06842

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471885] Review Request: oci-umount - OCI umount hook for docker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471885

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
oci-umount-2.0.0-2.gitf90b64c.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-333f924756

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
fstransform-0.9.3-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5284fd387d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483202] Review Request: golang-github-mattn-go-shellwords - Parse line as shell words

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483202

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
golang-github-mattn-go-shellwords-1.0.3-3.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6148bdb031

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483308] Review Request: pgzero - A zero-boilerplate 2D games framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483308

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
pgzero-1.1-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a6119d4d5d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #2 from chucks.8...@gmail.com ---
Thanks. I'll get that fixed up. Quick question: because this is a development
library, should I add the suffix "-devel" to my package or not?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484226] Review Request: python-zict - Mutable mapping tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484226



--- Comment #2 from Elliott Sales de Andrade  ---
Those were actually optional test dependencies which I've now enabled since
python-lmdb is available on F26+.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/dask/fedora-rawhide-x86_64/00593450-python-zict/python-zict.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/dask/fedora-rawhide-x86_64/00593450-python-zict/python-zict-0.1.2-3.fc28.src.rpm
Description: Zict builds abstract MutableMapping classes that consume and build
on other MutableMappings. They can be composed with each other to form
intuitive interfaces over complex storage systems policies.
Fedora Account System Username: qulogic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468454] Review Request: php-pecl-timecop - Time travel and freezing extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468454



--- Comment #13 from Fedora Update System  ---
php-pecl-timecop-1.2.8-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476440] Review Request: gimp-luminosity-masks - Luminosity mask channels plug-in for Gimp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476440



--- Comment #14 from Fedora Update System  ---
gimp-luminosity-masks-0-3.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634



--- Comment #37 from Fedora Update System  ---
syncthing-0.14.36-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484219] Review Request: python-partd - Appendable key-value storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484219



--- Comment #2 from Elliott Sales de Andrade  ---
I'm pretty sure %{python2_version} is only useful on EPEL (which I wasn't
really planning on adding) because there are no other releases of Python 2 on
Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484223] Review Request: python-tblib - Traceback serialization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484223



--- Comment #2 from Elliott Sales de Andrade  ---
It looks like the Provides part is automatic and using the R/BR is just a
nice-to-have, not a requirement, isn't it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484222] Review Request: no-more-secrets - A recreation of the " decrypting text" effect from the 1992 movie Sneakers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484222



--- Comment #2 from Mark McKinstry  ---
* I'm not sure how to create a meaningful name for the archive.

* I added in the CFLAGS but used the %{optflags} macro instead which includes
the -g flag. The Makefile doesn't have an option for CXXFLAGS so I left that
out.

* I switched to the %make_install macro .

* I removed rm -rf %{buildroot} .

spec:
https://mmckinst.fedorapeople.org/packages/no-more-secrets/no-more-secrets.spec

srpm:
https://mmckinst.fedorapeople.org/packages/no-more-secrets/no-more-secrets-0.3.2-2.fc25.src.rpm

copr:
https://copr.fedorainfracloud.org/coprs/mmckinst/no-more-secrets/build/593434/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Group: Development/Tools
The "Group:" tag should not be used.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>License:   GPL+
"GPL+" should only be used when upstream doesn't specify the licence version.
You're using GPL v3 or later, so the tag should be "GPLv3+".
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448687] Review Request: nodejs-is-obj - Check if a value is an object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448687

Jared Smith  changed:

   What|Removed |Added

  Flags|needinfo?(jsmith.fedora@gma |
   |il.com) |



--- Comment #5 from Jared Smith  ---
Sorry for the delay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448687] Review Request: nodejs-is-obj - Check if a value is an object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448687

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-08-23 18:45:02



--- Comment #4 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448688] Review Request: nodejs-dot-prop - Get, set, or delete a property from a nested object using a dot path

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448688
Bug 1448688 depends on bug 1448687, which changed state.

Bug 1448687 Summary: Review Request: nodejs-is-obj - Check if a value is an 
object
https://bugzilla.redhat.com/show_bug.cgi?id=1448687

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484561] Review Request: python-ludolph - Monitoring Jabber Bot with Zabbix support, completely written in Python.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484561



--- Comment #6 from Miro Hrončok  ---
9) Also, please add the following provide to python3 subpackage, so users can
just `dnf install ludolph`:

Provides: %{pypi_name} = %{version}-%{release}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484561] Review Request: python-ludolph - Monitoring Jabber Bot with Zabbix support, completely written in Python.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484561



--- Comment #5 from Miro Hrončok  ---
8) There are 3 tests that run quite fine, please add a %check section that runs
them both for python2 and python3 (note that you'll need to BuildRequire all
the runtime Requires as well as the test runner (python2/3-nose)).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484561] Review Request: python-ludolph - Monitoring Jabber Bot with Zabbix support, completely written in Python.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484561



--- Comment #4 from Miro Hrončok  ---
4) seems to be entirely OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419715] Review Request: hwcrypto-native - enable digital signature for Chrome and Firefox > 52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419715

Levente Farkas  changed:

   What|Removed |Added

 CC||lfar...@lfarkas.org



--- Comment #7 from Levente Farkas  ---
any update with this package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467003] Review Request: libgpiod - C library and tools for interacting with linux GPIO char device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467003



--- Comment #12 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libgpiod. You may create the branch "f27"
using git in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484561] Review Request: python-ludolph - Monitoring Jabber Bot with Zabbix support, completely written in Python.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484561



--- Comment #3 from Miro Hrončok  ---
Also, when following 3, the python2 subpackage does not need to require
systemd.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484561] Review Request: python-ludolph - Monitoring Jabber Bot with Zabbix support, completely written in Python.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484561



--- Comment #2 from Miro Hrončok  ---
Thanks for your contribution to Fedora :) Quick peek at the specfile:

1) this is there twice:

BuildRequires:  systemd

2) The %post, %preun, %postun as written would happen on the "main" package
python-ludolph, but there is not such package built here, use %post
python3-%{pypi_name} etc. to make them work with the package owning the
%{_unitdir}/ludolph.service file:

%post python3-%{pypi_name}
%systemd_post ludolph.service

...

You would also need to do this for the python2 subpackage, but see 3.


3) The %{_unitdir}/ludolph.service generally shouldn't be in both subpackages.
The service calls /usr/bin/ludolph and that is only in the python3 subpackage.
Having the file in both packages thus makes no sense. Also, a common file
across 2 subpackages is almost always painful. I.e. if both packages are
installed, they need to be in the same version-release, otherwise dnf/rpm would
scream on us "File xyz form python2-... conflicts with file from python3-..." -
rule of thumb -> avoid it when possible. Here it is possible and also easy. if
not avoidable, create a common subpackage required by both subpackages needing
the file (not relevant here).


4) The ghost config file is also shared and honestly I don't know if shared
ghost files are problematic or not. Will investigate.


5) the systemd service file talks about /run/ludolph/ludolph.pid - and the
package doesn't own /run/ludolph. I've looked at avahi (similar case), where
/run/avahi-daemon/ belongs to the avahi package and it is a ghost (%ghost %dir
%{_localstatedir}/run/avahi-daemon). The file inside does not belong to
anything. Now I don't have a guideline here to quite, but what avahi does seems
reasonable and others do it in similar way.


(And the following are more curious questions, based of what I've seen last
time we talked about this IRL.)

6) the package seems not to do anything about tmpfiles.d. Does it work?

7) no selinux problems?



Otherwise the specfile look legible. Will do a full review once we finish this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484561] Review Request: python-ludolph - Monitoring Jabber Bot with Zabbix support, completely written in Python.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484561

Miro Hrončok  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mhron...@redhat.com
 Blocks|177841 (FE-NEEDSPONSOR) |
   Assignee|nob...@fedoraproject.org|mhron...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Miro Hrončok  ---
Will review the package and eventually sponsor Richard. I know him from real
life.

LiftingFE-NEEDSPONSOR.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484561] Review Request: python-ludolph - Monitoring Jabber Bot with Zabbix support, completely written in Python.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484561

Richard Kellner  changed:

   What|Removed |Added

URL||https://github.com/erigones
   ||/Ludolph
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484561] New: Review Request: python-ludolph - Monitoring Jabber Bot with Zabbix support, completely written in Python.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484561

Bug ID: 1484561
   Summary: Review Request: python-ludolph - Monitoring Jabber Bot
with Zabbix support, completely written in Python.
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: richard.kell...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/erigones/Ludolph/master/rpmbuild/SPECS/python-ludolph.spec
SRPM URL:
https://github.com/erigones/Ludolph/raw/master/rpmbuild/SRPMS/python-ludolph-1.0.1-1.fc26.src.rpm
Description: Monitoring Jabber Bot with Zabbix support, completely written in
Python.

Features
* Simple and modular design
* Alerts from Zabbix
* Multi-User Chat (XEP-0045)
* Colorful messages (XEP-0071)
* Attention (XEP-0224)
* Avatars (XEP-0084)
* Roster management and ACL configuration
* Webhooks and Cron jobs
* Plugins and commands

Fedora Account System Username: ricco

I am a co-creator of this bot and also an active developer and a package
maintainer at GitHub. Repository: https://github.com/erigones/Ludolph 

This is my first package to Fedora, but hopefully not last and I will be able
to find a sponsor. The bot has support to easily write plugins in Python, and
my intention is to package some of the plugins as RPMs as well. 

Koji builds:
f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=21427587
f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=21427631
f28: https://koji.fedoraproject.org/koji/taskinfo?taskID=21427756
rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=21427917

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480972] Review Request: golang-github-BurntSushi-xgbutil - XGB is the X protocol Go language Binding

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480972

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
I thought I had already done it, but now it's ok, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476489] Review Request: xfce4-statusnotifier-plugin - Panel area status notifier plugin for Xfce4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476489

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-23 15:54:30



--- Comment #12 from Fedora Update System  ---
xfce4-statusnotifier-plugin-0.1.0-1.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468454] Review Request: php-pecl-timecop - Time travel and freezing extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468454

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-23 15:54:05



--- Comment #12 from Fedora Update System  ---
php-pecl-timecop-1.2.8-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431868
Bug 1431868 depends on bug 1427634, which changed state.

Bug 1427634 Summary: Review Request: syncthing - Continuous File Synchronization
https://bugzilla.redhat.com/show_bug.cgi?id=1427634

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-08-14 09:57:28 |2017-08-23 15:53:55



--- Comment #36 from Fedora Update System  ---
syncthing-0.14.36-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-23 15:53:48



--- Comment #26 from Fedora Update System  ---
danmaq-0.2-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476440] Review Request: gimp-luminosity-masks - Luminosity mask channels plug-in for Gimp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476440

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-23 15:53:52



--- Comment #13 from Fedora Update System  ---
gimp-luminosity-masks-0-3.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480971] Review Request: golang-github-alecthomas-assert - Fork of stretchr/testify/ assert that uses FailNow

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480971



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-alecthomas-assert

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421063] Review Request: deepin-gir-generator - Generate static golang bindings for GObject

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421063

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #5 from Robert-André Mauchin  ---
@mosquito: Could you please build this package in Koji? I fixed the ownership
issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421046



--- Comment #8 from sensor@gmail.com ---
$ fedrepo-req golang-github-BurntSushi-xgbutil -t 1480972
Error: The Bugzilla ticket is not approved yet

golang-github-BurntSushi-xgbutil is not approve. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #9 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00593068-deepin-api/deepin-api.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00593068-deepin-api/deepin-api-3.1.11-2.fc26.src.rpm

I review and added some golang packages with gofed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,


 - MIT/X is not a valid Fedora license. Please consult the list of available
licenses here:
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
Here just MIT is sufficient:

License:MIT

 - Please use %python2dist/%python3dist macros when you can. See:
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

%if 0%{?with_doc}
BuildRequires:  python2dist(sphinx)
BuildRequires:  python2dist(incremental)
%endif
BuildRequires:  python2dist(setuptools)

BuildRequires:  python3-devel
BuildRequires:  python3dist(setuptools)

 And:

Requires:   python2dist(requests) >= 2.1.0
Requires:   python2dist(six)
Requires:   python2dist(twisted) >= 16.3.0
Requires:   python2dist(attrs)

 And:

Requires:   python3dist(requests) >= 2.1.0
Requires:   python3dist(six)
Requires:   python3dist(twisted) >= 16.3.0
Requires:   python3dist(attrs)

 - Your description lines are too long, they should be below 80 characters per
line.

 -  In generate html doc, change export PYTHONPATH to:

export PYTHONPATH=%{python2_sitelib}:%{python3_sitelib}:src

Otherwise sphinx-build fails to find the imported modules.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 58 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-treq/review-python-
 treq/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not 

[Bug 1359416] Review Request: gawk-xml - XML support for gawk

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359416



--- Comment #14 from Andrew Schorr  ---
Thanks David. I am changing the spec file to say "License: GPL+ and GPLv3+". 
I guess we may as well keep it in the GPL family.

After I commit these changes, I will generate a new version that fixes the
licensing issues and includes a simple man page for xmlgawk.1. The man page
says:

XMLGAWK(1) Utility Commands XMLGAWK(1)



NAME
   xmlgawk - gawk XML wrapper script


SYNOPSIS
   xmlgawk gawk options...


DESCRIPTION
   xmlgawk  is  a trivial wrapper script that invokes gawk with the xmllib
   library by inserting the  argument  -ixmllib  before  the  command-line
   arguments supplied by the user.


SEE ALSO
   info xmlgawk


ACKNOWLEDGEMENTS
   The script and library were originally written by Stefan Tramm.



Gawkextlib Project  Mon Aug 21 2017 XMLGAWK(1)

Does that look OK? I did a quick search for "Fedora man page guidelines" and
didn't find anything...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467003] Review Request: libgpiod - C library and tools for interacting with linux GPIO char device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467003

Vitaly Zaitsev  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #11 from Vitaly Zaitsev  ---
> This is completely unrelated to a package review and IMO is hence irrelevant, 
> it's something to be addressed with upstream.

This can be easily patched in %%prep:
sed -i 's/AC_PROG_LIBTOOL/LT_INIT([disable-static])/' configure.ac

Everything seems to be OK. The package is now approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166

mpr...@redhat.com  changed:

   What|Removed |Added

 CC||mpr...@redhat.com



--- Comment #10 from mpr...@redhat.com  ---
Please disregard my comment from above. This was testing in staging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166



--- Comment #9 from mpr...@redhat.com  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.stg.fedoraproject.org/rpms/fstransform

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484305] Review Request: dtkwm - Deepin graphical user interface library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484305



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/dtkwm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421063] Review Request: deepin-gir-generator - Generate static golang bindings for GObject

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421063



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-gir-generator

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484336] Review Request: libx86emu - x86 emulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484336

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,


 - The Group: tag is not needeed in Fedora, please remove it (twice). See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - You -devel subpackage must depend on the main package:

Requires:   %{name}%{?_isa} = %{version}-%{release}

 - Change make %{?_smp_mflags} into %make_build

 - Please change Source0: to:

Source0:   
https://github.com/wfeldt/libx86emu/archive/%{version}/%{name}-%{version}.tar.gz

 - You forgot to run ldconfig for you *.so files. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

%post -p /sbin/ldconfig


%postun -p /sbin/ldconfig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402446] Review Request: php-nikic-php-parser3 - A PHP parser written in PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402446

Shawn Iwinski  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-08-23 13:14:21



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484331] Review Request: python-incremental - Incremental is a small library that versions your Python projects.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484331

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
No issue, package accepted.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 22 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/python-
 incremental/review-python-incremental/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-incremental , python3-incremental
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description 

[Bug 1484316] Review Request: php-cs-fixer-accessible-object - A library to reveal object internals

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484316



--- Comment #1 from Remi Collet  ---
Spec:
https://git.remirepo.net/cgit/rpms/php/php-cs-fixer/php-cs-fixer-accessible-object.git/plain/php-cs-fixer-accessible-object.spec?id=a666feda0781c3286823652fbded865dcd00fad1

Srpm:
http://rpms.remirepo.net/SRPMS/php-cs-fixer-accessible-object-1.0.0-3.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484305] Review Request: dtkwm - Deepin graphical user interface library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484305

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Perfect, package accepted.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 13 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/dtkwm/review-dtkwm/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/include/libdtk-2.0
 (dtkwidget-devel, dtkcore-devel, dtkwm-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned 

[Bug 1484421] Review Request: fwts - Firmware Test Suite

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484421



--- Comment #2 from Benjamin Berg  ---
Thanks!

I have not included the README_SOURCE.txt with a comment as it is not really
useful in the binary package.

https://koji.fedoraproject.org/koji/taskinfo?taskID=21423208

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484226] Review Request: python-zict - Mutable mapping tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484226

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,


Please remove the commented and unnecessary BR.

If you can, please use the %python2dist/%python3dist macros. See
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

BuildRequires:  python2dist(pytest) python3-pytest
BuildRequires:  python2dist(heapdict) python3dist(heapdict)


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated", "*No copyright* BSD
 (unspecified)". 26 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/python-zict/review-python-
 zict/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane 

[Bug 1484218] Review Request: python-heapdict - A heap with decrease-key and increase-key operations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484218

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Everything is okay, package accepted.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated", "*No copyright* BSD
 (unspecified)". 10 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/python-heapdict/review-
 python-heapdict/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-heapdict , python3-heapdict
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: 

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166



--- Comment #8 from Fedora Update System  ---
fstransform-0.9.3-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8d38c5b2e6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166



--- Comment #7 from Fedora Update System  ---
fstransform-0.9.3-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-872be06842

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166



--- Comment #6 from Fedora Update System  ---
fstransform-0.9.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5284fd387d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484166] Review Request: fstransform - Tool for in-place file-system conversion without backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484166



--- Comment #5 from Fedora Update System  ---
fstransform-0.9.3-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9f1825da7f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org