[Bug 1485458] Review Request: orangefs - parallel network file system ( formerly PVFS2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485458

Neal Gompa  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #25 from Neal Gompa  ---
I have sponsored Martin Brandenburg into the Packager group.

Martin, welcome to the Fedora packagers team! You may now do the fedrepo-req
requests, per the process documentation[1].

[1]:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500072] Review Request: macromilter - Milter to check mails for suspicious Microsoft VBA macro code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500072



--- Comment #6 from Fedora Update System  ---
macromilter-3.3-1.20171009git4e8295f.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0fe0ed4ce2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500072] Review Request: macromilter - Milter to check mails for suspicious Microsoft VBA macro code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500072



--- Comment #5 from Fedora Update System  ---
macromilter-3.3-1.20171009git4e8295f.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9c37660a0a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500072] Review Request: macromilter - Milter to check mails for suspicious Microsoft VBA macro code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500072



--- Comment #4 from Fedora Update System  ---
macromilter-3.3-1.20171009git4e8295f.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-908d39fa3a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500072] Review Request: macromilter - Milter to check mails for suspicious Microsoft VBA macro code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500072

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505374] Review Request: python-oletools - Tools to analyze Microsoft OLE2 files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505374



--- Comment #12 from Fedora Update System  ---
python-oletools-0.51-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-890b45e723

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505374] Review Request: python-oletools - Tools to analyze Microsoft OLE2 files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505374



--- Comment #11 from Fedora Update System  ---
python-oletools-0.51-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-24faeb196e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505374] Review Request: python-oletools - Tools to analyze Microsoft OLE2 files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505374

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505374] Review Request: python-oletools - Tools to analyze Microsoft OLE2 files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505374



--- Comment #10 from Fedora Update System  ---
python-oletools-0.51-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-904ab0975e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505374] Review Request: python-oletools - Tools to analyze Microsoft OLE2 files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505374



--- Comment #9 from Robert Scheck  ---
Zbigniew, thank you very much for the review! Suggestions were applied.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #11 from mgans...@alice.de  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qxtglobalshortcut.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qxtglobalshortcut-0.0.1-0.4.20171021git1644620.fc26.src.rpm

%changelog
* Tue Oct 24 2017 Martin Gansser  -
0.0.1-0.4.20171021git1644620
- Add BR cmake
- Add BR pkgconfig(Qt5Widgets)

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22680117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505993] Review Request: python-feedgen - Feed Generator (ATOM, RSS, Podcasts)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505993

Randy Barlow  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #1 from Randy Barlow  ---
Just one minor suggestion that you can ignore if you prefer: you can define a
%global for the description so you don't have to repeat it. I do this for some
of my Python packages. Here's an example:

https://src.fedoraproject.org/rpms/python-pylons-sphinx-themes/blob/master/f/python-pylons-sphinx-themes.spec

Again, feel free to ignore, no big deal.

APPROVED!


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "GPL (v3)", "Unknown or generated". 40 files
 have unknown license. Detailed output of licensecheck in
 /home/rbarlow/reviews/1505993-python-feedgen/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if 

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591

Raphael Groner  changed:

   What|Removed |Added

 Whiteboard||FTBFS



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #10 from Raphael Groner  ---
Please please test your stuff before filing requests!

Therefore it's always a good idea to provide some link to a koji scratch build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505993] Review Request: python-feedgen - Feed Generator (ATOM, RSS, Podcasts)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505993

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ra...@electronsweatshop.com
   Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #9 from Raphael Groner  ---
Still FTBFS:

CMake Warning at cmake/qt5.cmake:1 (find_package):
  By not providing "FindQt5Widgets.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "Qt5Widgets", but CMake did not find one.
  Could not find a package configuration file provided by "Qt5Widgets" with
  any of the following names:
Qt5WidgetsConfig.cmake
qt5widgets-config.cmake
  Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set
  "Qt5Widgets_DIR" to a directory containing one of the above files.  If
  "Qt5Widgets" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  cmake/qt.cmake:4 (include)
  CMakeLists.txt:29 (include)
-- Configuring incomplete, errors occurred!
See also
"/builddir/build/BUILD/qxtglobalshortcut-16446200b699e0610b8a5fb20b74938225d81d87/CMakeFiles/CMakeOutput.log".
CMake Error at cmake/qt5.cmake:3 (message):
  Qt 5 is unavailable.  To compile with Qt 4 use -DWITH_QT5=OFF.

Add BuildRequires:  pkgconfig(Qt5Widgets)

Execute cmake with %cmake -DWITH_QT5=ON

Do you plan to build for EPEL7? Please notice the package name is cmake3 there
and Qt5 is Qt is maintained by Red Hat people in RHEL7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500072] Review Request: macromilter - Milter to check mails for suspicious Microsoft VBA macro code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500072



--- Comment #3 from Robert Scheck  ---
Robert-André, thank you very much for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #8 from Raphael Groner  ---
Are you interested in a review swap? Maybe take a look into bug #1506011.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506011] Review Request: nm-tray - NetworkManager tray icon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506011

Raphael Groner  changed:

   What|Removed |Added

 Blocks||928937 (qt-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506011] New: Review Request: nm-tray - NetworkManager tray icon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506011

Bug ID: 1506011
   Summary: Review Request: nm-tray - NetworkManager tray icon
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://raphgro.fedorapeople.org/review/qt/nm-tray/nm-tray.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/qt/nm-tray/nm-tray-0.3.0-1.fc27.src.rpm

Description:
nm-tray is a simple NetworkManager front end with information
icon residing in system tray (like e.g. nm-applet).
It's a pure Qt application.

Fedora Account System Username: raphgro

Test build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22678814

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #7 from mgans...@alice.de  ---
(In reply to Raphael Groner from comment #6)
> FTBFS:
> …
> + cd qxtglobalshortcut-16446200b699e0610b8a5fb20b74938225d81d87
> + %cmake .
> /var/tmp/rpm-tmp.1GGqi9: line 31: fg: no job control
> 
> Add BuildRequires: cmake

done, no extra file upload.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1295115] Review Request: swift-lang - Swift Programming Language by Apple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295115



--- Comment #34 from Ron Olson  ---
One thing that would presumably need to be worked out is that there are a bunch
of pulls from Github that I presume would be frowned on in that it's not a
properly self-contained project. Also Fedora does not provide libBlocksRuntime
for some reason, so that is yet another explicit checkout and install that
wouldn't pass muster from package reviewers. 

(In reply to Ron Olson from comment #33)
> As an update, I have updated the scripts to build Swift 4 (waiting for
> Corinne to pull the request):
> 
> https://github.com/tachoknight/swift-rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505108] Review Request: petsc4py - This package provides Python bindings for MPI PETSc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505108

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #7 from Robert-André Mauchin  ---
All ok for me, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1295115] Review Request: swift-lang - Swift Programming Language by Apple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295115

Ron Olson  changed:

   What|Removed |Added

 CC||tachokni...@gmail.com



--- Comment #33 from Ron Olson  ---
As an update, I have updated the scripts to build Swift 4 (waiting for Corinne
to pull the request):

https://github.com/tachoknight/swift-rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #6 from Raphael Groner  ---
FTBFS:
…
+ cd qxtglobalshortcut-16446200b699e0610b8a5fb20b74938225d81d87
+ %cmake .
/var/tmp/rpm-tmp.1GGqi9: line 31: fg: no job control

Add BuildRequires: cmake

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505993] New: Review Request: python-feedgen - Feed Generator (ATOM, RSS, Podcasts)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505993

Bug ID: 1505993
   Summary: Review Request: python-feedgen - Feed Generator (ATOM,
RSS, Podcasts)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lbal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lbalhar.fedorapeople.org/python-feedgen.spec
SRPM URL: https://lbalhar.fedorapeople.org/python-feedgen-0.6.1-1.fc26.src.rpm
Description: Feed Generator (ATOM, RSS, Podcasts). This module can be used to
generate web feeds in both ATOM and RSS format. It has support for extensions.
Included is, for example, an extension to produce Podcasts.
Fedora Account System Username: lbalhar

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=22677167

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #5 from Raphael Groner  ---
(In reply to mgans...@alice.de from comment #3)
> (In reply to Raphael Groner from comment #1)
…
> What can i do ?

https://github.com/Vacuum-IM/vacuum-im/tree/dev_qt5

… as replied to your issue at upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421914] Review Request: js-responsive-elements - A library that helps element to adapt and respond to the area they occupy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421914



--- Comment #6 from Fedora Update System  ---
js-responsive-elements-1.0.2-1.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a99b033b91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421914] Review Request: js-responsive-elements - A library that helps element to adapt and respond to the area they occupy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421914

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421914] Review Request: js-responsive-elements - A library that helps element to adapt and respond to the area they occupy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421914



--- Comment #5 from Fedora Update System  ---
js-responsive-elements-1.0.2-1.fc26 has been submitted as an update to Fedora
26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-593256d0f1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421914] Review Request: js-responsive-elements - A library that helps element to adapt and respond to the area they occupy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421914

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||js-responsive-elements-1.0.
   ||2-1.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421914] Review Request: js-responsive-elements - A library that helps element to adapt and respond to the area they occupy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421914



--- Comment #4 from Randy Barlow  ---
I fixed the Source0 as you suggested in
https://src.fedoraproject.org/rpms/js-responsive-elements/c/92501fbf637c2346fb08519c4595626c67a2e6cb?branch=master

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422741] Review Request: js-jquery-qrcode - A JavaScript library for standalone qrcode generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422741

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422741] Review Request: js-jquery-qrcode - A JavaScript library for standalone qrcode generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422741



--- Comment #5 from Fedora Update System  ---
js-jquery-qrcode-1.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-79e7d8ea00

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422741] Review Request: js-jquery-qrcode - A JavaScript library for standalone qrcode generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422741



--- Comment #6 from Fedora Update System  ---
js-jquery-qrcode-1.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1ce3e5ac9d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422741] Review Request: js-jquery-qrcode - A JavaScript library for standalone qrcode generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422741



--- Comment #7 from Fedora Update System  ---
js-jquery-qrcode-1.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a9e3bc4c72

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422741] Review Request: js-jquery-qrcode - A JavaScript library for standalone qrcode generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422741

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||js-jquery-qrcode-1.0-1.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505108] Review Request: petsc4py - This package provides Python bindings for MPI PETSc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505108



--- Comment #6 from Antonio Trande  ---
> These includes should probably go into -devel subpackages:

I'm not totally sure, but i moved header files under directories expected by
MPI guidelines.

Spec URL: https://sagitter.fedorapeople.org/petsc4py/petsc4py.spec
SRPM URL:
https://sagitter.fedorapeople.org/petsc4py/petsc4py-3.8.0-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422741] Review Request: js-jquery-qrcode - A JavaScript library for standalone qrcode generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422741



--- Comment #4 from Randy Barlow  ---
I've corrected the Source0 to use the name and version here:

https://src.fedoraproject.org/rpms/js-jquery-qrcode/c/6c62a00954c493a6f063228e651269491b8774b7?branch=master

I will update my other package review bug soon (I've been so swamped with all
the modularity Bodhi work ☺)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505945] Review Request: rubygem-elasticsearch-api - Ruby API for Elasticsearch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505945

Matthias Runge  changed:

   What|Removed |Added

 Status|NEW |POST
  Flags||fedora-review+



--- Comment #2 from Matthias Runge  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE_txt.html is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 289 files have unknown
 license. Detailed output of licensecheck in
 /home/mrunge/review/1505945-rubygem-elasticsearch-api/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
[x]: Package contains Requires: ruby(release).

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
False positive

[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see 

[Bug 1505945] Review Request: rubygem-elasticsearch-api - Ruby API for Elasticsearch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505945



--- Comment #1 from Sandro Bonazzola  ---
copr build:
https://copr.fedorainfracloud.org/coprs/sbonazzo/ovirt-fluentd/build/651441/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505945] Review Request: rubygem-elasticsearch-api - Ruby API for Elasticsearch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505945

Sandro Bonazzola  changed:

   What|Removed |Added

 Blocks||1505843




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1505843
[Bug 1505843] Build rubygem-elasticsearch-api 2.0.2 for CentOS OpsTools
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505945] Review Request: rubygem-elasticsearch-api - Ruby API for Elasticsearch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505945

Sandro Bonazzola  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|mru...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505945] New: Review Request: rubygem-elasticsearch-api - Ruby API for Elasticsearch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505945

Bug ID: 1505945
   Summary: Review Request: rubygem-elasticsearch-api - Ruby API
for Elasticsearch
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sbona...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://sbonazzo.fedorapeople.org/rubygem-elasticsearch-api.spec
SRPM URL:
https://sbonazzo.fedorapeople.org/rubygem-elasticsearch-api-2.0.2-1.fc28.src.rpm
 
Description: Ruby API for Elasticsearch. See the `elasticsearch` gem for full
integration.
Fedora Account System Username: sbonazzo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #4 from mgans...@alice.de  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qxtglobalshortcut.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qxtglobalshortcut-0.0.1-0.3.20171021git1644620.fc26.src.rpm

%changelog
* Tue Oct 24 2017 Martin Gansser  -
0.0.1-0.3.20171021git1644620
- Disable qt4 build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396492] Review Request: pdfbox1 - Java library for working with PDF documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396492



--- Comment #10 from gil cattaneo  ---
(In reply to Ben Rosser from comment #9)
> Is the package no longer necessary? 
NO
> Should the review just get closed?
NO


At the moment i have no time and resources to continue with this package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838



--- Comment #8 from Fedora Update System  ---
python-jnius-1.1.1-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff86a4ac6e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411984] Review Request: neofetch - a CLI system information tool written in Bash

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411984



--- Comment #32 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/neofetch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306

mgans...@alice.de  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-10-24 10:07:28



--- Comment #10 from mgans...@alice.de  ---
package has been built successfully on f25, f26, f27 and rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-jnius

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838



--- Comment #6 from Raphael Groner  ---
Thank you for the review.

https://pagure.io/releng/fedora-scm-requests/issue/2421
https://pagure.io/releng/fedora-scm-requests/issue/2422

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838

Christian Dersch  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Christian Dersch  ---
Looks good now → APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500072] Review Request: macromilter - Milter to check mails for suspicious Microsoft VBA macro code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500072



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/macromilter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505374] Review Request: python-oletools - Tools to analyze Microsoft OLE2 files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505374



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-oletools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838



--- Comment #4 from Raphael Groner  ---
Fixed.

Spec URL: https://raphgro.fedorapeople.org/review/py/jnius/python-jnius.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/py/jnius/python-jnius-1.1.1-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838



--- Comment #3 from Christian Dersch  ---
See https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838



--- Comment #2 from Raphael Groner  ---
> Single issue: Directory ownership for  
> /usr/lib64/python3.6/site-packages/__pycache__

What's wrong with it?

  
/usr/lib64/python3.6/site-packages/__pycache__/jnius_config.cpython-36.opt-1.pyc
   /usr/lib64/python3.6/site-packages/__pycache__/jnius_config.cpython-36.pyc

Do you mean to exclude the folder as such but explicitly keep the pyc files
only?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/i-nex

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838



--- Comment #1 from Christian Dersch  ---
Single issue: Directory ownership for 
/usr/lib64/python3.6/site-packages/__pycache__


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

==> Unversioned so-files are compiled Python modules -> fine

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 108 files have
 unknown license. Detailed output of licensecheck in
 /home/review/1505838-python-jnius/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib64/python3.6/site-
 packages/__pycache__(python36)

==> Please do NOT own __pycache__ folder but only files in there

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.

==> We have ExcludeArch here, submitter explained the reason and filed
bugs upstream -> fine

[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see 

[Bug 1500072] Review Request: macromilter - Milter to check mails for suspicious Microsoft VBA macro code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500072

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Hello,

 - For a dev snapshot, add the shortcommit to the Release field too:

Release:   1.20171009git%{shortcommit}%{?dist}

  And:

* Mon Oct 09 2017 Robert Scheck 
3.3-1.20171009git4e8295f

 - Package rame and SPEC name should be kept lowercase imho.

Package is good otherwise, it is accepted.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 37 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/macromilter/review-
 macromilter/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /etc/logrotate.d(samba-
 common, logrotate, ppp, sssd-common)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or 

[Bug 1505838] Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838

Christian Dersch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lupinix.fed...@gmail.com
   Assignee|nob...@fedoraproject.org|lupinix.fed...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505838] New: Review Request: python-jnius - Dynamic access to Java classes from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505838

Bug ID: 1505838
   Summary: Review Request: python-jnius - Dynamic access to Java
classes from Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://raphgro.fedorapeople.org/review/py/jnius/python-jnius.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/py/jnius/python-jnius-1.1.1-1.fc27.src.rpm
Description: Dynamic access to Java classes from Python
Fedora Account System Username: raphgro

Test build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22665654

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505108] Review Request: petsc4py - This package provides Python bindings for MPI PETSc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505108



--- Comment #5 from Robert-André Mauchin  ---
https://github.com/petsc/petsc4py is returning 404 too.


These includes should probably go into -devel subpackages:

thon2-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/openmpi/petsc4py/include/petsc4py/numpy.h
python2-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.PETSc.h
python2-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.PETSc_api.h
python2-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.h

python3-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/openmpi/petsc4py/include/petsc4py/numpy.h
python3-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.PETSc.h
python3-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.PETSc_api.h
python3-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.h

python2-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/mpich/petsc4py/include/petsc4py/numpy.h
python2-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.PETSc.h
python2-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.PETSc_api.h
python2-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.h

python3-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/mpich/petsc4py/include/petsc4py/numpy.h
python3-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.PETSc.h
python3-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.PETSc_api.h
python3-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1492084] Review Request: movit - GPU video filter library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1492084



--- Comment #13 from mgans...@alice.de  ---
(In reply to Terje Røsten from comment #12)
> FYI: gtest 1.8.0 is available in rawhide now. Sources included in package.
> 
> Can you try tip about setting GTEST_DIR?

there is no gtest-all.cc in the package gtest-devel:

+ export GTEST_DIR=/usr/include/gtest
+ GTEST_DIR=/usr/include/gtest
+ make check
g++ -MMD -MP  -Wall -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic
-fvisibility-inlines-hidden -I/usr/include/gtest/include -I/usr/include/SDL2
-D_REENTRANT   -I/usr/include/eigen3-DHAVE_SDL2 -o effect_chain_test.o -c
effect_chain_test.cpp
make: *** No rule to make target '/usr/include/gtest/src/gtest-all.cc', needed
by 'gtest-all.o'.  Stop.
error: Bad exit status from /var/tmp/rpm-tmp.LBk107 (%install)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499569

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499569



--- Comment #7 from Fedora Update System  ---
python-twilio-6.8.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-36f9e309ec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1210993



--- Comment #23 from Denis Arnaud  ---
Ok, so, taking all of that into account, it gives:
Spec URL: http://denisarnaud.fedorapeople.org/boost/boost157/boost157.spec
SRPM URL:
http://denisarnaud.fedorapeople.org/boost/boost157/boost157-1.57.0-6.src.rpm

Build on EPEL 6: https://koji.fedoraproject.org/koji/taskinfo?taskID=22664595

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474033] Review Request: ucx - Communication library implementing high-performance messaging

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474033



--- Comment #31 from Andrey Maslennikov  ---
Spec URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/21ae461fbf824e175bf0e37c989cea4d9c6a99ce/ucx.spec
SRPM URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/21ae461fbf824e175bf0e37c989cea4d9c6a99ce/ucx-1.2.2-1.fc25.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22663647

Changes:
1.
-Summary: UCX is a communication library implementing high-performance
messaging
+Summary: A communication library implementing high-performance messaging

2.
+# UCX doesn’t use glibc’s malloc because it is modifying ptmalloc library
+# to notify UCX about memory map/unmap events

Other comments:
>  Manpages would be nice.
Currently, we don't have resources for it. Is it a blocker?

>  Is this overlinking? You may want to look into this upstream.
Dependencies are invoked by `la_LIBADD`, it also include dependency's
dependencies.

License headers were fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #8 from mgans...@alice.de  ---
build fails on arch: s390x ppc64le ppc64 aarch64 armv7hl aarch64
will add ExcludeArch to spec file

ExcludeArch:aarch64 %arm ppc64le ppc64 s390x

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411984] Review Request: neofetch - a CLI system information tool written in Bash

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411984



--- Comment #31 from Kees de Jong  ---
(In reply to Ben Rosser from comment #30)
> Alright, package looks fine and is APPROVED.
> 
> Again, really sorry for the delay.

No worries, I am super busy anyway, thank you! I will close the 'bug' once the
package is submitted to the build and accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505374] Review Request: python-oletools - Tools to analyze Microsoft OLE2 files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505374

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
It seems that at least some of the python3 executables are not ready:

$ /usr/bin/mraptor-3.6
Traceback (most recent call last):
  File "/usr/bin/mraptor-3.6", line 11, in 
load_entry_point('oletools==0.51', 'console_scripts', 'mraptor')()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 563,
in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2651,
in load_entry_point
return ep.load()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2305,
in load
return self.resolve()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2311,
in resolve
module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/lib/python3.6/site-packages/oletools/mraptor.py", line 84, in

from oletools import olevba
  File "/usr/lib/python3.6/site-packages/oletools/olevba.py", line 237, in

import cStringIO
ModuleNotFoundError: No module named 'cStringIO'

$ /usr/bin/olevba-3.6
Traceback (most recent call last):
  File "/usr/bin/olevba-3.6", line 11, in 
load_entry_point('oletools==0.51', 'console_scripts', 'olevba')()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 563,
in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2651,
in load_entry_point
return ep.load()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2305,
in load
return self.resolve()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2311,
in resolve
module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/lib/python3.6/site-packages/oletools/olevba.py", line 237, in

import cStringIO
ModuleNotFoundError: No module named 'cStringIO'

Dunno. I don't think it's very useful to package this. I think you should
diasable
those executables that crash immediately.

--

A small inconsistency:
- you have foo-3.6 → foo-3, but foo-2.7 → foo-2 ← foo
I think the less specific name should always link to the more specific one,
i.e. foo-2.7 ← foo-2 ← foo.
In practice all those symlinks are provided in the same package, but at least
theoretically one might install some of the less specific symlinks, e.g. in
/usr/local/bin. So let's say that I install a python 3.7 version, with a
foo-3.7 executable, and symlink foo-3 too this. Things would still work as
expected, but there would be two foo-3 executables with different versions. I
found this much cleaner when the symlinks go one way. (It's OK as is though.)

OK, without further ado:
- package name is OK
- license is acceptable for Fedora (a combination of BSD/MIT/Python)
- license is specified correctly
- latest version
- builds and installs OK
- Provides/Requires/BuildRequires look correct
- Provides bundled() have been added
- fedora-review finds no issues

Package is APPROVED.

I see that F <= 27 has python-easygui, while rawhide has python2-easygui.
You'll probably need to addjust BR to build for F27-.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306
Bug 1505306 depends on bug 1505304, which changed state.

Bug 1505304 Summary: Review Request: libcpuid - Provides CPU identification for 
x86
https://bugzilla.redhat.com/show_bug.cgi?id=1505304

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505304] Review Request: libcpuid - Provides CPU identification for x86

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505304

mgans...@alice.de  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-10-24 03:37:13



--- Comment #13 from mgans...@alice.de  ---
%changelog
* Mon Oct 23 2017 Martin Gansser  -
0.4.0-4.20171023git2f10315
- Update to 0.4.0-4.20171023git2f10315
- Dropped %%{name}-not-use-4m-macro.patch
- Add ExcludeArch: aarch64 %%arm ppc64le ppc64 s390x

package has been built successfully on f25, f26, f27 and rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411984] Review Request: neofetch - a CLI system information tool written in Bash

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411984

Kees de Jong  changed:

   What|Removed |Added

Summary|neofetch - a CLI system |Review Request: neofetch -
   |information tool written in |a CLI system information
   |Bash|tool written in Bash



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 925993] Review Request: ghc-yesod-core - Yesod core library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=925993

Elliott Sales de Andrade  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
  Flags||fedora-review?



--- Comment #9 from Elliott Sales de Andrade  ---
Oops, sorry I missed this earlier. Unfortunately, it's one version out of date
now.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 2273280 bytes in 58 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 70 files have
 unknown license. Detailed output of licensecheck in
 review/925993-ghc-yesod-core/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does 

[Bug 1500691] Review Request: perl-lib-relative - Add paths relative to the current file to @INC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500691

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-10-24 03:19:11



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #7 from mgans...@alice.de  ---
thanks for the professional ticket review !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #6 from mgans...@alice.de  ---
(In reply to Robert-André Mauchin from comment #5)
> There's a typo in the Release field, it should be:
> 
> Release:3%{gver}%{?dist}
> 
> The ? is before dist, not gver.
> 
> Otherwise the package is good and is accepted.

typo fixed, no extra upload.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505304] Review Request: libcpuid - Provides CPU identification for x86

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505304



--- Comment #12 from mgans...@alice.de  ---
(In reply to Robert-André Mauchin from comment #11)
> You've introduced a typo in your %changelog: it should be 0.4.0-4, not
> 0.4.0-3 for the last entry.

fixed:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/libcpuid.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/libcpuid-0.4.0-4.20171023git2f10315.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org