[Bug 1373007] Review Request: rubygem-cool.io - A cool framework for doing high performance I/O in Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373007

Rich Megginson  changed:

   What|Removed |Added

  Flags|needinfo?(rmeggins@redhat.c |
   |om) |



--- Comment #5 from Rich Megginson  ---
I tried hacking the spec file like this and building on fedora 27:

 BuildRequires: rubygem-rspec >= 3.5.0
+BuildRequires: libev-devel
 Provides: rubygem(%{gem_name}) = %{version}

...

 %setup -q -D -T -n  %{gem_name}-%{version}

-gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec
+# remove libev source files from disk and gemspec
+rm -rf ext/libev
+gem spec %{SOURCE0} -l --ruby | sed 's@"ext/libev/.*".freeze, @@g' >
%{gem_name}.gemspec

 %build

but this fails to build:

gcc -I. -I/usr/include -I/usr/include/ruby/backward -I/usr/include -I.
-DRUBY_VERSION_CODE=242 -DHAVE_SYS_SELECT_H -DEV_USE_SELECT -DHAVE_POLL_H
-DEV_USE_POLL -DHAVE_SYS_EPOLL_H -DEV_USE_EPOLL -DHAVE_SYS_RESOURCE_H
-DHAVE_LINUX_PROCFS-fPIC -O2 -g -fno-strict-aliasing -m64 -o cool.io_ext.o
-c cool.io_ext.c
In file included from cool.io_ext.c:10:0:
ev_wrap.h:9:10: fatal error: ../libev/ev.h: No such file or directory
 #include "../libev/ev.h"
  ^~~
compilation terminated.

The next step would be to do some source code hacking to make it

 #include "libev/ev.h"

instead.

In short, it looks like this is going to be a good bit of work . . .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526214] Review Request: gawk-errno - Errno library for gawk

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526214



--- Comment #1 from Andrew Schorr  ---
This is another gawk extension library packaged similarly to gawk-xml,
gawk-pgsql, gawk-lmdb, and gawk-json. It is mostly useful for working with the
gawk-select library that enables I/O multiplexing in gawk (coming soon).

It passes rpmlint, licensecheck, and fedora-review. A koji build is here:
   https://koji.fedoraproject.org/koji/taskinfo?taskID=23693220

Thanks,
Andy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526214] New: Review Request: gawk-errno - Errno library for gawk

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526214

Bug ID: 1526214
   Summary: Review Request: gawk-errno - Errno library for gawk
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ajsch...@alumni.princeton.edu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://sourceforge.net/projects/gawkextlib/files/rpm-specs/gawk-errno.spec
SRPM URL:
https://sourceforge.net/projects/gawkextlib/files/srpms/gawk-errno-1.1.0-1.el7.centos.src.rpm
Description: The gawk-errno module is a gawk extension library containing some
usefulfunctions for working with ERRNO values.
Fedora Account System Username: ajschorr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526208] Review Request: ghc-criterion - Robust, reliable performance measurement and analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526208



--- Comment #1 from Elliott Sales de Andrade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=23691382

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526208] New: Review Request: ghc-criterion - Robust, reliable performance measurement and analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526208

Bug ID: 1526208
   Summary: Review Request: ghc-criterion - Robust, reliable
performance measurement and analysis
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: quantum.anal...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://qulogic.fedorapeople.org//ghc-criterion.spec
SRPM URL: http://qulogic.fedorapeople.org//ghc-criterion-1.2.6.0-1.fc26.src.rpm

Description:
This library provides a powerful but simple way to measure software
performance. It provides both a framework for executing and analysing
benchmarks and a set of driver functions that makes it easy to build and run
benchmarks, and to analyse their results.

The fastest way to get started is to read the
, followed
by the documentation and examples in the "Criterion.Main" module.

For examples of the kinds of reports that criterion generates, see
.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526018] Review Request: bolt - Thunderbolt system daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526018



--- Comment #3 from Christian Kellner  ---
Thanks for the reviews! I spotted the missing COPYING file only after the
release ... sigh. 
For now I have done what Robert-André suggested.

Updated spec file:
https://gist.github.com/gicmo/20f11540c235fc6d98f7dec3a2a97788

New scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=23690449

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525707] Review Request: mingw-enchant2 - MinGW Windows enchant2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525707

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706



--- Comment #11 from Fedora Update System  ---
enchant2-2.2.0-2.fc27 mingw-enchant2-2.2.0-2.fc27 has been submitted as an
update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-36fc2c0fb9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525707] Review Request: mingw-enchant2 - MinGW Windows enchant2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525707



--- Comment #6 from Fedora Update System  ---
enchant2-2.2.0-2.fc27 mingw-enchant2-2.2.0-2.fc27 has been submitted as an
update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-36fc2c0fb9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526200] Review Request: python-tinycss2 - Low-level CSS parser for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526200

Felix Schwarz  changed:

   What|Removed |Added

 Blocks||1475749




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1475749
[Bug 1475749] weasyprint 0.43 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526200] New: Review Request: python-tinycss2 - Low-level CSS parser for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526200

Bug ID: 1526200
   Summary: Review Request: python-tinycss2 - Low-level CSS parser
for Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fschw...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fschwarz.fedorapeople.org/2017/python-tinycss2.spec
SRPM URL:
https://fschwarz.fedorapeople.org/2017/python-tinycss2-0.6.1-1.fc27.src.rpm

Description:
tinycss2 is a modern, low-level CSS parser for Python. tinycss2 is a rewrite of
tinycss with a simpler API, based on the more recent CSS Syntax Level 3
specification.

Fedora Account System Username: fschwarz

This package is required to fix bug 1475749 (upgrading WeasyPrint to a current
version).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525707] Review Request: mingw-enchant2 - MinGW Windows enchant2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525707



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/mingw-enchant2. You may commit to the branch
"f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1466961

Hannes Frederic Sowa  changed:

   What|Removed |Added

 CC||hs...@redhat.com



--- Comment #19 from Hannes Frederic Sowa  ---
Hi Dave, oh, I see it hadn't build for f27. I need to take care of that. It is
in rawhide already though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/enchant2. You may commit to the branch "f27"
in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385244] Review Request: pew - Manage multiple Python virtual environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385244

Felix Schwarz  changed:

   What|Removed |Added

 CC||fschw...@fedoraproject.org



--- Comment #8 from Felix Schwarz  ---
seems like bug 1525570 is a review request for the same package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: python-pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Felix Schwarz  changed:

   What|Removed |Added

 CC||fschw...@fedoraproject.org



--- Comment #2 from Felix Schwarz  ---
seems like bug 1385244 is a review request for the same package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508068] Review Request: golang-gopkg-readline - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508068

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |MODIFIED
 CC||jsmith.fed...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Jared Smith  ---
Package is approved.  Please see the note below about duplicate files.  Also,
it appears that the spec file has an insignificant change from the one in the
SRPM.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/gocode/src/gopkg.in/readline.v1
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "do What The Fuck you want to Public
 License (v2)", "Unknown or generated". 42 files have unknown license.
 Detailed output of licensecheck in
 /home/jsmith/Documents/Personal/Reviews/1508068-golang-gopkg-
 readline/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/gocode/src/gopkg.in
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/gopkg.in
[x]: %build honors applicable compiler flags or justifies otherwise.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
 Note: No 

[Bug 1526170] New: Review Request: : perl-Cpanel-JSON-XS - CPanel fork of JSON::XS, fast and correct serializing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526170

Bug ID: 1526170
   Summary: Review Request: : perl-Cpanel-JSON-XS - CPanel fork of
JSON::XS, fast and correct serializing
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: emman...@seyman.fr
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS-3.0239-1.fc27.src.rpm
Description:
This module converts Perl data structures to JSON and vice versa. Its
primary goal is to be correct and its secondary goal is to be fast. To
reach the latter goal it was written in C.

Fedora Account System Username: eseyman
Rpmlint Output: 
perl-Cpanel-JSON-XS.src: W: spelling-error %description -l en_US versa ->
avers, verse, verso
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1466961



--- Comment #18 from Dave Love  ---
Why hasn't this been finished off?  I was expecting to be able to install it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508066] Review Request: golang-github-chzyer-test - Golang test utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508066

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Assignee|jsmith.fed...@gmail.com |zebo...@gmail.com
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jared Smith  ---
Package is approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have
 unknown license. Detailed output of licensecheck in
 /home/jsmith/Documents/Personal/Reviews/1508066-golang-github-chzyer-
 test/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com/chzyer(golang-github-chzyer-logex-
 devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
 github-chzyer-test-devel , golang-github-chzyer-test-unit-test-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate 

[Bug 1508066] Review Request: golang-github-chzyer-test - Golang test utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508066

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jsmith.fed...@gmail.com
   Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520572] Review Request: perl-Authen-DecHpwd - DEC VMS password hashing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520572

Sandro Mani  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||manisan...@gmail.com
   Assignee|nob...@fedoraproject.org|manisan...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520569] Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface for a portable traditional crypt function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520569

Sandro Mani  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||manisan...@gmail.com
   Assignee|nob...@fedoraproject.org|manisan...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526071] Review Request: nodejs-call-delayed - Like setTimeout, but with arguments reversed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526071

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525984] Review Request: python-ruamel-std-pathlib - An improvement over the standard pathlib module and pathlib2 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525984

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
Are you planning to support old EPEL or something? Why bother with the python3
flag at all (Fedora's going to be dropping Python 2, not 3; flagging the other
way makes more sense in some way)? Relatedly, it would be best to figure out
why tests are failing on Python 3 now.

Use %py2_install/%py3_install macros.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526132] New: Review Request: nodejs-immutable - Immutable Data Collections

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526132

Bug ID: 1526132
   Summary: Review Request: nodejs-immutable - Immutable Data
Collections
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-immutable/nodejs-immutable.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-immutable/nodejs-immutable-3.8.2-1.fc28.src.rpm
 
Description: Immutable Data Collections
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1387531
[Bug 1387531] Package tracker for supporting Node-RED
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706



--- Comment #9 from Robert-André Mauchin  ---
I've got a handful of Perl and Golang packages waiting for review:

https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW=Fedora=Package%20Review=zebob.m%40gmail.com=1=substring_id=8223620=Fedora_format=advanced

Feel free to pick one up if you have the time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526071] Review Request: nodejs-call-delayed - Like setTimeout, but with arguments reversed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526071



--- Comment #2 from Jared Smith  ---
Sorry about that -- please try these versions instead.

Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed-1.0.0-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525707] Review Request: mingw-enchant2 - MinGW Windows enchant2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525707



--- Comment #4 from Sandro Mani  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525707] Review Request: mingw-enchant2 - MinGW Windows enchant2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525707

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
All good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706



--- Comment #8 from Sandro Mani  ---
Thanks a lot! Let me know if I can review anything for you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525707] Review Request: mingw-enchant2 - MinGW Windows enchant2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525707



--- Comment #2 from Sandro Mani  ---
Spec URL: https://smani.fedorapeople.org/review/mingw-enchant2.spec
SRPM URL:
https://smani.fedorapeople.org/review/mingw-enchant2-2.2.0-2.fc28.src.rpm

%changelog
* Thu Dec 14 2017 Sandro Mani  - 2.2.0-2
- Add patch to fix FSF addresses

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #7 from Robert-André Mauchin  ---
Ok then package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706



--- Comment #6 from Sandro Mani  ---
Spec URL: https://smani.fedorapeople.org/review/enchant2.spec
SRPM URL: https://smani.fedorapeople.org/review/enchant2-2.2.0-2.fc28.src.rpm

%changelog
* Thu Dec 14 2017 Sandro Mani  - 2.2.0-2
- Add patch to fix FSF addresses
- Kill rpath


Builds fine for me in koji without autoreconf [1].

[1] https://koji.fedoraproject.org/koji/taskinfo?taskID=23685946

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526055] Review Request: nodejs-aws4 - Signs and prepares requests using AWS Signature Version 4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526055

Jared Smith  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-14 14:42:50



--- Comment #4 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526071] Review Request: nodejs-call-delayed - Like setTimeout, but with arguments reversed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526071

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
+ /usr/bin/mocha -R spec
module.js:538
throw err;
^
Error: Cannot find module 'coffee-script/register'

→ You need one more BR for the tests:

BuildRequires:npm(coffee-script)


With that:
 - license is ok
 - package builds in mock
 - latest version is packaged
 - tests are successful
 - no rpmlint issues

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #41 from Nicolas Chauvet (kwizart)  ---
(In reply to Hans de Goede from comment #38)
> Here is a new version of the pkg, updated to 5.2.2:
> 
> SPEC: https://fedorapeople.org/~jwrdegoede/VirtualBox-guest-additions.spec
> SRPM:
> https://fedorapeople.org/~jwrdegoede/VirtualBox-guest-additions-5.2.2-1.fc27.
> src.rpm
> 
> Unfortunately the kernel patches are still awaiting review by the misc
> subsys maintainers upstream. I did manage to get a review done by another
> kernel contributor (and addressed his comments), so hopefully something will
> happen wrt this soon.

Quick review with few minors things:

* Keep from using requires on kernel from userspace. Most of the time this is
invalid (you could be within a chroot , container or systemd-nspawn, etc). Also
you need to select the appropriate variant (on x86_64 kernel-debug exists or
even kernel-rt).
# FIXME once kernel modules have landed
#Requires:   kernel >= 4.FIXME

* Please use pkgconf --libs libpng and etc not to hardcode one particular
library path. (say if there is a  need to use one particular scl at some
point).

* Is there a way "not to hardcode the vendor", such as:
VBOX_BUILD_PUBLISHER=_%{?vendor}%{?!vendor:Unknown}

* The replacement of the RPM Fusion package should works for the "userspace"
but not much for the kmod-VirtualBox. Best is probably to keep a (virtual)
Provides: VirtualBox-kmod-common = 5.2.2 (the last version of the rpmfusion
counterpart before it is disabled). So that kmod-Virtualbox is kept while it
will not try to seek the main VirtualBox(host) capability.
Then, it will only be a matter for the kernel

Obsoletes/Provides for the akmod isn't an option because it will affect host
kmod-VirtualBox and VirtualBox users.

Another option is probably to only have the Obsoletes: akmod-VirtualBox <
5.22-100
(needs testing).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526055] Review Request: nodejs-aws4 - Signs and prepares requests using AWS Signature Version 4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526055



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-aws4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526091] Package Review: add python-sushy to Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526091

Alfredo Moralejo  changed:

   What|Removed |Added

Summary|Add python-sushy to Fedora  |Package Review: add
   ||python-sushy to Fedora



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526091] Add python-sushy to Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526091

Alfredo Moralejo  changed:

   What|Removed |Added

 CC||amora...@redhat.com,
   ||package-review@lists.fedora
   ||project.org
  Component|Module Review   |Package Review
Version|unspecified |rawhide
 Blocks||1486366 (RDO-QUEENS)
Product|Fedora Modules  |Fedora




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1486366
[Bug 1486366] Tracker: Blockers and Review requests for new RDO Queens
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526055] Review Request: nodejs-aws4 - Signs and prepares requests using AWS Signature Version 4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526055

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Requested package in ticket
https://pagure.io/releng/fedora-scm-requests/issue/3550

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #40 from Hans de Goede  ---
(In reply to Sergio Monteiro Basto from comment #39)
> Did you see this thread [1]

Weird, Vic writes: "Some apps like atril and emacs are failing because
VBoxOGLcrutil.so can't be found.", but the only thing requiring
VBoxOGLcrutil.so should be the replacement libGL.so.1 which only gets used if
LD_LIBRARY_PATH is set in the first place.

I've the feeling that Vic somehow has a ld.so.cache entry pointed to the vbox 
libGL.so.1. I'm not on rpmfusion-users, can you ask him to file a bugzilla so
we can discuss this there? Also ask him to check for ld.so.conf.d files which
may explain this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526055] Review Request: nodejs-aws4 - Signs and prepares requests using AWS Signature Version 4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526055

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---

 - License ok
 - Builds in mock
 - Tests ok
 - No rpmlint error

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526071] New: Review Request: nodejs-call-delayed - Like setTimeout, but with arguments reversed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526071

Bug ID: 1526071
   Summary: Review Request: nodejs-call-delayed - Like setTimeout,
but with arguments reversed
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-call-delayed/nodejs-call-delayed-1.0.0-1.fc28.src.rpm
 
Description: Like setTimeout, but with arguments reversed
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1387531
[Bug 1387531] Package tracker for supporting Node-RED
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526018] Review Request: bolt - Thunderbolt system daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526018

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---
 - This file is present twice in %files:

%{_unitdir}/%{name}.service

%{_unitdir}/bolt.service

 - Grab the license file from the GIT repo:

Source1: https://raw.githubusercontent.com/gicmo/bolt/master/COPYING

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525490] Review Request: cwm - calm window manager from OpenBSD project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525490

Bruno Meneguele  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||cwm-6.2-1.fc28
 Resolution|--- |NEXTRELEASE
Last Closed||2017-12-14 12:42:13



--- Comment #5 from Bruno Meneguele  ---
Package built:

  https://koji.fedoraproject.org/koji/buildinfo?buildID=1009493

Thank you guys.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520204] Review Request: ghc-statistics - A library of statistical types, data, and functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520204



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-statistics

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525984] Review Request: python-ruamel-std-pathlib - An improvement over the standard pathlib module and pathlib2 package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525984

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---

 - It would be better to use the following syntax

%global with_python3 1 → %bcond_without python3

   And:

%if 0%{?with_python3} → %if %{with python3}

 - In the following comment, double the % to avoid macros replacement:

#Source0:   
https://files.pythonhosted.org/packages/source/r/%%{pypi_name}/%%{pypi_name}-%%{version}.tar.gz

 - Add _example to %doc

 - BuildRequires:pytest → BuildRequires:python2-pytest

 - Run the tests provided:

%check
PYTHONPATH=$PYTHONPATH:%{buildroot}%{python2_sitelib} py.test-2
%if %{with python3}
PYTHONPATH=$PYTHONPATH:%{buildroot}%{python3_sitelib} py.test-3
%endif

 - Be more specific in %files:

%files -n python2-%{pname}
%license LICENSE
%doc README.rst
%{python2_sitelib}/ruamel/
%{python2_sitelib}/ruamel.std.pathlib-%{version}-py?.?.egg-info/
%{python2_sitelib}/ruamel.std.pathlib-%{version}-py?.?-nspkg.pth

%if %{with python3}
%files -n python%{python3_pkgversion}-%{pname}
%license LICENSE
%doc README.rst
%{python3_sitelib}/ruamel/
%{python3_sitelib}/ruamel.std.pathlib-%{version}-py?.?.egg-info/
%{python3_sitelib}/ruamel.std.pathlib-%{version}-py?.?-nspkg.pth
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1516328

Vít Ondruch  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Vít Ondruch  ---
Thx. I can't see any other issue with the package => APPROVED. Please continue
with the SCM request, import and build of the package:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Pack
age_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517000] Review Request: rubygem-notiffany - Notifier library ( extracted from Guard project)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517000

Vít Ondruch  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Vít Ondruch  ---
Thx. I can't see any other issue with the package => APPROVED. Please continue
with the SCM request, import and build of the package:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based system for authoring and publishing documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526056



--- Comment #1 from Vít Ondruch  ---
Please note that some of the dependencies needed for the full functionality
were dropped for the moment, so for example the "watch" command does not work
ATM, but hopefully, it will be resolved soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based system for authoring and publishing documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526056

Vít Ondruch  changed:

   What|Removed |Added

 Depends On|1516328 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1516328
[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing
Guard compatible plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1516328

Vít Ondruch  changed:

   What|Removed |Added

 Blocks|1526056 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1526056
[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based
system for authoring and publishing documentation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518181] Review Request: rubygem-diff_dirs - Ruby helper to diff two directories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518181

Vít Ondruch  changed:

   What|Removed |Added

 Blocks||1526056




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1526056
[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based
system for authoring and publishing documentation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based system for authoring and publishing documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526056

Vít Ondruch  changed:

   What|Removed |Added

 Depends On||1518169, 1518181, 1516328




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1516328
[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing
Guard compatible plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1518169
[Bug 1518169] Review Request: rubygem-sitemap_generator - Easily generate
XML Sitemaps
https://bugzilla.redhat.com/show_bug.cgi?id=1518181
[Bug 1518181] Review Request: rubygem-diff_dirs - Ruby helper to diff two
directories
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518169] Review Request: rubygem-sitemap_generator - Easily generate XML Sitemaps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518169

Vít Ondruch  changed:

   What|Removed |Added

 Blocks||1526056




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1526056
[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based
system for authoring and publishing documentation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1516328

Vít Ondruch  changed:

   What|Removed |Added

 Blocks||1526056




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1526056
[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based
system for authoring and publishing documentation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526056] New: Review Request: rubygem-ascii_binder - An AsciiDoc-based system for authoring and publishing documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526056

Bug ID: 1526056
   Summary: Review Request: rubygem-ascii_binder - An
AsciiDoc-based system for authoring and publishing
documentation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: vondr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/cgit/vondruch/public_git/rubygem-ascii_binder.git/plain/rubygem-ascii_binder.spec?id=bdb0c87d20a866c372825870d600b80c0c84cb8d
SRPM URL:
http://people.redhat.com/vondruch/rubygem-ascii_binder-0.1.13-1.fc28.src.rpm
Description: AsciiBinder is an AsciiDoc-based system for authoring and
publishing closely related documentation sets from a single source.
Fedora Account System Username: vondruch

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23683915

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526055] New: Review Request: nodejs-aws4 - Signs and prepares requests using AWS Signature Version 4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526055

Bug ID: 1526055
   Summary: Review Request: nodejs-aws4 - Signs and prepares
requests using AWS Signature Version 4
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-aws4/nodejs-aws4.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-aws4/nodejs-aws4-1.6.0-1.fc28.src.rpm
 
Description: Signs and prepares requests using AWS Signature Version 4
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1387531
[Bug 1387531] Package tracker for supporting Node-RED
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525490] Review Request: cwm - calm window manager from OpenBSD project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525490



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/cwm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526018] Review Request: bolt - Thunderbolt system daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526018

Yanko Kaneti  changed:

   What|Removed |Added

 CC||yan...@declera.com



--- Comment #1 from Yanko Kaneti  ---
- lacks a license file, both in the spec and in the release tarball

- "The %defattr directive in the %files list SHOULD ONLY be used when setting a
non-default value, or to reset to the default value after having set a
non-default value." to quote the guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520710] Review Request: gawk-json - JSON encoder/decoder for gawk

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520710

Andrew Schorr  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-14 11:38:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #39 from Sergio Monteiro Basto  ---
Hi Hans, 

Did you see this thread [1] I replied please "run app with VBoxOGLRun.sh or
export
LD_LIBRARY_PATH=/usr/lib64/VBoxGuestAdditions:/usr/lib/VBoxGuestAdditions" 
which Vic replied with : "I already set LD_LIBRARY_PATH as a  temporary
workaround.

Thanks" 

Conclusion, maybe we need enable LD_LIBRARY_PATH all the time , or may we move
some files from /usr/lib/VBoxGuestAdditions to /usr/lib/ ? 

Thanks,


[1] 
https://lists.rpmfusion.org/archives/list/rpmfusion-us...@lists.rpmfusion.org/thread/L365ROTMFLGVRBJCGT35FRCBLLNGV2PX/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #8 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f5d200ddd4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #7 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a9b144da91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526018] New: Review Request: bolt - Thunderbolt system daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526018

Bug ID: 1526018
   Summary: Review Request: bolt - Thunderbolt system daemon
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ckell...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



gicmo's scratch build of bolt-0.1-1.fc27.src.rpm for rawhide completed:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=23682724

spec file: https://gist.github.com/gicmo/20f11540c235fc6d98f7dec3a2a97788

Description:
bolt is a system daemon to manage thunderbolt 3 devices via a D-BUS
API. Thunderbolt 3 features different security modes that require
devices to be authorized before they can be used. The D-Bus API can be
used to list devices, enroll them (authorize and store them in the
local database) and forget them again (remove previously enrolled
devices). It also emits signals if new devices are connected (or
removed). During enrollment devices can be set to be automatically
authorized as soon as they are connected.  A command line tool, called
boltctl, can be used to control the daemon and perform all the above
mentioned tasks.

Fedora Account System Username: gicmo
github upstream link: https://github.com/gicmo/bolt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #38 from Hans de Goede  ---
Here is a new version of the pkg, updated to 5.2.2:

SPEC: https://fedorapeople.org/~jwrdegoede/VirtualBox-guest-additions.spec
SRPM:
https://fedorapeople.org/~jwrdegoede/VirtualBox-guest-additions-5.2.2-1.fc27.src.rpm

Unfortunately the kernel patches are still awaiting review by the misc subsys
maintainers upstream. I did manage to get a review done by another kernel
contributor (and addressed his comments), so hopefully something will happen
wrt this soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525707] Review Request: mingw-enchant2 - MinGW Windows enchant2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525707

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
The only issue I have found it the FSF address problem. Fix it with:

find -type f -print0 | xargs -0 sed -i \
  's|59 Temple Place - Suite 330|51 Franklin Street, Fifth Floor|;
   s|02111-1307|02110-1301|'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706



--- Comment #5 from Robert-André Mauchin  ---
PR for FSF address: https://github.com/AbiWord/enchant/pull/176
Add it as a comment to remind you to remove the patch at the next release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Algorithm-Loops. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481645] Review Request: python-pyobd - OBD-II (SAE-J1979) compliant scantool software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481645



--- Comment #16 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pyobd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525490] Review Request: cwm - calm window manager from OpenBSD project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525490

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706



--- Comment #4 from Robert-André Mauchin  ---
Wnen I do this in mock, it fails because files were generated with automake
1.15 wnereas system has 1.15.1. Try it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274



--- Comment #11 from Peter Oliver  ---
Thanks.  I've updated the spec to use C.UTF-8, too.

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/mavit/twitter-twemoji-fonts/fedora-rawhide-x86_64/00663056-twitter-twemoji-fonts/twitter-twemoji-fonts-2.3.1-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517584] Review Request: ocaml-qtest - Inline (Unit) Tests for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517584



--- Comment #9 from Fedora Update System  ---
ocaml-qtest-2.7-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e919a8a36e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517584] Review Request: ocaml-qtest - Inline (Unit) Tests for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517584

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
ocaml-qtest-2.7-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f39db4e34f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274



--- Comment #10 from Jeremy Bicha  ---
(In reply to Peng Wu from comment #8)
> The problem is that nototools can't by installed when we package,
> the upstream didn't tell when the tools can be installed.

I don't think that's true. It works fine in Debian (but Debian has a lot of
tools to automatically do the right thing for Python packages).

In Debian, nototools ships all the stuff from
/usr/lib/python2.7/dist-packages/nototools/

but for /usr/bin, only add_vs_cmap is installed (with the .py suffix dropped.
If you do that, you'll need to patch the Noto Color Emoji build script to look
for add_vs_cmap without the .py suffix too)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706



--- Comment #3 from Sandro Mani  ---
sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g;
s|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool

seems sufficient, without the need to call autoreconf, or am I missing
something?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525706] Review Request: enchant2 - An Enchanting Spell Checking Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525706

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---

 - The package contains a bundled gnulib thus you need to add a:

Provides:  bundled(gnulib)

 - Rpath issues:

enchant2.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/enchant-2
['/usr/lib64']
enchant2.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/enchant-lsmod-2
['/usr/lib64']
enchant2.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/enchant-2/enchant_hunspell.so ['/usr/lib64']
enchant2-aspell.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/enchant-2/enchant_aspell.so ['/usr/lib64']
enchant2-voikko.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/enchant-2/enchant_voikko.so ['/usr/lib64']

   Fix it in %build:

%build
autoreconf -vif
%configure \
--with-aspell \
--with-hunspell-dir=%{_datadir}/myspell \
--disable-static

sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g;
s|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool

You'll need to add BR:

BuildRequires: automake
BuildRequires: libtool

 - There are files with header containing an older incorrect FSF address. Patch
them and notify upstream:

enchant2-devel.x86_64: E: incorrect-fsf-address
/usr/include/enchant-2/enchant++.h
enchant2-devel.x86_64: E: incorrect-fsf-address
/usr/include/enchant-2/enchant-provider.h
enchant2-devel.x86_64: E: incorrect-fsf-address
/usr/include/enchant-2/enchant.h
enchant2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/enchant2-2.2.0-1.fc28.x86_64/providers/enchant_aspell.c
enchant2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/enchant2-2.2.0-1.fc28.x86_64/providers/enchant_hunspell.cpp
enchant2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/enchant2-2.2.0-1.fc28.x86_64/src/enchant-lsmod.c
enchant2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/enchant2-2.2.0-1.fc28.x86_64/src/enchant-provider.h
enchant2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/enchant2-2.2.0-1.fc28.x86_64/src/enchant.c
enchant2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/enchant2-2.2.0-1.fc28.x86_64/src/enchant.h
enchant2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/enchant2-2.2.0-1.fc28.x86_64/src/lib.c
enchant2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/enchant2-2.2.0-1.fc28.x86_64/src/pwl.c
enchant2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/enchant2-2.2.0-1.fc28.x86_64/src/pwl.h

  Fix it with:

%prep
%autosetup -p1 -n enchant-%{version}

find -type f -print0 | xargs -0 sed -i \
  's|59 Temple Place - Suite 330|51 Franklin Street, Fifth Floor|;
   s|02111-1307|02110-1301|'


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Provides: bundled(gnulib) in place as required.
  Note: Bundled gnulib but no Provides: bundled(gnulib)
  See:
 
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Requirement_if_you_bundle


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Rpath absent or only used for internal libs.
 Note: See rpmlint output
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "LGPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated", "MIT/X11 (BSD like)", "*No copyright* LGPL", "LGPL (v3 or
 later)", "FSF All Permissive", "GPL (v2 or later) (with incorrect FSF
 address)", "LGPL (v2.1 or later)", "GPL (v3)". 98 files have unknown
 license. Detailed output of licensecheck in
 /home/bob/packaging/review/enchant2/review-enchant2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.

[Bug 1525860] Review Request: naver-nanum-gothic-coding-fonts - Nanum Gothic Coding family of Korean TrueType fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525860

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



--- Comment #1 from Parag AN(पराग)  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Suggestions:
1) Remove Group: tag

2) There is no appstream metainfo file. Please write one and install to the
upstream recommended new location /usr/share/metainfo
See
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Fonts.html

3) Do not reset to older builds, always start renamed package from where we
left old package so this package should have
Version:2.000
Release:9%{?dist}

and

# Remove in F30
Provides:   nhn-nanum-gothic-coding-fonts = %{version}-9
Obsoletes:  nhn-nanum-gothic-coding-fonts < 2.000-9

4) Follow
https://pagure.io/fontpackages/raw/master/f/spec-templates/spectemplate-fonts-simple.spec
and add %check also

5) Good to document reason why this rename is happening just above Obsoletes:
and Provides: line


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 2 files have unknown license. Detailed
 output of licensecheck in /home/parag/1525860-naver-nanum-gothic-
 coding-fonts/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: SourceX tarball 

[Bug 1525490] Review Request: cwm - calm window manager from OpenBSD project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525490



--- Comment #2 from Bruno Meneguele  ---
Hi Robert-André,

thanks for the quick review! And indeed, I missed the license file because on
official repo it was removed once all source files had the license within (it
seems to be a bit difference philosophy :) ). But I did what you suggested:
copied the LICENSE file from older source tree and also added BSD to "License:
" field.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/bmeneguele/cwm/fedora-rawhide-x86_64/00687312-cwm/cwm.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bmeneguele/cwm/fedora-rawhide-x86_64/00687312-cwm/cwm-6.2-1.fc28.src.rpm

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525906] Review Request: js-respond - A fast & lightweight polyfill for min/ max-width CSS3 Media Queries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525906

Xavier Bachelot  changed:

   What|Removed |Added

Summary|Review Request: js-respond  |Review Request: js-respond
   |- A fast & lightweight  |- A fast & lightweight
   |polyfill for min/max-width  |polyfill for min/max-width
   |CSS3 Media Queries   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525906] New: Review Request: js-respond - A fast & lightweight polyfill for min/ max-width CSS3 Media Queries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525906

Bug ID: 1525906
   Summary: Review Request: js-respond - A fast & lightweight
polyfill for min/max-width CSS3 Media Queries
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: xav...@bachelot.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://www.bachelot.org/fedora/SPECS/js-respond.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/js-respond-1.4.2-1.fc27.src.rpm

Description:
The goal of this script is to provide a fast and lightweight (3kb minified /
1kb gzipped) script to enable responsive web designs in browsers that don't
support CSS3 Media Queries - in particular, Internet Explorer 8 and under.
It's written in such a way that it will probably patch support for other
non-supporting browsers as well.

Fedora Account System Username: xavierb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520570] Review Request: perl-Scalar-String - String aspects of scalars

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520570



--- Comment #9 from Fedora Update System  ---
perl-Scalar-String-0.003-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2ef3dd9357

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1524504] Review Request: python-gattlib - Library to access Bluetooth LE devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1524504



--- Comment #11 from Fedora Update System  ---
pybluez-0.22-8.fc27, python-gattlib-0.20150805-2.fc27 has been pushed to the
Fedora 27 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d2779719df

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514208] Review Request: ghc-gi-ggit - Libgit2-glib bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514208

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
ghc-gi-ggit-1.0.1-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-64aa7c8dde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517006] Review Request: vimiv - An image viewer with vim-like keybindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517006



--- Comment #16 from Fedora Update System  ---
vimiv-0.9.1-4.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dde3662529

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jitka Plesnikova  ---
> Description 
> TODO: Please update the description to provide a bit more information. 
>   E.g. to something like this:
>   Algorithm::Loops provides several functions (NestedLoops, MapCar*, Filter,
>   and NextPermute*) for doing different types of looping constructs. By
>   default, no functions are exported into a namespace.
Ok.

> BuildRequires are ok
> FIX: Please add the version restriction for perl(ExtUtils::MakeMaker) to
>  6.76 or higher, because NO_PACKLIST option was added in this version.
Ok.

> $ rpm -qp --requires perl-Algorithm-Loops-1.032-1.fc28.noarch.rpm | sort |
> uniq -c
>   1 perl(Carp)
>   2 perl(Exporter)
>   1 perl(:MODULE_COMPAT_5.26.1)
>   2 perl(strict)
>   2 perl(vars)
>   1 perl(warnings)
>   1 rpmlib(CompressedFileNames) <= 3.0.4-1
>   1 rpmlib(FileDigests) <= 4.6.0-1
>   1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>   1 rpmlib(PayloadIsXz) <= 5.2-1
> Binary requires are almost Ok.
> FIX: Please remove explicit run-requires of 'perl(Exporter)',
>  'perl(strict)' and 'perl(vars)', because they are found by
>  generators.
Ok.


> TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in
> %install.
Ok.

> TODO: Please add 'ex' to %doc.
Not change.

The package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525900] New: Review Request: js-html5shiv - Enable use of HTML5 sectioning elements in legacy browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525900

Bug ID: 1525900
   Summary: Review Request: js-html5shiv - Enable use of HTML5
sectioning elements in legacy browsers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: xav...@bachelot.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://www.bachelot.org/fedora/SPECS/js-html5shiv.spec
SRPM URL:
https://www.bachelot.org/fedora/SRPMS/js-html5shiv-3.7.3-1.fc27.src.rpm

Description:
The HTML5 Shiv enables use of HTML5 sectioning elements in legacy Internet
Explorer and provides basic HTML5 styling for Internet Explorer 6-9, Safari 4.x
(and iPhone 3.x), and Firefox 3.x.

Fedora Account System Username: xavierb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481645] Review Request: python-pyobd - OBD-II (SAE-J1979) compliant scantool software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481645



--- Comment #15 from Jaroslav Škarvada  ---
(In reply to Raphael Groner from comment #14)
> APPROVED
>
Thanks.

> - Did you poke upstream about incorrect FSF address? See rpmlint warnings
> below.
>
Yes, I sent the patch upstream.

> - Please do not forget to retire pyopd after successful import of this
> package.
OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525860] Review Request: naver-nanum-gothic-coding-fonts - Nanum Gothic Coding family of Korean TrueType fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525860

Peng Wu  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|panem...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525860] New: Review Request: naver-nanum-gothic-coding-fonts - Nanum Gothic Coding family of Korean TrueType fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525860

Bug ID: 1525860
   Summary: Review Request: naver-nanum-gothic-coding-fonts -
Nanum Gothic Coding family of Korean TrueType fonts
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: p...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://pwu.fedorapeople.org/fonts/naver-nanum-gothic-coding-fonts/naver-nanum-gothic-coding-fonts.spec
SRPM URL:
https://pwu.fedorapeople.org/fonts/naver-nanum-gothic-coding-fonts/naver-nanum-gothic-coding-fonts-2.000-1.fc26.src.rpm
Description: Nanum Gothic Coding family of Korean TrueType fonts
Fedora Account System Username:pwu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373007] Review Request: rubygem-cool.io - A cool framework for doing high performance I/O in Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373007

Sandro Bonazzola  changed:

   What|Removed |Added

  Flags||needinfo?(rmeggins@redhat.c
   ||om)



--- Comment #4 from Sandro Bonazzola  ---
Rich, any chance you can help with comment #3?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274



--- Comment #9 from Peng Wu  ---
(In reply to Peter Oliver from comment #6)
> Peng Wu: Do you please happen to remember why the spec file for
> google-noto-emoji-fonts includes the following lines?
> 
> > # Work around UTF-8
> > export LANG=zh_CN.UTF-8

Because the python script of build process will print Unicode character,
by default python 2 will crash with Unicode character in koji.

By setting non-English locale will work around the crash.

Thanks for the comments, I changed it to "C.UTF-8" now. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org