[Bug 1539554] New: Review Request: php-phpunit-php-invoker2 - Invoke callables with a timeout

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539554

Bug ID: 1539554
   Summary: Review Request: php-phpunit-php-invoker2 - Invoke
callables with a timeout
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://git.remirepo.net/cgit/rpms/php/phpunit/php-phpunit-php-invoker2.git/plain/php-phpunit-php-invoker2.spec?id=4cb460f06ef7c50e976069513e56d5699fe803a8
SRPM URL:
http://rpms.remirepo.net/SRPMS/php-phpunit-php-invoker2-2.0.0-1.remi.src.rpm
Description: 
phpunit/php-invoker provides the means to invoke a callable with a timeout.

Autoloader: /usr/share/php/SebastianBergmann/Invoker/autoload.php


Fedora Account System Username: remi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436734] Review Request: ocfs2-tools - Tools for managing the Oracle Cluster Filesystem 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436734

Robin Lee  changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #3 from Robin Lee  ---
Spec URL: https://cheeselee.fedorapeople.org/ocfs2-tools.spec
SRPM URL: https://cheeselee.fedorapeople.org/ocfs2-tools-1.8.5-2.fc28.src.rpm

Re-open for review.

Changes:
- Fix build for f28
- Move COPYING to %%license
- Use %%make_install
- one BR or R per line

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - VPNs on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #10 from digimer  ---
I'll need a sponsor to take the next step in packaging this RPM for fedora.
Would anyone on this BZ be interested/able to do that for me? If not, I'll post
in the main list.

Cheers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539319] Review Request: ghc-data-default-instances-old-locale - Default instances for types in old-locale

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539319

Jens Petersen  changed:

   What|Removed |Added

 Status|POST|MODIFIED
   Fixed In Version||ghc-data-default-instances-
   ||old-locale-0.0.1-5.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539318] Review Request: ghc-data-default-instances-dlist - Default instances for types in dlist

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539318

Jens Petersen  changed:

   What|Removed |Added

 Status|POST|MODIFIED
   Fixed In Version||ghc-data-default-instances-
   ||dlist-0.0.1-5.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539317] Review Request: ghc-data-default-instances-containers - Default instances for types in containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539317

Jens Petersen  changed:

   What|Removed |Added

 Status|POST|MODIFIED
   Fixed In Version||ghc-data-default-instances-
   ||containers-0.0.1-5.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #15 from Fedora Update System  ---
python-giacpy-0.6.5-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-28145db148

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #23 from Fedora Update System  ---
timeshift-18.1.1-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8ccaa9e31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
python-giacpy-0.6.5-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5e0bc7a4b2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #22 from Fedora Update System  ---
timeshift-18.1.1-2.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d465f39a50

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476458] Review Request: paho-c - MQTT client library in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476458

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #33 from Fedora Update System  ---
paho-c-1.2.0-10.el6 has been pushed to the Fedora EPEL 6 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-f9bab306e7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #21 from Fedora Update System  ---
timeshift-18.1.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-c4a955e60b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476458] Review Request: paho-c - MQTT client library in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476458



--- Comment #34 from Fedora Update System  ---
paho-c-1.2.0-10.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-c6252bfaca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532023] Review Request: ddupdate - A Dynamic DNS Updater

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532023

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-28 16:32:30



--- Comment #10 from Fedora Update System  ---
ddupdate-0.2.0-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366



--- Comment #7 from Fedora Update System  ---
linux-driver-management-1.0.2-1.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dfcc2de15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #9 from markusN  ---
Created attachment 1387344
  --> https://bugzilla.redhat.com/attachment.cgi?id=1387344=edit
Updated SPEC file for GRASS GIS 7.4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539257] Review Request: rust-pretty-git-prompt - Your current git repository information inside a beautiful shell prompt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539257

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-28 15:46:38



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #8 from markusN  ---
(In reply to Iwicki Artur from comment #7)
> I compared this with a couple of appdata files I have installed on my system
> and yes, it seems that the value of the "" tag should end with
> ".desktop".

OK, fixed upstream (will then ship with the future GRASS GIS 7.4.1).

The two $RPM_BUILD_ROOT entries needed and not the same as %buildroot
(compilation fails when changing them to %buildroot), so I left them as-is.

All other suggestions are included (new SPEC attached) and compile successfully
on EPEL7 and Fedora:
https://copr.fedorainfracloud.org/coprs/neteler/grass74/build/706613/

Thanks again for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539267] Review Request: rust-tabwriter - Elastic tabstops

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539267

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-28 15:43:23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #20 from Fedora Update System  ---
timeshift-18.1.1-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2034535a48

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #19 from Fedora Update System  ---
timeshift-18.1.1-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f67cb13026

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #18 from Fedora Update System  ---
timeshift-18.1.1-4.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-132058f52d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538067] Review Request: nodejs-decimal-js - A Javascript library for arbitrary-precision arithmetic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538067



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-decimal-js

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/linux-driver-management

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538069] Review Request: nodejs-historic-readline - A JavaScript library extending the node readline module to save history to file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538069



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-historic-readline

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539319] Review Request: ghc-data-default-instances-old-locale - Default instances for types in old-locale

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539319



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-data-default-instances-old-locale. You
may commit to the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539318] Review Request: ghc-data-default-instances-dlist - Default instances for types in dlist

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539318



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-data-default-instances-dlist. You may
commit to the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539317] Review Request: ghc-data-default-instances-containers - Default instances for types in containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539317



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-data-default-instances-containers. You
may commit to the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539257] Review Request: rust-pretty-git-prompt - Your current git repository information inside a beautiful shell prompt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539257



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-pretty-git-prompt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539267] Review Request: rust-tabwriter - Elastic tabstops

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539267



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-tabwriter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #7 from Iwicki Artur  ---
I compared this with a couple of appdata files I have installed on my system
and yes, it seems that the value of the "" tag should end with ".desktop".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #6 from markusN  ---
Thanks to both for the quick review.

(In reply to Iwicki Artur from comment #5)
> >Group: Applications/Engineering
> The "Group:" tag is not used in Fedora.
> 
> ># EPEL7 fails on url tag, so we ignore failure:
> >appstream-util validate-relax --nonet 
> >%{buildroot}/%{_datadir}/appdata/*.appdata.xml || echo "Ignoring 
> >appstream-util failure"
>
> What exactly is the error here?

This one:

appstream-util validate-relax --nonet
/builddir/build/BUILDROOT/grass-7.4.0-2.el7.centos.x86_64//usr/share/appdata/grass.appdata.xml
/builddir/build/BUILDROOT/grass-7.4.0-2.el7.centos.x86_64//usr/share/appdata/grass.appdata.xml:
GLib-GIO-Message: Using the 'memory' GSettings backend.  Your settings will not
be saved or shared with other applications.
FAILED:
? markup-invalid:  does not have correct extension for kind
Validation of files failed

> Could we patch the appdata file so the validation doesn't fail?

The "offending" line is this one:

  org.osgeo.grass

Does it need to be
  org.osgeo.grass.desktop
?

> >%post
> >/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
> >
> >%postun
> >if [ $1 -eq 0 ] ; then
> > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
> > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || 
> > :
> >fi
> >
> >%posttrans
> >/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> The icon cache scriplets are no longer used in Fedora. These should be made
> EPEL-only.
> 
> Another minor issue I can see is the mixed use of $RPM_BUILD_ROOT and
> %buildroot. It is preferred to pick one and stick with it.

OK, thanks. I am now testing with an updated SPEC file which includes fixes as
per comment 4.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446

Björn 'besser82' Esser  changed:

   What|Removed |Added

 CC||besse...@fedoraproject.org



--- Comment #17 from Björn 'besser82' Esser  ---
This package does not follow the packaging guidelines, as it does NOT apply the
systems LDFLAGS properly!  I've fixed that in dist-git [1] and triggered a
rebuild for all distros.


[1]  https://src.fedoraproject.org/rpms/timeshift/c/483bd66

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #5 from Iwicki Artur  ---
>Group: Applications/Engineering
The "Group:" tag is not used in Fedora.

># EPEL7 fails on url tag, so we ignore failure:
>appstream-util validate-relax --nonet 
>%{buildroot}/%{_datadir}/appdata/*.appdata.xml || echo "Ignoring 
>appstream-util failure"
What exactly is the error here? Could we patch the appdata file so the
validation doesn't fail?

>%post
>/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
>
>%postun
>if [ $1 -eq 0 ] ; then
>   /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
>   /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || 
> :
>fi
>
>%posttrans
>/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
The icon cache scriplets are no longer used in Fedora. These should be made
EPEL-only.

Another minor issue I can see is the mixed use of $RPM_BUILD_ROOT and
%buildroot. It is preferred to pick one and stick with it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #4 from Antonio Trande  ---
- Fix dependencies between packages:

%{name}%{?isa}-libs = %{version}-%{release} becomes
%{name}-libs%{?_isa} = %{version}-%{release}

or

%{name}%{?isa} = %{version}-%{release} becomes
%{name}%{?_isa} = %{version}-%{release}

- '-gui' sub-package already gets 'grass-libs' through 'grass'; line #110 can
be removed.

- appdata.xml files go into '/usr/share/metainfo'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538067] Review Request: nodejs-decimal-js - A Javascript library for arbitrary-precision arithmetic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538067

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

Antonio Trande  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #3 from markusN  ---
No, I am not sponsored so far. My goal is to get this update of GRASS GIS into
Fedora which addresses most (all?) of the open bugs:

https://bugzilla.redhat.com/buglist.cgi?component=grass_id=8348120=Fedora

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Antonio Trande  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366



--- Comment #4 from Neal Gompa  ---
(In reply to Antonio Trande from comment #3)
> - Please, include CC-BY-SA as lincense
> 
> CC by-sa (v3.0)
> ---
> linux-driver-management-1.0.2/man/ldm-session-init.1.md
> linux-driver-management-1.0.2/man/mkmodaliases.1.md
> 

Fixing.

> - Following directories look owned by other packages.
> 
> Note: Directories without known owners: /usr/share/gir-1.0, /usr/share
>  /gtk-doc (gtk-doc), /usr/share/vala/vapi (vala),
> /usr/share/gtk-doc/html (gtk-doc),
>  /usr/lib64/girepository-1.0, /usr/share/vala (vala)
> 

It seems to be common to not own those directories or require their packages, a
number of other ones do the same thing, presumably to avoid unnecessary
dependencies.

> - Some tests are failed but should occur for missing hardware.
> 

I'm in contact with the upstream developer, and he's assured me that this is
related to umockdev being fickle, and has little to do with the application
itself. I run the tests because I want to see the programs execute, not because
I necessarily care about the output.

> - Some minor issues from rpmlint.
> 

Aside from the devel dependency error, these are all false positives.

> - Some headers look not installed; see following note.
> 

Those are false positives related to debuginfo+debugsource generation.



Valid issues fixed. New links below (release unchanged).

Spec URL:
http://kinginuyasha.enanocms.org/downloads/linux-driver-management.spec

SRPM URL:
http://kinginuyasha.enanocms.org/downloads/linux-driver-management-1.0.2-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538067] Review Request: nodejs-decimal-js - A Javascript library for arbitrary-precision arithmetic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538067



--- Comment #2 from Timothée Floure  ---
Thank you for the dl-test.sh script, I didn't know it.

Updated specfile and source RPM :

Spec URL:
https://fedorapeople.org/~fnux/pkg-reviews/nodejs-decimal-js/nodejs-decimal-js.spec
SRPM URL:
https://fedorapeople.org/~fnux/pkg-reviews/nodejs-decimal-js/nodejs-decimal-js-9.0.1-2.fc26.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366



--- Comment #3 from Antonio Trande  ---
- Please, include CC-BY-SA as lincense

CC by-sa (v3.0)
---
linux-driver-management-1.0.2/man/ldm-session-init.1.md
linux-driver-management-1.0.2/man/mkmodaliases.1.md

- Following directories look owned by other packages.

Note: Directories without known owners: /usr/share/gir-1.0, /usr/share
 /gtk-doc (gtk-doc), /usr/share/vala/vapi (vala), /usr/share/gtk-doc/html
(gtk-doc),
 /usr/lib64/girepository-1.0, /usr/share/vala (vala)

- Some tests are failed but should occur for missing hardware.

- Some minor issues from rpmlint.

- Some headers look not installed; see following note.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: linux-driver-management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/cli/cli.h linux-driver-management-
  debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/bluetooth-device.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/device.h linux-driver-management-
  debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/dmi-device.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/glx-manager.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/gpu-config.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/hid-device.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/ldm-private.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/manager-private.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/manager.h linux-driver-management-
  debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/modalias.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/pci-device.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/plugin.h linux-driver-management-
  debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/plugins/modalias-plugin.h linux-
  driver-management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/provider.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/usb-device.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/src/lib/wifi-device.h linux-driver-
  management-debugsource : /usr/src/debug/linux-driver-
  management-1.0.2-1.fc28.x86_64/x86_64-redhat-linux-gnu/src/lib/ldm-
  enums.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "CC by-sa (v3.0)", "LGPL (v2.1 or later)", "Unknown or
 generated". 75 files have unknown license. Detailed output of
 licensecheck in /home/sagitter/1539366-linux-driver-
 management/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gir-1.0, /usr/share
 /gtk-doc, /usr/share/vala/vapi, /usr/share/gtk-doc/html,
 /usr/lib64/girepository-1.0, /usr/share/vala
[?]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(kde-
 platform-plugin, libreport-plugin-kerneloops, cups-client, efivar-
 libs, netcdf, policycoreutils-python-utils, lz4-libs, qemu-block-
  (fedora-review bug?)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain 

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

Antonio Trande  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com



--- Comment #2 from Antonio Trande  ---
Are you sponsored?
fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #1 from markusN  ---
I have made a minor update (included as a patch), now it also compiles on
EPEL7:

http://data.neteler.org/tmp/grass-7.4.0-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535549] Review Request: mupen64plus - Nintendo 64 Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535549

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #11 from Robert-André Mauchin  ---
> So, what to do about this? 

Just notify upstream about it.


Package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538069] Review Request: nodejs-historic-readline - A JavaScript library extending the node readline module to save history to file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538069

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
All ok, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538219] Review Request: rubygem-guard-shell - Guard gem for running shell commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538219

Vít Ondruch  changed:

   What|Removed |Added

 Blocks||1526056




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1526056
[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based
system for authoring and publishing documentation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based system for authoring and publishing documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526056

Vít Ondruch  changed:

   What|Removed |Added

 Depends On||1538219



--- Comment #6 from Vít Ondruch  ---
Here is updated version:

Spec URL:
https://fedorapeople.org/cgit/vondruch/public_git/rubygem-ascii_binder.git/plain/rubygem-ascii_binder.spec?id=9f17644089c8a66bfa09cc7356a55b67b805f488
SRPM URL:
http://people.redhat.com/vondruch/rubygem-ascii_binder-0.1.14-2.fc28.src.rpm

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=24514805

It fixes the trollop BR and since rubygem-guard-shell is available now in
Fedora, it enables the dependency. The guard-livereload is still disabled,
since it is not in Fedora and moreover, it requires browser extension. Will see
if we will get that into the Fedora.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538219
[Bug 1538219] Review Request: rubygem-guard-shell - Guard gem for running
shell commands
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538069] Review Request: nodejs-historic-readline - A JavaScript library extending the node readline module to save history to file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538069



--- Comment #2 from Timothée Floure  ---
Updated specfile and SRPM addressing the two fisrt issues :
Spec URL:
https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline/nodejs-historic-readline.spec
SRPM URL:
https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline/nodejs-historic-readline-1.0.8-3.fc26.src.rpm

I also opened an issue [0] with upstream regarding the LICENSE file.

Thanks for the review !

[0] https://github.com/Centiq/historic-readline/issues/3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #18 from Mathieu Bridon  ---
>> Alright Mathieu I will take those packages.
> 
> I just made you admin for those 3 packages.
> 
> Somehow I can't find how to remove myself, though. :-/

And I just found it, thanks to Pierre-Yves.

They are all yours now, take good care of them. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539281] Review Request: rust-chan - Multi-producer, multi-consumer channels with select

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539281



--- Comment #5 from Randy Barlow  ---
Igor, I've added the rust-sig! I'm also adding an f27 branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366



--- Comment #2 from Neal Gompa  ---
Fixed. New links below (release unchanged).

Spec URL:
http://kinginuyasha.enanocms.org/downloads/linux-driver-management.spec

SRPM URL:
http://kinginuyasha.enanocms.org/downloads/linux-driver-management-1.0.2-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491216



--- Comment #19 from Neal Gompa  ---

> Source0:
> https://github.com/SatelliteQE/%{name}/archive/%{version}.tar.gz

Could you change this to:

Source0:   
https://github.com/SatelliteQE/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

This reflects the recommended form per the guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags

> %autosetup -n %{name}-%{version}

This can just be "%autosetup"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||anto.tra...@gmail.com
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Antonio Trande  ---
ldconfig scripts are absent.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] New: Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366

Bug ID: 1539366
   Summary: Review Request: linux-driver-management - Generic
driver management framework for Linux
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ngomp...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/Linux-Driver-Management/fedora-27-x86_64/00706524-linux-driver-management/linux-driver-management.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/Linux-Driver-Management/fedora-27-x86_64/00706524-linux-driver-management/linux-driver-management-1.0.2-1.fc27.src.rpm

Description:
Linux Driver Management provides a core library and some tooling
to enable the quick and easy enumeration of system devices,
and functionality to match devices to packages/drivers.

This is designed to be as agnostic as feasible whilst supporting
a wide range of device classes, to provide a building block for
driver management and discovery in Linux distributions.


Fedora Account System Username: ngompa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #17 from Mathieu Bridon  ---
> Alright Mathieu I will take those packages.

I just made you admin for those 3 packages.

Somehow I can't find how to remove myself, though. :-/

>> Please take them, Michal; it's only fair :)
> 
> Also, I think Python SIG might be interested in co-maintaining those packages.

The Python SIG already had commit permissions on all 3 packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539359] Review Request: rust-take - Cell allowing the inner value to be consumed without a mutable reference

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539359

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1539362 (rust-tokio-proto)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1539362
[Bug 1539362] Review Request: rust-tokio-proto - Network application
framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539357] Review Request: rust-tokio-service - Core `Service` trait for Tokio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539357

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1539362 (rust-tokio-proto)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1539362
[Bug 1539362] Review Request: rust-tokio-proto - Network application
framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539362] Review Request: rust-tokio-proto - Network application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539362

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1539359 (rust-take),
   ||1539357
   ||(rust-tokio-service)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1539357
[Bug 1539357] Review Request: rust-tokio-service - Core `Service` trait for
Tokio
https://bugzilla.redhat.com/show_bug.cgi?id=1539359
[Bug 1539359] Review Request: rust-take - Cell allowing the inner value to
be consumed without a mutable reference
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539362] New: Review Request: rust-tokio-proto - Network application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539362

Bug ID: 1539362
   Summary: Review Request: rust-tokio-proto - Network application
framework
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-proto.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-proto-0.1.1-1.fc28.src.rpm
Description:
Network application framework.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491216



--- Comment #18 from Pavlina Moravcova Varekova  ---
Thank you very much. Files are corrected:
Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec
SRPM URL:
https://people.redhat.com/pmoravec/5minute/5minute-0.2.26-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539359] New: Review Request: rust-take - Cell allowing the inner value to be consumed without a mutable reference

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539359

Bug ID: 1539359
   Summary: Review Request: rust-take - Cell allowing the inner
value to be consumed without a mutable reference
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-take.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-take-0.1.0-1.fc28.src.rpm
Description:
Cell allowing the inner value to be consumed without a mutable reference.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539319] Review Request: ghc-data-default-instances-old-locale - Default instances for types in old-locale

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539319



--- Comment #2 from Jens Petersen  ---
Thanks a lot, Elliot

https://pagure.io/releng/fedora-scm-requests/issue/4308

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539318] Review Request: ghc-data-default-instances-dlist - Default instances for types in dlist

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539318



--- Comment #2 from Jens Petersen  ---
Thank you very much!

https://pagure.io/releng/fedora-scm-requests/issue/4307

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539317] Review Request: ghc-data-default-instances-containers - Default instances for types in containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539317



--- Comment #2 from Jens Petersen  ---
Thank you, Elliot

https://pagure.io/releng/fedora-scm-requests/issue/4306

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539357] New: Review Request: rust-tokio-service - Core `Service` trait for Tokio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539357

Bug ID: 1539357
   Summary: Review Request: rust-tokio-service - Core `Service`
trait for Tokio
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-service.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-service-0.1.0-1.fc28.src.rpm
Description:
Core `Service` trait for Tokio.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org