[Bug 1520922] Review Request: extractpdfmark - Extract page mode and named destinations as PDFmark from PDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520922



--- Comment #11 from William Moreno  ---
(In reply to Federico Bruni from comment #6)
> (In reply to William Moreno from comment #4)
> > Hello
> > 
> > Advancing with this review in fedora we do not need:
> > 
> > rm -rf %{buildroot}
> > 
> > And the changelog is missing the - %{version}.%{release} information.
> 
> Thanks William, I've made the changes requested, pushed to Pagure repo and
> made a new build here:
> https://copr.fedorainfracloud.org/coprs/fedelibre/extractpdfmark/build/
> 702296/
> 
> I'll check Omar's review in the next days

Hello Federico I have seen a real interest in you to become a packager, please
post the last version of your spec file and source rpm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #17 from Fedora Update System  ---
python-giacpy-0.6.5-3.fc27 qcas-0.5.3-5.fc27 giac-1.4.9.45-2.fc27 has been
submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6fd9d49e4d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #16 from Fedora Update System  ---
python-giacpy-0.6.5-3.fc26 qcas-0.5.3-5.fc26 giac-1.4.9.45-2.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-20e6c0f7cc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495293] Review Request: python-Naked - A command line application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495293



--- Comment #7 from Fedora Update System  ---
python-Naked-0.1.31-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-472ea01f77

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495293] Review Request: python-Naked - A command line application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535549] Review Request: mupen64plus - Nintendo 64 Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535549



--- Comment #13 from Wade Berrier  ---
I guess I need a sponsor?

My pagure.io requests were closed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520922] Review Request: extractpdfmark - Extract page mode and named destinations as PDFmark from PDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520922



--- Comment #10 from marcindulak  ---
(In reply to Björn Persson from comment #9)
> (In reply to marcindulak from comment #8)
> > mv %{buildroot}%{_docdir}/%{name} %{buildroot}%{_pkgdocdir}
> 
> Where those aren't equal, the correct solution is to pass
> "--docdir=%{_pkgdocdir}" to configure. That should work as Autoconf is used.

As:

%configure --docdir=%{_pkgdocdir}

and not as

./configure --docdir=%{_pkgdocdir}

as I've tried initially.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520922] Review Request: extractpdfmark - Extract page mode and named destinations as PDFmark from PDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520922

Björn Persson  changed:

   What|Removed |Added

 CC||bj...@xn--rombobjrn-67a.se



--- Comment #9 from Björn Persson  ---
(In reply to marcindulak from comment #8)
> mv %{buildroot}%{_docdir}/%{name} %{buildroot}%{_pkgdocdir}

Where those aren't equal, the correct solution is to pass
"--docdir=%{_pkgdocdir}" to configure. That should work as Autoconf is used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535549] Review Request: mupen64plus - Nintendo 64 Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535549



--- Comment #12 from Wade Berrier  ---
Upstream notified about the incorrect addresses in the license files:

https://github.com/mupen64plus/mupen64plus-core/issues/527

Git repo requests:

f27:

https://pagure.io/releng/fedora-scm-requests/issue/4359

f26:

https://pagure.io/releng/fedora-scm-requests/issue/4360

I've been following the instructions at
https://fedoraproject.org/wiki/Package_Review_Process

Anything else other than what's in there that I need to do?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274



--- Comment #23 from Neal Gompa  ---
@Peter, I need specifically links laid out specifically as they are in the
original post, so that fedora-review can process it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #22 from Alexander Ploumistos  ---
Also, I installed molsketch and all its subpackages in mock (built using the
same spec file as in koji build 24441314) and there were no errors:

$ mock -r fedora-rawhide-x86_64 --install
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-doc-0.5.1-4.fc28.noarch.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-devel-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debugsource-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debuginfo-0.5.1-4.fc28.x86_64.rpm

INFO: mock.py version 1.4.8 starting (python version = 3.6.4)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.8
INFO: Mock Version: 1.4.8
Finish: chroot init
INFO: installing package(s):
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-doc-0.5.1-4.fc28.noarch.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-devel-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debugsource-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debuginfo-0.5.1-4.fc28.x86_64.rpm

[…]

Installed:
  molsketch.x86_64 0.5.1-4.fc28  
molsketch-debuginfo.x86_64 0.5.1-4.fc28   molsketch-debugsource.x86_64
0.5.1-4.fc28
  molsketch-devel.x86_64 0.5.1-4.fc28
molsketch-doc.noarch 0.5.1-4.fc28 SDL.x86_64 1.2.15-29.fc28 
  atk.x86_64 2.27.1-1.fc28   
gdk-pixbuf2-modules.x86_64 2.36.11-1.fc28 gtk-update-icon-cache.x86_64
3.22.26-2.fc28  
  gtk2.x86_64 2.24.32-1.fc28 
openbabel.x86_64 2.4.1-10.fc28qt5-designer.x86_64
5.10.0-2.fc28
  qt5-doctools.x86_64 5.10.0-2.fc28  
qt5-linguist.x86_64 5.10.0-2.fc28 qt5-qttools.x86_64
5.10.0-2.fc28 
  qt5-qttools-common.noarch 5.10.0-2.fc28
qt5-qttools-devel.x86_64 5.10.0-2.fc28   
qt5-qttools-libs-designer.x86_64 5.10.0-2.fc28   
  qt5-qttools-libs-designercomponents.x86_64 5.10.0-2.fc28   
qt5-qttools-libs-help.x86_64 5.10.0-2.fc28wxBase.x86_64 2.8.12-29.fc27  
  wxGTK.x86_64 2.8.12-29.fc27

Complete!
INFO: 
Finish: run

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #21 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #7)
> >- Header files in -devel subpackage, if present.
> >  Note: molsketch-debugsource :
> >  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
> >  molsketch-debugsource :
> > ...
> 
> 'qmake' does not install all header files, i don't know why. Can you ask to
> upstream which headers must be provided?

Hendrik looked into that one:

> after having had a look at the RPM's content I'm confused... It appears to 
> contain everything from the source, headers, cpp files, even the generated 
> headers and sources (i.e. Qt's moc files). Did they give you any hints as to 
> what is missing? Or how we can test it? Were they not able to properly debug 
> it (i.e. did the debugger not find the files?)?

And it's true, the devel subpackage contains even the generated headers, not
just the original ones, so what is the problem there?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274

Peter Oliver  changed:

   What|Removed |Added

  Flags|needinfo?(ma...@mavit.org.u |
   |k)  |



--- Comment #22 from Peter Oliver  ---
Latest is:

SRPM:
https://copr-be.cloud.fedoraproject.org/results/mavit/twitter-twemoji-fonts/fedora-rawhide-x86_64/00705303-twitter-twemoji-fonts/twitter-twemoji-fonts-2.4.0-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520922] Review Request: extractpdfmark - Extract page mode and named destinations as PDFmark from PDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520922

marcindulak  changed:

   What|Removed |Added

 CC||marcin.du...@gmail.com



--- Comment #8 from marcindulak  ---
About the problem with duplicate COPYING: a simple rm will be easier to
maintain, moreover COPYING is not the only packaging problem, try to rpmbuild
for EPEL7.

If you prefer to maintain a patch then look how other distributions solved the
problem - Debian already uses such patch:
https://sources.debian.org/patches/extractpdfmark/1.0.2-1/0002-Exclude-some-docs-from-install.patch/

%install
%make_install
rm -f %{buildroot}%{_docdir}/%{name}/COPYING
mv %{buildroot}%{_docdir}/%{name} %{buildroot}%{_pkgdocdir}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #61 from Sergio Monteiro Basto  ---
(In reply to Hans de Goede from comment #51)

> - Use pkgconfig to get include/libs instead of hardcoding (rhbz#1534595)

we can't use pkgconf, for example: 

pkgconf --cflags libxml-2.0

-I/usr/include/libxml2 

when we have to use [1] and result with pkgconf is [2] , which doesn't work .

[1]
SDK_VBOX_LIBXML2_INCS=/usr/include/libxml2

[2]
SDK_VBOX_LIBXML2_INCS=-I/usr/include/libxml2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org