[Bug 1559249] Review Request: langpacks-install - Tool to get auto installed langpacks on GNOME session startup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559249



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25871396

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559249] New: Review Request: langpacks-install - Tool to get auto installed langpacks on GNOME session startup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559249

Bug ID: 1559249
   Summary: Review Request: langpacks-install - Tool to get auto
installed langpacks on GNOME session startup
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org/fedora-work/langpacks-install.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/langpacks-install-1.0.0-2.fc28.src.rpm

Description:
This tool will help to automatically install the langpacks on your system.
It automatically runs at the start of GNOME desktop environment. It will
first check if langpacks package for your language is already installed
or not. If not then ask the PackageKit to install that package. Its then
upto end user to check the PackageKit notification and install the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559247] Review Request: embree2 - Collection of high-performance ray tracing kernels developed at Intel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559247

Luya Tshimbalanga  changed:

   What|Removed |Added

   Verified||Customer
  Flags||fedora-review+



--- Comment #1 from Luya Tshimbalanga  ---
embree 3.0.0 is not backward compatible with embree 2.17.4 so embree2 was
needed for application like LuxRender and Yafaray

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559247] New: Review Request: embree2 - Collection of high-performance ray tracing kernels developed at Intel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559247

Bug ID: 1559247
   Summary: Review Request: embree2 - Collection of
high-performance ray tracing kernels developed at
Intel
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: l...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/luya/embree2/fedora-28-x86_64/00730830-embree2/embree2.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/luya/embree2/fedora-28-x86_64/00730830-embree2/embree2-2.17.4-1.fc28.src.rpm
Description: A collection of high-performance ray tracing kernels intended to
graphics 
application engineers that want to improve the performance of their
application.
Fedora Account System Username: luya

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558745] Review Request: R-geepack - Generalized Estimating Equation Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558745



--- Comment #6 from Fedora Update System  ---
R-geepack-1.2.1-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-9c92440cb0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558745] Review Request: R-geepack - Generalized Estimating Equation Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558745



--- Comment #5 from Fedora Update System  ---
R-geepack-1.2.1-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-dbf7521288

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558745] Review Request: R-geepack - Generalized Estimating Equation Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558745



--- Comment #4 from Fedora Update System  ---
R-geepack-1.2.1-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f382ce1739

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558745] Review Request: R-geepack - Generalized Estimating Equation Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558745

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558752] Review Request: R-lmodel2 - Model II Regression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558752



--- Comment #6 from Fedora Update System  ---
R-lmodel2-1.7.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b3c1f692da

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558752] Review Request: R-lmodel2 - Model II Regression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558752

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558752] Review Request: R-lmodel2 - Model II Regression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558752



--- Comment #4 from Fedora Update System  ---
R-lmodel2-1.7.3-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d1cdb079b4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558752] Review Request: R-lmodel2 - Model II Regression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558752



--- Comment #5 from Fedora Update System  ---
R-lmodel2-1.7.3-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-604841284f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558751] Review Request: R-labeling - Axis Labeling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558751



--- Comment #6 from Fedora Update System  ---
R-labeling-0.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-395bf1ad07

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558751] Review Request: R-labeling - Axis Labeling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558751



--- Comment #5 from Fedora Update System  ---
R-labeling-0.3-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b2f670e67f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558751] Review Request: R-labeling - Axis Labeling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558751



--- Comment #4 from Fedora Update System  ---
R-labeling-0.3-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7fda6e513b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558751] Review Request: R-labeling - Axis Labeling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558751

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558748] Review Request: R-gtable - Arrange 'Grobs' in Tables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558748



--- Comment #6 from Fedora Update System  ---
R-gtable-0.2.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-35ca58054b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558748] Review Request: R-gtable - Arrange 'Grobs' in Tables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558748



--- Comment #5 from Fedora Update System  ---
R-gtable-0.2.0-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dbbc1ccae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558748] Review Request: R-gtable - Arrange 'Grobs' in Tables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558748



--- Comment #4 from Fedora Update System  ---
R-gtable-0.2.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0051805804

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558748] Review Request: R-gtable - Arrange 'Grobs' in Tables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558748

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558742] Review Request: R-gee - Generalized Estimation Equation Solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558742



--- Comment #6 from Fedora Update System  ---
R-gee-4.13.19-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-141b514d6b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558742] Review Request: R-gee - Generalized Estimation Equation Solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558742



--- Comment #5 from Fedora Update System  ---
R-gee-4.13.19-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-93f9ae633c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558742] Review Request: R-gee - Generalized Estimation Equation Solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558742

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558742] Review Request: R-gee - Generalized Estimation Equation Solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558742



--- Comment #4 from Fedora Update System  ---
R-gee-4.13.19-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0539911f62

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558752] Review Request: R-lmodel2 - Model II Regression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558752



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-lmodel2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558751] Review Request: R-labeling - Axis Labeling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558751



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-labeling

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558748] Review Request: R-gtable - Arrange 'Grobs' in Tables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558748



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-gtable

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558745] Review Request: R-geepack - Generalized Estimating Equation Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558745



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-geepack

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558742] Review Request: R-gee - Generalized Estimation Equation Solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558742



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-gee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559200] Review Request: R-processx - Execute and Control System Processes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559200



--- Comment #1 from Elliott Sales de Andrade  ---
koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25866392

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559200] New: Review Request: R-processx - Execute and Control System Processes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559200

Bug ID: 1559200
   Summary: Review Request: R-processx - Execute and Control
System Processes
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: quantum.anal...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: https://qulogic.fedorapeople.org//R-processx.spec
SRPM URL: https://qulogic.fedorapeople.org//R-processx-2.0.0.1-1.fc27.src.rpm

Description:
Portable tools to run system processes in the background. It can check if
a background process is running; wait on a background process to finish;
get the exit status of finished processes; kill background processes and
their children; restart processes. It can read the standard output and
error of the processes, using non-blocking connections. 'processx' can
poll a process for standard output or error, with a timeout. It can also
poll several processes at once.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558894] Review Request: R-clipr - Read and Write from the System Clipboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558894

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558892] Review Request: R-callr - Call R from R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558892

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781



--- Comment #7 from Fedora Update System  ---
libdmapsharing4-3.9.1-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-9ab4832284

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558882] Review Request: R-bindrcpp - An 'Rcpp' Interface to Active Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558882

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558859] Review Request: R-poLCA - Polytomous variable Latent Class Analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558859

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558859] Review Request: R-poLCA - Polytomous variable Latent Class Analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558859

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #11 from Jie Kang  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/24x24,
 /usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64,
 /usr/share/icons/hicolor/32x32/apps,
 /usr/share/icons/hicolor/24x24/apps,
 /usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64-debug/lib,
 /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/16x16,
 /usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64-debug,
 /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/48x48/apps,
 /usr/lib/jvm, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id/0d [...]
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in java-openjdk, java-openjdk-debug
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: If the source package does not include license text(s) as a 

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #10 from Jie Kang  ---
(In reply to jiri vanek from comment #6)
> [] Package must own all directories that it creates.
>will be fixed.  Only /usr/lib/jvm should not be owned. it is owned by
> japackage tools. Also I think it is mentioned somewher ein guidelines, but
> have not found. Are you sure with generic /usr/share/ stuff?
> Also I belive I own /usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64
>  at least it is listed for me...

Right, [ ] means to manually check. I guess it wasn't able to automatically
see? I would be suprised about
/usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64 too but anyways, I'm going
to see how it looks on my system.

> [] %config files are marked noreplace or the reason is justified.
>  Note: No (noreplace) in %config
> 
> /etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64/conf/
> management/jmxremote.password.template
>   This one realy do not deserves to be noreplace. It is config tempalte   
> 
>  %config
> 
> /etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64/conf/
> accessibility.properties
>   I had not marked this one, as it contains generated path and shold be
> fully contorlled by packager. Unluvkily, the only palce where jdk founds it
> is conf.

Okay. As it asks for justification, can comments be added to the spec for each
of them?

> 
> Same for debug variants.
> 
> [ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
>  contains icons.
>  Note: icons in java-openjdk, java-openjdk-debug
> 
> It is, inst it?

Checked and you're right, it is invoked.

> 
> 
> [!]: Uses parallel make %{?_smp_mflags} macro.
> I do not dare to use this flag. The build of OJDK is to complex to set
> anything on top.

Okay. This isn't MUST or even SHOULD but EXTRA so can be ignored; thanks for
justification.

> 
> [!]: Spec use %global instead of %define unless justified.
> This is major thing, and cant be fixed. The Usage of %global on top of
> %define is  wrongly interpreted in fedora. If you change any of highlighted
> define to global, the build will misbehave for you. This rpmlint was
> invalidated in f27 and  RPM 4.14. I will try to find the chnageset and
> bugzilla which made me to change those selected globals back to defines.

Okay, your justification sounds good. Is there anyway to add information to the
spec on this? Any point even? 

I'll post an updated review (still two things incomplete) but I will try to
check file ownerships next morning.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #6 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-3.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a90c00a7dd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558874] Review Request: R-R.oo - R Object-Oriented Programming with or without References

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558874

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - Conforms to the Packaging Guidelines

 - Please correct encoding and line endings for:

R-R.oo.noarch: W: wrong-file-end-of-line-encoding
/usr/share/R/library/R.oo/CITATION
R-R.oo.noarch: W: wrong-file-end-of-line-encoding
/usr/share/R/library/R.oo/NEWS
R-R.oo.noarch: W: file-not-utf8 /usr/share/R/library/R.oo/NEWS


Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #5 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-3.fc28 has been submitted as an update to Fedora
28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-46f209a383

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558859] Review Request: R-poLCA - Polytomous variable Latent Class Analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558859



--- Comment #3 from Elliott Sales de Andrade  ---
Toggle fedora-review flag, please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558859] Review Request: R-poLCA - Polytomous variable Latent Class Analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558859

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-gopkg-readline-1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 CC||domi...@greysector.net
 Blocks||1558953




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1558953
[Bug 1558953] Unexpected import path for chzyer's readline library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636

Jared Smith  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jared Smith  ---
Package is APPROVED.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "do What The Fuck you want to Public
 License", "Unknown or generated". 42 files have unknown license.
 Detailed output of licensecheck in
 /home/jsmith/Documents/Fedora/Reviews/1556636-golang-gopkg-
 readline-1/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/gopkg.in/readline.v1/runes(golang-gopkg-
 readline-devel), /usr/share/gocode/src/gopkg.in/readline.v1(golang-
 gopkg-readline-devel), /usr/share/gocode/src/github.com/chzyer(golang-
 github-chzyer-logex-devel, golang-github-chzyer-test-devel),
 /usr/share/gocode/src/gopkg.in(golang-gopkg-sourcemap-1-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 9 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No 

[Bug 1558789] Review Request: R-orcutt - Estimate Procedure in Case of First Order Autocorrelation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558789

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518262



--- Comment #17 from Neal Gompa  ---
The SRPM URL is invalid. Please post a working SRPM link.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #9 from jiri vanek  ---
> > I see hundreds of "java-openjdk.spec: E: specfile-error error: Too many
> > levels of recursion in macro expansion. It is likely caused by recursive
> > macro declaration."
...
> > The warning can be ignored, for the macro expansion error, is that expected
> > and ignorable?
> 
> Can be ignored.
> 
As aslo explained in See
https://github.com/rpm-software-management/rpm/issues/127

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #8 from jiri vanek  ---
> [!]: Spec use %global instead of %define unless justified.
> This is major thing, and cant be fixed. The Usage of %global on top of
> %define is  wrongly interpreted in fedora. If you change any of highlighted
> define to global, the build will misbehave for you. This rpmlint was
> invalidated in f27 and  RPM 4.14. I will try to find the chnageset and
> bugzilla which made me to change those selected globals back to defines.

Twomajor ones:
https://src.fedoraproject.org/rpms/java-1.8.0-openjdk/c/cba2530f5fbb5597453d37b3b77423881346daf1?branch=f27
https://src.fedoraproject.org/rpms/java-1.8.0-openjdk/c/c75033910e507464e836ef13acdf19330d4e940d?branch=f27
See https://github.com/rpm-software-management/rpm/issues/127 to comments at 
"pmatilai commented on Aug 18, 2017"

(initiated in https://bugzilla.redhat.com/show_bug.cgi?id=1482192)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558784] Review Request: R-rprintf - Adaptive Builder for Formatted Strings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558784

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - Conforms to the Packaging Guidelines

 - Fix the line encoding for:

R-rprintf.noarch: W: wrong-file-end-of-line-encoding
/usr/share/R/library/rprintf/NEWS

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #7 from jiri vanek  ---
(In reply to jiri vanek from comment #5)
> Created attachment 1411281 [details]
> check from another user

You had nicely nearly no-intersection :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781

W. Michael Petullo  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-03-21 13:57:18



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #6 from jiri vanek  ---
[] Package must own all directories that it creates.
   will be fixed.  Only /usr/lib/jvm should not be owned. it is owned by
japackage tools. Also I think it is mentioned somewher ein guidelines, but have
not found. Are you sure with generic /usr/share/ stuff?
Also I belive I own /usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64 
at least it is listed for me...
[] %config files are marked noreplace or the reason is justified.
 Note: No (noreplace) in %config

/etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64/conf/management/jmxremote.password.template
  This one realy do not deserves to be noreplace. It is config tempalte   

 %config

/etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64/conf/accessibility.properties
  I had not marked this one, as it contains generated path and shold be fully
contorlled by packager. Unluvkily, the only palce where jdk founds it is conf.

Same for debug variants.

[ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in java-openjdk, java-openjdk-debug

It is, inst it?


[!]: Uses parallel make %{?_smp_mflags} macro.
I do not dare to use this flag. The build of OJDK is to complex to set anything
on top.

[!]: Spec use %global instead of %define unless justified.
This is major thing, and cant be fixed. The Usage of %global on top of %define
is  wrongly interpreted in fedora. If you change any of highlighted define to
global, the build will misbehave for you. This rpmlint was invalidated in f27
and  RPM 4.14. I will try to find the chnageset and bugzilla which made me to
change those selected globals back to defines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558779] Review Request: R-rgdal - Bindings for the 'Geospatial' Data Abstraction Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558779

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #93 from Fedora Update System  ---
kronosnet-1.1-8.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-603c1c93cf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #92 from Fedora Update System  ---
kronosnet-1.1-8.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-94bdc0ccfb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #91 from Fedora Update System  ---
kronosnet-1.1-8.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6eae0c4a51

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #5 from jiri vanek  ---
Created attachment 1411281
  --> https://bugzilla.redhat.com/attachment.cgi?id=1411281=edit
check from another user

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #4 from Jie Kang  ---
Package Review
==

SPEC: https://jvanek.fedorapeople.org/java-openjdk/v04/f28/java-openjdk.spec
SRPM:
https://jvanek.fedorapeople.org/java-openjdk/v04/f28/java-openjdk-10.0.0.46-3.fc28.src.rpm

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/24x24,
 /usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64,
 /usr/share/icons/hicolor/32x32/apps,
 /usr/share/icons/hicolor/24x24/apps,
 /usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64-debug/lib,
 /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/16x16,
 /usr/lib/jvm/java-10-openjdk-10.0.0.46-3.fc27.x86_64-debug,
 /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/48x48/apps,
 /usr/lib/jvm, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id/0d [...]
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[ ]: %config files are marked noreplace or the reason is justified.
 Note: No (noreplace) in %config

/etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64/conf/management/jmxremote.password.template
 %config

/etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64/conf/accessibility.properties
 %config

/etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64-debug/conf/management/jmxremote.password.template
 %config

/etc/java/java-10-openjdk/java-10-openjdk-10.0.0.46-3.fc27.x86_64-debug/conf/accessibility.properties
[x]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in java-openjdk, java-openjdk-debug
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under 

[Bug 1558757] Review Request: R-tkrplot - TK Rplot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558757

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518262



--- Comment #16 from Zuzana Svetlikova  ---
So, I looked into it.. it generated provides just fine, and for requires it
skips the uppermost node_modules directory, but still generates requires for
bundled modules. Here I used %__provides_exclude_from macro.
As for the nodejs- prefix, I left nodejs-yarn and removed it from yarnpkg, but
maybe someone else could express their opinion on this.

Spec URL: https://fedorapeople.org/~zvetlik/nodejs-yarn/nodejs-yarn.spec
SRPM URL:
https://fedorapeople.org/~zvetlik/nodejs-yarn/nodejs-yarn-1.5.1-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558726] Review Request: python-libusb1 - Pure-python wrapper for libusb-1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558726

Jonny Heggheim  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2018-03-21 12:26:07



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558756] Review Request: R-statnet.common - Common R Scripts and Utilities Used by the Statnet Project Software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558756

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558726] Review Request: python-libusb1 - Pure-python wrapper for libusb-1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558726



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-libusb1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #21 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dcee533d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558752] Review Request: R-lmodel2 - Model II Regression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558752

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #3 from jiri vanek  ---
Released:
http://mail.openjdk.java.net/pipermail/announce/2018-March/000247.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558726] Review Request: python-libusb1 - Pure-python wrapper for libusb-1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558726



--- Comment #5 from Jonny Heggheim  ---
(In reply to Robert-André Mauchin from comment #4)
> Package approved.

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558726] Review Request: python-libusb1 - Pure-python wrapper for libusb-1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558726

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717



--- Comment #11 from Itamar Reis Peixoto  ---
some people are talking about retiring python2 in rawhide, do you have a new
version compatible with python3 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558751] Review Request: R-labeling - Axis Labeling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558751

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557725] Review Request: R-whisker - {{mustache}} for R, logicless templating

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557725

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
R-whisker-0.3.2-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1f6c5a1f66

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371

Jie Kang  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

David Benoit  changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #7 from David Benoit  ---
Latest build

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00730212-racket/racket-6.12-1.fc27.src.rpm

SPEC:
https://copr-be.cloud.fedoraproject.org/results/dbenoit/racket/fedora-27-x86_64/00730212-racket/racket.spec

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25844207


rpmlint:

[dbenoit@dbenoit]$ rpmlint racket.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[dbenoit@dbenoit]$ rpmlint racket-6.12-1.fc27.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


Changelog:
- fix text encoding issue in description section
- remove doc-open-url scriptlets
- add scriptlet to fix paths in html docs
- add patch2 to backport rpaths fix in compiled .zo files
- add patch3 to backport rpaths fix in web-server-lib
- add patch4 to configure doc open url dynamically at runtime
- remove override of __arch_install_post

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558541] Review Request: python-ratelimitingfilter - Token-bucket based rate limiter for Python logging system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558541



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-ratelimitingfilter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371

jiri vanek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557371] Review Request: java-openjdk - rolling release for short term support OpenJDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557371



--- Comment #2 from jiri vanek  ---
(In reply to Jie Kang from comment #1)
> Created attachment 1409888 [details]
> Diff of spelling/grammar/consistency changes to spec
> 
> I've attached a diff making spelling/grammar/consistency (spaces, endings,
> etc.) changes to the spec. Could you look it over and see if it's okay to
> apply?

I got one more same patch from community. I will apply them both (with yours as
native speaker proffered) a and update builds and sources
> 
> As far as rpmlint on the spec at:
> https://jvanek.fedorapeople.org/java-openjdk/v04/f28/java-openjdk.spec
> 
> I see hundreds of "java-openjdk.spec: E: specfile-error error: Too many
> levels of recursion in macro expansion. It is likely caused by recursive
> macro declaration."

hehe :))) it only means you are on old fedora :)) Rpm had recursion depth
limited by hard-coded 12, which is to low for our packages!-))  Since f27  this
limits bumped to 64. You will not see this error here.

> 
> The final output is: 0 packages and 1 specfiles checked; 571 errors, 1
> warnings.
> 
> The warning can be ignored, for the macro expansion error, is that expected
> and ignorable?

Can be ignored.

TYVM!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558748] Review Request: R-gtable - Arrange 'Grobs' in Tables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558748

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558541] Review Request: python-ratelimitingfilter - Token-bucket based rate limiter for Python logging system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558541



--- Comment #2 from Martin Kutlak  ---
Thank you for the review.

I've edited the description to meet the below 80 chars on line rule.

https://mkutlak.fedorapeople.org/pkg_review/ratelimitingfilter/ratelimitingfilter.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #20 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc28 has been pushed to the Fedora 28
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1608d21400

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558745] Review Request: R-geepack - Generalized Estimating Equation Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558745

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - Conforms to the Packaging Guidelines

 - Fix the encoding and line encoding of:

R-geepack.x86_64: W: wrong-file-end-of-line-encoding
/usr/lib64/R/library/geepack/doc/geepack-manual.Rnw
R-geepack.x86_64: W: file-not-utf8
/usr/lib64/R/library/geepack/doc/geepack-manual.Rnw

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libdmapsharing4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558976] Review Request: mycrypto - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558976

Rene Jr Purcell  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558976] New: Review Request: mycrypto - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558976

Bug ID: 1558976
   Summary: Review Request: mycrypto - Client-side tool for
interacting with the Ethereum network
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rene.purc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00730408-mycrypto/mycrypto.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00730408-mycrypto/mycrypto-3.12.0-1.fc27.src.rpm
Description: This is the second package I submit, It's pretty much an upstream
fork from the other package I've made(etherwallet). There's no binary, no real
dependency other than a browser. The package install the files in
/usr/share/mycrypto/ and copy a .desktop file which open
/usr/share/mycrypto/index.html with xdg-open.
Fedora Account System Username: arsenick

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551153] Review Request: tuned-profiles-nfv-host-bin - Binaries that are needed for the NFV host Tuned profile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551153

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2018-03-21 08:39:55



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558312



--- Comment #2 from Rene Jr Purcell  ---
Thank you for your suggestions, I think I've fixed most/all of your point.

Here's the Spec and srpm updated.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00730407-etherwallet/mew.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00730407-etherwallet/etherwallet-3.21.02-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558742] Review Request: R-gee - Generalized Estimation Equation Solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558742

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508068] Review Request: golang-gopkg-readline - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508068



--- Comment #6 from Dominik 'Rathann' Mierzejewski  ---
This seems to have the wrong import path specified, see bug 1558953.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558726] Review Request: python-libusb1 - Pure-python wrapper for libusb-1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558726



--- Comment #3 from Jonny Heggheim  ---
(In reply to Robert-André Mauchin from comment #2)
>  - Remove existing egg-info in %prep
> 
>  - The correct shorthand for LGPLv2.1+ is LGPLv2+. Fix the license field
> accordingly.
> 

Thanks, fixed and uploaded new version.


> License:LGPLv2+
> ...
> %prep
> %autosetup -n %{srcname}-%{version}
> rm -rf %{srcname}.egg-info


Spec URL: http://jonny.fedorapeople.org//python-libusb1.spec
SRPM URL: http://jonny.fedorapeople.org//python-libusb1-1.6.4-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557766] Review Request: libb2 - C library providing BLAKE2b, BLAKE2s , BLAKE2bp, BLAKE2sp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557766



--- Comment #5 from Antonio Trande  ---
Thank you Robert.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558726] Review Request: python-libusb1 - Pure-python wrapper for libusb-1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558726

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Robert-André Mauchin  ---
 - Remove existing egg-info in %prep

 - The correct shorthand for LGPLv2.1+ is LGPLv2+. Fix the license field
accordingly.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.6/site-
 packages/__pycache__(python3-cycler, python3-sh, python3-libs)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[!]: Binary eggs must be removed in %prep
 Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-libusb1 , python3-libusb1
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: 

[Bug 1558473] Review Request: xtl - QuantStack tools library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558473



--- Comment #3 from Elliott Sales de Andrade  ---
Split out documentation. Also, modified test run to only skip the single broken
one instead of all of them.

Spec URL: https://qulogic.fedorapeople.org/xtl.spec
SRPM URL: https://qulogic.fedorapeople.org/xtl-0.4.4-2.fc27.src.rpm

koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25853393

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #19 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc28 has been submitted as an update to
Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1608d21400

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740
Bug 1550740 depends on bug 1552371, which changed state.

Bug 1552371 Summary: Implement -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}  qmake 
equivalent
https://bugzilla.redhat.com/show_bug.cgi?id=1552371

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #18 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dcee533d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org