[Bug 1739807] Review Request: cpu-x - Gathers information on CPU, motherboard and more
https://bugzilla.redhat.com/show_bug.cgi?id=1739807 --- Comment #9 from Artem --- (In reply to Igor Gnatenko from comment #8) > Also I don't see any reason to create -data subpackage. [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2160640 bytes in /usr/share Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/cpu-x/fedora-30-x86_64/01000631-cpu-x/cpu-x.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/cpu-x/fedora-30-x86_64/01000631-cpu-x/cpu-x-3.2.4-7.20190806git11158d2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739807] Review Request: cpu-x - Gathers information on CPU, motherboard and more
https://bugzilla.redhat.com/show_bug.cgi?id=1739807
--- Comment #8 from Igor Gnatenko ---
> > BuildRequires: pkgconfig(ncurses)
> BuildRequires: pkgconfig(ncursesw)
is still not fixed.
> Requires: %{name}%{?_isa} = %{version}-%{release}
won't work since package is noarch. Also I don't see any reason to create -data
subpackage.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739807] Review Request: cpu-x - Gathers information on CPU, motherboard and more
https://bugzilla.redhat.com/show_bug.cgi?id=1739807 --- Comment #7 from Artem --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/cpu-x/fedora-30-x86_64/00999780-cpu-x/cpu-x.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/cpu-x/fedora-30-x86_64/00999780-cpu-x/cpu-x-3.2.4-6.20190806git11158d2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739807] Review Request: cpu-x - Gathers information on CPU, motherboard and more
https://bugzilla.redhat.com/show_bug.cgi?id=1739807 --- Comment #6 from Artem --- Fixed. Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/cpu-x/fedora-30-x86_64/00999777-cpu-x/cpu-x.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/cpu-x/fedora-30-x86_64/00999777-cpu-x/cpu-x-3.2.4-5.20190806git11158d2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739807] Review Request: cpu-x - Gathers information on CPU, motherboard and more
https://bugzilla.redhat.com/show_bug.cgi?id=1739807 --- Comment #5 from Igor Gnatenko --- (In reply to Artem from comment #4) > Thank you. Fixed. Filed bug in upstream about bundled modules. But i still > don't understand how handle correctly polkit. It seems to be optional > dependency and we can make it as 'Recommends' but should i own > '/usr/share/polkit-1' in this case or not? Don't make it Recommends. Just drop it. And yes, you need to own the directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739807] Review Request: cpu-x - Gathers information on CPU, motherboard and more
https://bugzilla.redhat.com/show_bug.cgi?id=1739807 --- Comment #4 from Artem --- Thank you. Fixed. Filed bug in upstream about bundled modules. But i still don't understand how handle correctly polkit. It seems to be optional dependency and we can make it as 'Recommends' but should i own '/usr/share/polkit-1' in this case or not? Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/cpu-x/fedora-30-x86_64/00999774-cpu-x/cpu-x.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/cpu-x/fedora-30-x86_64/00999774-cpu-x/cpu-x-3.2.4-4.20190806git11158d2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1736017] Review Request: nats-server - High-Performance server for NATS, the cloud native messaging system
https://bugzilla.redhat.com/show_bug.cgi?id=1736017
--- Comment #8 from Hirotaka Wakabayashi ---
Hello Robert-André,
Thanks for your reply.
In the spec file,
"help2man --no-discard-stderr --no-info --version-string=%{version}
%{buildroot}%{_bindir}/%{name}" should be
"help2man --no-discard-stderr --no-info --version-string=%{version}
%{buildroot}%{_sbindir}/%{name}"
because of a failure of building the binary packages.
```
+ help2man --no-discard-stderr --no-info --version-string=2.0.2
/builddir/build/BUILDROOT/nats-server-2.0.2-1.fc31.x86_64/usr/bin/nats-server
BUILDSTDERR: help2man: can't get `--help' info from
/builddir/build/BUILDROOT/nats-server-2.0.2-1.fc31.x86_64/usr/bin/nats-server
```
Please see
https://kojipkgs.fedoraproject.org//work/tasks/2229/37032229/build.log
Thanks in advance,
Hirotaka Wakabayashi
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1736009] Review Request: golang-github-zmap-zlint - X.509 Certificate Linter based on CA/B Forum Baseline Requirements and RFC 5280
https://bugzilla.redhat.com/show_bug.cgi?id=1736009 --- Comment #2 from Hirotaka Wakabayashi --- Hello Robert-André, I reviewed this package. This packages SHOULD contain manpages for zlint and zlint-gtld-update. Please see the https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages ``` golang-github-zmap-zlint.x86_64: W: no-manual-page-for-binary zlint golang-github-zmap-zlint.x86_64: W: no-manual-page-for-binary zlint-gtld-update ``` Here are the results of rpmlint. ``` $ rpmlint ~/rpmbuild/SRPMS/golang-github-zmap-zlint-0-0.1.20190801git9971d62.fc31.src.rpm golang-github-zmap-zlint.src: W: spelling-error %description -l en_US linter -> liner, liter, inter 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint /home/vagrant/rpmbuild/RPMS/noarch/golang-github-zmap-zlint-devel-0-0.1.20190801git9971d62.fc31.noarch.rpm golang-github-zmap-zlint-devel.noarch: W: spelling-error %description -l en_US linter -> liner, liter, inter golang-github-zmap-zlint-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/zmap/zlint/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint /home/vagrant/rpmbuild/RPMS/x86_64/golang-github-zmap-zlint-debuginfo-0-0.1.20190801git9971d62.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/vagrant/rpmbuild/RPMS/x86_64/golang-github-zmap-zlint-0-0.1.20190801git9971d62.fc31.x86_64.rpm golang-github-zmap-zlint.x86_64: W: spelling-error %description -l en_US linter -> liner, liter, inter golang-github-zmap-zlint.x86_64: W: no-manual-page-for-binary zlint golang-github-zmap-zlint.x86_64: W: no-manual-page-for-binary zlint-gtld-update 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint /home/vagrant/rpmbuild/RPMS/x86_64/golang-github-zmap-zlint-debugsource-0-0.1.20190801git9971d62.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ``` Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731568] Review Request: python-pytest-sugar - Change the default look and feel of pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1731568 --- Comment #9 from Fedora Update System --- python-pytest-sugar-0.9.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ab375e6516 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1732942] Review Request: libmodulemd1 - Module metadata manipulation library
https://bugzilla.redhat.com/show_bug.cgi?id=1732942 --- Comment #17 from Fedora Update System --- libmodulemd1-1.8.15-3.fc29.1 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731568] Review Request: python-pytest-sugar - Change the default look and feel of pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1731568 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- python-pytest-sugar-0.9.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0bd6518c51 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1738293] Review Request: compton-ng - Compositor for X11, active fork
https://bugzilla.redhat.com/show_bug.cgi?id=1738293 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- compton-ng-7.2-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-82c9bdd767 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739290] Review Request: angband - Text-based roguelike RPG game
https://bugzilla.redhat.com/show_bug.cgi?id=1739290 --- Comment #4 from Wart --- Updated spec and src rpm based to fix the issues described in comment #3: https://wart.fedorapeople.org/angband.spec https://wart.fedorapeople.org/angband-4.1.3-4.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1507662] Review Request: nodejs-engine-dot-io-client - Client for the realtime Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1507662 Bug 1507662 depends on bug 1417615, which changed state. Bug 1417615 Summary: nodejs-ws-7.1.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1417615 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731568] Review Request: python-pytest-sugar - Change the default look and feel of pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1731568 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2019-ab375e6516 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ab375e6516 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731568] Review Request: python-pytest-sugar - Change the default look and feel of pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1731568 --- Comment #7 from Fedora Update System --- FEDORA-2019-0bd6518c51 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0bd6518c51 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1619610] mozilla-filesystem to own %_libdir/mozilla/native-messaging-hosts
https://bugzilla.redhat.com/show_bug.cgi?id=1619610 --- Comment #4 from Ben Cotton --- This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1677491] libldac doesn't support big-endian, s390x build fails
https://bugzilla.redhat.com/show_bug.cgi?id=1677491 --- Comment #2 from Ben Cotton --- This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739820] Review Request: soup-sharp - .NET bindings for libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1739820 Antonio changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Antonio --- Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739820] Review Request: soup-sharp - .NET bindings for libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1739820 --- Comment #10 from Robert-André Mauchin --- - This package installs files under 'gtk-sharp3-gapi' and 'monodoc' directories. Should be these required package on runtime? Required monodoc for the new doc subpackage and pkgconfig(gapi-3.0) for main package Fixed AUTHORS line endings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623787] minizip-2.8.8 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1623787 --- Comment #5 from Ben Cotton --- This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1738676] Review Request: golang-schwanenlied-yawning-bsaes - BitSliced AES
https://bugzilla.redhat.com/show_bug.cgi?id=1738676 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-schwanenlied-yawning-bsaes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739820] Review Request: soup-sharp - .NET bindings for libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1739820 --- Comment #9 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/soup-sharp.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/soup-sharp-2.42.2-1.20190810git0f36d10.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1729965] Wrong License: tag for jquery-ui
https://bugzilla.redhat.com/show_bug.cgi?id=1729965 --- Comment #2 from Ben Cotton --- This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1737248] Review Request: golang-github-gorilla-csrf - Cross Site Request Forgery (CSRF) prevention middleware
https://bugzilla.redhat.com/show_bug.cgi?id=1737248 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-08-13 18:55:01 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1738676] Review Request: golang-schwanenlied-yawning-bsaes - BitSliced AES
https://bugzilla.redhat.com/show_bug.cgi?id=1738676 Jared Smith changed: What|Removed |Added Blocks||1738685 ||(golang-gitlab-yawning-utls ||) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1738685 [Bug 1738685] Review Request: golang-gitlab-yawning-utls - Fork of the Go standard TLS library, providing access to the ClientHello -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1738685] Review Request: golang-gitlab-yawning-utls - Fork of the Go standard TLS library, providing access to the ClientHello
https://bugzilla.redhat.com/show_bug.cgi?id=1738685 Jared Smith changed: What|Removed |Added Depends On||1738676 ||(golang-schwanenlied-yawnin ||g-bsaes) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1738676 [Bug 1738676] Review Request: golang-schwanenlied-yawning-bsaes - BitSliced AES -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1738685] Review Request: golang-gitlab-yawning-utls - Fork of the Go standard TLS library, providing access to the ClientHello
https://bugzilla.redhat.com/show_bug.cgi?id=1738685 Jared Smith changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1738685] Review Request: golang-gitlab-yawning-utls - Fork of the Go standard TLS library, providing access to the ClientHello
https://bugzilla.redhat.com/show_bug.cgi?id=1738685 Jared Smith changed: What|Removed |Added CC||jsmith.fed...@gmail.com Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com Flags||fedora-review? --- Comment #1 from Jared Smith --- mock -r fedora-rawhide-x86_64 rebuild golang-gitlab-yawning-utls-0.0.11-1.1.fc31.src.rpm INFO: mock.py version 1.4.16 starting (python version = 3.7.4)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run INFO: Start(golang-gitlab-yawning-utls-0.0.11-1.1.fc31.src.rpm) Config(fedora-rawhide-x86_64) Start: clean chroot Finish: clean chroot Start: chroot init INFO: calling preinit hooks INFO: enabled root cache Start: unpacking root cache Finish: unpacking root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.16 INFO: Mock Version: 1.4.16 Start: dnf update No matches found for the following disable plugin patterns: local, spacewalk fedora 45 kB/s | 13 kB 00:00 Dependencies resolved. Nothing to do. Complete! Finish: dnf update Finish: chroot init Start: build phase for golang-gitlab-yawning-utls-0.0.11-1.1.fc31.src.rpm Start: build setup for golang-gitlab-yawning-utls-0.0.11-1.1.fc31.src.rpm Building target platforms: x86_64 Building for target x86_64 setting SOURCE_DATE_EPOCH=1565214821 Wrote: /builddir/build/SRPMS/golang-gitlab-yawning-utls-0.0.11-1.1.fc31.src.rpm No matches found for the following disable plugin patterns: local, spacewalk fedora 59 kB/s | 13 kB 00:00 No matching package to install: 'golang(git.schwanenlied.me/yawning/bsaes.git)' Not all dependencies satisfied Error: Some packages could not be found. ERROR: Exception(golang-gitlab-yawning-utls-0.0.11-1.1.fc31.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 8 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-rawhide-x86_64/result ERROR: Command failed: # /usr/bin/dnf builddep --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 31 --setopt=deltarpm=False --disableplugin=local --disableplugin=spacewalk --disableplugin=local --disableplugin=spacewalk /var/lib/mock/fedora-rawhide-x86_64/root//builddir/build/SRPMS/golang-gitlab-yawning-utls-0.0.11-1.1.fc31.src.rpm No matches found for the following disable plugin patterns: local, spacewalk fedora 59 kB/s | 13 kB 00:00 No matching package to install: 'golang(git.schwanenlied.me/yawning/bsaes.git)' Not all dependencies satisfied Error: Some packages could not be found. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739820] Review Request: soup-sharp - .NET bindings for libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1739820
--- Comment #8 from Antonio ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
- This package installs files under 'gtk-sharp3-gapi' and 'monodoc'
directories.
Should be these required package on runtime?
- See minor warnings from 'rpmlint'
= MUST items =
C/C++:
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GNU Lesser General
Public License (v3 or later)". 17 files have unknown license. Detailed
output of licensecheck in /home/sagitter/1739820-soup-
sharp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gapi-3.0,
/usr/lib/monodoc, /usr/lib/monodoc/sources
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/mono(mono-core,
webkit2-sharp), /usr/lib/mono/gac(mono-core, gtk-sharp2, gnome-sharp,
webkit2-sharp)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in soup-
sharp , soup-sharp-devel
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
[Bug 1740786] Review Request: jolokia-jvm-agent - Jolokia JVM Agent
https://bugzilla.redhat.com/show_bug.cgi?id=1740786 --- Comment #1 from Severin Gehwolf --- Created attachment 1603449 --> https://bugzilla.redhat.com/attachment.cgi?id=1603449=edit Script to smoke test the jolokia jvm agent -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740804] Review Request: prometheus-jmx-exporter - Prometheus JMX Exporter
https://bugzilla.redhat.com/show_bug.cgi?id=1740804 --- Comment #1 from Severin Gehwolf --- Created attachment 1603445 --> https://bugzilla.redhat.com/attachment.cgi?id=1603445=edit Script to smoke test the jmx exporter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740795] Review Request: prometheus-simpleclient-java - Prometheus JVM Client
https://bugzilla.redhat.com/show_bug.cgi?id=1740795 Severin Gehwolf changed: What|Removed |Added Blocks||1740804 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1740804 [Bug 1740804] Review Request: prometheus-jmx-exporter - Prometheus JMX Exporter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740804] New: Review Request: prometheus-jmx-exporter - Prometheus JMX Exporter
https://bugzilla.redhat.com/show_bug.cgi?id=1740804 Bug ID: 1740804 Summary: Review Request: prometheus-jmx-exporter - Prometheus JMX Exporter Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: sgehw...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 1740795 Target Milestone: --- Classification: Fedora SPEC URL: https://jerboaa.fedorapeople.org/rpm/prometheus-jmx-exporter/prometheus-jmx-exporter.spec SRPM URL: https://jerboaa.fedorapeople.org/rpm/prometheus-jmx-exporter/prometheus-jmx-exporter-0.12.0-1.fc30.src.rpm JMX to Prometheus exporter: a collector that can configurably scrape and expose mBeans of a JMX target. This exporter is intended to be run as a Java Agent, exposing a HTTP server and serving metrics of the local JVM. FAS username: jerboaa This built in mock (rawhide) with the prometheus-simpleclient-java package from bug 1740795 installed. RPM Lint: $ rpmlint prometheus-jmx-exporter.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/sgehwolf/rpmbuild/SRPMS/prometheus-jmx-exporter-0.12.0-1.fc30.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1740795 [Bug 1740795] Review Request: prometheus-simpleclient-java - Prometheus JVM Client -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740795] Review Request: prometheus-simpleclient-java - Prometheus JVM Client
https://bugzilla.redhat.com/show_bug.cgi?id=1740795 --- Comment #1 from Severin Gehwolf --- RPM Lint: $ rpmlint prometheus-simpleclient-java.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint prometheus-simpleclient-java-0.6.0-1.fc30.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740795] New: Review Request: prometheus-simpleclient-java - Prometheus JVM Client
https://bugzilla.redhat.com/show_bug.cgi?id=1740795 Bug ID: 1740795 Summary: Review Request: prometheus-simpleclient-java - Prometheus JVM Client Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: sgehw...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora SPEC URL: https://jerboaa.fedorapeople.org/rpm/prometheus-simpleclient-java/prometheus-simpleclient-java.spec SRPM URL: https://jerboaa.fedorapeople.org/rpm/prometheus-simpleclient-java/prometheus-simpleclient-java-0.6.0-1.fc30.src.rpm Prometheus instrumentation library for JVM applications. This is a build dependency for prometheus-jmx-exporter, a Java Agent exporting JMX metrics as prometheus data. As such only bits needed for jmx-exported have been built and enabled (as well as tested). FAS username: jerboaa Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=37002300 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API
https://bugzilla.redhat.com/show_bug.cgi?id=1740710 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #2 from Miro Hrončok --- URL:https://github.com/sarugaku/requirementslib ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740786] New: Review Request: jolokia-jvm-agent - Jolokia JVM Agent
https://bugzilla.redhat.com/show_bug.cgi?id=1740786 Bug ID: 1740786 Summary: Review Request: jolokia-jvm-agent - Jolokia JVM Agent Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: sgehw...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora SPEC URL: https://jerboaa.fedorapeople.org/rpm/jolokia-jvm-agent/jolokia-jvm-agent.spec SRPM URL: https://jerboaa.fedorapeople.org/rpm/jolokia-jvm-agent/jolokia-jvm-agent-1.6.2-1.fc30.src.rpm Jolokia is a JMX-HTTP bridge giving an alternative to JSR-160 connectors. It is an agent based approach with support for many platforms. In addition to basic JMX operations it enhances JMX remoting with unique features like bulk requests and fine grained security policies. Fedora Account System Username: jerboaa Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=37001731 RPM Lint: $ rpmlint jolokia-jvm-agent.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint jolokia-jvm-agent-1.6.2-1.fc30.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740415] Review Request: gnome-internet-radio-locator - GNOME Internet Radio Locator
https://bugzilla.redhat.com/show_bug.cgi?id=1740415 --- Comment #1 from Artem --- Seems like duplicate of this :( https://bugzilla.redhat.com/show_bug.cgi?id=1517451 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739807] Review Request: cpu-x - Gathers information on CPU, motherboard and more
https://bugzilla.redhat.com/show_bug.cgi?id=1739807
--- Comment #3 from Igor Gnatenko ---
> pushd build
> %make_install
> popd
%make_install -C build
> appstream-util validate-relax --nonet
> %{buildroot}%{_metainfodir}/%{name}.appdata.xml
> desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
This should go in the %check section
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739807] Review Request: cpu-x - Gathers information on CPU, motherboard and more
https://bugzilla.redhat.com/show_bug.cgi?id=1739807
Igor Gnatenko changed:
What|Removed |Added
CC||i.gnatenko.br...@gmail.com
--- Comment #2 from Igor Gnatenko ---
Agree with Elliott, don't create subpackages. Just own directories. For
example,
https://src.fedoraproject.org/rpms/rust-ripgrep/blob/master/f/rust-ripgrep.spec#_42
* I believe that spec is missing BuildRequires: gettext-devel
* Missing BuildRequires: pkgconfig(json-c)
* I think you need to unbundle dmidecode and bandwidth (both seem to be GPLv2+,
so at least declare bundled provides)
* BuildRequires: pkgconfig(libarchive) does not seem to be needed
> BuildRequires: pkgconfig(gtk+-3.0)
BuildRequires: pkgconfig(gtk+-3.0) >= 3.12.0
> BuildRequires: pkgconfig(ncurses)
BuildRequires: pkgconfig(ncursesw)
> BuildRequires: pkgconfig(libcpuid)
BuildRequires: pkgconfig(libcpuid) >= 0.4.0
> Requires: polkit%{?_isa}
This is not really needed, you are fine with just owning appropriate
directories (so that there are no dangling dirs on a removal).
> %{_datadir}/bash-completion/completions/%{name}
%dir %{_datadir}/bash-completion
%dir %{_datadir}/bash-completion/completions
%{_datadir}/bash-completion/%{name}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1690412] Review Request: kiwix-lib - Common code base for all Kiwix ports
https://bugzilla.redhat.com/show_bug.cgi?id=1690412 Vasiliy Glazov changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-08-13 15:15:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740634] Review Request: linuxconsoletools - Tools for connecting joysticks & legacy devices to the kernel's input subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1740634 --- Comment #2 from Vasiliy Glazov --- OK. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #9 from Artem --- > Large data in /usr/share should live in a noarch subpackage if package is > arched. > Note: Arch-ed rpms have a total of 7526400 bytes in /usr/share Now witch separate translation because of this. And other packaging fixes. Spec URL: https://atim.fedorapeople.org/for-review/qownnotes.spec SRPM URL: https://atim.fedorapeople.org/for-review/qownnotes-1.8.4-6.20190810git0302b2c.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API
https://bugzilla.redhat.com/show_bug.cgi?id=1740710 Petr Viktorin changed: What|Removed |Added CC||pvikt...@redhat.com --- Comment #1 from Petr Viktorin --- That description is not really convincing. What does this do? What's the reason to have this in Fedora? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740634] Review Request: linuxconsoletools - Tools for connecting joysticks & legacy devices to the kernel's input subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1740634
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
- I think you should own: %dir %{_libexecdir}/joystick
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/libexec/joystick
Package otherwise approved. Please fix the aforementioned issue before import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/linuxconsoletools
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v2 or later)", "*No copyright*
GNU General Public License", "GPL (v2 or later) (with incorrect FSF
address)", "*No copyright* GNU General Public License (v2)". 24 files
have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/linuxconsoletools/review-
linuxconsoletools/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/libexec/joystick
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[Bug 1740634] Review Request: linuxconsoletools - Tools for connecting joysticks & legacy devices to the kernel's input subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1740634 Vasiliy Glazov changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2019-08-13 14:49:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1737248] Review Request: golang-github-gorilla-csrf - Cross Site Request Forgery (CSRF) prevention middleware
https://bugzilla.redhat.com/show_bug.cgi?id=1737248 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gorilla-csrf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1735762] Review Request: fctxpd- This daemon adds FC network intelligence in host and host intelligence in FC network
https://bugzilla.redhat.com/show_bug.cgi?id=1735762
--- Comment #6 from Robert-André Mauchin ---
Yes, COPR is fine.
- Builds failed for me because the archive downloaded has a different root
folder, so the folder should be changed in autosetup:
%prep
%autosetup -n bsn-fc-txptd-%{commit}
- Another issue is the %changelog entry:
fc_txptd.x86_64: W: incoherent-version-in-changelog 0.1-1
['0.1-1.20190813gitc195e67.fc31', '0.1-1.20190813gitc195e67']
It must reflect the Version-Release from the header, so:
*Mon Aug 12 2019 Muneendra -
0.1-1.20190813gitc195e67
The rest of the SPEC is fine.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v2 or later)", "*No copyright*
GNU General Public License (v2)". 9 files have unknown license.
Detailed output of licensecheck in
/home/bob/packaging/review/fc_txptd/review-fc_txptd/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fc_txptd
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from
[Bug 1739820] Review Request: soup-sharp - .NET bindings for libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1739820 --- Comment #7 from Robert-André Mauchin --- There's no compose these days, you can enable local to test it with latest packages from Koji: fedora-review -m fedora-rawhide-x86_64 -o"--enablerepo=local" -b 1739820 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740710] New: Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API
https://bugzilla.redhat.com/show_bug.cgi?id=1740710 Bug ID: 1740710 Summary: Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pkop...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fedora-rawhide-x86_64/00997891-python-pip-shims/python-pip-shims.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fedora-rawhide-x86_64/00997891-python-pip-shims/python-pip-shims-0.3.2-1.fc31.src.rpm Description: The authors of pip do not condone the use of this package. Relying on pip's internals is a dangerous idea for your software as they are broken intentionally and regularly. This package may not always be completely updated up PyPI, so relying on it may break your code! User beware! Fedora Account System Username: pkopkan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1736017] Review Request: nats-server - High-Performance server for NATS, the cloud native messaging system
https://bugzilla.redhat.com/show_bug.cgi?id=1736017 --- Comment #7 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/nats-server.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/nats-server-2.0.2-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1737248] Review Request: golang-github-gorilla-csrf - Cross Site Request Forgery (CSRF) prevention middleware
https://bugzilla.redhat.com/show_bug.cgi?id=1737248 --- Comment #3 from Robert-André Mauchin --- Thanks for the reviews! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1738293] Review Request: compton-ng - Compositor for X11, active fork
https://bugzilla.redhat.com/show_bug.cgi?id=1738293 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2019-82c9bdd767 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-82c9bdd767 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature
https://bugzilla.redhat.com/show_bug.cgi?id=1739786 --- Comment #11 from Ankur Sinha (FranciscoD) --- I forgot to add: So, if we can please remove these from the spec for the time being, we can get this review back on track. (Further discussion of these macros and their adoption should occur on the devel ML, probably via a Change announcement: https://fedoraproject.org/wiki/Changes/Policy similar to how the automated dep generators were announced: https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature
https://bugzilla.redhat.com/show_bug.cgi?id=1739786 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|needinfo?(pkop...@redhat.co | |m) | --- Comment #10 from Ankur Sinha (FranciscoD) --- (In reply to Petr Viktorin from comment #9) > > There's also no mention of these macros in the python packaging > > guidelines---should we wait for them to be made public before using them? > > They are currently experimental. If you use them, you should be prepared to > follow the development and maybe adjust the package if we need to do any > changes (though we'll try to not break stuff). > In this case, I think it is best to wait until they're announced to the whole community---as part of the Python packaging guidelines---before using them. What do you think Zbigniew? We need to ensure that these specs remain consistent since all members of the neuro-sig (at least) would be looking after them. I'm all for early adoption, but I do not think these are ready for adoption yet, especially since the review process also requires others to know how they are meant to be used. We may not mind keeping up with the changes to these macros, but it isn't fair to expect others to keep up with their development also. (Additionally, the current set of python macros already makes the spec quite short and neat, so moving to these new ones doesn't seem too urgent to me.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1740649] New: Review Request: copydeps - find and copy a program's dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1740649 Bug ID: 1740649 Summary: Review Request: copydeps - find and copy a program's dependencies Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@svgames.pl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora spec: https://svgames.pl/fedora/copydeps-4.0-1.spec srpm: https://svgames.pl/fedora/copydeps-4.0-1.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=36995831 copr: https://copr.fedorainfracloud.org/coprs/suve/copydeps/build/996633/ Description: copydeps is a small program that can be used to find and copy all .so / .dll files needed by a program to run. This can be useful when you want to bundle an application together with all its dependencies. Fedora Account System Username: suve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature
https://bugzilla.redhat.com/show_bug.cgi?id=1739786 Petr Viktorin changed: What|Removed |Added CC||pvikt...@redhat.com --- Comment #9 from Petr Viktorin --- > There's also no mention of these macros in the python packaging > guidelines---should we wait for them to be made public before using them? They are currently experimental. If you use them, you should be prepared to follow the development and maybe adjust the package if we need to do any changes (though we'll try to not break stuff). Anyway, you should put SETUP_REQUIRES in your pyproject.toml as well: ['pytest-runner', 'setuptools_scm', 'pypandoc', 'pandoc', 'six'] Unfortunately, setuptools needs to download code from the Internet to bootstrap and read the info from setup.py -- which isn't allowed in Fedora. It's one of the reasons for the move to pyproject.toml. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739786] Review Request: python-makefun - Dynamically create python functions with a proper signature
https://bugzilla.redhat.com/show_bug.cgi?id=1739786
Patrik Kopkan changed:
What|Removed |Added
Flags||needinfo?(pkop...@redhat.co
||m)
--- Comment #8 from Patrik Kopkan ---
diff -Naur makefun-1.6.10.orig/pyproject.toml makefun-1.6.10/pyproject.toml
--- makefun-1.6.10.orig/pyproject.toml 1970-01-01 01:00:00.0 +0100
+++ makefun-1.6.10/pyproject.toml 2019-08-13 13:39:52.688122126 +0200
@@ -0,0 +1,3 @@
+[build-system]
+requires = ["setuptools", "setuptools-scm", "wheel"]
+build-backend = "setuptools.build_meta"
I tried this patch adding pyproject.toml. Build still fails, will investigate.
INFO: mock.py version 1.4.17 starting (python version = 3.7.3)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
INFO: Start(python-makefun-1.6.10-1.fc29.src.rpm)
Config(fedora-rawhide-x86_64)
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.17
INFO: Mock Version: 1.4.17
Finish: chroot init
Start: build phase for python-makefun-1.6.10-1.fc29.src.rpm
Start: build setup for python-makefun-1.6.10-1.fc29.src.rpm
Building target platforms: x86_64
Building for target x86_64
setting SOURCE_DATE_EPOCH=1565395200
Wrote: /builddir/build/SRPMS/python-makefun-1.6.10-1.fc31.src.rpm
fedora37
kB/s | 19 kB 00:00
Package pyproject-rpm-macros-0-4.fc31.noarch is already installed.
Dependencies resolved.
Nothing to do.
Complete!
Finish: build setup for python-makefun-1.6.10-1.fc29.src.rpm
Start: rpmbuild python-makefun-1.6.10-1.fc29.src.rpm
Start: Outputting list of installed packages
Finish: Outputting list of installed packages
Building target platforms: x86_64
Building for target x86_64
setting SOURCE_DATE_EPOCH=1565395200
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.TUBPvu
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf makefun-1.6.10
+ /usr/bin/gzip -dc /builddir/build/SOURCES/makefun-1.6.10.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd makefun-1.6.10
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/bin/cat /builddir/build/SOURCES/pyproject.toml.patch
+ /usr/bin/patch -s --fuzz=0 --no-backup-if-mismatch
+ sed -r -i 's/'\''pandoc'\'', //' setup.py
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%generate_buildrequires): /bin/sh -e /var/tmp/rpm-tmp.oYCEIw
+ umask 022
+ cd /builddir/build/BUILD
+ cd makefun-1.6.10
+ echo python3-devel
+ echo 'python3dist(packaging)'
+ echo 'python3dist(pip) >= 19'
+ echo 'python3dist(pytoml)'
+ rm -rfv '*.dist-info/'
+ '[' -f /usr/bin/python3 ']'
+ /usr/bin/python3 -I /usr/lib/rpm/redhat/pyproject_buildrequires.py -r
Handling setuptools from build-system.requires
Requirement satisfied: setuptools
(installed: setuptools 41.0.1)
Handling setuptools-scm from build-system.requires
Requirement satisfied: setuptools-scm
(installed: setuptools-scm 3.3.3)
Handling wheel from build-system.requires
Requirement satisfied: wheel
(installed: wheel 0.33.1)
setup.py:46: DeprecationWarning: Due to possible ambiguity, 'convert()' is
deprecated. Use 'convert_file()' or 'convert_text()'.
LONG_DESCRIPTION = pypandoc.convert(path.join(here, 'docs',
'long_description.md'), 'rst').replace('\r', '')
Handling wheel from get_requires_for_build_wheel
Requirement satisfied: wheel
(installed: wheel 0.33.1)
Handling pytest-runner from get_requires_for_build_wheel
Handling setuptools_scm from get_requires_for_build_wheel
Handling pypandoc from get_requires_for_build_wheel
Requirement satisfied: pypandoc
(installed: pypandoc 1.4)
Handling six from get_requires_for_build_wheel
Requirement satisfied: six
(installed: six 1.12.0)
setup.py:46: DeprecationWarning: Due to possible ambiguity, 'convert()' is
deprecated. Use 'convert_file()' or 'convert_text()'.
LONG_DESCRIPTION = pypandoc.convert(path.join(here, 'docs',
'long_description.md'), 'rst').replace('\r', '')
Download error on https://pypi.org/simple/pytest-runner/: [Errno -2] Name or
service not known -- Some packages may not be found!
Couldn't find index page for 'pytest-runner' (maybe misspelled?)
Download error on https://pypi.org/simple/: [Errno -2] Name or service not
known -- Some packages may not be found!
No local packages or working download links found for pytest-runner
Traceback (most recent call last):
File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 241, in main
extras=args.extras,
File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 195, in
generate_requires
generate_run_requirements(backend, requirements)
File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 169, in
generate_run_requirements
[Bug 1740634] New: Review Request: linuxconsoletools - Tools for connecting joysticks & legacy devices to the kernel's input subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1740634 Bug ID: 1740634 Summary: Review Request: linuxconsoletools - Tools for connecting joysticks & legacy devices to the kernel's input subsystem Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: vasc...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/Vascom/linuxconsoletools/master/linuxconsoletools.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5816/36995816/linuxconsoletools-1.6.1-1.fc31.src.rpm Description: This package contains utilities for testing and configuring joysticks, connecting legacy devices to the kernel's input subsystem (providing support for serial mice, touchscreens etc.), and test the input event layer. It is unretirement of linuxconsoletools package because it needed for gpm, fpc and lazarus to build other free pascal (fpc) packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1735762] Review Request: fctxpd- This daemon adds FC network intelligence in host and host intelligence in FC network
https://bugzilla.redhat.com/show_bug.cgi?id=1735762
--- Comment #5 from MUNEENDRA (Broadcom) ---
(In reply to Robert-André Mauchin from comment #4)
> - %global _sysdir usr/lib is not needed anymore
>
> - please separate your %changelog entries by a newline
>
> - the archive seems corrupted, please check the Source URL. Also if you
> package the "master" tip, you should link to the commit:
>
> %global commit f6f9e112f016089709cfd15b33df5ab0996e5c08
> %global shortcommit %(c=%{commit}; echo ${c:0:7})
> %global snapshotdate20190812
>
> Name: fc_txptd
> Version:0.1
> Release:1.%{snapshotdate}git%{shortcommit}%{?dist}
> Summary:Fibrechannel transport daemon
>
> License:GPLv2+
> URL:https://github.com/brocade/bsn-fc-txptd/
> Source0:%{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz
>
> […]
>
> %prep
> %autosetup -n %{name}-%{commit}
>
>
> Although you should tag a Release in Github, it would be better. Also you
> shouldn't upload binaries like fc_txptd-0.1.tar.gz and
> fc_txptd-0.1-1.fc28.src.rpm to your GIT repo. Upload them to 3rd party
> hosting service if you need to reference them here.
Hi Robert,
Thanks for the review.
As you mentioned above i have removed the fc_txptd-0.1.tar.gz and
fc_txptd-0.1-1.fc28.src.rpm from the GIT repo.
Sorry iam new to the packaging and have couple of queries on the same.
In the below link it was mentioned that
If you have no place to put your spec and SRPM then i can place the same in
https://copr.fedorainfracloud.org.
https://fedoraproject.org/wiki/Package_Review_Process
As per the above doc i have created a project
https://copr.fedorainfracloud.org/coprs/muneendra/fctxpd/
And build the package for few distributions.
https://copr.fedorainfracloud.org/coprs/muneendra/fctxpd/build/998427/
Can i mention spec URL and SRPM URL as below . Is this right way.
Spec URL:
https://github.com/brocade/bsn-fc-txptd/blob/master/SPEC/fc_txptd.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/muneendra/fctxpd/srpm-builds/00998427/fc_txptd-0.1-1.20190813gitc195e67.fc28.src.rpm
Any inputs here will help me a lot.
Regards,
Muneendra.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1736009] Review Request: golang-github-zmap-zlint - X.509 Certificate Linter based on CA/B Forum Baseline Requirements and RFC 5280
https://bugzilla.redhat.com/show_bug.cgi?id=1736009 Hirotaka Wakabayashi changed: What|Removed |Added Status|NEW |ASSIGNED CC||hiw...@yahoo.com Assignee|nob...@fedoraproject.org|hiw...@yahoo.com Flags||fedora-review? --- Comment #1 from Hirotaka Wakabayashi --- A successful Koji scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=36994859 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #8 from Artem --- License quick fix. Spec URL: https://atim.fedorapeople.org/for-review/qownnotes.spec SRPM URL: https://atim.fedorapeople.org/for-review/qownnotes-1.8.4-6.20190810git0302b2c.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #7 from Artem --- Fixed. Please check. Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00998387-qownnotes/qownnotes.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00998387-qownnotes/qownnotes-1.8.4-5.20190810git0302b2c.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739780] Review Request: poetry - Python dependency management and packaging made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1739780 Fabio Valentini changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2019-08-13 10:15:48 --- Comment #7 from Fabio Valentini --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1354153 Submitted for f30: https://bodhi.fedoraproject.org/updates/FEDORA-2019-458e2b6e9e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739779] Review Request: python-cleo - Create beautiful and testable command-line interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1739779 Fabio Valentini changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2019-08-13 10:15:09 --- Comment #4 from Fabio Valentini --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1354150 Submitted for f30: https://bodhi.fedoraproject.org/updates/FEDORA-2019-458e2b6e9e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739780] Review Request: poetry - Python dependency management and packaging made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1739780 Bug 1739780 depends on bug 1739779, which changed state. Bug 1739779 Summary: Review Request: python-cleo - Create beautiful and testable command-line interfaces https://bugzilla.redhat.com/show_bug.cgi?id=1739779 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739778] Review Request: python-clikit - Utilities to build beautiful and testable CLIs
https://bugzilla.redhat.com/show_bug.cgi?id=1739778 Fabio Valentini changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2019-08-13 10:14:28 --- Comment #4 from Fabio Valentini --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1354149 Submitted for f30: https://bodhi.fedoraproject.org/updates/FEDORA-2019-458e2b6e9e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739777] Review Request: python-pastel - Bring colors to your terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1739777 Fabio Valentini changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2019-08-13 10:13:39 --- Comment #3 from Fabio Valentini --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1354145 Submitted for f30: https://bodhi.fedoraproject.org/updates/FEDORA-2019-458e2b6e9e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739780] Review Request: poetry - Python dependency management and packaging made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1739780 Bug 1739780 depends on bug 1739777, which changed state. Bug 1739777 Summary: Review Request: python-pastel - Bring colors to your terminal https://bugzilla.redhat.com/show_bug.cgi?id=1739777 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #6 from Vasiliy Glazov --- Need to change flto=$(nproc) to flto=auto for repeatable builds on different cpus. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1737248] Review Request: golang-github-gorilla-csrf - Cross Site Request Forgery (CSRF) prevention middleware
https://bugzilla.redhat.com/show_bug.cgi?id=1737248 Hirotaka Wakabayashi changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
