[Bug 1785069] Review request: lector -- ebook reader and collection manager
https://bugzilla.redhat.com/show_bug.cgi?id=1785069 --- Comment #7 from Andrew Toskin --- (In reply to Michael Schwendt from comment #5) > The reason is simple. No translation files get installed into the buildroot > [yet]. %find_lang --with-qt would search for Qt's compiled translation files > *.qm, which are created with the lrelease tool from Qt Linguist (package > qt5-linguist). I'm not really sure what you're trying to say here. Sounds like maybe you're saying I need to BuildRequire qt5-linguist, and run lrelease at some point in the script? Or maybe not, since Robert says: (In reply to Robert-André Mauchin from comment #6) > The translations are compiled into a resources file, no need to find_lang > them indeed. But I didn't manage to get Lector launched into another > language. Funny, when I thought to actually just try changing the language with no %find_lang at all, Lector successfully changed to Spanish when I changed my system language to Spanish. Maybe it's not the packaging that's the problem, just the source translations are slightly broken or incomplete? I asked upstream about this here -- https://github.com/BasioMeusPuga/Lector/issues/117 ...I've sent upstream a pull request for the AppStream metainfo.xml file. Feel free to take a look there in case I missed or messed up something. https://github.com/BasioMeusPuga/Lector/pull/120 I'll take another look at the issues flagged by rpmlint and then have another updated spec for you soon. Thanks again, both of you, for your continued help :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1780849] Review Request: pymol - PyMOL Molecular Graphics System
https://bugzilla.redhat.com/show_bug.cgi?id=1780849
--- Comment #15 from Sergio Monteiro Basto ---
Created attachment 1648700
--> https://bugzilla.redhat.com/attachment.cgi?id=1648700=edit
pymol-python3.patch
Applying this patch, fixes brp-python-bytecompile script, i.e. we can remove
%define __brp_python_bytecompile %{nil}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1780849] Review Request: pymol - PyMOL Molecular Graphics System
https://bugzilla.redhat.com/show_bug.cgi?id=1780849
Sergio Monteiro Basto changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #14 from Sergio Monteiro Basto ---
I'd would propose all patches be -p1 instead -p0 [1] and use %py3_build and
%py3_install [2].
Also I'd remove "%define __brp_python_bytecompile %{nil}" with next patch in
attachment .
Other questions raised on my previous comment one are replied (bug in other
place) and Development files must be in a -devel package , for now we can keep
it on main package.
Package APPROVED !
Please add me as maintainer and I could do the changes myself
[1]
%autosetup -n pymol-open-source-%{version} -p1
[2]
%build
%py3_build -- --use-msgpackc=c++11 --glut
%install
%py3_install -- --use-msgpackc=c++11 --glut
--pymol-path=%{python3_sitearch}/pymol
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1780849] Review Request: pymol - PyMOL Molecular Graphics System
https://bugzilla.redhat.com/show_bug.cgi?id=1780849 --- Comment #13 from Sergio Monteiro Basto --- Rawhide is broken again , please add me on https://src.fedoraproject.org/rpms/mmtf-cpp and or build mmtf-ccp on Fedora 31 , I want bring pymol to F31 anyway I guess . -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785981] Review Request: python-socketio - Socket.IO server
https://bugzilla.redhat.com/show_bug.cgi?id=1785981 Bug 1785981 depends on bug 1785979, which changed state. Bug 1785979 Summary: Review Request: python-engineio - Engine.IO server https://bugzilla.redhat.com/show_bug.cgi?id=1785979 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785979] Review Request: python-engineio - Engine.IO server
https://bugzilla.redhat.com/show_bug.cgi?id=1785979 Mukundan Ragavan changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-12-31 00:25:38 --- Comment #4 from Mukundan Ragavan --- Built on rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #5 from W. Michael Petullo --- Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-4.0.0-0.1.b0.fc31.src.rpm Description: - Use upstream URL - Allow dependency generator to pick Python dependencies - Require binutils -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495
Fabian Affolter changed:
What|Removed |Added
CC||m...@fabian-affolter.ch
--- Comment #4 from Fabian Affolter ---
Just some comments:
- URL:https://pypi.python.org/pypi/%{srcname}
I suggest to use the location of the upstream
(https://github.com/Gallopsled/pwntools) instead of PyPI.
- Isn't the dependency generator picking-up the Requires:?
- According the pwntools documentation is binutils
(https://docs.pwntools.com/en/stable/install/binutils.html) also a requirement.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1183169] Review Request: ykfde - opening LUKS with yubikey
https://bugzilla.redhat.com/show_bug.cgi?id=1183169 Benjamin Pereto changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2019-12-30 21:58:24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1662777] Review Request: python-pytest-randomly - Pytest plugin to randomly order tests and control random.seed
https://bugzilla.redhat.com/show_bug.cgi?id=1662777 --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- Oops, upstream is at version 3.2.0 now. Please update! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1708161] Review Request: python-testfixtures - A collection of helpers and mock objects for unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1708161 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- Robert-André, I'll assign this to you, since you have already done most of the review work. If you can't take this for any reason, feel free to reassign to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds
https://bugzilla.redhat.com/show_bug.cgi?id=1787069 --- Comment #3 from Artem --- 8. Try to delete whole 'src/engine/external/' in '%prep' to be sure that nothing is bundled here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #2 from Artem ---
5. The license should be probably:
zlib and CC-BY-SA and ASL 2.0 and MIT and Public Domain and BSD
Please explaining the multiple licensing breakdown in spec file
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/
6. You need to own all directories. In this case you should move
'Requires: hicolor-icon-theme'
to
'-data' subpackage section.
7. Move
%{_datadir}/applications/%{name}.desktop
to
main package:
%files
%{_datadir}/applications/%{name}.desktop
---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "zlib/libpng license Apache License
(v2.0) Creative Commons Attribution-ShareAlike Public License (v3.0)",
"Expat License", "zlib/libpng license", "*No copyright* Creative
Commons Attribution-ShareAlike Public License (v3.0)", "*No copyright*
Public domain", "Khronos License Expat License BSD 2-clause
"Simplified" License", "BSD 2-clause "Simplified" License",
"zlib/libpng license Aladdin Free Public License", "BSD 3-clause "New"
or "Revised" License", "Expat License BSD 2-clause "Simplified"
License", "Khronos License BSD 2-clause "Simplified" License". 1208
files have unknown license. Detailed output of licensecheck in
/mnt/data-linux/tmp/review/1787069-ddnet/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/icons/hicolor,
/usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/512x512,
/usr/share/man/man.6, /usr/share/icons/hicolor/16x16/apps,
/usr/share/icons/hicolor/512x512/apps,
/usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/32x32/apps,
/usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/128x128/apps,
/usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/16x16,
/usr/share/icons/hicolor/48x48/apps,
/usr/share/icons/hicolor/256x256/apps
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/ddnet(defaulting,
Failed, C, locale,, set, to), /usr/share/ddnet/data(defaulting,
Failed, C, locale,, set, to), /usr/share/ddnet/data/audio(defaulting,
Failed, C, locale,, set, to),
/usr/share/ddnet/data/countryflags(defaulting, Failed, C, locale,,
set, to), /usr/share/ddnet/data/editor(defaulting, Failed, C, locale,,
set, to), /usr/share/ddnet/data/editor/entities(defaulting, Failed, C,
locale,, set, to),
/usr/share/ddnet/data/editor/entities_clear(defaulting, Failed, C,
locale,, set, to), /usr/share/ddnet/data/fonts(defaulting, Failed, C,
locale,, set, to), /usr/share/ddnet/data/languages(defaulting, Failed,
C, locale,, set, to), /usr/share/ddnet/data/mapres(defaulting, Failed,
C, locale,, set, to), /usr/share/ddnet/data/maps(defaulting, Failed,
C, locale,, set, to), /usr/share/ddnet/data/shader(defaulting, Failed,
C, locale,, set, to), /usr/share/ddnet/data/skins(defaulting, Failed,
C, locale,, set, to), /usr/share/doc/ddnet-server(defaulting, Failed,
C, locale,, set, to), /usr/share/licenses/ddnet-server(defaulting,
Failed, C, locale,, set, to), /usr/lib64/ddnet(defaulting, Failed, C,
locale,, set, to), /usr/share/doc/ddnet(defaulting, Failed, C,
locale,, set, to), /usr/share/licenses/ddnet(defaulting, Failed, C,
locale,, set, to)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds
https://bugzilla.redhat.com/show_bug.cgi?id=1787069 Artem changed: What|Removed |Added Status|NEW |ASSIGNED CC||ego.corda...@gmail.com Blocks||177841 (FE-NEEDSPONSOR) Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #1 from Artem --- 1. Recommended to use pkgconfig for -devel packages https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/#_buildrequires_pkgconfigfoo_vs_foo_devel 2. Recommended to write AppData manifest file and send it upstream https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ 3. Maybe add BR: mysql for 'server' package? -DMYSQL=[ON|OFF] https://github.com/ddnet/ddnet#building-on-linux-and-macos 4. You need to find a sponsor https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787069] New: Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds
https://bugzilla.redhat.com/show_bug.cgi?id=1787069 Bug ID: 1787069 Summary: Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: elxr...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/elxreno/ddnet/fedora-31-x86_64/01136640-ddnet/ddnet.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/elxreno/ddnet/fedora-31-x86_64/01136640-ddnet/ddnet-12.8.1-4.fc31.src.rpm Description: DDraceNetwork (DDNet) is an actively maintained version of DDRace, a Teeworlds modification with a unique cooperative gameplay. Help each other play through custom maps with up to 64 players, compete against the best in international tournaments, design your own maps, or run your own server. Fedora Account System Username: elxreno -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1050744] Review Request: belle-sip - Linphone SIP stack
https://bugzilla.redhat.com/show_bug.cgi?id=1050744 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-12-30 16:12:38 --- Comment #55 from Rex Dieter --- Yes, this was imported long-ago apparently (or was dup'd?) commit c8e9350a41bd74d1a3ab6631284a1486f7e9ed74 (origin/f25, origin/f24, origin/f23) Author: nucleo Date: Tue Jul 19 19:09:52 2016 +0300 import belle-sip commit 0a08a5522c173933baf4578b40425036711d1a22 Author: Fedora Release Engineering Date: Tue Jul 19 15:28:03 2016 + Initial setup of the repo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 W. Michael Petullo changed: What|Removed |Added CC||upstream-release-monitoring ||@fedoraproject.org --- Comment #3 from W. Michael Petullo --- *** Bug 1697445 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786858] Review Request: golang-rsc-binaryregexp - Go regexp for binary/latin-1 data
https://bugzilla.redhat.com/show_bug.cgi?id=1786858
Jared Smith changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Jared Smith ---
Package is approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in
/home/jsmith/Documents/Fedora/Reviews/1786858-golang-rsc-
binaryregexp/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/rsc.io(golang-rsc-qr-devel, to, C, Failed,
golang-rsc-letsencrypt-devel, locale,, golang-rsc-pdf-devel, set,
defaulting), /usr/share/gocode/src/rsc.io/binaryregexp(to, C, Failed,
locale,, set, defaulting),
/usr/share/gocode/src/rsc.io/binaryregexp/syntax(to, C, Failed,
locale,, set, defaulting), /usr/share/licenses/golang-rsc-
binaryregexp-devel(to, C, Failed, locale,, set, defaulting)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is
[Bug 1786858] Review Request: golang-rsc-binaryregexp - Go regexp for binary/latin-1 data
https://bugzilla.redhat.com/show_bug.cgi?id=1786858 Jared Smith changed: What|Removed |Added Status|NEW |ASSIGNED CC||jsmith.fed...@gmail.com Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786857] Review Request: golang-github-andygrunwald-gerrit - Go(lang) client/library for Gerrit Code Review
https://bugzilla.redhat.com/show_bug.cgi?id=1786857 Jared Smith changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #2 from Jared Smith --- Package is approved. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/jsmith/Documents/Fedora/Reviews/1786857-golang-github- andygrunwald-gerrit/licensecheck.txt [X]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/golang-github- andygrunwald-gerrit-devel(defaulting, locale,, Failed, C, to, set), /usr/share/gocode/src/github.com(golang-github-groupcache-devel, golang-github-tinylib-msgp-devel, golang-github-mitchellh-wordwrap- devel, golang-github-boombuler-barcode-devel, compat-golang-github- tylerb-graceful-devel, golang-github-backtrace-labs-bcd-devel, golang- github-beevik-ntp-devel, golang-github-circonus-labs-apiclient-devel, golang-github-op-logging-devel, golang-github-pkg-sftp-devel, golang- github-anacrolix-missinggo-devel, golang-github-disintegration- imaging-devel, golang-github-stretchr-objx-devel, golang-github- paulbellamy-ratecounter-devel, golang-github-hashicorp-yamux-devel, golang-github-opencontainers-image-spec-devel, golang-github- smartystreets-assertions-devel, golang-github-hashicorp-hclog-devel, golang-github-hashicorp-checkpoint-devel, golang-github-kardianos- osext-devel, golang-github-bugsnag-devel, golang-github-bradfitz- smtpd-devel, golang-github-xorm-devel, golang-github-masterminds- semver-devel, golang-github-ianlancetaylor-cgosymbolizer-devel, golang-github-peterbourgon-g2s-devel, golang-github-apache-arrow- devel, golang-github-shurcool-httpfs-devel, golang-github-apache- thrift-devel, golang-github-zyedidia-poller-devel, golang-github-grpc- ecosystem-middleware-devel, golang-github-bradfitz-gomemcache-devel, golang-github-google-gofuzz-devel, golang-github-briandowns-spinner- devel, golang-github-maruel-panicparse-devel, golang-github-marstr- guid-devel, golang-github-containerd-continuity-devel, golang-github- jeffail-gabs-devel, golang-github-pquerna-otp-devel, golang- github-h2non-gock-devel, golang-github-gobuffalo-packd-devel, golang- github-marstr-goalias-devel, golang-github-ishidawataru-sctp-devel, golang-github-gofrs-flock-devel, golang-github-cockroachdb- returncheck-devel, golang-github-pquerna-ffjson-devel, golang-github- andybalholm-cascadia-devel, golang-github-openapi-runtime-devel, golang-github-hashicorp-memdb-devel, golang-github-xanzy-ssh-agent- devel, golang-github-spaolacci-murmur3-devel, golang-github-klauspost- compress-devel, golang-github-docker-units-devel, golang-github- emirpasic-gods-devel, golang-github-transip-gotransip-devel, golang- github-coreos-systemd-devel, golang-github-gddo-devel, golang-github- grpc-ecosystem-prometheus-devel, golang-github-jinzhu-now-devel, golang-github-hashicorp-consul-devel, golang-github-jmank88-nuts- devel, golang-github-hashicorp-sockaddr-devel, golang-github-revel- pathtree-devel, golang-github-digitalocean-godo-devel, golang-github- wjdp-htmltest-devel, golang-github-burntsushi-xgb-devel, golang- github-lucas-clemente-aes12-devel, golang-github-nytimes-gziphandler- devel, golang-github-emicklei-restful-devel, golang-github-joho- godotenv-devel, golang-github-vbatts-tar-split-devel, golang-github- karrick-godirwalk-devel, golang-github-nrdcg-goinwx-devel, golang- github-mdlayher-wifi-devel, golang-github-puerkitobio-goquery-devel, golang-github-pquerna-cachecontrol-devel, golang-github-google-wire- devel, golang-github-opencontainers-selinux-devel, golang-github- rackspace-gophercloud-devel, golang-github-sourcegraph- syntaxhighlight-devel, golang-github-theupdateframework-notary-devel, golang-github-influxdata-influxql-devel, golang-github-goftp-server- devel, golang-github-lib-pq-devel, golang-github-lithammer-dedent- devel, golang-github-cockroachdb-apd-devel, golang-github-gohugoio- hugo-devel, golang-github-xordataexchange-crypt-devel,
[Bug 1786857] Review Request: golang-github-andygrunwald-gerrit - Go(lang) client/library for Gerrit Code Review
https://bugzilla.redhat.com/show_bug.cgi?id=1786857 Jared Smith changed: What|Removed |Added CC||jsmith.fed...@gmail.com Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786365] Review Request: xsnow - Let it snow on your desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1786365 --- Comment #3 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/xsnow -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786109] Review Request: scottfree - Interpreter for Scott Adams format text adventure games
https://bugzilla.redhat.com/show_bug.cgi?id=1786109 --- Comment #3 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/scottfree -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786773] Review Request: obs-service-recompress - An OBS source service: Recompress files
https://bugzilla.redhat.com/show_bug.cgi?id=1786773 --- Comment #2 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/obs-service-recompress -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786774] Review Request: obs-service-tar_scm - An OBS source service: checkout or update a tarball from svn/git/hg
https://bugzilla.redhat.com/show_bug.cgi?id=1786774 --- Comment #2 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/obs-service-tar_scm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786766] Review Request: minigalaxy - GOG client for Linux that lets you download and play your GOG Linux games
https://bugzilla.redhat.com/show_bug.cgi?id=1786766 --- Comment #4 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/minigalaxy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
