[Bug 1767918] Review Request: targetd - Revive package
https://bugzilla.redhat.com/show_bug.cgi?id=1767918 Elliott Sales de Andrade changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||targetd-0.8.9-1.fc32 ||targetd-0.8.9-1.fc31 ||targetd-0.8.9-1.fc30 Resolution|--- |ERRATA Last Closed||2020-01-03 04:58:00 --- Comment #11 from Elliott Sales de Andrade --- This seems to have been built. Please tag the bugs in your package updates next time so they are closed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos
https://bugzilla.redhat.com/show_bug.cgi?id=1768192
--- Comment #14 from Elliott Sales de Andrade ---
(In reply to Kees de Jong from comment #11)
> > You shouldn't use internal macros like %__make; just run make directly.
> Is there a reason for this? If the macro exists, then it can be used, right?
> I haven't read anything about this in the maintainer guide. I figured, the
> macro exists, so that implies it may be used.
>
No, it's internal, and there's no need to use it. Just because it exists,
doesn't mean it should be used.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
> Macro forms of system executables SHOULD NOT be used except when there is a
> need to allow the location of those executables to be configurable. For
> example, rm should be used in preference to %{__rm}, but %{__python3} is
> acceptable.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #13 from Elliott Sales de Andrade --- fedora-review 404s downloading those links. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785853] Review Request: rust-rust_hawktracer_sys - Sys crate for the rust_hawktracer library
https://bugzilla.redhat.com/show_bug.cgi?id=1785853
--- Comment #2 from Jerry James ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Please look into the non-executable-script,
wrong-script-end-of-line-encoding,
and wrong-file-end-of-line-encoding rpmlint messages.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "Apache License
(v2.0)", "*No copyright* Beerware License". 259 files have unknown
license. Detailed output of licensecheck in
/home/jamesjer/1785853-rust-rust_hawktracer_sys/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all
[Bug 1785853] Review Request: rust-rust_hawktracer_sys - Sys crate for the rust_hawktracer library
https://bugzilla.redhat.com/show_bug.cgi?id=1785853 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #1 from Jerry James --- I will take this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785853] Review Request: rust-rust_hawktracer_sys - Sys crate for the rust_hawktracer library
https://bugzilla.redhat.com/show_bug.cgi?id=1785853 Jerry James changed: What|Removed |Added Blocks||1785851 ||(rust-rust_hawktracer_norma ||l_macro) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785851 [Bug 1785851] Review Request: rust-rust_hawktracer_normal_macro - Helper crate for hawktracer profiling library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785851] Review Request: rust-rust_hawktracer_normal_macro - Helper crate for hawktracer profiling library
https://bugzilla.redhat.com/show_bug.cgi?id=1785851 Jerry James changed: What|Removed |Added Depends On||1785853 ||(rust-rust_hawktracer_sys) --- Comment #2 from Jerry James --- Nothing can be installed without rust-rust_hawktracer_sys, so I will review that one first. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785853 [Bug 1785853] Review Request: rust-rust_hawktracer_sys - Sys crate for the rust_hawktracer library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786207] Review Request: python-aiozmq - ZeroMQ integration with asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1786207 --- Comment #6 from Mukundan Ragavan --- Thanks for the review and clarification! I will change gitrev to match the shortcommit when I import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785851] Review Request: rust-rust_hawktracer_normal_macro - Helper crate for hawktracer profiling library
https://bugzilla.redhat.com/show_bug.cgi?id=1785851 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #1 from Jerry James --- I will take this review. I would appreciate a review of bug 1787470 in exchange. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787470] New: Review Request: ocaml-sexplib0 - Definition of S-expressions and some base converters
https://bugzilla.redhat.com/show_bug.cgi?id=1787470 Bug ID: 1787470 Summary: Review Request: ocaml-sexplib0 - Definition of S-expressions and some base converters Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/ocaml-sexplib0/ocaml-sexplib0.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-sexplib0/ocaml-sexplib0-0.13.0-1.fc32.src.rpm Fedora Account System Username: jjames Description: This package contains a library with the definition of S-expressions and some base converters. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787429] Review Request: mopidy - An extensible music server written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787429 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms Doc Type|--- |If docs needed, set a value --- Comment #2 from Raphael Groner --- Sorry for the delay of any answer. Currently, I am the package maintainer of the pykka package. It had been orphaned about a year ago and I decided to claim it because of interest in mopidy as a project but never managed to continue my initial work. As far as I know, pykka is needed for the spotify extension only. I gave up with mopidy in favor of kodi as the better alternative in my eyes for consuming any streaming services. Feel free to claim ownership of the pykka package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1783848] Review Request: rust-zstd-safe - Safe low-level bindings for the zstd compression library
https://bugzilla.redhat.com/show_bug.cgi?id=1783848 --- Comment #2 from Jerry James --- It looks like something is missing from the rust-zstd-sys package. Trying to install all of the rust-zstd-safe packages: Error: Problem: conflicting requests - nothing provides crate(zstd-sys/bindgen) = 1.4.15 needed by rust-zstd-safe+bindgen-devel-2.0.3-1.fc32.noarch (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) Indeed, there is no rust-zstd-sys+bindgen-devel package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1783848] Review Request: rust-zstd-safe - Safe low-level bindings for the zstd compression library
https://bugzilla.redhat.com/show_bug.cgi?id=1783848 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #1 from Jerry James --- I will take this review. I would appreciate a review of bug 1787467 if you can do so. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787467] New: Review Request: ocaml-cinaps - Trivial Metaprogramming tool using the OCaml toplevel
https://bugzilla.redhat.com/show_bug.cgi?id=1787467 Bug ID: 1787467 Summary: Review Request: ocaml-cinaps - Trivial Metaprogramming tool using the OCaml toplevel Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/ocaml-cinaps/ocaml-cinaps.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-cinaps/ocaml-cinaps-0.13.0-1.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/ocaml-cinaps/ocaml-cinaps.rpmlintrc Fedora Account System Username: jjames Description: Cinaps is a trivial Metaprogramming tool for OCaml using the OCaml toplevel. It is intended for two purposes: - when you want to include a bit of generated code in a file, but writing a proper generator/ppx rewriter is not worth it; - when you have many repeated blocks of similar code in your program, to help writing and maintaining them. It is not intended as a general preprocessor, and in particular can only be used to generate static code that is independent of the system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785391] Review Request: python-spec - Specification-style output for python-nose
https://bugzilla.redhat.com/show_bug.cgi?id=1785391 --- Comment #7 from Felix Schwarz --- (In reply to Paul Howarth from comment #5) > As for the test suite, I can't seem to get it to run properly during the > build. Any ideas? I'm sorry that I lured you in the wrong direction. I just found https://github.com/bitprophet/spec/issues/29#issuecomment-16341460 so it seems the test suite is actually broken. If the maintainer did not bother I don't think there is a point in trying to fix this in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787443] Review Request: python-pytest-isort - Pytest plugin to check import ordering using isort
https://bugzilla.redhat.com/show_bug.cgi?id=1787443 Fabian Affolter changed: What|Removed |Added Blocks||1787452 (python-devtools) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787452 [Bug 1787452] Review Request: python-devtools - Dev tools for Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787450] Review Request: python-pytest-toolbox - Numerous useful plugins for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1787450 Fabian Affolter changed: What|Removed |Added Blocks||1787452 (python-devtools) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787452 [Bug 1787452] Review Request: python-devtools - Dev tools for Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787452] Review Request: python-devtools - Dev tools for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787452 Fabian Affolter changed: What|Removed |Added Depends On||1787450 ||(python-pytest-toolbox), ||1787443 ||(python-pytest-isort) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787443 [Bug 1787443] Review Request: python-pytest-isort - Pytest plugin to check import ordering using isort https://bugzilla.redhat.com/show_bug.cgi?id=1787450 [Bug 1787450] Review Request: python-pytest-toolbox - Numerous useful plugins for pytest -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787452] Review Request: python-devtools - Dev tools for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787452 Fabian Affolter changed: What|Removed |Added Alias||python-devtools Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #9 from W. Michael Petullo --- Updated URL. I had updated the Source0 before. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787452] New: Review Request: python-devtools - Dev tools for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787452 Bug ID: 1787452 Summary: Review Request: python-devtools - Dev tools for Python Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-devtools.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-devtools-0.5.1-1.fc31.src.rpm Project URL: https://github.com/samuelcolvin/python-devtools Description: The debug print command Python never had (and other things). Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40057301 rpmlint output: $ rpmlint python-devtools-0.5.1-1.fc31.src.rpm python-devtools.src: W: spelling-error Summary(en_US) Dev -> Dec, Devi, Dee 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint python3-devtools-0.5.1-1.fc31.noarch.rpm python3-devtools.noarch: W: spelling-error Summary(en_US) Dev -> Dec, Devi, Dee 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1783828] Review Request: rust-zstd-sys - Low-level bindings for the zstd compression library
https://bugzilla.redhat.com/show_bug.cgi?id=1783828
Jerry James changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Jerry James ---
This package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[Bug 1787443] Review Request: python-pytest-isort - Pytest plugin to check import ordering using isort
https://bugzilla.redhat.com/show_bug.cgi?id=1787443 Fabian Affolter changed: What|Removed |Added Alias||python-pytest-isort -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787450] Review Request: python-pytest-toolbox - Numerous useful plugins for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1787450 Fabian Affolter changed: What|Removed |Added Alias||python-pytest-toolbox Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787443] Review Request: python-pytest-isort - Pytest plugin to check import ordering using isort
https://bugzilla.redhat.com/show_bug.cgi?id=1787443 Fabian Affolter changed: What|Removed |Added Blocks||1787450 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787450 [Bug 1787450] Review Request: python-pytest-toolbox - Numerous useful plugins for pytest -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787450] Review Request: python-pytest-toolbox - Numerous useful plugins for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1787450 Fabian Affolter changed: What|Removed |Added Depends On||1787448 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787448 [Bug 1787448] Review Request: python-pydantic - Data validation and settings management -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787450] Review Request: python-pytest-toolbox - Numerous useful plugins for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1787450 Fabian Affolter changed: What|Removed |Added Depends On||1787443 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787443 [Bug 1787443] Review Request: python-pytest-isort - Pytest plugin to check import ordering using isort -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787448] Review Request: python-pydantic - Data validation and settings management
https://bugzilla.redhat.com/show_bug.cgi?id=1787448 Fabian Affolter changed: What|Removed |Added Blocks||1787450 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787450 [Bug 1787450] Review Request: python-pytest-toolbox - Numerous useful plugins for pytest -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787450] New: Review Request: python-pytest-toolbox - Numerous useful plugins for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1787450 Bug ID: 1787450 Summary: Review Request: python-pytest-toolbox - Numerous useful plugins for pytest Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytest-toolbox.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytest-toolbox-0.4-1.fc31.src.rpm Project URL: https://github.com/samuelcolvin/pytest-toolbox Description: Numerous useful plugins for pytest. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40056747 rpmlint output: $ rpmlint python-pytest-toolbox-0.4-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python3-pytest-toolbox-0.4-1.fc31.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787448] New: Review Request: python-pydantic - Data validation and settings management
https://bugzilla.redhat.com/show_bug.cgi?id=1787448 Bug ID: 1787448 Summary: Review Request: python-pydantic - Data validation and settings management Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pydantic.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pydantic-1.3-1.fc31.src.rpm Project URL: https://github.com/samuelcolvin/pydantic Description: Data validation and settings management using Python type hinting. Fast and extensible, pydantic plays nicely with your linters/IDE/brain. Define how data should be in pure, canonical Python 3.6+; validate it with pydantic. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40056415 rpmlint output: $ rpmlint python-pydantic-1.3-1.fc31.src.rpm python-pydantic.src: W: spelling-error %description -l en_US linters -> liners, liters, inters 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint python3-pydantic-* python3-pydantic.x86_64: W: spelling-error %description -l en_US linters -> liners, liters, inters python3-pydantic.x86_64: E: zero-length /usr/lib64/python3.7/site-packages/pydantic/py.typed 2 packages and 0 specfiles checked; 1 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1783828] Review Request: rust-zstd-sys - Low-level bindings for the zstd compression library
https://bugzilla.redhat.com/show_bug.cgi?id=1783828 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #2 from Jerry James --- I will take this review. Can you review bug 1787447 in exchange? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787447] New: Review Request: python-sphinx-math-dollar - Sphinx extension to enable LaTeX math with $$
https://bugzilla.redhat.com/show_bug.cgi?id=1787447 Bug ID: 1787447 Summary: Review Request: python-sphinx-math-dollar - Sphinx extension to enable LaTeX math with $$ Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/python-sphinx-math-dollar/python-sphinx-math-dollar.spec SRPM URL: https://jjames.fedorapeople.org/python-sphinx-math-dollar/python-sphinx-math-dollar-1.1.1-1.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/python-sphinx-math-dollar/python-sphinx-math-dollar.rpmlintrc Fedora Account System Username: jjames Description: sphinx-math-dollar is a Sphinx extension to let you write LaTeX math using $$. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #8 from Fabian Affolter --- It's hard to keep track if the release is not bumped. I saw the same release tag and that the URL still points to PyPI but the description says otherwise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787443] New: Review Request: python-pytest-isort - Pytest plugin to check import ordering using isort
https://bugzilla.redhat.com/show_bug.cgi?id=1787443 Bug ID: 1787443 Summary: Review Request: python-pytest-isort - Pytest plugin to check import ordering using isort Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytest-isort.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytest-isort-0.3.1-1.fc31.src.rpm Project URL: http://github.com/moccu/pytest-isort/ Description: py.test plugin to check import ordering using isort. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40055953 rpmlint output: $ rpmlint python3-pytest-isort-0.3.1-1.fc31.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python-pytest-isort-0.3.1-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787429] Review Request: mopidy - An extensible music server written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787429 --- Comment #1 from Tobias --- Spec URL: https://raw.githubusercontent.com/fork-graveyard/mopidy-packaging/v3/mopidy.spec SRPM URL: https://github.com/fork-graveyard/mopidy-packaging/releases/download/v3/mopidy-3.0.1-1.fc30.src.rpm fixed title and made a slight change in the spec file (second directory must be writable by service). apologies for the noise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787429] Review Request: mopidy - An extensible music server written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787429 Tobias changed: What|Removed |Added Summary|Review Request: -|written in Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787429] New: Review Request: -
https://bugzilla.redhat.com/show_bug.cgi?id=1787429 Bug ID: 1787429 Summary: Review Request: - Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: t-fed...@girst.at QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/fork-graveyard/mopidy-packaging/v2/mopidy.spec SRPM URL: https://github.com/fork-graveyard/mopidy-packaging/releases/download/v2/mopidy-3.0.1-1.fc30.src.rpm Description: Mopidy plays music from local disk, and a plethora of streaming services and sources. You edit the playlist from any phone, tablet, or computer using a variety of MPD and web clients. Fedora Account System Username: girst Note that this only intends to package the "local disk" part of the description; the streaming services are implemented in extensions, which I might look at packaging later. This package depends on python3-pykka, which I intend to (co)maintain. rpmlint: mopidy.src: W: spelling-error %description -l en_US playlist -> play list, play-list, pluralist 1 packages and 0 specfiles checked; 0 errors, 1 warnings. This is the official spelling in all their documentation, and AFAIK a valid spelling. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787425] New: Review Request: python-webthing-ws - WebThing WebSocket consumer and API client
https://bugzilla.redhat.com/show_bug.cgi?id=1787425 Bug ID: 1787425 Summary: Review Request: python-webthing-ws - WebThing WebSocket consumer and API client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-webthing-ws.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-webthing-ws-0.1.0-1.fc31.src.rpm Project URL: https://github.com/fabaff/webthing-ws Description: A WebThing WebSocket consumer and API client. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40054149 rpmlint output: $ rpmlint python-webthing-ws-0.1.0-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python3-webthing-ws-0.1.0-1.fc31.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787419] New: Review Request: python-email-validator - A robust email syntax and deliverability validation library
https://bugzilla.redhat.com/show_bug.cgi?id=1787419 Bug ID: 1787419 Summary: Review Request: python-email-validator - A robust email syntax and deliverability validation library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-email-validator.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-email-validator-1.0.5-1.fc31.src.rpm Project URL: https://github.com/JoshData/python-email-validator Description: This library validates that address are of the form x...@y.com. This is the sort of validation you would want for a login form on a website. Key features: - Good for validating email addresses used for logins/identity. - Friendly error messages when validation fails (appropriate to show to end users). - (optionally) Checks deliverability: Does the domain name resolve? - Supports internationalized domain names and (optionally) internationalized local parts. - Normalizes email addresses (important for internationalized addresses!). Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40051774 rpmlint output: $ rpmlint python-email-validator-1.0.5-1.fc31.src.rpm python-email-validator.src: W: spelling-error Summary(en_US) deliverability -> deliver ability, deliver-ability, venerability python-email-validator.src: W: spelling-error %description -l en_US logins -> losing, login, loins python-email-validator.src: W: spelling-error %description -l en_US deliverability -> deliver ability, deliver-ability, venerability 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint python3-email-validator-1.0.5-1.fc31.noarch.rpm python3-email-validator.noarch: W: spelling-error Summary(en_US) deliverability -> deliver ability, deliver-ability, venerability python3-email-validator.noarch: W: spelling-error %description -l en_US logins -> losing, login, loins python3-email-validator.noarch: W: spelling-error %description -l en_US deliverability -> deliver ability, deliver-ability, venerability python3-email-validator.noarch: W: no-manual-page-for-binary email_validator 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1525984] Review Request: python-ruamel-std-pathlib - An improvement over the standard pathlib module and pathlib2 package
https://bugzilla.redhat.com/show_bug.cgi?id=1525984 Jared Smith changed: What|Removed |Added Flags|needinfo?(jsmith.fedora@gma | |il.com) | --- Comment #9 from Jared Smith --- No, I'm no longer needing this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787366] New: Review Request: php-psr-http-server-middleware - Common interface for HTTP server-side middleware
https://bugzilla.redhat.com/show_bug.cgi?id=1787366 Bug ID: 1787366 Summary: Review Request: php-psr-http-server-middleware - Common interface for HTTP server-side middleware Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://git.remirepo.net/cgit/rpms/php/psr/php-psr-http-server-middleware.git/plain/php-psr-http-server-middleware.spec?id=6d25a387b858dfb3bce8b2e16298ce732635871c SRPM URL: http://rpms.remirepo.net/SRPMS/php-psr-http-server-middleware-1.0.1-1.remi.src.rpm Description: This repository holds the MiddlewareInterface related to PSR-15 (HTTP Server Request Handlers). Note that this is not a Middleware implementation of its own. It is merely the interface that describe a Middleware. Please refer to the specification for a description: https://www.php-fig.org/psr/psr-15/ Autoloader: /usr/share/php/Psr/Http/Server/middleware-autoload.php Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1778530] Review Request: libfido2 - FIDO2 libraries and utilities for support of U2F / WebAuthn
https://bugzilla.redhat.com/show_bug.cgi?id=1778530 Tomas Mraz changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #7 from Tomas Mraz --- I've sponsored you into the packager group. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1778530] Review Request: libfido2 - FIDO2 libraries and utilities for support of U2F / WebAuthn
https://bugzilla.redhat.com/show_bug.cgi?id=1778530
Tomas Mraz changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|fedora-review? |fedora-review+
|needinfo?(tm...@redhat.com) |
--- Comment #6 from Tomas Mraz ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 2-clause "Simplified" License",
"ISC License", "ISC License BSD 2-clause "Simplified" License", "BSD
(unspecified)". 181 files have unknown license. Detailed output of
licensecheck in /home/mraz/rhsrc/review-libfido2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgv2.
[-]: Description and summary sections in the package spec file
[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds
https://bugzilla.redhat.com/show_bug.cgi?id=1787069 --- Comment #11 from Michael --- Oh yes, I missed this. Thank you for your review and your help! Spec URL: https://raw.githubusercontent.com/ElXreno/ddnet/042238f5c09be3f1cc9d099a29634d04c2a3/ddnet.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2153/40052153/ddnet-12.8.1-6.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785541] Review Request: git-filter-repo - Quickly rewrite git repository history (git-filter-branch replacement)
https://bugzilla.redhat.com/show_bug.cgi?id=1785541 Sahana Prasad changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785541] Review Request: git-filter-repo - Quickly rewrite git repository history (git-filter-branch replacement)
https://bugzilla.redhat.com/show_bug.cgi?id=1785541
--- Comment #3 from Sahana Prasad ---
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* Expat License", "Unknown or generated", "Expat
License", "GPL (v2 or later)". 47 files have unknown license. Detailed
output of licensecheck in /home/sprasad/Project_libssh/libssh-
mirror/FedoraReview/review-git-filter-repo/licensecheck.txt
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 102400 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
files.
you could try to use use -p to preserve timestamps.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
---
Checking:
[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
Artem changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from Artem ---
Few minor issues:
1. '%{_mandir}/man.6/' is incorrect place. Should been '%{_mandir}/man6/'
install -Dp -m 0644 man/DDNet.6 %{buildroot}%{_mandir}/man6/DDNet.6
install -Dp -m 0644 man/DDNet-Server.6
%{buildroot}%{_mandir}/man6/DDNet-Server.6
2. BSD license not needed anymore since you unbundled 'json-parser'. You need
to remove it from License tag and from breakdown license explanation section.
Please fix this before import. Otherwise LGTM.
Rpmlint
---
Checking: ddnet-12.8.1-6.fc32.x86_64.rpm
ddnet-data-12.8.1-6.fc32.noarch.rpm
ddnet-server-12.8.1-6.fc32.x86_64.rpm
ddnet-debuginfo-12.8.1-6.fc32.x86_64.rpm
ddnet-debugsource-12.8.1-6.fc32.x86_64.rpm
ddnet-12.8.1-6.fc32.src.rpm
ddnet.x86_64: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
ddnet-data.noarch: W: no-documentation
ddnet-data.noarch: W: pem-certificate /usr/share/ddnet/data/ca-ddnet.pem
ddnet.src: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
ddnet.src:95: W: unversioned-explicit-provides
bundled(dejavu-sans-cjkname-fonts)
ddnet.src:96: W: unversioned-explicit-provides
bundled(dejavu-wenquanyi-micro-hei-fonts)
6 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (debuginfo)
---
Checking: ddnet-server-debuginfo-12.8.1-6.fc32.x86_64.rpm
ddnet-debuginfo-12.8.1-6.fc32.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "ru_UA.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "ru_UA.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
ddnet-data.noarch: W: no-documentation
ddnet-data.noarch: W: pem-certificate /usr/share/ddnet/data/ca-ddnet.pem
ddnet.x86_64: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
6 packages and 0 specfiles checked; 0 errors, 3 warnings.
Source checksums
https://github.com/ddnet/ddnet/archive/12.8.1/ddnet-12.8.1.tar.gz :
CHECKSUM(SHA256) this package :
139e28f02f11569c1adc6119e9eaf732916ea56c4c84c6af10f9fab94e4abfb4
CHECKSUM(SHA256) upstream package :
139e28f02f11569c1adc6119e9eaf732916ea56c4c84c6af10f9fab94e4abfb4
Requires
ddnet (rpmlib, GLIBC filtered):
ddnet-data
libGL.so.1()(64bit)
libGLEW.so.2.1()(64bit)
libGLU.so.1()(64bit)
libSDL2-2.0.so.0()(64bit)
libX11.so.6()(64bit)
libc.so.6()(64bit)
libcrypto.so.1.1()(64bit)
libcrypto.so.1.1(OPENSSL_1_1_0)(64bit)
libcurl.so.4()(64bit)
libfreetype.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libjsonparser.so.1.1()(64bit)
libm.so.6()(64bit)
libopusfile.so.0()(64bit)
libpnglite.so.0()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libwavpack.so.1()(64bit)
libz.so.1()(64bit)
libz.so.1(ZLIB_1.2.0)(64bit)
rtld(GNU_HASH)
ddnet-data (rpmlib, GLIBC filtered):
ddnet
hicolor-icon-theme
ddnet-server (rpmlib, GLIBC filtered):
ddnet(x86-64)
libc.so.6()(64bit)
libcrypto.so.1.1()(64bit)
libcrypto.so.1.1(OPENSSL_1_1_0)(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libjsonparser.so.1.1()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libz.so.1()(64bit)
libz.so.1(ZLIB_1.2.0)(64bit)
rtld(GNU_HASH)
ddnet-debuginfo (rpmlib, GLIBC filtered):
ddnet-debugsource (rpmlib, GLIBC filtered):
Provides
ddnet:
application()
application(ddnet.desktop)
bundled(dejavu-sans-cjkname-fonts)
bundled(dejavu-wenquanyi-micro-hei-fonts)
ddnet
ddnet(x86-64)
metainfo()
metainfo(ddnet.appdata.xml)
mimehandler(x-scheme-handler/ddnet)
ddnet-data:
ddnet-data
ddnet-server:
ddnet-server
ddnet-server(x86-64)
ddnet-debuginfo:
ddnet-debuginfo
ddnet-debuginfo(x86-64)
debuginfo(build-id)
[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #12 from Kees de Jong --- I copy pasted the URLs from the top of the thread, which did not contain the raw links. Below are the raw links. Spec URL: https://raw.githubusercontent.com/AquaL1te/git-secrets/master/git-secrets.spec SRPM URL: https://github.com/AquaL1te/git-secrets/raw/master/git-secrets-1.3.0-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #11 from Kees de Jong --- > You shouldn't use internal macros like %__make; just run make directly. Is there a reason for this? If the macro exists, then it can be used, right? I haven't read anything about this in the maintainer guide. I figured, the macro exists, so that implies it may be used. > Also, remember to link both spec and srpm. The links are still the same, but are changed on GitHub. I'll include them now anyway. > If you need git at build time, do you not need it at runtime, too? Also, do > you need full git, or can git-core work? Good one! git-core is indeed sufficient too and is indeed also needed for runtime. I've updated the spec file and created new builds: Spec URL: https://github.com/AquaL1te/git-secrets/blob/master/git-secrets.spec SRPM URL: https://github.com/AquaL1te/git-secrets/blob/master/git-secrets-1.3.0-1.fc30.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40051909 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #7 from W. Michael Petullo --- The spec file and the SRPM have indeed changed at the upload location. I did not increment the release tag, since there has not yet been an approved release of this version. Should I have? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1658153] Review Request: wdune - wdune (white_dune) is a graphical VRML97/X3D editor
https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #101 from Jun Aruga --- > $ fedpkg request-repo wdune > Could not execute request_repo: A Bugzilla bug is required on new repository > requests > > I hope this counts as a Bugzilla bug Did you execute the command again after the Pagure repository was created? If it is yes, the command message is incorrect, and could be improved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786204] Review Request: golang-github-youmark-pkcs8 - Parse and convert private keys in PKCS#8 format
https://bugzilla.redhat.com/show_bug.cgi?id=1786204 Hirotaka Wakabayashi changed: What|Removed |Added Status|NEW |ASSIGNED CC||hiw...@yahoo.com Assignee|nob...@fedoraproject.org|hiw...@yahoo.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787336] New: Review Request: python-aiohttp-socks - Proxy connector for aiohttp
https://bugzilla.redhat.com/show_bug.cgi?id=1787336 Bug ID: 1787336 Summary: Review Request: python-aiohttp-socks - Proxy connector for aiohttp Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiohttp-socks.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiohttp-socks-0.3.3-1.fc31.src.rpm Project URL: https://github.com/romis2012/aiohttp-socks Description: Proxy connector for aiohttp. SOCKS4(a), SOCKS5, HTTP (tunneling), Proxy chains are supported. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40051476 rpmlint output: $ rpmlint python-aiohttp-socks-0.3.3-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python3-aiohttp-socks-0.3.3-1.fc31.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786918] Review Request: restmbmaster - Rest API gateway to Modbus slaves
https://bugzilla.redhat.com/show_bug.cgi?id=1786918
Dan Horák changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||d...@danny.cz
Assignee|nob...@fedoraproject.org|d...@danny.cz
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #1 from Dan Horák ---
few rather cosmetic issues
- s/Source:/Source0:/
- you can use %{make_build} and %{make_install} instead of make + parameters in
%build and %install
- consider using %{name} in Source and %files instead of repeating
"restmbmaster"
- $RPM_BUILD_ROOT is being obsoleted, %{buildroot} is the modern equivalent
- drop the %config/%attr options for the unit file, the system unit file is not
a config file and the set attributes are the default ones anyway
- you might want to include /etc/restmbmaster/ directory in the package
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds
https://bugzilla.redhat.com/show_bug.cgi?id=1787069 --- Comment #9 from Michael --- Spec URL: https://raw.githubusercontent.com/ElXreno/ddnet/443e001a8d1ee20c985123ece1718cd31086a23f/ddnet.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1107/40051107/ddnet-12.8.1-6.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds
https://bugzilla.redhat.com/show_bug.cgi?id=1787069 --- Comment #8 from Michael --- Thanks for your patch. I applied it. Also, now I can provide ddnet without bundled md5 and json-parser (thanks upstream for help with it, issue url: [1]). [1] https://github.com/ddnet/ddnet/issues/2022 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787314] Review Request: python-aioftp - FTP client/server for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1787314 Fabian Affolter changed: What|Removed |Added Depends On||1787309 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787309 [Bug 1787309] Review Request: python-siosocks - Sans-io socks proxy client/server with couple io backends -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787309] Review Request: python-siosocks - Sans-io socks proxy client/server with couple io backends
https://bugzilla.redhat.com/show_bug.cgi?id=1787309 Fabian Affolter changed: What|Removed |Added Blocks||1787314 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787314 [Bug 1787314] Review Request: python-aioftp - FTP client/server for asyncio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787314] New: Review Request: python-aioftp - FTP client/server for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1787314 Bug ID: 1787314 Summary: Review Request: python-aioftp - FTP client/server for asyncio Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aioftp.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aioftp-0.14.0-1.fc31.src.rpm Project URL: https://github.com/aio-libs/aioftp Description: FTP client/server for asyncio. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40051053 rpmlint output: $ rpmlint python-aioftp-0.14.0-1.fc31.src.rpm python-aioftp.src: W: spelling-error Summary(en_US) asyncio -> syncopation python-aioftp.src: W: spelling-error %description -l en_US asyncio -> syncopation python-aioftp.src: W: invalid-url Source0: https://github.com/aio-libs/aioftp/archive/0.14.0/aioftp-0.14.0.tar.gz HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint python3-aioftp-0.14.0-1.fc31.noarch.rpm python3-aioftp.noarch: W: spelling-error Summary(en_US) asyncio -> syncopation python3-aioftp.noarch: W: spelling-error %description -l en_US asyncio -> syncopation 1 packages and 0 specfiles checked; 0 errors, 2 warnings Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787309] Review Request: python-siosocks - Sans-io socks proxy client/server with couple io backends
https://bugzilla.redhat.com/show_bug.cgi?id=1787309 Fabian Affolter changed: What|Removed |Added Depends On||1787307 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787307 [Bug 1787307] Review Request: python-pytest-trio - Pytest plugin for trio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787307] Review Request: python-pytest-trio - Pytest plugin for trio
https://bugzilla.redhat.com/show_bug.cgi?id=1787307 Fabian Affolter changed: What|Removed |Added Blocks||1787309 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1787309 [Bug 1787309] Review Request: python-siosocks - Sans-io socks proxy client/server with couple io backends -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787309] New: Review Request: python-siosocks - Sans-io socks proxy client/server with couple io backends
https://bugzilla.redhat.com/show_bug.cgi?id=1787309 Bug ID: 1787309 Summary: Review Request: python-siosocks - Sans-io socks proxy client/server with couple io backends Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-siosocks.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-siosocks-0.1.0-1.fc31.src.rpm Project URL: https://github.com/pohmelie/siosocks Description: socks 4/5 client/server library/framework. - No one-shot socks servers - Sans-io - asyncio-ready Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40051042 rpmlint output: $ rpmlint python-siosocks-0.1.0-1.fc31.src.rpm python-siosocks.src: W: summary-not-capitalized C sans-io socks proxy client/server with couple io backends python-siosocks.src: W: spelling-error %description -l en_US asyncio -> syncopation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint python3-siosocks-0.1.0-1.fc31.noarch.rpm python3-siosocks.noarch: W: summary-not-capitalized C sans-io socks proxy client/server with couple io backends python3-siosocks.noarch: W: spelling-error %description -l en_US asyncio -> syncopation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787307] New: Review Request: python-pytest-trio - Pytest plugin for trio
https://bugzilla.redhat.com/show_bug.cgi?id=1787307
Bug ID: 1787307
Summary: Review Request: python-pytest-trio - Pytest plugin for
trio
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: m...@fabian-affolter.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytest-trio.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-pytest-trio-0.5.2-1.fc31.src.rpm
Project URL: https://github.com/python-trio/pytest-trio
Description:
This is a pytest plugin to help you test projects that use Trio, a friendly
library for concurrency and async I/O in Python.
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=40051038
rpmlint output:
$ rpmlint python-pytest-trio-0.5.2-1.fc31.src.rpm
python-pytest-trio.src: W: spelling-error %description -l en_US async -> sync,
a sync
python-pytest-trio.src:55: W: macro-in-comment %check
python-pytest-trio.src:56: W: macro-in-comment %{buildroot}
python-pytest-trio.src:56: W: macro-in-comment %{python3_sitelib}
python-pytest-trio.src:56: W: macro-in-comment %{python3_version}
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
$ rpmlint python3-pytest-trio-0.5.2-1.fc31.noarch.rpm
python3-pytest-trio.noarch: W: spelling-error %description -l en_US async ->
sync, a sync
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Fedora Account System Username: fab
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787306] New: Review Request: Bubblemail - An unread mail notification dbus service
https://bugzilla.redhat.com/show_bug.cgi?id=1787306 Bug ID: 1787306 Summary: Review Request: Bubblemail - An unread mail notification dbus service Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: razer...@free.fr QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: http://bubblemail.free.fr/fedora/bubblemail-0.3.spec SRPM URL: http://bubblemail.free.fr/fedora/bubblemail-0.3-1.src.rpm Description: Bubblemail is a DBus service providing a list of the new and unread user mail from local mailboxes, pop, imap, and gnome online accounts. It include a libnotify frontend to create notifications and can be used by other frontends as well. Fedora Account System Username: Razer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787304] New: Review Request: python-AWSIoTPythonSDK - SDK for connecting to AWS IoT using Python
https://bugzilla.redhat.com/show_bug.cgi?id=1787304 Bug ID: 1787304 Summary: Review Request: python-AWSIoTPythonSDK - SDK for connecting to AWS IoT using Python Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-AWSIoTPythonSDK.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-AWSIoTPythonSDK-1.4.7-1.fc31.src.rpm Project URL: https://github.com/aws/aws-iot-device-sdk-python Description: The AWS IoT Device SDK for Python allows developers to write Python script to use their devices to access the AWS IoT platform through MQTT or MQTT over the WebSocket protocol. By connecting their devices to AWS IoT, users can securely work with the message broker, rules, and the device shadow (sometimes referred to as a thing shadow) provided by AWS IoT and with other AWS services like AWS Lambda, Amazon Kinesis, Amazon S3, and more. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40050976 rpmlint output: $ rpmlint python-AWSIoTPythonSDK-1.4.7-1.fc31.src.rpm python-AWSIoTPythonSDK.src: W: invalid-url Source0: https://github.com/aws/aws-iot-device-sdk-python/archive/v1.4.7.tar.gz/AWSIoTPythonSDK-1.4.7.tar.gz HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint python3-AWSIoTPythonSDK-1.4.7-1.fc31.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #6 from Fabian Affolter --- The spec file and the SRPM were not updated at the upload location. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785970] Review Request: python-jsonrpcserver - Process JSON-RPC requests
https://bugzilla.redhat.com/show_bug.cgi?id=1785970 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|POST Flags||fedora-review+ --- Comment #2 from Zbigniew Jędrzejewski-Szmek --- Should be all good now. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786207] Review Request: python-aiozmq - ZeroMQ integration with asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1786207 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|POST Flags||fedora-review+ --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- > shortcommit uses first seven chars from the commit and gitrev variable uses > the last eight The first seven (or eight) is appropriate. That snippet is supposed to uniquely identify the commit. So what matters is what git accepts. And git accepts any prefix of the sha1 hash, as long as it is unique. Something like 7 or 8 characters is usually unique, and 7 was the default abbreviation in git for a long time iirc. + package name is OK + latest version (recent git snapshot) + license is acceptable for Fedora (BSD) + license is specified correctly + builds and installs OK + BR/R/P look OK rpmlint has only bogus hints. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
