[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870



--- Comment #5 from Nicolas Mailhot  ---
Also fixed the URL

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22406

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Parag AN(पराग)  ---

Review:

I downloaded manually required srpm file and did below review of this package.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-apparatus-fonts-1.0-1.fc33.noarch.rpm
  sil-apparatus-fonts-1.0-1.fc33.src.rpm
sil-apparatus-fonts.noarch: W: invalid-url URL:
https://software.sil.org/ApparatusSIL/ HTTP Error 404: Not Found
sil-apparatus-fonts.src: W: invalid-url URL:
https://software.sil.org/ApparatusSIL/ HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums

https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=AppSIL1.0.zip=ApparatusSIL.zip#/ApparatusSIL.zip
:
  CHECKSUM(SHA256) this package :
0d8e3143b9c46c97916ab2cf85ae2187fe33b9b40859567a5524266dd58581bc
  CHECKSUM(SHA256) upstream package :
0d8e3143b9c46c97916ab2cf85ae2187fe33b9b40859567a5524266dd58581bc


Requires

sil-apparatus-fonts (rpmlib, GLIBC filtered):
config(sil-apparatus-fonts)
fontpackages-filesystem



Provides

sil-apparatus-fonts:
config(sil-apparatus-fonts)
font(apparatussil)
metainfo()
metainfo(org.fedoraproject.sil-apparatus-fonts.metainfo.xml)
sil-apparatus-fonts


All other things like license, config, metainfo files looks good.


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1806386] New: Re-review Request: pnmixer - Lightweight mixer applet

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1806386

Bug ID: 1806386
   Summary: Re-review Request: pnmixer - Lightweight mixer applet
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mtas...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Re-review request for un-retirement

Spec URL: https://mtasaka.fedorapeople.org/Review_request/pnmixer/pnmixer.spec
SRPM URL:
https://mtasaka.fedorapeople.org/Review_request/pnmixer/pnmixer-0.7.2-3.fc30.src.rpm
Description: 
PNMixer is system tray sound mixer. Currently it supports ALSA and PulseAudio.
It is written in C, depends only on GTK+, and does not require Gnome.

PNMixer is a fork of OBMixer with a number of additions. These include:
* Volume adjustment with the scroll wheel
* Textual display of volume level in popup window
* Continuous volume adjustment when dragging the slider (not just when you let
  go)
* Draw a volume level onto system tray icon
* Use system icon theme for icons and use mute/low/medium/high volume icons
* Configurable middle click action (default is mute/unmute)
* Preferences for:
  * volume text display
  * volume text position
  * icon theme
  * amount to adjust per scroll
  * middle click action
  * drawing of volume level on tray icon
Fedora Account System Username: mtasaka

koji scratch build for F33:
https://koji.fedoraproject.org/koji/taskinfo?taskID=41822931

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1806336] Review Request: perl-Test-Command-Simple - Test external commands (nearly) as easily as loaded modules

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1806336

Sergio Monteiro Basto  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Sergio Monteiro Basto  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated




= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[?]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Artistic License". 14 files have
 unknown license. Detailed output of licensecheck in
 /home/sergio/rpmbuild/1806336-perl-Test-Command-
 Simple/licensecheck.txt
[?]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/perl5/vendor_perl/Test(perl-Fennec, perl-Test-
 CheckManifest, perl-Test-Cmd, perl-Test-Directory, perl-Test-Command,
 perl-Net-Statsd-Server, perl-Test-Class, perl-Test-Deep-Type, perl-
 Test-Run-CmdLine, perl-Test-PostgreSQL, perl-Test-Number-Delta, perl-
 Test-Exception, perl-Test-YAML, perl-Test-Requires-Git, perl-Test-
 FailWarnings, perl-Test-Name-FromLine, perl-Test-Dependencies, perl-
 Test-Able-Runner, perl-Test-NoBreakpoints, perl-Test-HTTP-Server-
 Simple, perl-Test-Exit, perl-Test-JSON, perl-Test-EOL, perl-Test-
 DistManifest, perl-Test-WWW-Mechanize, perl-Test-Inline, perl-MooseX-
 Daemonize, perl-Test-MockTime, perl-Test-Most, perl-Test-
 DBICSchemaLoaderDigest, perl-Test-Script-Run, perl-Test-Regexp-
 Pattern, perl-Test-Version, perl-Test-NoPlan, perl-Dist-Zilla, perl-
 Test-Refcount, perl-Test-Trap, perl-Test-utf8, perl-Test-WWW-
 Mechanize-Catalyst, perl-Test-AutoLoader, perl-Test-Compile, perl-
 Test-Log-Dispatch, perl-Test-ConsistentVersion, perl-Test-Git, perl-
 Test-Unit-Runner-Xml, perl-Test-WriteVariants, perl-Test-Mock-Time,
 perl-Test-TypeTiny, perl-Test-Identity, perl-Test-Unit, perl-Test-
 CPAN-Meta, perl-Test-YAML-Meta, perl-Test-Apocalypse, perl-Test-
 Prereq, perl-CPAN-Changes, perl-Test-Regression, perl-Test-Warnings,
 perl-Test-Warn, perl-SQL-Translator, perl-Test-Mojibake, perl-Test-
 Deep-Fuzzy, perl-Test-Pod-Coverage, perl-Test-Timer, perl-Test-
 MockModule, perl-Test-Kwalitee-Extra, perl-Test-Perl-Critic-
 Progressive, perl-Test-Differences, perl-Test-Image-GD, perl-Test-
 Object, perl-HTML-Lint, perl-Test-Assert, perl-Test-LectroTest, perl-
 Test-Kwalitee, perl-Test-Reporter, perl-Test-MinimumVersion, perl-
 Test-Stream, perl-Test-Unit-Lite, perl-Test-Tolerant, perl-Test-
 mysqld, perl-Test-Regexp, perl-Test-File, perl-Test-Without-Module,
 perl-Test-CPAN-Meta-JSON, perl-Test-MockRandom, perl-Test-SharedFork,
 perl-Test-Smoke, perl-Test-Run, perl-Perl-Tags, perl-Test-Inter, perl-
 Test-Perl-Critic-Policy, perl-Test-API, perl-Test-Specio, perl-Test-
 Synopsis, perl-Test-Routine, perl-Test-Is, perl-Test-Log-Log4perl,
 perl-Test-InDistDir, perl-Test-TempDir, perl-Code-TidyAll, perl-Test-
 Mock-Guard, perl-Test-Dir, perl-Test-Distribution, perl-Test-Pod-
 Spelling-CommonMistakes, perl-Test-RunValgrind, perl-Test-Deep, perl-
 Test-Carp, perl-Test-CleanNamespaces, perl-Test-Fatal, perl-Test-Pod,
 perl-Test-Fixme, perl-Test-HasVersion, perl-Test-Expect, perl-Test-
 File-ShareDir, perl-Test-MockObject, perl-Test-Toolbox, perl-Test-
 Able, perl-Test-CheckDeps, perl-Test-Mock-LWP, perl-Test-LWP-
 UserAgent, perl-Test-Modern, perl-Spellunker, perl-Test-Mojo, perl-
 Test-Database, perl-Test-WWW-Selenium, perl-Test-Harness, perl-Test-
 TrailingSpace, perl-Test-NeedsDisplay, perl-Test-TinyMocker, perl-
 Test-Abortable, perl-Test-Assertions, perl-Test-Module-Used, perl-
 Test-POE-Client-TCP, perl-Test-NoWarnings, perl-Test-Needs, perl-Test-
 Fake-HTTPD, perl-Test-Block, perl-Test-Pod-Content, perl-Test-
 HexString, perl-Excel-Template-Plus, perl-Test-Perl-Critic, perl-Test-
 Vars, perl-Test-XML, perl-Test-Pod-No404s, perl-Test-Requires, perl-
 Test-RDF-Trine-Store, perl-Test-More-UTF8, perl-Test-Spec, perl-Test-
 Portability-Files, perl-Alien-Build, perl-Test-HTTP-Server-Simple-
 StashWarnings, perl-Test-ClassAPI, perl-Test-Type, perl-Test-TempDir-
 Tiny, perl-Test-CheckChanges, perl-Test-Simple, perl-Test-Class-Most,
 perl-Test-Valgrind, perl-Test-MemoryGrowth, perl-Test-Pod-LinkCheck,
 

[Bug 1778530] Review Request: libfido2 - FIDO2 libraries and utilities for support of U2F / WebAuthn

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1778530

Gary Buhrmaster  changed:

   What|Removed |Added

  Flags|needinfo?(gary.buhrmaster@g |
   |mail.com)   |



--- Comment #16 from Gary Buhrmaster  ---
Clearing the "needinfo" request, as I believe this is now resolved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1806336] Review Request: perl-Test-Command-Simple - Test external commands (nearly) as easily as loaded modules

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1806336

Sergio Monteiro Basto  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ser...@serjux.com
   Assignee|nob...@fedoraproject.org|ser...@serjux.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805562] Review Request: golang-github-jcmturner-gofork - Forked Go standard library packages with work arounds

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805562



--- Comment #6 from Fedora Update System  ---
golang-github-jcmturner-gofork-1.0.0-1.fc30 has been pushed to the Fedora 30
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-57a8125297

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805566] Review Request: golang-github-dpotapov-spnego - Cross-platform HTTP calls with Kerberos authentication

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805566



--- Comment #4 from Fedora Update System  ---
golang-github-dpotapov-spnego-0-0.1.20200222gitc2c6091.fc30 has been pushed to
the Fedora 30 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f6ee0691d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805564] Review Request: golang-gopkg-jcmturner-gokrb5-5 - Pure Go Kerberos library for clients and services

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805564



--- Comment #6 from Fedora Update System  ---
golang-gopkg-jcmturner-gokrb5-5-5.3.0-1.fc30 has been pushed to the Fedora 30
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-2e6af0b1f0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805557] Review Request: golang-gopkg-jcmturner-goidentity-2 - Go interface for authenticated identities and attributes

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805557



--- Comment #6 from Fedora Update System  ---
golang-gopkg-jcmturner-goidentity-2-2.0.0-1.fc30 has been pushed to the Fedora
30 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-fa8cbee681

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-02-24 01:34:35



--- Comment #17 from Fedora Update System  ---
ddnet-12.9.1-1.fc31 has been pushed to the Fedora 31 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1763468] Review Request: samdump2 - Retrieves syskey and extracts hashes from Windows SAM hive

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1763468



--- Comment #2 from Michal Ambroz  ---
Hello,
thank you for review - here comes the update.

Spec URL: http://rebus.fedorapeople.org/SPECS/samdump2.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/samdump2-3.0.0-16.fc30.src.rpm

>- Package does not use a name that already exists.
yes - this is the same package, same owner.
Package was FTBS with contemporary openss, orphaned and marked as dead for
fc31.
Now it compiles again with new openssl versions so I would like to resurrect it
again.

Michal Ambroz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1795071] Review Request: python-textparser - Python text parser

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1795071



--- Comment #16 from Fedora Update System  ---
python-textparser-0.23.0-2.el8 has been pushed to the Fedora EPEL 8 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1694894

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #13 from Fedora Update System  ---
FEDORA-2020-f5bdcff86b has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f5bdcff86b

--- Comment #14 from Fedora Update System  ---
FEDORA-2020-2c5eb82fae has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-2c5eb82fae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1694894

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #13 from Fedora Update System  ---
FEDORA-2020-f5bdcff86b has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f5bdcff86b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1806336] New: Review Request: perl-Test-Command-Simple - Test external commands (nearly) as easily as loaded modules

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1806336

Bug ID: 1806336
   Summary: Review Request: perl-Test-Command-Simple - Test
external commands (nearly) as easily as loaded modules
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: manisan...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://smani.fedorapeople.org/review/perl-Test-Command-Simple.spec
SRPM URL:
https://smani.fedorapeople.org/review/perl-Test-Command-Simple-0.05-1.fc33.src.rpm
Description: Test external commands (nearly) as easily as loaded modules
Fedora Account System Username: smani

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1803945] Review Request: zita-ajbridge - Allows ALSA devices to be JACK clients

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803945

Ralf Senderek  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #10 from Ralf Senderek  ---
So your package has been APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1803945] Review Request: zita-ajbridge - Allows ALSA devices to be JACK clients

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803945

Ralf Senderek  changed:

   What|Removed |Added

 Status|ASSIGNED|RELEASE_PENDING



--- Comment #9 from Ralf Senderek  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
 Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: 

[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803942

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #11 from Neal Gompa  ---
This is taken care of.

Congratulations on becoming an official Fedora packager, Radka!


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1803945] Review Request: zita-ajbridge - Allows ALSA devices to be JACK clients

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803945



--- Comment #8 from Erich Eickmeyer  ---
(In reply to Ralf Senderek from comment #6)
> (In reply to Ralf Senderek from comment #5)
> 
> > I'd suggest %{_mandir}/man1/ if you don't want to specify the three
> > man pages by name.
> 
> This should be %{_mandir}/man1/zita* so you don't claim ownership of the
> man1 directory, of course.

Since there are other packages with the name zita, I decided to be even more
specific with manpages.

(In reply to Ralf Senderek from comment #7)
> There are two more changes to be made to the spec file:
> 
> 1) Remove the Group tag. (see
> https://fedoraproject.org/wiki/Changes/Remove_Group_Tag)
> 
> 2) Use the parallel make %{?_smp_mflags} macro.

1) Done.

2) Done.

SRPM:
https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01249880-zita-ajbridge/zita-ajbridge-0.8.2-3.fc33.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1780906] Review Request: arbor - Multi-compartment neural network simulation library

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1780906

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-02-23 17:49:06



--- Comment #7 from Ankur Sinha (FranciscoD)  ---
Built for rawhide now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1803945] Review Request: zita-ajbridge - Allows ALSA devices to be JACK clients

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803945



--- Comment #7 from Ralf Senderek  ---
There are two more changes to be made to the spec file:

1) Remove the Group tag. (see
https://fedoraproject.org/wiki/Changes/Remove_Group_Tag)

2) Use the parallel make %{?_smp_mflags} macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805943] Review Request: sil-shimenkan-fonts - A Miao (Pollard) script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805943



--- Comment #2 from Nicolas Mailhot  ---
Thanks for the review! The URL points nowhere right now, SIL is still creating
the font homepage

https://pagure.io/releng/fedora-scm-requests/issue/22388

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1803945] Review Request: zita-ajbridge - Allows ALSA devices to be JACK clients

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803945



--- Comment #6 from Ralf Senderek  ---
(In reply to Ralf Senderek from comment #5)

> I'd suggest %{_mandir}/man1/ if you don't want to specify the three
> man pages by name.

This should be %{_mandir}/man1/zita* so you don't claim ownership of the man1
directory, of course.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870



--- Comment #3 from Nicolas Mailhot  ---
Sorry about that, I messed up the last refactoring of SIL specs in that case
(Apparatus is one of their oldest projects and it is not published the same way
as others)

copr, mock, rpmbuild & spectool are quite happy with the spec except the source
is named %{archivename.sip} (not really what you want it to be).

Please use:
https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01249599-sil-apparatus-fonts/sil-apparatus-fonts.spec
https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01249599-sil-apparatus-fonts/sil-apparatus-fonts-1.0-3.fc33.noarch.rpm

They should work better.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805894] Review Request: sil-ezra-fonts - An Hebrew font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805894



--- Comment #2 from Nicolas Mailhot  ---
Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22400

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805886] Review Request: sil-dai-banna-fonts - A font family for rendering New Tai Lue (Xishuangbanna Dai)

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805886



--- Comment #3 from Nicolas Mailhot  ---
uchardet detects /usr/share/doc/sil-dai-banna-fonts-doc/sample.txt as UTF-8, so
something weird is going in rpmlint’s encoding detection

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805886] Review Request: sil-dai-banna-fonts - A font family for rendering New Tai Lue (Xishuangbanna Dai)

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805886



--- Comment #2 from Nicolas Mailhot  ---
Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22399

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805880] Review Request: sil-awami-nastaliq-fonts - A Nastaliq-style Arabic script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805880



--- Comment #2 from Nicolas Mailhot  ---
Fixed the changelog (it was good initially, I do swear)

Thanks a lot for the review!
https://pagure.io/releng/fedora-scm-requests/issue/22398

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805864] Review Request: sil-annapurna-fonts - A Devanagari font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805864



--- Comment #3 from Nicolas Mailhot  ---
Fixed the warnings :( If SIL continues committing executable doc I may just
dump a generic chmod in all SIL specs.

Thanks a lot for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22397

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805795] Review Request: sil-andika-compact-fonts - A font family for literacy and beginning readers

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805795



--- Comment #2 from Nicolas Mailhot  ---
Thanks for the review!
https://pagure.io/releng/fedora-scm-requests/issue/22396

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805787] Review Request: sil-alkalami-fonts - A font family for the Arabic-based writing systems in the Kano region of Nigeria and Niger

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805787



--- Comment #2 from Nicolas Mailhot  ---
Fixed! Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22394

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805797] Review Request: sil-andika-new-basic-fonts - A font family for literacy and beginning readers

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805797



--- Comment #2 from Nicolas Mailhot  ---
Thanks for the review!
https://pagure.io/releng/fedora-scm-requests/issue/22393

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805990] Review Request: symbian-m-yuppy-gb-fonts - A Chinese font family with a unique, modern feel

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805990



--- Comment #4 from Nicolas Mailhot  ---
Thanks for the review! Hope Symbian’s investment proves useful in Fedora

https://pagure.io/releng/fedora-scm-requests/issue/22392

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805962] Review Request: sil-tai-heritage-pro-fonts - A traditional style Tai Viet script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805962



--- Comment #2 from Nicolas Mailhot  ---
Fixed! Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22391

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805957] Review Request: sil-tagmukay-fonts - A Shifinagh font that supports the Tawallammat dialect of Tamajaq

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805957



--- Comment #3 from Nicolas Mailhot  ---
Ah, drat, all the rpm enhancements to get rid of %defattr do not apply to %doc…
Fixed! 

Thanks for the review!
https://pagure.io/releng/fedora-scm-requests/issue/22390

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805946] Review Request: sil-sophia-nubian-fonts - A font family for Nubian languages which use the Coptic Unicode character set

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805946



--- Comment #2 from Nicolas Mailhot  ---
Fixed the summary, thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22389

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1803945] Review Request: zita-ajbridge - Allows ALSA devices to be JACK clients

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1803945



--- Comment #5 from Ralf Senderek  ---
Whenever you change your spec file you must update the
SRPM file, otherwise people would build your package using
the old spec file.
Please upload an up-to-date SRPM.

With regards to the use of wildcards, please see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/

As a general rule I think it's best to be as specific as possible
so folks can see which files you're packaging by looking at the 
spec file.

I'd suggest %{_mandir}/man1/ if you don't want to specify the three
man pages by name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Parag AN(पराग)  ---
ERROR: 'Cannot parse Source0 url
https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=AppSIL1.0.zip=%{archivename.zip}#/%{archivename.zip}'
 

debug log says
02-23 12:23 root DEBUGReviewError: 'Cannot parse Source0 url
https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=AppSIL1.0.zip=%{archivename.zip}#/%{archivename.zip}'
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/FedoraReview/spec_file.py", line 171,
in _get_sources
result[tag] = self.spec.sourceHeader.format(unquote(url))
_rpm.error: unknown tag: "archivename.zip"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805864] Review Request: sil-annapurna-fonts - A Devanagari font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805864



--- Comment #2 from Parag AN(पराग)  ---
ah please ignore previous comment.

Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-annapurna-fonts-1.204-1.fc33.noarch.rpm
  sil-annapurna-fonts-doc-1.204-1.fc33.noarch.rpm
  sil-annapurna-fonts-1.204-1.fc33.src.rpm
sil-annapurna-fonts.noarch: W: spurious-executable-perm
/usr/share/doc/sil-annapurna-fonts/AnnapurnaSIL-GraphiteFeatures.odt
sil-annapurna-fonts-doc.noarch: W: summary-not-capitalized C
sil-annapurna-fonts optional documentation files
sil-annapurna-fonts-doc.noarch: E: description-line-too-long C This package
provides optional documentation files shipped with sil-annapurna-fonts.
sil-annapurna-fonts-doc.noarch: W: spurious-executable-perm
/usr/share/doc/sil-annapurna-fonts-doc/AnnapurnaSIL-features.pdf
3 packages and 0 specfiles checked; 1 errors, 3 warnings.

Source checksums

https://github.com/silnrsi/font-annapurna/releases/download/v1.204/AnnapurnaSIL-1.204.tar.xz
:
  CHECKSUM(SHA256) this package :
b9c31d4259f5579d8ce677ea161d761b1abc13c220b798a73e9d5d22710237d5
  CHECKSUM(SHA256) upstream package :
b9c31d4259f5579d8ce677ea161d761b1abc13c220b798a73e9d5d22710237d5


Requires

sil-annapurna-fonts (rpmlib, GLIBC filtered):
config(sil-annapurna-fonts)
fontpackages-filesystem

sil-annapurna-fonts-doc (rpmlib, GLIBC filtered):



Provides

sil-annapurna-fonts:
config(sil-annapurna-fonts)
font(annapurnasil)
metainfo()
metainfo(org.fedoraproject.sil-annapurna-fonts.metainfo.xml)
sil-annapurna-fonts

sil-annapurna-fonts-doc:
sil-annapurna-fonts-doc


All other things like license, config, metainfo files looks good.

Issues:
1) Please fix rpmlint warnings before import.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805934] Review Request: sil-namdhinggo-fonts - A font family for the Limbu writing system of Nepal

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805934



--- Comment #2 from Nicolas Mailhot  ---
Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22387

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805894] Review Request: sil-ezra-fonts - An Hebrew font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805894

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-ezra-sr-fonts-2.51-1.fc33.noarch.rpm
  sil-ezra-fonts-2.51-1.fc33.src.rpm
sil-ezra-sr-fonts.noarch: W: spelling-error %description -l en_US cantillation
-> scintillation, cancellation, titillation
sil-ezra-fonts.src: W: spelling-error %description -l en_US cantillation ->
scintillation, cancellation, titillation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums

https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=EzraSIL251.zip=EzraSIL251.zip#/EzraSIL251.zip
:
  CHECKSUM(SHA256) this package :
fd2894531aab32ff7d6845e3d0b4c0401c91f64ba637d13624dfc17a3e815831
  CHECKSUM(SHA256) upstream package :
fd2894531aab32ff7d6845e3d0b4c0401c91f64ba637d13624dfc17a3e815831


Requires

sil-ezra-sr-fonts (rpmlib, GLIBC filtered):
config(sil-ezra-sr-fonts)
fontpackages-filesystem



Provides

sil-ezra-sr-fonts:
config(sil-ezra-sr-fonts)
font(ezrasilsr)
metainfo()
metainfo(org.fedoraproject.sil-ezra-sr-fonts.metainfo.xml)
sil-ezra-sr-fonts



All other things like license, config, metainfo files looks good.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805886] Review Request: sil-dai-banna-fonts - A font family for rendering New Tai Lue (Xishuangbanna Dai)

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805886

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-dai-banna-fonts-2.200-1.fc33.noarch.rpm
  sil-dai-banna-fonts-doc-2.200-1.fc33.noarch.rpm
  sil-dai-banna-fonts-2.200-1.fc33.src.rpm
sil-dai-banna-fonts.noarch: E: summary-too-long C Dai Banna SIL, a font family
for rendering New Tai Lue (Xishuangbanna Dai) characters
sil-dai-banna-fonts.noarch: W: spelling-error %description -l en_US
Xishuangbanna -> Shijiazhuang
sil-dai-banna-fonts-doc.noarch: W: summary-not-capitalized C
sil-dai-banna-fonts optional documentation files
sil-dai-banna-fonts-doc.noarch: E: description-line-too-long C This package
provides optional documentation files shipped with sil-dai-banna-fonts.
sil-dai-banna-fonts-doc.noarch: W: spurious-executable-perm
/usr/share/doc/sil-dai-banna-fonts-doc/DaiBannaSIL.pdf
sil-dai-banna-fonts-doc.noarch: W: file-not-utf8
/usr/share/doc/sil-dai-banna-fonts-doc/sample.txt
sil-dai-banna-fonts.src: E: summary-too-long C Dai Banna SIL, a font family for
rendering New Tai Lue (Xishuangbanna Dai) characters
sil-dai-banna-fonts.src: W: spelling-error %description -l en_US Xishuangbanna
-> Shijiazhuang
3 packages and 0 specfiles checked; 3 errors, 5 warnings.

Source checksums

https://software.sil.org/downloads/r/daibanna/DaiBanna-2.200.zip :
  CHECKSUM(SHA256) this package :
bab67e560484ee9bc041d1e95ae2e36a08ceb9cde6800ef032381fae0700f691
  CHECKSUM(SHA256) upstream package :
bab67e560484ee9bc041d1e95ae2e36a08ceb9cde6800ef032381fae0700f691


Requires

sil-dai-banna-fonts (rpmlib, GLIBC filtered):
config(sil-dai-banna-fonts)
fontpackages-filesystem

sil-dai-banna-fonts-doc (rpmlib, GLIBC filtered):



Provides

sil-dai-banna-fonts:
config(sil-dai-banna-fonts)
font(daibannasilbook)
font(daibannasillight)
metainfo()
metainfo(org.fedoraproject.sil-dai-banna-fonts.metainfo.xml)
sil-dai-banna-fonts

sil-dai-banna-fonts-doc:
sil-dai-banna-fonts-doc

All other things like license, config, metainfo files looks good.

Issues:
1) Fix rpmlint issues before import of this package


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805932] Review Request: sil-mondulkiri-fonts - A Khmer script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805932



--- Comment #2 from Nicolas Mailhot  ---
Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22386

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805864] Review Request: sil-annapurna-fonts - A Devanagari font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805864

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-awami-nastaliq-fonts-2.000-1.fc33.noarch.rpm
  sil-awami-nastaliq-fonts-2.000-1.fc33.src.rpm
sil-awami-nastaliq-fonts.noarch: W: no-version-in-last-changelog
sil-awami-nastaliq-fonts.src: W: no-version-in-last-changelog
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums

https://github.com/silnrsi/font-awami/releases/download/v2.000/AwamiNastaliq-2.000.tar.xz
:
  CHECKSUM(SHA256) this package :
35d3abbdc4756ed73371aadb5907f8d38457da374c9ee380cef771b9141c4b80
  CHECKSUM(SHA256) upstream package :
35d3abbdc4756ed73371aadb5907f8d38457da374c9ee380cef771b9141c4b80


Requires

sil-awami-nastaliq-fonts (rpmlib, GLIBC filtered):
config(sil-awami-nastaliq-fonts)
fontpackages-filesystem



Provides

sil-awami-nastaliq-fonts:
config(sil-awami-nastaliq-fonts)
font(awaminastaliq)
metainfo()
metainfo(org.fedoraproject.sil-awami-nastaliq-fonts.metainfo.xml)
sil-awami-nastaliq-fonts


All other things like license, config, metainfo files looks good.

Issues:
1) Please fix rpmlint warning "no-version-in-last-changelog" before import.
(Seems missing release number in Changelog)

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805880] Review Request: sil-awami-nastaliq-fonts - A Nastaliq-style Arabic script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805880

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-awami-nastaliq-fonts-2.000-1.fc33.noarch.rpm
  sil-awami-nastaliq-fonts-2.000-1.fc33.src.rpm
sil-awami-nastaliq-fonts.noarch: W: no-version-in-last-changelog
sil-awami-nastaliq-fonts.src: W: no-version-in-last-changelog
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums

https://github.com/silnrsi/font-awami/releases/download/v2.000/AwamiNastaliq-2.000.tar.xz
:
  CHECKSUM(SHA256) this package :
35d3abbdc4756ed73371aadb5907f8d38457da374c9ee380cef771b9141c4b80
  CHECKSUM(SHA256) upstream package :
35d3abbdc4756ed73371aadb5907f8d38457da374c9ee380cef771b9141c4b80


Requires

sil-awami-nastaliq-fonts (rpmlib, GLIBC filtered):
config(sil-awami-nastaliq-fonts)
fontpackages-filesystem



Provides

sil-awami-nastaliq-fonts:
config(sil-awami-nastaliq-fonts)
font(awaminastaliq)
metainfo()
metainfo(org.fedoraproject.sil-awami-nastaliq-fonts.metainfo.xml)
sil-awami-nastaliq-fonts



All other things like license, config, metainfo files looks good.


Issues:
1) Please fix rpmlint warning "no-version-in-last-changelog" before import.
(Seems missing release number in Changelog)

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805926] Review Request: sil-mondulkiri-extra-fonts - Extra Khmer script font families from the SIL Mondulkiri project

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805926



--- Comment #2 from Nicolas Mailhot  ---
Thanks for the review!

I fixed the spelling bits rpmlint did not like in the macro templates (not sure
this is worth a new release)
https://pagure.io/fonts-rpm-macros/c/5f50c715c3b6a3dabb7371d33e7c4fd9e4e12b7c

https://pagure.io/releng/fedora-scm-requests/issue/22385

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805921] Review Request: sil-harmattan-fonts - A Warsh-style Arabic script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805921



--- Comment #3 from Nicolas Mailhot  ---
Thanks a lot for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22384

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805913] Review Request: sil-gentium-plus-fonts - A Latin/Greek/Cyrillic font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805913



--- Comment #2 from Nicolas Mailhot  ---
Thanks a lot for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22382

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805387] Review Request: rust-maybe-uninit - MaybeUninit for friends of backwards compatibility

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805387

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-02-23 10:36:07



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805387] Review Request: rust-maybe-uninit - MaybeUninit for friends of backwards compatibility

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805387



--- Comment #2 from Igor Gnatenko  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-maybe-uninit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805387] Review Request: rust-maybe-uninit - MaybeUninit for friends of backwards compatibility

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805387

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||i.gnatenko.br...@gmail.com
   Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com
  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805795] Review Request: sil-andika-compact-fonts - A font family for literacy and beginning readers

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805795

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-andika-compact-fonts-5.000-1.fc33.noarch.rpm
  sil-andika-compact-fonts-5.000-1.fc33.src.rpm
sil-andika-compact-fonts.noarch: W: spelling-error %description -l en_US
letterforms -> letter forms, letter-forms, letterbombs
sil-andika-compact-fonts.src: W: spelling-error %description -l en_US
letterforms -> letter forms, letter-forms, letterbombs
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums

https://software.sil.org/downloads/r/andika/AndikaCompact-5.000.zip :
  CHECKSUM(SHA256) this package :
047d7abc6a12abf83fe0e62177e835434392c3c6d79e46433bc610fda05e0331
  CHECKSUM(SHA256) upstream package :
047d7abc6a12abf83fe0e62177e835434392c3c6d79e46433bc610fda05e0331


Requires

sil-andika-compact-fonts (rpmlib, GLIBC filtered):
config(sil-andika-compact-fonts)
fontpackages-filesystem



Provides

sil-andika-compact-fonts:
config(sil-andika-compact-fonts)
font(andikacompact)
metainfo()
metainfo(org.fedoraproject.sil-andika-compact-fonts.metainfo.xml)
sil-andika-compact-fonts



APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805797] Review Request: sil-andika-new-basic-fonts - A font family for literacy and beginning readers

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805797

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-andika-new-basic-fonts-5.500-1.fc33.noarch.rpm
  sil-andika-new-basic-fonts-5.500-1.fc33.src.rpm
sil-andika-new-basic-fonts.noarch: W: spelling-error %description -l en_US
letterforms -> letter forms, letter-forms, letterbombs
sil-andika-new-basic-fonts.src: W: spelling-error %description -l en_US
letterforms -> letter forms, letter-forms, letterbombs
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums

https://software.sil.org/downloads/r/andika/AndikaNewBasic-5.500.zip :
  CHECKSUM(SHA256) this package :
18308284a3e98cd7712d057742d8d6cd040a52ec0479a1dcf92d57815f8d368a
  CHECKSUM(SHA256) upstream package :
18308284a3e98cd7712d057742d8d6cd040a52ec0479a1dcf92d57815f8d368a


Requires

sil-andika-new-basic-fonts (rpmlib, GLIBC filtered):
config(sil-andika-new-basic-fonts)
fontpackages-filesystem



Provides

sil-andika-new-basic-fonts:
config(sil-andika-new-basic-fonts)
font(andikanewbasic)
metainfo()
metainfo(org.fedoraproject.sil-andika-new-basic-fonts.metainfo.xml)
sil-andika-new-basic-fonts


All other things like license, config, metainfo files looks good.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805787] Review Request: sil-alkalami-fonts - A font family for the Arabic-based writing systems in the Kano region of Nigeria and Niger

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805787

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-alkalami-fonts-1.200-1.fc33.noarch.rpm
  sil-alkalami-fonts-doc-1.200-1.fc33.noarch.rpm
  sil-alkalami-fonts-1.200-1.fc33.src.rpm
sil-alkalami-fonts.noarch: E: summary-too-long C Alkalami, a font family for
the Arabic-based writing systems in the Kano region of Nigeria and Niger
sil-alkalami-fonts.noarch: W: spelling-error %description -l en_US ajami ->
jamming
sil-alkalami-fonts.noarch: W: spelling-error %description -l en_US Alkǎlami
sil-alkalami-fonts.noarch: W: spelling-error %description -l en_US al -> AL,
la, Al
sil-alkalami-fonts.noarch: W: spelling-error %description -l en_US qalam ->
salaam
sil-alkalami-fonts.noarch: W: spelling-error %description -l en_US ascenders ->
ascendance, descender, ascends
sil-alkalami-fonts.noarch: W: spelling-error %description -l en_US descenders
-> descender, descender s, descends
sil-alkalami-fonts-doc.noarch: W: summary-not-capitalized C sil-alkalami-fonts
optional documentation files
sil-alkalami-fonts-doc.noarch: E: description-line-too-long C This package
provides optional documentation files shipped with sil-alkalami-fonts.
sil-alkalami-fonts.src: E: summary-too-long C Alkalami, a font family for the
Arabic-based writing systems in the Kano region of Nigeria and Niger
sil-alkalami-fonts.src: W: spelling-error %description -l en_US ajami ->
jamming
sil-alkalami-fonts.src: W: spelling-error %description -l en_US Alkǎlami
sil-alkalami-fonts.src: W: spelling-error %description -l en_US al -> AL, la,
Al
sil-alkalami-fonts.src: W: spelling-error %description -l en_US qalam -> salaam
sil-alkalami-fonts.src: W: spelling-error %description -l en_US ascenders ->
ascendance, descender, ascends
sil-alkalami-fonts.src: W: spelling-error %description -l en_US descenders ->
descender, descender s, descends
3 packages and 0 specfiles checked; 3 errors, 13 warnings.

Source checksums

https://github.com/silnrsi/font-alkalami/releases/download/v1.200/Alkalami-1.200.tar.xz
:
  CHECKSUM(SHA256) this package :
632747ad5ebb9a9b9e91d1bc810e2a0314709edeb035dc5931812b74327fef17
  CHECKSUM(SHA256) upstream package :
632747ad5ebb9a9b9e91d1bc810e2a0314709edeb035dc5931812b74327fef17


Requires

sil-alkalami-fonts (rpmlib, GLIBC filtered):
config(sil-alkalami-fonts)
fontpackages-filesystem

sil-alkalami-fonts-doc (rpmlib, GLIBC filtered):



Provides

sil-alkalami-fonts:
config(sil-alkalami-fonts)
font(alkalami)
font(alkalamilight)
metainfo()
metainfo(org.fedoraproject.sil-alkalami-fonts.metainfo.xml)
sil-alkalami-fonts

sil-alkalami-fonts-doc:
sil-alkalami-fonts-doc


All other things like license, config, metainfo files looks good.

Issues:
1) Fix rpmlint warnings before import of this package.

All other things like license, config, metainfo files looks good.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805921] Review Request: sil-harmattan-fonts - A Warsh-style Arabic script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805921

Parag AN(पराग)  changed:

   What|Removed |Added

 Depends On||1805797
  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Parag AN(पराग)  ---
Got it, the required dependency is in other review.
APPROVED.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1805797
[Bug 1805797] Review Request: sil-andika-new-basic-fonts - A font family for
literacy and beginning readers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805797] Review Request: sil-andika-new-basic-fonts - A font family for literacy and beginning readers

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805797

Parag AN(पराग)  changed:

   What|Removed |Added

 Blocks||1805921




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1805921
[Bug 1805921] Review Request: sil-harmattan-fonts - A Warsh-style Arabic script
font family
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805990] Review Request: symbian-m-yuppy-gb-fonts - A Chinese font family with a unique, modern feel

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805990

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: symbian-m-yuppy-gb-fonts-1.00-1.fc33.noarch.rpm
  symbian-m-yuppy-gb-fonts-1.00-1.fc33.src.rpm
symbian-m-yuppy-gb-fonts.noarch: W: spelling-error %description -l en_US
letterform -> letter form, letter-form, letterbomb
symbian-m-yuppy-gb-fonts.noarch: W: no-documentation
symbian-m-yuppy-gb-fonts.src: W: spelling-error %description -l en_US
letterform -> letter form, letter-form, letterbomb
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

Source checksums

https://raw.githubusercontent.com/SymbianSource/oss.FCL.sf.os.textandloc/59666d6704fee305b0fdd74974f7b4f42659c6a6/fontservices/referencefonts/truetype/MYuppyGB-Medium_README.TXT
:
  CHECKSUM(SHA256) this package :
f7c2c3b012e870077ef159890f614f83bb430bfd7dde0a77d978ea1e6a677236
  CHECKSUM(SHA256) upstream package :
f7c2c3b012e870077ef159890f614f83bb430bfd7dde0a77d978ea1e6a677236
https://raw.githubusercontent.com/SymbianSource/oss.FCL.sf.os.textandloc/59666d6704fee305b0fdd74974f7b4f42659c6a6/fontservices/referencefonts/truetype/MYuppyGB-Medium.ttf
:
  CHECKSUM(SHA256) this package :
a5b6d8ab3d098796ef93178b5a384419738f3ac573b6943b2dc11500347be973
  CHECKSUM(SHA256) upstream package :
a5b6d8ab3d098796ef93178b5a384419738f3ac573b6943b2dc11500347be973


Requires

symbian-m-yuppy-gb-fonts (rpmlib, GLIBC filtered):
config(symbian-m-yuppy-gb-fonts)
fontpackages-filesystem



Provides

symbian-m-yuppy-gb-fonts:
config(symbian-m-yuppy-gb-fonts)
font(myuppygb-medium)
metainfo()
metainfo(org.fedoraproject.symbian-m-yuppy-gb-fonts.metainfo.xml)
symbian-m-yuppy-gb-fonts


All other things like license, config, metainfo files looks good.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805962] Review Request: sil-tai-heritage-pro-fonts - A traditional style Tai Viet script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805962

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-tai-heritage-pro-fonts-2.600-1.fc33.noarch.rpm
  sil-tai-heritage-pro-fonts-2.600-1.fc33.src.rpm
sil-tai-heritage-pro-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/sil-tai-heritage-pro-fonts/developer/RegressionTestReferenceHistory.txt
sil-tai-heritage-pro-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/sil-tai-heritage-pro-fonts/developer/TaiHeritagePro-workflow.txt
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums

https://github.com/silnrsi/font-taiheritagepro/releases/download/v2.600/TaiHeritagePro-2.600.tar.xz
:
  CHECKSUM(SHA256) this package :
72ec66a7ac126f2bff66f2f9957923214d296f69843034fc3f27eabc036b7031
  CHECKSUM(SHA256) upstream package :
72ec66a7ac126f2bff66f2f9957923214d296f69843034fc3f27eabc036b7031


Requires

sil-tai-heritage-pro-fonts (rpmlib, GLIBC filtered):
config(sil-tai-heritage-pro-fonts)
fontpackages-filesystem



Provides

sil-tai-heritage-pro-fonts:
config(sil-tai-heritage-pro-fonts)
font(taiheritagepro)
metainfo()
metainfo(org.fedoraproject.sil-tai-heritage-pro-fonts.metainfo.xml)
sil-tai-heritage-pro-fonts

All other things like license, config, metainfo files looks good.

Issues:
1) Fix the rpmlint warning "wrong-file-end-of-line-encoding" before import of
this package.


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805957] Review Request: sil-tagmukay-fonts - A Shifinagh font that supports the Tawallammat dialect of Tamajaq

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805957



--- Comment #2 from Parag AN(पराग)  ---
Wait, fix the rpmlint warning "spurious-executable-perm" before import of this
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805957] Review Request: sil-tagmukay-fonts - A Shifinagh font that supports the Tawallammat dialect of Tamajaq

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805957

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-tagmukay-fonts-2.000-1.fc33.noarch.rpm
  sil-tagmukay-fonts-2.000-1.fc33.src.rpm
sil-tagmukay-fonts.noarch: W: spelling-error %description -l en_US Tawallammat
-> Taramasalata
sil-tagmukay-fonts.noarch: W: spurious-executable-perm
/usr/share/doc/sil-tagmukay-fonts/Tagmukay-Glyphs.odt
sil-tagmukay-fonts.noarch: W: spurious-executable-perm
/usr/share/doc/sil-tagmukay-fonts/Tagmukay-SmartFontFeatures.odt
sil-tagmukay-fonts.src: W: spelling-error %description -l en_US Tawallammat ->
Taramasalata
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Source checksums

https://github.com/silnrsi/font-tagmukay/releases/download/v2.000/Tagmukay-2.000.tar.xz
:
  CHECKSUM(SHA256) this package :
0ac09c04f3907324a24135d73036975cde7f2df4c22c8024b50dbec9e2142704
  CHECKSUM(SHA256) upstream package :
0ac09c04f3907324a24135d73036975cde7f2df4c22c8024b50dbec9e2142704


Requires

sil-tagmukay-fonts (rpmlib, GLIBC filtered):
config(sil-tagmukay-fonts)
fontpackages-filesystem



Provides

sil-tagmukay-fonts:
config(sil-tagmukay-fonts)
font(tagmukay)
metainfo()
metainfo(org.fedoraproject.sil-tagmukay-fonts.metainfo.xml)
sil-tagmukay-fonts

All other things like license, config, metainfo files looks good.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805946] Review Request: sil-sophia-nubian-fonts - A font family for Nubian languages which use the Coptic Unicode character set

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805946

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.


Rpmlint
---
Checking: sil-sophia-nubian-fonts-1.0-1.fc33.noarch.rpm
  sil-sophia-nubian-fonts-1.0-1.fc33.src.rpm
sil-sophia-nubian-fonts.noarch: E: summary-too-long C Sophia Nubian, a font
family for Nubian languages which use the Coptic Unicode character set
sil-sophia-nubian-fonts.src: E: summary-too-long C Sophia Nubian, a font family
for Nubian languages which use the Coptic Unicode character set
2 packages and 0 specfiles checked; 2 errors, 0 warnings.

Source checksums

https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=SN1.0.zip=SN1.0.zip#/SN1.0.zip
:
  CHECKSUM(SHA256) this package :
d1c4748b712cd43f3fd30f8a6a34ee362d102912e900c82f04380206ae7b9b5f
  CHECKSUM(SHA256) upstream package :
d1c4748b712cd43f3fd30f8a6a34ee362d102912e900c82f04380206ae7b9b5f


Requires

sil-sophia-nubian-fonts (rpmlib, GLIBC filtered):
config(sil-sophia-nubian-fonts)
fontpackages-filesystem



Provides

sil-sophia-nubian-fonts:
config(sil-sophia-nubian-fonts)
font(sophianubian)
metainfo()
metainfo(org.fedoraproject.sil-sophia-nubian-fonts.metainfo.xml)
sil-sophia-nubian-fonts


All other things like license, config, metainfo files looks good.

Issues:
1) Fix the summary-too-long rpmlint warning before import of this package

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805943] Review Request: sil-shimenkan-fonts - A Miao (Pollard) script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805943

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-shimenkan-fonts-1.000-1.fc33.noarch.rpm
  sil-shimenkan-fonts-1.000-1.fc33.src.rpm
sil-shimenkan-fonts.noarch: W: spelling-error %description -l en_US
positionning -> positioning, interposition, transitioning
sil-shimenkan-fonts.noarch: W: invalid-url URL:
https://software.sil.org/shimenkan/ HTTP Error 404: Not Found
sil-shimenkan-fonts.src: W: spelling-error %description -l en_US positionning
-> positioning, interposition, transitioning
sil-shimenkan-fonts.src: W: invalid-url URL:
https://software.sil.org/shimenkan/ HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Source checksums

https://github.com/silnrsi/font-shimenkan/releases/download/v1.000/Shimenkan-1.000.tar.xz
:
  CHECKSUM(SHA256) this package :
32283d9417f1233708dccce244a176aee1cee40b7b030e440cfba8d68fe56b78
  CHECKSUM(SHA256) upstream package :
32283d9417f1233708dccce244a176aee1cee40b7b030e440cfba8d68fe56b78


Requires

sil-shimenkan-fonts (rpmlib, GLIBC filtered):
config(sil-shimenkan-fonts)
fontpackages-filesystem



Provides

sil-shimenkan-fonts:
config(sil-shimenkan-fonts)
font(shimenkan)
font(shimenkanbook)
font(shimenkanextralight)
font(shimenkanlight)
metainfo()
metainfo(org.fedoraproject.sil-shimenkan-fonts.metainfo.xml)
sil-shimenkan-fonts


All other things like license, config, metainfo files looks good.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805934] Review Request: sil-namdhinggo-fonts - A font family for the Limbu writing system of Nepal

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805934

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-namdhinggo-fonts-1.004-1.fc33.noarch.rpm
  sil-namdhinggo-fonts-1.004-1.fc33.src.rpm
sil-namdhinggo-fonts.noarch: W: spelling-error %description -l en_US honour ->
honor, hon our, hon-our
sil-namdhinggo-fonts.src: W: spelling-error %description -l en_US honour ->
honor, hon our, hon-our
sil-namdhinggo-fonts.src:21: W: non-break-space line 21, char 59
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

Source checksums

https://software.sil.org/downloads/r/namdhinggo/NamdhinggoSIL-1.004.zip :
  CHECKSUM(SHA256) this package :
8bd69ee93687f2b3fcb705b0c8867c8ff573edcaf9a5c51a08a8ca1c1ddc966b
  CHECKSUM(SHA256) upstream package :
8bd69ee93687f2b3fcb705b0c8867c8ff573edcaf9a5c51a08a8ca1c1ddc966b


Requires

sil-namdhinggo-fonts (rpmlib, GLIBC filtered):
config(sil-namdhinggo-fonts)
fontpackages-filesystem



Provides

sil-namdhinggo-fonts:
config(sil-namdhinggo-fonts)
font(namdhinggosil)
metainfo()
metainfo(org.fedoraproject.sil-namdhinggo-fonts.metainfo.xml)
sil-namdhinggo-fonts



All other things like license, config, metainfo files looks good.

Issues:
1) Fix rpmlint warning "sil-namdhinggo-fonts.src:21: W: non-break-space line
21, char 59"


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805932] Review Request: sil-mondulkiri-fonts - A Khmer script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805932

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint:

sil-mondulkiri-fonts-all.noarch: W: spelling-error %description -l en_US
metapackage -> meta package, meta-package, prepackage
sil-mondulkiri-fonts-all.noarch: W: no-documentation
sil-mondulkiri-fonts-doc.noarch: W: summary-not-capitalized C
sil-mondulkiri-fonts optional documentation files
sil-mondulkiri-fonts-doc.noarch: E: description-line-too-long C This package
provides optional documentation files shipped with sil-mondulkiri-fonts.
5 packages and 0 specfiles checked; 1 errors, 3 warnings.


Source checksums

https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=Mondulkiri-7.100=Mondulkiri-7.100.zip#/Mondulkiri-7.100.zip
:
  CHECKSUM(SHA256) this package :
c2e5dc08f4835be9a0da5cf9dcf92105aff973e47fc31e075e8bc44bec632c85
  CHECKSUM(SHA256) upstream package :
c2e5dc08f4835be9a0da5cf9dcf92105aff973e47fc31e075e8bc44bec632c85


Requires

sil-busra-fonts (rpmlib, GLIBC filtered):
config(sil-busra-fonts)
fontpackages-filesystem

sil-mondulkiri-fonts-all (rpmlib, GLIBC filtered):
sil-busra-fonts
sil-mondulkiri-fonts

sil-mondulkiri-fonts-doc (rpmlib, GLIBC filtered):



Provides

sil-busra-fonts:
config(sil-busra-fonts)
font(khmerbusra)
metainfo()
metainfo(org.fedoraproject.sil-busra-fonts.metainfo.xml)
sil-busra-fonts

sil-mondulkiri-fonts-all:
sil-mondulkiri-fonts-all

sil-mondulkiri-fonts-doc:
sil-mondulkiri-fonts-doc

All other things like license, config, metainfo files looks good.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805926] Review Request: sil-mondulkiri-extra-fonts - Extra Khmer script font families from the SIL Mondulkiri project

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805926

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
sil-busra-bunong-fonts.noarch: W: spelling-error %description -l en_US coengs
-> coverings
sil-busra-diagnostic-fonts.noarch: W: spelling-error %description -l en_US
xspace -> space, x space
sil-busra-diagnostic-fonts.noarch: W: spelling-error %description -l en_US
coengs -> coverings
sil-busra-dot-fonts.noarch: W: spelling-error %description -l en_US codepoint
-> code point, code-point, codependent
sil-busra-moe-fonts.noarch: W: spelling-error %description -l en_US coeng ->
conger
sil-mondulkiri-extra-fonts-all.noarch: W: spelling-error %description -l en_US
metapackage -> meta package, meta-package, prepackage
sil-mondulkiri-extra-fonts-all.noarch: W: no-documentation
sil-mondulkiri-extra-fonts-doc.noarch: W: summary-not-capitalized C
sil-mondulkiri-extra-fonts optional documentation files
sil-mondulkiri-extra-fonts-doc.noarch: E: description-line-too-long C This
package provides optional documentation files shipped with
sil-mondulkiri-extra-fonts.
sil-ratanakiri-fonts.noarch: W: spelling-error %description -l en_US coengs ->
coverings
sil-ratanakiri-fonts.noarch: W: spelling-error %description -l en_US coeng ->
conger
12 packages and 0 specfiles checked; 1 errors, 10 warnings.


Source checksums

https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=Mondulkiri-5.300=Mondulkiri-5.300.zip#/Mondulkiri-5.300.zip
:
  CHECKSUM(SHA256) this package :
4ff38760e48f3185c515088d91bc9e6a17402cbb3be316c06681c231db580f88
  CHECKSUM(SHA256) upstream package :
4ff38760e48f3185c515088d91bc9e6a17402cbb3be316c06681c231db580f88



All other things like license, config, metainfo files looks good.

Issues:
1) Fix Summary not capitalized and description not wrapped to 80 characters.
2) fedora-review failed to install generated packages in mock. But let's not
block this review here. Tested manually installing generated packages. Working
fine.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805921] Review Request: sil-harmattan-fonts - A Warsh-style Arabic script font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805921

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-harmattan-fonts-1.001-1.fc33.noarch.rpm
  sil-harmattan-fonts-1.001-1.fc33.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Source checksums

https://software.sil.org/downloads/r/harmattan/Harmattan-1.001.zip :
  CHECKSUM(SHA256) this package :
bf4b24e5e38c7df908ddff1344de732b20c9f3aafd724e112f4315597aaf6be3
  CHECKSUM(SHA256) upstream package :
bf4b24e5e38c7df908ddff1344de732b20c9f3aafd724e112f4315597aaf6be3


Requires

sil-harmattan-fonts (rpmlib, GLIBC filtered):
config(sil-harmattan-fonts)
font(andikanewbasic)
fontpackages-filesystem



Provides

sil-harmattan-fonts:
config(sil-harmattan-fonts)
font(harmattan)
metainfo()
metainfo(org.fedoraproject.sil-harmattan-fonts.metainfo.xml)
sil-harmattan-fonts



All other things like license, config, metainfo files looks good.


This package failed to install in mock due to unavailable dependency
"font(andikanewbasic)".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805913] Review Request: sil-gentium-plus-fonts - A Latin/Greek/Cyrillic font family

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805913

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-gentium-plus-fonts-5.000-1.fc33.noarch.rpm
  sil-gentium-plus-fonts-5.000-1.fc33.src.rpm
sil-gentium-plus-fonts.noarch: W: spelling-error %description -l en_US bukva ->
kabuki
sil-gentium-plus-fonts.noarch: W: spelling-error %description -l en_US raz ->
raze, razz, ran
sil-gentium-plus-fonts.src: W: spelling-error %description -l en_US bukva ->
kabuki
sil-gentium-plus-fonts.src: W: spelling-error %description -l en_US raz ->
raze, razz, ran
2 packages and 0 specfiles checked; 0 errors, 4 warnings.



Source checksums

https://software.sil.org/downloads/r/gentium/GentiumPlus-5.000.zip :
  CHECKSUM(SHA256) this package :
335911f17bd2de4e43742e1d0367cfeff19a90abf7ed604f100a42705042e154
  CHECKSUM(SHA256) upstream package :
335911f17bd2de4e43742e1d0367cfeff19a90abf7ed604f100a42705042e154


Requires

sil-gentium-plus-fonts (rpmlib, GLIBC filtered):
config(sil-gentium-plus-fonts)
fontpackages-filesystem



Provides

sil-gentium-plus-fonts:
config(sil-gentium-plus-fonts)
font(gentiumplus)
metainfo()
metainfo(org.fedoraproject.sil-gentium-plus-fonts.metainfo.xml)
sil-gentium-plus-fonts

All other things like license, config, metainfo files looks good.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org