[Bug 1816457] Review Request: ocaml-mlmpfr - OCaml bindings for MPFR
https://bugzilla.redhat.com/show_bug.cgi?id=1816457 --- Comment #1 from Vasiliy Glazov --- It is normal that unversioned .so file not in devel subpackage? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301 Benson Muite changed: What|Removed |Added CC||benson_mu...@emailplus.org --- Comment #4 from Benson Muite --- Can you check it builds on more than x86, in particular ARM-hfp and AArch64, see https://fedoraproject.org/wiki/Architectures -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816457] Review Request: ocaml-mlmpfr - OCaml bindings for MPFR
https://bugzilla.redhat.com/show_bug.cgi?id=1816457 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED CC||vasc...@gmail.com Assignee|nob...@fedoraproject.org|vasc...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816457] New: Review Request: ocaml-mlmpfr - OCaml bindings for MPFR
https://bugzilla.redhat.com/show_bug.cgi?id=1816457 Bug ID: 1816457 Summary: Review Request: ocaml-mlmpfr - OCaml bindings for MPFR Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/ocaml-mlmpfr/ocaml-mlmpfr.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-mlmpfr/ocaml-mlmpfr-4.0.2-1.fc33.src.rpm Fedora Account System Username: jjames Description: This library provides OCaml bindings for MPFR. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804307] Review Request: python-jack-client - JACK Audio Connection Kit (JACK) Client for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1804307 --- Comment #9 from Fedora Update System --- FEDORA-2020-a165853141 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a165853141 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a165853141 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803945] Review Request: zita-ajbridge - Allows ALSA devices to be JACK clients
https://bugzilla.redhat.com/show_bug.cgi?id=1803945 --- Comment #13 from Fedora Update System --- FEDORA-2020-d1ab84dbde has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d1ab84dbde \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d1ab84dbde See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801352] Review Request: raysession - Ray Session is a GNU/Linux session manager for audio programs
https://bugzilla.redhat.com/show_bug.cgi?id=1801352 --- Comment #25 from Fedora Update System --- FEDORA-2020-4eb045a393 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-4eb045a393 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4eb045a393 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815154] Review Request: python-sphinx-press-theme - A Sphinx-doc theme based on Vuepress
https://bugzilla.redhat.com/show_bug.cgi?id=1815154 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- FEDORA-2020-92c812f0b5 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-92c812f0b5` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-92c812f0b5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1795053] Review Request: wfuzz - Web fuzzer
https://bugzilla.redhat.com/show_bug.cgi?id=1795053 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2020-d505615c49 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d505615c49 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d505615c49 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808405] Review Request: python-ana - Python module to provide easy distributed data storage
https://bugzilla.redhat.com/show_bug.cgi?id=1808405 Fedora Update System changed: What|Removed |Added Status|POST|ON_QA --- Comment #4 from Fedora Update System --- FEDORA-2020-a252c3d2a6 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a252c3d2a6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a252c3d2a6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809097] Review Request: php-marcusschwarz-lesserphp - a LESS compiler written in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1809097 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System --- FEDORA-2020-589fa35724 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-589fa35724 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-589fa35724 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Fedora Update System changed: What|Removed |Added Status|NEW |ON_QA --- Comment #56 from Fedora Update System --- FEDORA-2020-7d4505de5e has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-7d4505de5e` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d4505de5e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704522] Review Request: zork - Public Domain source code to the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522 --- Comment #16 from Fedora Update System --- FEDORA-2020-fee0637f32 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-fee0637f32 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-fee0637f32 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813860] Review Request: micropipenv - A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files
https://bugzilla.redhat.com/show_bug.cgi?id=1813860 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-03-24 01:48:27 --- Comment #13 from Fedora Update System --- FEDORA-2020-a4d894708a has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704522] Review Request: zork - Public Domain source code to the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522 --- Comment #15 from Fedora Update System --- FEDORA-EPEL-2020-29d6c63c6c has been pushed to the Fedora EPEL 6 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-29d6c63c6c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682
--- Comment #14 from Honggang LI ---
(In reply to lsun from comment #13)
> Thanks all for the comments!
> Below are the updated info (2.0.1) trying to solve these comments.
>
> Spec URL:
> https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.1/
> rshim.spec
> SRPM URL:
> https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.1/
> rshim-2.0.1-1.fc31.src.rpm
*
Task method: VersionDiffBuild
Task URL: https://cov01.lab.eng.brq.redhat.com/covscanhub/task/164815/
Comment:
Added (+), Fixed (-)
SLEEP +2
TAINTED_SCALAR+1
BUFFER_SIZE_WARNING -1
CLANG_WARNING -4
LOCK -2
OVERRUN -1
PW.BAD_PRINTF_FORMAT_STRING -3
RESOURCE_LEAK -1
SIZEOF_MISMATCH -1
SLEEP -4
TAINTED_SCALAR-7
*
Newly introduced defects
List of Defects
Error: TAINTED_SCALAR (CWE-20): [#def1]
rshim-2.0.1/src/rshim.c:2209: tainted_argument: Calling function
"rshim_fd_full_read" taints argument "index".
rshim-2.0.1/src/rshim.c:2211: tainted_data: Using tainted variable "index" as
an index into an array "rshim_devs".
rshim-2.0.1/src/rshim.c:2211: remediation: Ensure that tainted values are
properly sanitized, by checking that their values are within a permissible
range.
# 2209| rc = rshim_fd_full_read(rshim_work_fd[0], ,
sizeof(index));
# 2210| if (rc == sizeof(index)) {
# 2211|-> bd = rshim_devs[index];
# 2212| if (bd)
# 2213| rshim_work_handler(bd);
Error: SLEEP (CWE-367): [#def2]
rshim-2.0.1/src/rshim_pcie.c:392: lock_acquire: Calling function
"pthread_mutex_lock" acquires lock "bd->mutex".
rshim-2.0.1/src/rshim_pcie.c:400: sleep: Call to "rshim_register" might sleep
while holding lock "bd->mutex".
# 398| */
# 399| rshim_lock();
# 400|-> ret = rshim_register(bd);
# 401| if (ret) {
# 402| rshim_unlock();
Error: SLEEP (CWE-367): [#def3]
rshim-2.0.1/src/rshim_pcie_lf.c:524: lock_acquire: Calling function
"pthread_mutex_lock" acquires lock "bd->mutex".
rshim-2.0.1/src/rshim_pcie_lf.c:532: sleep: Call to "rshim_register" might
sleep while holding lock "bd->mutex".
# 530| */
# 531| rshim_lock();
# 532|-> ret = rshim_register(bd);
# 533| if (ret) {
# 534| rshim_unlock();
> koji build URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=42727191
>
> Below are the unsolved coverity warnings and explanations (based on Comment
> 12):
>
> Error: LOCK (CWE-667): [#def2]
> [lsun] Function rshim_write_delayed() has lock held outside by the caller.
> No need to unlock it on return.
>
> Error: LOCK (CWE-667): [#def3]
> [lsun] same.
>
> Error: MISSING_LOCK (CWE-667): [#def4]
> [lsun] This is the RSH_DEV_TYPE_TMFIFO case and is called from
> rshim_fifo_input()and rshim_fifo_output(). In both cases the ringlock are
> already held.
>
> Error: MISSING_LOCK (CWE-667): [#def5]
> [lsun] This one is called from the 'RSH_EVENT_ATTACH' handling, which
> already has the lock held when calling rshim_notify(bd, RSH_EVENT_ATTACH, 0).
>
> Error: MISSING_LOCK (CWE-667): [#def6]
> [lsun] same
>
> Error: SLEEP (CWE-367): [#def26]
> rshim_register(bd);
> [lsun] This one is called during device probe at early stage. The sleep
> purpose is to detect if any other driver has already attached to the same
> rshim device (since it could be attached from USB or PCIe via different host
> machine). The probing takes some time. The sleep here is ok.
>
> Error: MISSING_LOCK (CWE-667): [#def24]
> Error: MISSING_LOCK (CWE-667): [#def25]
> [lsun] same as [#def4 above.
Thanks for the comments.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704522] Review Request: zork - Public Domain source code to the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2020-7d28ec15d7 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-7d28ec15d7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787218] Review Request: python-aiopg - Postgres integration with asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1787218 --- Comment #2 from Fabian Affolter --- Thanks for the feedback. * Mon Mar 23 2020 Fabian Affolter - 1.0.0-2 - Make tests optional - Don't use psycopg2-binary Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiopg.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiopg-1.0.0-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816267] Review Request: python-ajpy - AJP package crafting library
https://bugzilla.redhat.com/show_bug.cgi?id=1816267 Fabian Affolter changed: What|Removed |Added Blocks||1816367 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1816367 [Bug 1816367] Review Request: patator - A multi-purpose brute-forcer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816367] Review Request: patator - A multi-purpose brute-forcer
https://bugzilla.redhat.com/show_bug.cgi?id=1816367 Fabian Affolter changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Depends On||1816267, 1816279, 1816295 Doc Type|--- |If docs needed, set a value --- Comment #1 from Fabian Affolter --- Sorry, missed the files. Spec URL: https://fab.fedorapeople.org/packages/SRPMS/patator.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/patator-0.8-1.fc31.src.rpm Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages https://bugzilla.redhat.com/show_bug.cgi?id=1816267 [Bug 1816267] Review Request: python-ajpy - AJP package crafting library https://bugzilla.redhat.com/show_bug.cgi?id=1816279 [Bug 1816279] Review Request: python-cx-oracle - Python interface to Oracle https://bugzilla.redhat.com/show_bug.cgi?id=1816295 [Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 Fabian Affolter changed: What|Removed |Added Blocks||1816367 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1816367 [Bug 1816367] Review Request: patator - A multi-purpose brute-forcer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816279] Review Request: python-cx-oracle - Python interface to Oracle
https://bugzilla.redhat.com/show_bug.cgi?id=1816279 Fabian Affolter changed: What|Removed |Added Blocks||1816367 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1816367 [Bug 1816367] Review Request: patator - A multi-purpose brute-forcer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816367] New: Review Request: patator - A multi-purpose brute-forcer
https://bugzilla.redhat.com/show_bug.cgi?id=1816367 Bug ID: 1816367 Summary: Review Request: patator - A multi-purpose brute-forcer Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: SRPM URL: Project URL: https://github.com/lanjelot/patator Description: Patator is a multi-purpose brute-forcer, with a modular design and a flexible usage. It supports a wide range of services. Koji scratch build: fails, missing dependenies rpmlint output: $ rpmlint patator-0.8-1.fc31.src.rpm patator.src: W: spelling-error Summary(en_US) forcer -> force, forces, forced patator.src: W: spelling-error %description -l en_US forcer -> force, forces, forced 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint patator-0.8-1.fc31.noarch.rpm patator.noarch: W: spelling-error Summary(en_US) forcer -> force, forces, forced patator.noarch: W: spelling-error %description -l en_US forcer -> force, forces, forced patator.noarch: W: no-manual-page-for-binary patator 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806241] Review Request: php-webimpress-safe-writer - Tool to write files safely, to avoid race conditions
https://bugzilla.redhat.com/show_bug.cgi?id=1806241 --- Comment #11 from Fedora Update System --- FEDORA-2020-24ab48bb12 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797524] Review Request: sourcextractor++ - A program that extracts a catalog of sources from astronomical images
https://bugzilla.redhat.com/show_bug.cgi?id=1797524 --- Comment #22 from Fedora Update System --- FEDORA-2020-bf285e44c1 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 l...@mellanox.com changed: What|Removed |Added Flags|needinfo?(l...@mellanox.com | |) | --- Comment #13 from l...@mellanox.com --- Thanks all for the comments! Below are the updated info (2.0.1) trying to solve these comments. Spec URL: https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.1/rshim.spec SRPM URL: https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.1/rshim-2.0.1-1.fc31.src.rpm koji build URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=42727191 Below are the unsolved coverity warnings and explanations (based on Comment 12): Error: LOCK (CWE-667): [#def2] [lsun] Function rshim_write_delayed() has lock held outside by the caller. No need to unlock it on return. Error: LOCK (CWE-667): [#def3] [lsun] same. Error: MISSING_LOCK (CWE-667): [#def4] [lsun] This is the RSH_DEV_TYPE_TMFIFO case and is called from rshim_fifo_input()and rshim_fifo_output(). In both cases the ringlock are already held. Error: MISSING_LOCK (CWE-667): [#def5] [lsun] This one is called from the 'RSH_EVENT_ATTACH' handling, which already has the lock held when calling rshim_notify(bd, RSH_EVENT_ATTACH, 0). Error: MISSING_LOCK (CWE-667): [#def6] [lsun] same Error: SLEEP (CWE-367): [#def26] rshim_register(bd); [lsun] This one is called during device probe at early stage. The sleep purpose is to detect if any other driver has already attached to the same rshim device (since it could be attached from USB or PCIe via different host machine). The probing takes some time. The sleep here is ok. Error: MISSING_LOCK (CWE-667): [#def24] Error: MISSING_LOCK (CWE-667): [#def25] [lsun] same as [#def4 above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816283] Review Request: rust-ref-cast - Safely cast to where the struct U contains a single field of type T
https://bugzilla.redhat.com/show_bug.cgi?id=1816283 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-03-23 19:48:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301
david08...@gmail.com changed:
What|Removed |Added
CC||david08...@gmail.com
--- Comment #3 from david08...@gmail.com ---
Not a full review, but some comments:
Group: is deprecated, please remove
License should be: GPLv3+
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
Name should probably not include the version:
Name: openfoam
I am not sure whether this is a MUST, but the release should start at 1 and be
bumped whenever you change the spec, without a new release:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_simple_versioning
%defattr(-,root,root,-) isn't needed, please remove
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions
I don't think prefix should be set; it is certainly not allowed to use /opt
Buildroot should not be set:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
'%package -n %{name}-examples' -> '%package examples'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com Flags||fedora-review? --- Comment #2 from Ankur Sinha (FranciscoD) --- Hi Mark, I'll help review this, and I can sponsor you when it's ready too. Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301 --- Comment #1 from mark.ole...@esi-group.com --- FE-NEEDSPONSOR -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816281] Review Request: rust-ref-cast-impl - Derive implementation for ref_cast::RefCast
https://bugzilla.redhat.com/show_bug.cgi?id=1816281 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-03-23 18:48:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816301] New: Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301 Bug ID: 1816301 Summary: Review Request: openfoam - computational fluid dynamics Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: mark.ole...@esi-group.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/openfoam/openfoam/epel-7-x86_64/01304439-openfoam1912/openfoam1912.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/openfoam/openfoam/epel-7-x86_64/01304439-openfoam1912/openfoam1912-1912-200312.el7.src.rpm Description: herOpenFOAM has an extensive range of features to solve complex fluid flows involving chemical reactions, turbulence and heat transfer, solid dynamics and electromagnetics Fedora Account System Username: openfoam My first Fedora package, seeking sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801352] Review Request: raysession - Ray Session is a GNU/Linux session manager for audio programs
https://bugzilla.redhat.com/show_bug.cgi?id=1801352 --- Comment #24 from Fedora Update System --- FEDORA-2020-aac56ea73b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-aac56ea73b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816283] Review Request: rust-ref-cast - Safely cast to where the struct U contains a single field of type T
https://bugzilla.redhat.com/show_bug.cgi?id=1816283 --- Comment #2 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ref-cast -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816283] Review Request: rust-ref-cast - Safely cast to where the struct U contains a single field of type T
https://bugzilla.redhat.com/show_bug.cgi?id=1816283
Vasiliy Glazov changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Vasiliy Glazov ---
Approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 14 files have unknown
license. Detailed output of licensecheck in /home/vascom/1816283-rust-
ref-cast/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
ref-cast-devel , rust-ref-cast+default-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should
[Bug 1816281] Review Request: rust-ref-cast-impl - Derive implementation for ref_cast::RefCast
https://bugzilla.redhat.com/show_bug.cgi?id=1816281 --- Comment #2 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ref-cast-impl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] New: Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 Bug ID: 1816295 Summary: Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-mysqlclient.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-mysqlclient-1.4.6-1.fc31.src.rpm Project URL: https://github.com/PyMySQL/mysqlclient-python Description: MySQLdb is an interface to the popular MySQL database server that provides the Python database API. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42725486 rpmlint output: $ rpmlint python-mysqlclient-1.4.6-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python*mysql*.rpm python-mysqlclient-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/python-mysqlclient-doc/html/objects.inv python-mysqlclient-doc.x86_64: W: file-not-utf8 /usr/share/doc/python-mysqlclient-doc/html/objects.inv 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816281] Review Request: rust-ref-cast-impl - Derive implementation for ref_cast::RefCast
https://bugzilla.redhat.com/show_bug.cgi?id=1816281
Vasiliy Glazov changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Vasiliy Glazov ---
Approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 4 files have unknown license. Detailed
output of licensecheck in /home/vascom/1816281-rust-ref-cast-
impl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
ref-cast-impl-devel , rust-ref-cast-impl+default-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]:
[Bug 1816283] Review Request: rust-ref-cast - Safely cast to where the struct U contains a single field of type T
https://bugzilla.redhat.com/show_bug.cgi?id=1816283 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED CC||vasc...@gmail.com Assignee|nob...@fedoraproject.org|vasc...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816281] Review Request: rust-ref-cast-impl - Derive implementation for ref_cast::RefCast
https://bugzilla.redhat.com/show_bug.cgi?id=1816281 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED CC||vasc...@gmail.com Assignee|nob...@fedoraproject.org|vasc...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804307] Review Request: python-jack-client - JACK Audio Connection Kit (JACK) Client for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1804307 --- Comment #8 from Fedora Update System --- FEDORA-2020-a165853141 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a165853141 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809262] Review Request: rtl-wmbus - Software defined receiver for wireless M-Bus with RTL-SDR
https://bugzilla.redhat.com/show_bug.cgi?id=1809262 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rtl-wmbus -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816283] New: Review Request: rust-ref-cast - Safely cast to where the struct U contains a single field of type T
https://bugzilla.redhat.com/show_bug.cgi?id=1816283 Bug ID: 1816283 Summary: Review Request: rust-ref-cast - Safely cast to where the struct U contains a single field of type T Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: i.gnatenko.br...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-ref-cast.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-ref-cast-1.0.0-1.fc33.src.rpm Description: Safely cast to where the struct U contains a single field of type T. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803945] Review Request: zita-ajbridge - Allows ALSA devices to be JACK clients
https://bugzilla.redhat.com/show_bug.cgi?id=1803945 --- Comment #12 from Fedora Update System --- FEDORA-2020-5f53525c21 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5f53525c21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816281] New: Review Request: rust-ref-cast-impl - Derive implementation for ref_cast::RefCast
https://bugzilla.redhat.com/show_bug.cgi?id=1816281 Bug ID: 1816281 Summary: Review Request: rust-ref-cast-impl - Derive implementation for ref_cast::RefCast Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: i.gnatenko.br...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-ref-cast-impl.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-ref-cast-impl-1.0.0-1.fc33.src.rpm Description: Derive implementation for ref_cast::RefCast. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809263] Review Request: wmbusmeters - Read the wireless mbus protocol to acquire utility meter readings
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #4 from Damian Wrobel ---
(In reply to Robert-André Mauchin from comment #3)
> - mv %{buildroot}/lib %{buildroot}/usr/ → mv %{buildroot}/lib
> %{buildroot}%{_prefix}
Fixed
> - rm %{_sysconfdir}/logrotate.d/wmbusmeters if you don't need to use it,
> %exclude is reserved for use with multiple packages
Fixed
> - You need to add the systemd scriptlets:
>
> %post
> %systemd_post %{name}@.service
>
> %preun
> %systemd_preun %{name}@.service
>
> %postun
> %systemd_postun_with_restart %{name}@.service
>
Fixed however, I'm using wmbusmeters@\*.service instead of %{name}@.service as
the
%{name}@.service is just the template not the real service name.
> %forgemeta -v
Fixed
Updated spec & SRPM:
Spec URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/wmbusmeters.spec
SRPM URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/wmbusmeters-0.9.27-6.fc31.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816279] New: Review Request: python-cx-oracle - Python interface to Oracle
https://bugzilla.redhat.com/show_bug.cgi?id=1816279 Bug ID: 1816279 Summary: Review Request: python-cx-oracle - Python interface to Oracle Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-cx-oracle.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-cx-oracle-7.3.0-1.fc31.src.rpm Project URL: https://oracle.github.io/python-cx_Oracle Description: Python interface to Oracle Database conforming to the Python DB API 2.0 specification. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42724321 rpmlint output: $ rpmlint python-cx-oracle-7.3.0-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python*-cx-oracle* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815154] Review Request: python-sphinx-press-theme - A Sphinx-doc theme based on Vuepress
https://bugzilla.redhat.com/show_bug.cgi?id=1815154 --- Comment #17 from Fedora Update System --- FEDORA-2020-c4844514fd has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-c4844514fd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815154] Review Request: python-sphinx-press-theme - A Sphinx-doc theme based on Vuepress
https://bugzilla.redhat.com/show_bug.cgi?id=1815154 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #16 from Fedora Update System --- FEDORA-2020-92c812f0b5 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-92c812f0b5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809262] Review Request: rtl-wmbus - Software defined receiver for wireless M-Bus with RTL-SDR
https://bugzilla.redhat.com/show_bug.cgi?id=1809262 --- Comment #2 from Damian Wrobel --- (In reply to Robert-André Mauchin from comment #1) > - Split the LICENSE from the README.md: Fixed >- The changelog entries have incorrect version-release: Fixed > - %forgemeta -v Fixed. Thank you very much for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806539] Review Request: gnome-applets - Small applications for the GNOME panel
https://bugzilla.redhat.com/show_bug.cgi?id=1806539 --- Comment #2 from Artem --- https://atim.fedorapeople.org/for-review/gnome-applets.spec https://atim.fedorapeople.org/for-review/gnome-applets-3.34.0-5.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816267] New: Review Request: python-ajpy - AJP package crafting library
https://bugzilla.redhat.com/show_bug.cgi?id=1816267 Bug ID: 1816267 Summary: Review Request: python-ajpy - AJP package crafting library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-ajpy.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-ajpy-0.0.4-1.fc31.src.rpm Project URL: https://github.com/hypn0s/AJPy/ Description: AJPy aims to craft AJP requests in order to communicate with AJP connectors. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42723434 rpmlint output: $ rpmlint python-ajpy-0.0.4-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python3-ajpy-0.0.4-1.fc31.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 --- Comment #12 from Michal Schmidt --- Honggang provided his test results in: https://people.redhat.com/honli/bz1814682/rshim-2.0-1.fc31.tar.xz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809261] Review Request: fixedptc - Fixed point math header only library for C
https://bugzilla.redhat.com/show_bug.cgi?id=1809261 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fixedptc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 --- Comment #11 from Michal Schmidt --- I reproduced it on a Fedora system. You can install csmock: dnf install csmock And apply the "clang" checker on your source RPM: csmock -t clang -r fedora-rawhide-x86_64 -o output/ ./rshim-2.0-1.fc31.src.rpm You'll find "scan-results.*" in the "output/" directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 --- Comment #6 from Artem --- Thanks everyone for help. Fixed, but successful validation desktop file and this new XDG entries still not possible in Fedora. https://atim.fedorapeople.org/for-review/gnome-flashback.spec https://atim.fedorapeople.org/for-review/gnome-flashback-3.34.2-4.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809261] Review Request: fixedptc - Fixed point math header only library for C
https://bugzilla.redhat.com/show_bug.cgi?id=1809261 --- Comment #5 from Damian Wrobel --- (In reply to Robert-André Mauchin from comment #4) > - Same issue with changelog, version-release are incorrects > > %changelog Fixed > - %forgemeta -v Fixed. Thank you very much for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816258] New: Review Request: ffuf - Fast web fuzzer written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1816258 Bug ID: 1816258 Summary: Review Request: ffuf - Fast web fuzzer written in Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/ffuf.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/ffuf-1.0.2-1.fc31.src.rpm Project URL: https://github.com/ffuf/ffuf Description: Fast web fuzzer written in Go. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42722477 rpmlint output: $ rpmlint ffuf-1.0.2-1.fc31.src.rpm ffuf.src: W: spelling-error Summary(en_US) fuzzer -> fuzzier, fuzzes, fuzzed ffuf.src: W: spelling-error %description -l en_US fuzzer -> fuzzier, fuzzes, fuzzed 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint ffuf* ffuf.x86_64: W: spelling-error Summary(en_US) fuzzer -> fuzzier, fuzzes, fuzzed ffuf.x86_64: W: spelling-error %description -l en_US fuzzer -> fuzzier, fuzzes, fuzzed ffuf.x86_64: W: no-manual-page-for-binary ffuf 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: fab Needed to disable the tests. There is a segmentation violation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806544] Review Request: gnome-panel - GNOME Flashback panel
https://bugzilla.redhat.com/show_bug.cgi?id=1806544 --- Comment #2 from Artem --- @eclipseo, thanks a lot as always. Somewhat fixed: Spec URL: https://atim.fedorapeople.org/for-review/gnome-panel.spec SRPM URL: https://atim.fedorapeople.org/for-review/gnome-panel-3.34.1-4.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816093] Review Request: python-pytest-subtests - Support for unittest subTest() and subtests fixture
https://bugzilla.redhat.com/show_bug.cgi?id=1816093 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-subtests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 --- Comment #10 from l...@mellanox.com --- (In reply to Honggang LI from comment #8) > (In reply to lsun from comment #4) > > > Thanks Honggang for the comments. I am working on it and will post new > > version after fixing these warnings. > > Please fix those issue for this fedora package review. When we import this > package for RHEL-8, > we will have to fix those issue. Because it is a mandatory task for RHEL > package import. > > Fix those issues earlier will save time for us in the future. > > Thanks Yes, definitely. I have been working on it and planned to submit a new version today. One question about the coverity warnings: Is there a way I could run koji to get the same output? Or is it possible you could give me some details about this warning: "4 CLANG_WARNING"? I ran coverity locally but couldn't get this one. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682
--- Comment #9 from l...@mellanox.com ---
(In reply to Honggang LI from comment #7)
> 1814682-rshim]$ rpm -qpl results/rshim-2.0-1.fc33.x86_64.rpm | grep man
> /usr/share/man/man1/bfrshim.1.gz
> ^
>
> 1814682-rshim]$ rpm -qpl results/rshim-2.0-1.fc33.x86_64.rpm | grep bin
> /usr/bin/bfrshim
>
>
> ./src/rshim.c:2092: rc = system("modprobe cuse");
> ./src/rshim_net.c:56: rc = system("modprobe tun");
>
> The binary 'bfrshim' may execute 'modprobe' command, which requires
> administrator permission.
> I suggest to move 'bfrshim' into the '/usr/sbin' directory, and install the
> manpage into man-8 section instead of man-1.
This binary does need root permission to run. I'll update it as suggested.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815936] Review Request: reSIProcate - SIP and TURN stacks, with SIP proxy and TURN server implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1815936 Daniel Pocock changed: What|Removed |Added Flags|needinfo?(dan...@pocock.com | |.au)| --- Comment #7 from Daniel Pocock --- When I look at this part of your output: In file included from /usr/include/boost/date_time/posix_time/posix_time_types.hpp:16, from /usr/include/asio/time_traits.hpp:23, from /usr/include/asio/deadline_timer_service.hpp:27, from /usr/include/asio/basic_deadline_timer.hpp:25, from /usr/include/asio.hpp:20, from ReTurnConfig.hxx:5, from ReTurnConfig.cxx:16: it looks like asio-1.10.8 In asio-1.14.0, you can see /usr/include/asio/deadline_timer_service.hpp has become: /usr/include/asio/detail/deadline_timer_service.hpp and it doesn't include time_traits.hpp. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704522] Review Request: zork - Public Domain source code to the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522 --- Comment #13 from Fedora Update System --- FEDORA-EPEL-2020-bd24cabef2 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-bd24cabef2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816093] Review Request: python-pytest-subtests - Support for unittest subTest() and subtests fixture
https://bugzilla.redhat.com/show_bug.cgi?id=1816093 --- Comment #3 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815936] Review Request: reSIProcate - SIP and TURN stacks, with SIP proxy and TURN server implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1815936 Jared Smith changed: What|Removed |Added Flags||needinfo?(dan...@pocock.com ||.au) --- Comment #6 from Jared Smith --- Still having the same issues on Rawhide: g++ -DHAVE_CONFIG_H -I. -I.. -DRESIP_OSTYPE_LINUX -DRESIP_ARCH_X86_64 -DRESIP_LARCH_ -D_REENTRANT -DRESIP_TOOLCHAIN_GNU -I .. -DASIO_HAS_BOOST_BIND -DBOOST_ASIO_HAS_STD_CHRONO -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/include/libdb4 -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -Wall -Wno-deprecated -c -o TlsServer.o TlsServer.cxx In file included from ReTurnConfig.cxx:16: ReTurnConfig.hxx:116:13: error: 'steady_timer' in namespace 'asio' does not name a type 116 | asio::steady_timer mTimer; | ^~~~ ReTurnConfig.cxx:34:22: error: 'chrono' is not a namespace-name 34 | using namespace std::chrono; | ^~ ReTurnConfig.cxx: In constructor 'reTurn::ReTurnUserFileScanner::ReTurnUserFileScanner(asio::io_service&, reTurn::ReTurnConfig&)': ReTurnConfig.cxx:365:4: error: class 'reTurn::ReTurnUserFileScanner' does not have any field named 'mTimer' 365 |mTimer(ioService, seconds(mLoopInterval)) |^~ ReTurnConfig.cxx:365:22: error: 'seconds' was not declared in this scope 365 |mTimer(ioService, seconds(mLoopInterval)) | ^~~ ReTurnConfig.cxx:365:22: note: suggested alternatives: In file included from /usr/include/boost/chrono/chrono.hpp:11, from /usr/include/boost/chrono/include.hpp:15, from /usr/include/boost/chrono.hpp:17, from ReTurnConfig.cxx:14: /usr/include/boost/chrono/duration.hpp:201:44: note: 'boost::chrono::seconds' 201 | typedef duration seconds; // at least 35 bits needed |^~~ In file included from /usr/include/boost/date_time/posix_time/posix_time_types.hpp:16, from /usr/include/asio/time_traits.hpp:23, from /usr/include/asio/deadline_timer_service.hpp:27, from /usr/include/asio/basic_deadline_timer.hpp:25, from /usr/include/asio.hpp:20, from ReTurnConfig.hxx:5, from ReTurnConfig.cxx:16: /usr/include/boost/date_time/posix_time/posix_time_duration.hpp:53:30: note: 'boost::posix_time::seconds' 53 | class BOOST_SYMBOL_VISIBLE seconds : public time_duration | ^~~ ReTurnConfig.cxx: In member function 'void reTurn::ReTurnUserFileScanner::start()': ReTurnConfig.cxx:383:7: error: 'mTimer' was not declared in this scope 383 | mTimer.expires_from_now(seconds(timerInterval)); | ^~ ReTurnConfig.cxx:383:31: error: 'seconds' was not declared in this scope 383 | mTimer.expires_from_now(seconds(timerInterval)); | ^~~ ReTurnConfig.cxx:383:31: note: suggested alternatives: In file included from /usr/include/boost/chrono/chrono.hpp:11, from /usr/include/boost/chrono/include.hpp:15, from /usr/include/boost/chrono.hpp:17, from ReTurnConfig.cxx:14: /usr/include/boost/chrono/duration.hpp:201:44: note: 'boost::chrono::seconds' 201 | typedef duration seconds; // at least 35 bits needed |^~~ In file included from /usr/include/boost/date_time/posix_time/posix_time_types.hpp:16, from /usr/include/asio/time_traits.hpp:23, from /usr/include/asio/deadline_timer_service.hpp:27, from /usr/include/asio/basic_deadline_timer.hpp:25, from /usr/include/asio.hpp:20, from ReTurnConfig.hxx:5, from ReTurnConfig.cxx:16: /usr/include/boost/date_time/posix_time/posix_time_duration.hpp:53:30: note: 'boost::posix_time::seconds' 53 | class BOOST_SYMBOL_VISIBLE seconds : public time_duration | ^~~ In file included from TurnManager.hxx:9, from RequestHandler.hxx:10, from TcpConnection.hxx:11, from TcpServer.hxx:10, from TcpServer.cxx:1: ReTurnConfig.hxx:116:13: error: 'steady_timer' in namespace 'asio' does not name a type 116 | asio::steady_timer mTimer; | ^~~~ In file included from
[Bug 1815154] Review Request: python-sphinx-press-theme - A Sphinx-doc theme based on Vuepress
https://bugzilla.redhat.com/show_bug.cgi?id=1815154 --- Comment #15 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinx-press-theme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815515] Review Request: js-d3-flame-graph - A D3.js plugin that produces flame graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1815515 Andreas Gerstmayr changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-03-23 14:45:49 --- Comment #3 from Andreas Gerstmayr --- Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816093] Review Request: python-pytest-subtests - Support for unittest subTest() and subtests fixture
https://bugzilla.redhat.com/show_bug.cgi?id=1816093 José Matos changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from José Matos --- This a very simple python package. The license is correct, appropriated and included in the package. The package follows the fedora name scheme and is according to the Fedora guidelines. So the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810027] Review Request: rust-escargot - Cargo API written in Paris
https://bugzilla.redhat.com/show_bug.cgi?id=1810027 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-03-23 14:36:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816093] Review Request: python-pytest-subtests - Support for unittest subTest() and subtests fixture
https://bugzilla.redhat.com/show_bug.cgi?id=1816093 José Matos changed: What|Removed |Added Status|NEW |ASSIGNED CC||jama...@fc.up.pt Assignee|nob...@fedoraproject.org|jama...@fc.up.pt Flags||fedora-review? --- Comment #1 from José Matos --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815810] Review Request: python-pg8000 - Pure Python PostgreSQL Driver
https://bugzilla.redhat.com/show_bug.cgi?id=1815810 Ernestas Kulik changed: What|Removed |Added Status|CLOSED |NEW Resolution|WONTFIX |--- Keywords||Reopened -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815810] Review Request: python-pg8000 - Pure Python PostgreSQL Driver
https://bugzilla.redhat.com/show_bug.cgi?id=1815810 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch --- Comment #12 from Fabian Affolter --- I might need pg8000 in the future. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809927] Review Request: python-aiostream - Generator-based operators for asynchronous iteration
https://bugzilla.redhat.com/show_bug.cgi?id=1809927 --- Comment #2 from Fabian Affolter --- Thanks for your feedback. (In reply to Robert-André Mauchin from comment #1) > - You must install the LICENSE with %license in %files > > %license LICENSE Added > BuildRequires: python3-pytest-runner Added %changelog * Mon Mar 23 2020 Fabian Affolter - 0.4.1-2 - Add missing BR - Add LICENSE file (rhbz#1809927) Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiostream.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiostream-0.4.1-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 José Matos changed: What|Removed |Added Status|MODIFIED|NEW --- Comment #55 from José Matos --- Thank you Neal. I think that now we should be awarded the "Spring cleanings" badge. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704522] Review Request: zork - Public Domain source code to the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522 --- Comment #12 from Fedora Update System --- FEDORA-EPEL-2020-7d28ec15d7 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-7d28ec15d7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815154] Review Request: python-sphinx-press-theme - A Sphinx-doc theme based on Vuepress
https://bugzilla.redhat.com/show_bug.cgi?id=1815154 --- Comment #14 from José Matos --- Thank you for the review. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #54 from Fedora Update System --- FEDORA-2020-9185d89caf has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9185d89caf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704522] Review Request: zork - Public Domain source code to the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #11 from Fedora Update System --- FEDORA-2020-fee0637f32 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-fee0637f32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816135] Review Request: libjcat - Library for reading Jcat files
https://bugzilla.redhat.com/show_bug.cgi?id=1816135 Richard Hughes changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2020-03-23 13:57:55 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815154] Review Request: python-sphinx-press-theme - A Sphinx-doc theme based on Vuepress
https://bugzilla.redhat.com/show_bug.cgi?id=1815154
Fabian Affolter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #13 from Fabian Affolter ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD (unspecified)", "Expat License".
26 files have unknown license. Detailed output of licensecheck in
/home/fab/Documents/repos/reviews/1815154-python-sphinx-press-
theme/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
[Bug 1816135] Review Request: libjcat - Library for reading Jcat files
https://bugzilla.redhat.com/show_bug.cgi?id=1816135 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libjcat -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815515] Review Request: js-d3-flame-graph - A D3.js plugin that produces flame graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1815515 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/js-d3-flame-graph -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815788] Review Request: rust-bodhi-cli - Bodhi CLI client based on bodhi-rs
https://bugzilla.redhat.com/show_bug.cgi?id=1815788 Fabio Valentini changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||rust-bodhi-cli-0.3.1-2.fc33 Resolution|--- |RAWHIDE Last Closed||2020-03-23 13:11:06 --- Comment #4 from Fabio Valentini --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1480846 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815785] Review Request: rust-fedora-update-feedback - Provide feedback for fedora updates (inspired by fedora-easy-karma)
https://bugzilla.redhat.com/show_bug.cgi?id=1815785 Fabio Valentini changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||rust-fedora-update-feedback ||-0.5.0-2.fc33 Resolution|--- |RAWHIDE Last Closed||2020-03-23 13:10:38 --- Comment #4 from Fabio Valentini --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1480843 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810026] Review Request: rust-assert_fs - Filesystem fixtures and assertions for testing
https://bugzilla.redhat.com/show_bug.cgi?id=1810026 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-03-23 13:09:36 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1811410] Re-Review Request: mkdocs - Python tool to create HTML documentation from markdown sources
https://bugzilla.redhat.com/show_bug.cgi?id=1811410 --- Comment #5 from José Matos --- (In reply to Robin Lee from comment #4) > > These are not necessary. They are built automatically: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > > #_dependencies > > These requirements are not automatically generated. python3dist(lunr) is generated: Requires mkdocs (rpmlib, GLIBC filtered): /usr/bin/python3 bootswatch-fonts fontawesome-fonts fontawesome-fonts-web google-roboto-slab-fonts js-jquery1 js-jquery2 lato-fonts python(abi) python3.8dist(click) python3.8dist(jinja2) python3.8dist(livereload) python3.8dist(lunr) python3.8dist(markdown) python3.8dist(pyyaml) python3.8dist(setuptools) python3.8dist(tornado) python3dist(lunr) python3dist(mdx-gh-links) python3dist(nltk) Notice as lunr appears above. Regarding nltk I am curious why it is a dependency of mkdocs, it is not mentioned in the documentation and it does not show in the code. BTW the License should be: License: BSD and Tumbolia The Tumbolia appears because of file mkdocs-1.1/mkdocs/utils/ghp_import.py -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816135] Review Request: libjcat - Library for reading Jcat files
https://bugzilla.redhat.com/show_bug.cgi?id=1816135 Richard Hughes changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #2 from Richard Hughes --- All nitpicks fixed, thanks for the speedy review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814887] Review Request: rust-libslirp-sys - Rust FFI bindings for libslirp
https://bugzilla.redhat.com/show_bug.cgi?id=1814887 Marc-Andre Lureau changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-03-23 12:48:17 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815936] Review Request: reSIProcate - SIP and TURN stacks, with SIP proxy and TURN server implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1815936 Daniel Pocock changed: What|Removed |Added Flags|needinfo?(dan...@pocock.com |needinfo- |.au)| --- Comment #5 from Daniel Pocock --- Thanks for looking at this. To resolve those errors, you need a buildroot override to get asio-1.14.0, see my earlier comments about asio The asio-1.10.x RPM in Fedora will generate errors like that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815936] Review Request: reSIProcate - SIP and TURN stacks, with SIP proxy and TURN server implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1815936 --- Comment #4 from Jared Smith --- Sorry, my apologies -- the test above was on Fedora 32. Trying on Rawhide now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816135] Review Request: libjcat - Library for reading Jcat files
https://bugzilla.redhat.com/show_bug.cgi?id=1816135
Kalev Lember changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||klem...@redhat.com
Assignee|nob...@fedoraproject.org|klem...@redhat.com
Flags||fedora-review+
--- Comment #1 from Kalev Lember ---
A few notes:
> %{_datadir}/vala/vapi/jcat.deps
> %{_datadir}/vala/vapi/jcat.vapi
You should make sure the directory is included in the package to not cause
unowned directories when uninstalling the rpm. Something like:
%dir %{_datadir}/vala
%dir %{_datadir}/vala/vapi
... should take care of it.
> %{_libexecdir}/installed-tests/libjcat/jcat-self-test
> %{_datadir}/installed-tests/libjcat/*
> %dir %{_datadir}/installed-tests/libjcat
Same thing here, need to own %{_datadir}/installed-tests and
%{_libexecdir}/installed-tests and %{_libexecdir}/installed-tests/libjcat
directories.
> %check
> %meson_test
>
> %install
> %meson_install
This is not really a problem, but I'd personally reorder the two sections
because %check runs after %install.
> %{_datadir}/man/man1/*.1.gz
Can you use a glob such as '*.1*' to avoid hard coding the .gz extension?
Flatpak builds for instance use different compression.
rpmlint output:
$ rpmlint libjcat-0.1.0-0.23.20200323git.fc32.src.rpm
libjcat-0.1.0-0.23.20200323git.fc32.src.rpm
libjcat-devel-0.1.0-0.23.20200323git.fc32.x86_64.rpm
libjcat-tests-0.1.0-0.23.20200323git.fc32.x86_64.rpm
libjcat.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
libjcat.src: W: spelling-error %description -l en_US checksums -> check sums,
check-sums, checks
libjcat.src: W: file-size-mismatch libjcat-0.1.0.tar.xz = 52096,
http://people.freedesktop.org/~hughsient/releases/libjcat-0.1.0.tar.xz = 52148
libjcat.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
libjcat.src: W: spelling-error %description -l en_US checksums -> check sums,
check-sums, checks
libjcat.src: W: file-size-mismatch libjcat-0.1.0.tar.xz = 52096,
http://people.freedesktop.org/~hughsient/releases/libjcat-0.1.0.tar.xz = 52148
4 packages and 0 specfiles checked; 0 errors, 6 warnings.
The file size being different sounds like either you updated the tarball or
there's a man in the middle attack :) Maybe update the tarball in the srpm and
switch to https sources to make MITM harder to do?
These are all just small nitpicks; package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815936] Review Request: reSIProcate - SIP and TURN stacks, with SIP proxy and TURN server implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1815936 Jared Smith changed: What|Removed |Added Flags||needinfo?(dan...@pocock.com ||.au) --- Comment #3 from Jared Smith --- I tried building this in Rawhide, but wasn't successful. The first issue I ran into was that on line 168 of your spec file, you have PYCONFIG hard-coded to /usr/bin/python3.7-config, where in Fedora the python3-devel package provides /usr/bin/python3-config and /usr/bin/python-config. Once I changed that, I ran into the following issue during compilation: g++ -DHAVE_CONFIG_H -I. -I.. -DRESIP_OSTYPE_LINUX -DRESIP_ARCH_X86_64 -DRESIP_LARCH_ -D_REENTRANT -DRESIP_TOOLCHAIN_GNU -I .. -DASIO_HAS_BOOST_BIND -DBOOST_ASIO_HAS_STD_CHRONO -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/include/libdb4 -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -Wall -Wno-deprecated -c -o TlsServer.o TlsServer.cxx In file included from ReTurnConfig.cxx:16: ReTurnConfig.hxx:116:13: error: 'steady_timer' in namespace 'asio' does not name a type 116 | asio::steady_timer mTimer; | ^~~~ ReTurnConfig.cxx:34:22: error: 'chrono' is not a namespace-name 34 | using namespace std::chrono; | ^~ ReTurnConfig.cxx: In constructor 'reTurn::ReTurnUserFileScanner::ReTurnUserFileScanner(asio::io_service&, reTurn::ReTurnConfig&)': ReTurnConfig.cxx:365:4: error: class 'reTurn::ReTurnUserFileScanner' does not have any field named 'mTimer' 365 |mTimer(ioService, seconds(mLoopInterval)) |^~ ReTurnConfig.cxx:365:22: error: 'seconds' was not declared in this scope 365 |mTimer(ioService, seconds(mLoopInterval)) | ^~~ ReTurnConfig.cxx:365:22: note: suggested alternatives: In file included from /usr/include/boost/chrono/chrono.hpp:11, from /usr/include/boost/chrono/include.hpp:15, from /usr/include/boost/chrono.hpp:17, from ReTurnConfig.cxx:14: /usr/include/boost/chrono/duration.hpp:201:44: note: 'boost::chrono::seconds' 201 | typedef duration seconds; // at least 35 bits needed |^~~ In file included from /usr/include/boost/date_time/posix_time/posix_time_types.hpp:16, from /usr/include/asio/time_traits.hpp:23, from /usr/include/asio/deadline_timer_service.hpp:27, from /usr/include/asio/basic_deadline_timer.hpp:25, from /usr/include/asio.hpp:20, from ReTurnConfig.hxx:5, from ReTurnConfig.cxx:16: /usr/include/boost/date_time/posix_time/posix_time_duration.hpp:53:30: note: 'boost::posix_time::seconds' 53 | class BOOST_SYMBOL_VISIBLE seconds : public time_duration | ^~~ ReTurnConfig.cxx: In member function 'void reTurn::ReTurnUserFileScanner::start()': ReTurnConfig.cxx:383:7: error: 'mTimer' was not declared in this scope 383 | mTimer.expires_from_now(seconds(timerInterval)); | ^~ ReTurnConfig.cxx:383:31: error: 'seconds' was not declared in this scope 383 | mTimer.expires_from_now(seconds(timerInterval)); | ^~~ ReTurnConfig.cxx:383:31: note: suggested alternatives: In file included from /usr/include/boost/chrono/chrono.hpp:11, from /usr/include/boost/chrono/include.hpp:15, from /usr/include/boost/chrono.hpp:17, from ReTurnConfig.cxx:14: /usr/include/boost/chrono/duration.hpp:201:44: note: 'boost::chrono::seconds' 201 | typedef duration seconds; // at least 35 bits needed |^~~ In file included from /usr/include/boost/date_time/posix_time/posix_time_types.hpp:16, from /usr/include/asio/time_traits.hpp:23, from /usr/include/asio/deadline_timer_service.hpp:27, from /usr/include/asio/basic_deadline_timer.hpp:25, from /usr/include/asio.hpp:20, from ReTurnConfig.hxx:5, from ReTurnConfig.cxx:16: /usr/include/boost/date_time/posix_time/posix_time_duration.hpp:53:30: note: 'boost::posix_time::seconds' 53 | class BOOST_SYMBOL_VISIBLE seconds : public time_duration | ^~~ In file included from TurnManager.hxx:9, from
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 --- Comment #3 from Neal Gompa --- This spec file is illogically organized and hard to read. Please move subpackage definitions up with the rest of the preamble. You may also choose to organize it Mandriva-style where all the declarative parts are in one place, like so: Preamble %description %files # - %package %description %files # - %prep %build %install # - %changelog Basically, please make it readable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #2 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Nils Philippsen changed: What|Removed |Added Status|NEW |ASSIGNED CC||nphil...@redhat.com Doc Type|--- |If docs needed, set a value --- Comment #1 from Nils Philippsen --- Spec URL: https://raw.githubusercontent.com/AdamSaleh/python-rpmautospec/master/python-rpmautospec.spec SRPM URL: https://raw.githubusercontent.com/AdamSaleh/python-rpmautospec/master/rpms/python-rpmautospec-0.0.1-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816135] New: Review Request: libjcat - Library for reading Jcat files
https://bugzilla.redhat.com/show_bug.cgi?id=1816135 Bug ID: 1816135 Summary: Review Request: libjcat - Library for reading Jcat files Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rhug...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://people.freedesktop.org/~hughsient/temp/libjcat.spec SRPM URL: https://people.freedesktop.org/~hughsient/temp/libjcat-0.1.0-1.fc32.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42715759 Description: This library allows reading and writing gzip-compressed JSON catalog files, which can be used to store GPG, PKCS-7 and SHA-256 checksums for each file. ` This provides equivalent functionality to the catalog files supported in Microsoft Windows. Fedora Account System Username: rhughes This will be needed for the next fwupd release as a mandatory build dependency, and the majority of code in this new library are the existing GPG and PKCS-7 helpers in fwupd. As part of fwupd, various security review teams have audited the use of GnuTLS and GpgME with no issues found. rpmlint output: $ rpmlint SPECS/libjcat.spec RPMS/libjcat-* SRPMS/libjcat-0.1.0-1.fc32.src.rpm libjcat.x86_64: W: spelling-error %description -l en_US gzip -> zip, grip, g zip libjcat.x86_64: W: spelling-error %description -l en_US checksums -> check sums, check-sums, checks libjcat.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip libjcat.src: W: spelling-error %description -l en_US checksums -> check sums, check-sums, checks 7 packages and 1 specfiles checked; 0 errors, 4 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] New: Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Bug ID: 1816124 Summary: Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: asa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://github.com/AdamSaleh/python-rpmautospec/blob/master/python-rpmautospec.spec SRPM URL: https://github.com/AdamSaleh/python-rpmautospec/blob/master/rpms/python-rpmautospec-0.0.1-1.fc31.src.rpm?raw=true Description: Package and CLI tool to generate release fields and changelogs Fedora Account System Username: asaleh Succesful scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=42715293 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815788] Review Request: rust-bodhi-cli - Bodhi CLI client based on bodhi-rs
https://bugzilla.redhat.com/show_bug.cgi?id=1815788 --- Comment #3 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bodhi-cli -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1811410] Re-Review Request: mkdocs - Python tool to create HTML documentation from markdown sources
https://bugzilla.redhat.com/show_bug.cgi?id=1811410 --- Comment #4 from Robin Lee --- Spec URL: https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01315366-mkdocs/mkdocs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01315366-mkdocs/mkdocs-1.1-3.fc33.src.rpm Changes: Add symlinks to the Roboto fonts. (In reply to José Matos from comment #3) > (In reply to Robin Lee from comment #2) > > > > Changes: > > - Requires python3dist(lunr) python3dist(nltk) > > These are not necessary. They are built automatically: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_dependencies These requirements are not automatically generated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
