[Bug 1822464] New: Review Request: python-siphash - SipHash in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1822464 Bug ID: 1822464 Summary: Review Request: python-siphash - SipHash in Python Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ego.corda...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/atim/python-packages/fedora-32-x86_64/01332002-python-siphash/python-siphash.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/python-packages/fedora-32-x86_64/01332002-python-siphash/python-siphash-0.0.1-1.fc32.src.rpm Description: A Python implementation of SipHash-2-4, a fast short-input PRF with a 128-bit key and 64-bit output. Fedora Account System Username: atim -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 Disha Oberoi changed: What|Removed |Added CC||dishaoberoi...@gmail.com Flags|needinfo?(aashirana4uu@gmai | |l.com) | |needinfo?(midnight@alphacom | |m.net) | --- Comment #103 from Disha Oberoi --- Hi gys i am disha i am best call girls in uttarakhand our info visite more my site http://www.dishaoberoi.com http://www.neelamnainital.com -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815810] Review Request: python-pg8000 - Pure Python PostgreSQL Driver
https://bugzilla.redhat.com/show_bug.cgi?id=1815810
--- Comment #14 from Neal Gompa ---
More comments:
> %pycached %{python3_sitelib}/%{pypi_name}/__init__.py
> %pycached %{python3_sitelib}/%{pypi_name}/core.py
> %pycached %{python3_sitelib}/%{pypi_name}/_version.py
This is completely unnecessary for this module, please just use
"%{python3_sitelib}/%{pypi_name}/"
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812411] Review request: bookworm - simple, focused eBook reader
https://bugzilla.redhat.com/show_bug.cgi?id=1812411 --- Comment #14 from Bob Hepple --- Good catch Petr, I totally missed that. I'll put this on hiatus until I can resolve it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682
Michal Schmidt changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|fedora-review+ |fedora-review?
--- Comment #31 from Michal Schmidt ---
Thank you Honggang for the detailed review results.
I disagree with the overall PASSED result, though the package is almost there.
Liming,
please fix this item flagged by fedora-review:
> [!]: Uses parallel make %{?_smp_mflags} macro.
The recommended fix is to use the "%make_build" macro.
You still have this in the %install section:
> %__spec_install_post
Please remove it.
About these BRs:
> BuildRequires: systemd-units
> BuildRequires: systemd-rpm-macros
The first one seems unnecessary.
systemd-rpm-macros should be sufficient.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807682] Review Request: golang-goftp-server - FTP server framework written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1807682 Olivier Lemasle changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739290] Review Request: angband - Text-based roguelike RPG game
https://bugzilla.redhat.com/show_bug.cgi?id=1739290 Wart changed: What|Removed |Added Blocks||1364745 (FE-GAMESIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822362] New: Review Request: duc - Disk usage analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1822362 Bug ID: 1822362 Summary: Review Request: duc - Disk usage analyzer Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: w...@kobold.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fedorapeople.org/~wart/duc.spec SRPM URL: https://fedorapeople.org/~wart/duc-1.4.4-3.fc33.src.rpm Description: A library and suite of tools for inspecting disk usage Fedora Account System Username: wart -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818936] Review Request: perl-Mojolicious-Plugin-OpenAPI - OpenAPI / Swagger plugin for Mojolicious
https://bugzilla.redhat.com/show_bug.cgi?id=1818936 --- Comment #2 from Emmanuel Seyman --- Thank you for the review, Petr. I believe I've taken into account all your comments. I also updated the package to version 3.31 which came out since I submitted the review request. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Mojolicious-Plugin-OpenAPI/perl-Mojolicious-Plugin-OpenAPI.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Mojolicious-Plugin-OpenAPI/perl-Mojolicious-Plugin-OpenAPI-3.31-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818886] Review Request: golang-github-bobesa-domain-util - Handler for URL parts and identification of TLD and subdomain
https://bugzilla.redhat.com/show_bug.cgi?id=1818886
Olivier Lemasle changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Olivier Lemasle ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-bobesa-domain-util-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all
[Bug 1818886] Review Request: golang-github-bobesa-domain-util - Handler for URL parts and identification of TLD and subdomain
https://bugzilla.redhat.com/show_bug.cgi?id=1818886 Olivier Lemasle changed: What|Removed |Added Status|NEW |ASSIGNED CC||o.lema...@gmail.com Assignee|nob...@fedoraproject.org|o.lema...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821691] Review Request: golang-github-kit - Library for microservices
https://bugzilla.redhat.com/show_bug.cgi?id=1821691 Olivier Lemasle changed: What|Removed |Added Status|NEW |ASSIGNED CC||o.lema...@gmail.com Assignee|nob...@fedoraproject.org|o.lema...@gmail.com Flags||fedora-review? --- Comment #1 from Olivier Lemasle --- This library is already packaged in Fedora: https://src.fedoraproject.org/rpms/golang-github-kit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818936] Review Request: perl-Mojolicious-Plugin-OpenAPI - OpenAPI / Swagger plugin for Mojolicious
https://bugzilla.redhat.com/show_bug.cgi?id=1818936 --- Comment #1 from Petr Pisar --- URL and Source0 addresses are usable. Ok. Source0 archive (SHA-256: e828a3256bb2217abd1b947c0cad145e09a5fc8e858aade3b04792d4b8a6a5b4) is original. Ok. Summary verified from lib/Mojolicious/Plugin/OpenAPI.pm. Ok. Description verified from lib/Mojolicious/Plugin/OpenAPI.pm. Ok. License verified from Makefile.PL, lib/Mojolicious/Plugin/OpenAPI.pm, README.md. Ok. MIT-licensed files not in any binary package: t/v3-style-array.t, t/v3-basic.t, t/spec/v2-petstore.json, t/v3-nullable.t. ASL 2.0-licensed files no in any binary package: t/spec/bundlecheck.json. TODO: Please, put a comment into the spec file above the License tag reading that these files have a different license. No XS code, noarch BuildArch is Ok. FIX: Build-require 'perl-generators'. You package does does not list all Perl run-time dependencies and it relies on the generators. FIX: Build-require 'perl-interpreter' (perl-Mojolicious-Plugin-OpenAPI.spec:51). FIX: Build-require 'make' (perl-Mojolicious-Plugin-OpenAPI.spec:52). The macro is provided by rpm that does not depend on make. TODO: Constrain 'perl(Mojolicious)' dependency with '>= 8.00' (META.json:34) if you believe that the metadata are correct. TODO: Unset DUMMY_DB_ERROR, JSON_VALIDATOR_DEBUG, and MOJO_OPENAPI_DEBUG environment variables before executing "make check". They are used through-out the code and could influence the tests. TODO: Suggest 'perl(Text::Markdown)' (lib/Mojolicious/Plugin/OpenAPI/SpecRenderer.pm:8). TODO: Recommend 'perl(Config)' (lib/JSON/Validator/OpenAPI/Mojolicious.pm:10). Test::Pod, Test::Pod::Coverage, Test::CPAN::Changes are optional. Ok. TODO: Build-require 'perl(Text::Markdown)' for optional tests (t/plugin-spec-renderer-standalone.t:43). All tests pass. Ok. TODO: There are suspicous warnings printed when running the tests. It would be greate to report them to the upstream: Format rule for 'unknown' is missing at /usr/share/perl5/vendor_perl/JSON/Validator.pm line 750. Format rule for 'binary' is missing at /usr/share/perl5/vendor_perl/JSON/Validator.pm line 750. Use of uninitialized value in string eq at /home/test/rpmbuild/BUILD/Mojolicious-Plugin-OpenAPI-3.30/blib/lib/JSON/Validator/OpenAPI/Mojolicious.pm line 58. Use of uninitialized value in string eq at /home/test/rpmbuild/BUILD/Mojolicious-Plugin-OpenAPI-3.30/blib/lib/JSON/Validator/OpenAPI/Mojolicious.pm line 58. $ rpmlint perl-Mojolicious-Plugin-OpenAPI.spec ../SRPMS/perl-Mojolicious-Plugin-OpenAPI-3.30-1.fc33.src.rpm ../RPMS/noarch/perl-Mojolicious-Plugin-OpenAPI-3.30-1.fc33.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is OK. $ rpm -q -lv -p ../RPMS/noarch/perl-Mojolicious-Plugin-OpenAPI-3.30-1.fc33.noarch.rpm drwxr-xr-x2 root root0 Apr 8 16:54 /usr/share/doc/perl-Mojolicious-Plugin-OpenAPI -rw-r--r--1 root root12242 Mar 24 02:24 /usr/share/doc/perl-Mojolicious-Plugin-OpenAPI/Changes -rw-r--r--1 root root10945 Mar 24 02:24 /usr/share/doc/perl-Mojolicious-Plugin-OpenAPI/README.md -rw-r--r--1 root root 3104 Apr 8 16:53 /usr/share/man/man3/JSON::Validator::OpenAPI::Mojolicious.3pm.gz -rw-r--r--1 root root 4848 Apr 8 16:53 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI.3pm.gz -rw-r--r--1 root root 4053 Apr 8 16:53 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Cors.3pm.gz -rw-r--r--1 root root 4334 Apr 8 16:53 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Guides::OpenAPIv2.3pm.gz -rw-r--r--1 root root 4908 Apr 8 16:53 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Guides::OpenAPIv3.3pm.gz -rw-r--r--1 root root 1915 Apr 8 16:53 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Guides::Swagger2.3pm.gz -rw-r--r--1 root root 2712 Apr 8 16:53 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::Security.3pm.gz -rw-r--r--1 root root 2935 Apr 8 16:53 /usr/share/man/man3/Mojolicious::Plugin::OpenAPI::SpecRenderer.3pm.gz drwxr-xr-x2 root root0 Apr 8 16:53 /usr/share/perl5/vendor_perl/JSON drwxr-xr-x2 root root0 Apr 8 16:53 /usr/share/perl5/vendor_perl/JSON/Validator drwxr-xr-x2 root root0 Apr 8 16:53 /usr/share/perl5/vendor_perl/JSON/Validator/OpenAPI -rw-r--r--1 root root20604 Mar 24 02:23 /usr/share/perl5/vendor_perl/JSON/Validator/OpenAPI/Mojolicious.pm drwxr-xr-x2 root root0 Apr 8 16:53 /usr/share/perl5/vendor_perl/Mojolicious drwxr-xr-x2 root root0 Apr 8 16:53 /usr/share/perl5/vendor_perl/Mojolicious/Plugin
[Bug 1820799] Review Request: golang-github-evilsocket-islazy - Go library containing a set of opinionated packages
https://bugzilla.redhat.com/show_bug.cgi?id=1820799 Olivier Lemasle changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821330] Review Request: python-apypie - Python bindings for Apipie
https://bugzilla.redhat.com/show_bug.cgi?id=1821330 --- Comment #7 from Ondrej Gajdusek --- Comments addressed. Spec URL: https://copr-be.cloud.fedoraproject.org/results/ogajduse/apypie/fedora-rawhide-x86_64/01330845-python-apypie/python-apypie.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ogajduse/apypie/fedora-rawhide-x86_64/01330845-python-apypie/python-apypie-0.2.1-2.fc33.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/ogajduse/apypie/build/1330845/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820799] Review Request: golang-github-evilsocket-islazy - Go library containing a set of opinionated packages
https://bugzilla.redhat.com/show_bug.cgi?id=1820799
--- Comment #1 from Olivier Lemasle ---
Package approved
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 11 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
[?]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
---
Checking: golang-github-evilsocket-islazy-devel-1.10.6-1.fc33.noarch.rpm
golang-github-evilsocket-islazy-1.10.6-1.fc33.src.rpm
golang-github-evilsocket-islazy-devel.noarch: W: hidden-file-or-dir
[Bug 1815726] Re-Review Request: mkdocs-material - A material design theme for MkDocs
https://bugzilla.redhat.com/show_bug.cgi?id=1815726
--- Comment #2 from Robin Lee ---
Spec URL: https://cheeselee.fedorapeople.org/mkdocs-material.spec
SRPM URL:
https://cheeselee.fedorapeople.org/mkdocs-material-5.0.1-1.fc33.src.rpm
Changes:
- Update to 5.0.1
- No globbing %%{python3_sitelib}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820799] Review Request: golang-github-evilsocket-islazy - Go library containing a set of opinionated packages
https://bugzilla.redhat.com/show_bug.cgi?id=1820799 Olivier Lemasle changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820799] Review Request: golang-github-evilsocket-islazy - Go library containing a set of opinionated packages
https://bugzilla.redhat.com/show_bug.cgi?id=1820799 Olivier Lemasle changed: What|Removed |Added CC||o.lema...@gmail.com Assignee|nob...@fedoraproject.org|o.lema...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815728] Re-Review Request: mkdocs-bootstrap - Bootstrap theme for MKDocs
https://bugzilla.redhat.com/show_bug.cgi?id=1815728
--- Comment #2 from Robin Lee ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330834-mkdocs-bootstrap/mkdocs-bootstrap.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330834-mkdocs-bootstrap/mkdocs-bootstrap-1.1-2.fc33.src.rpm
Change:
- No globbing %%{python3_sitelib}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815727] Re-Review Request: mkdocs-alabaster - Alabaster port for MkDocs
https://bugzilla.redhat.com/show_bug.cgi?id=1815727
--- Comment #2 from Robin Lee ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330828-mkdocs-alabaster/mkdocs-alabaster.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330828-mkdocs-alabaster/mkdocs-alabaster-0.8.0-2.fc33.src.rpm
Change:
- No globbing %%{python3_sitelib}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815725] Re-Review Request: mkdocs-cinder - A clean responsive theme for the MkDocs
https://bugzilla.redhat.com/show_bug.cgi?id=1815725
--- Comment #3 from Robin Lee ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330820-mkdocs-cinder/mkdocs-cinder.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330820-mkdocs-cinder/mkdocs-cinder-1.0.3-1.fc33.src.rpm
Changes:
- Update to 1.0.3
- No globbing %%{python3_sitelib}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815729] Re-Review Request: mkdocs-bootswatch - Bootswatch themes for MkDocs
https://bugzilla.redhat.com/show_bug.cgi?id=1815729
--- Comment #2 from Robin Lee ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330826-mkdocs-bootswatch/mkdocs-bootswatch.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01330826-mkdocs-bootswatch/mkdocs-bootswatch-1.1-2.fc33.src.rpm
Change:
- No globbing %%{python3_sitelib}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812411] Review request: bookworm - simple, focused eBook reader
https://bugzilla.redhat.com/show_bug.cgi?id=1812411 Petr Viktorin changed: What|Removed |Added CC||pvikt...@redhat.com --- Comment #13 from Petr Viktorin --- There's an issue that fedora-review should have reported on the package: - Package must not depend on deprecated() packages. Note: python27 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ I've opened Bug#1822231 to sort it out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818936] Review Request: perl-Mojolicious-Plugin-OpenAPI - OpenAPI / Swagger plugin for Mojolicious
https://bugzilla.redhat.com/show_bug.cgi?id=1818936 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822220] Review Request: golang-github-olivere-elastic-6 - Elasticsearch 6 client for Go
https://bugzilla.redhat.com/show_bug.cgi?id=180 Fabian Affolter changed: What|Removed |Added Depends On||1821922 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1821922 [Bug 1821922] Review Request: golang-github-olivere-env - Reading environment variables -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821922] Review Request: golang-github-olivere-env - Reading environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1821922 Fabian Affolter changed: What|Removed |Added Blocks||180 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=180 [Bug 180] Review Request: golang-github-olivere-elastic-6 - Elasticsearch 6 client for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822220] New: Review Request: golang-github-olivere-elastic-6 - Elasticsearch 6 client for Go
https://bugzilla.redhat.com/show_bug.cgi?id=180 Bug ID: 180 Summary: Review Request: golang-github-olivere-elastic-6 - Elasticsearch 6 client for Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-6.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-6-6.2.29-1.fc31.src.rpm Project URL: https://github.com/olivere/elastic Description: Elasticsearch 6 client for Go. Koji scratch build: fails due to missing dependency rpmlint output: $ rpmlint golang-github-olivere-elastic-6-6.2.29-1.fc31.src.rpm golang-github-olivere-elastic-6.src: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-6.src: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-6.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint golang-github-olivere-elastic-6-devel-6.2.29-1.fc31.noarch.rpm golang-github-olivere-elastic-6-devel.noarch: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-6-devel.noarch: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-6-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/olivere/elastic.v6/.goipath 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821922] Review Request: golang-github-olivere-env - Reading environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1821922 Fabian Affolter changed: What|Removed |Added Blocks||1822214 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822214 [Bug 1822214] Review Request: golang-github-olivere-elastic-5 - Elasticsearch 5 client for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822214] New: Review Request: golang-github-olivere-elastic-5 - Elasticsearch 5 client for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1822214 Bug ID: 1822214 Summary: Review Request: golang-github-olivere-elastic-5 - Elasticsearch 5 client for Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-5.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-5-5.0.84-1.fc31.src.rpm Project URL: https://github.com/olivere/elastic Description: Elasticsearch 5 client for Go. Koji scratch build: fails due to missing dependency rpmlint output: $ rpmlint golang-github-olivere-elastic-5-5.0.84-1.fc31.src.rpm golang-github-olivere-elastic-5.src: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-5.src: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-5.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint golang-github-olivere-elastic-5-devel-5.0.84-1.fc31.noarch.rpm golang-github-olivere-elastic-5-devel.noarch: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-5-devel.noarch: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-5-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/olivere/elastic.v5/.goipath 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822214] Review Request: golang-github-olivere-elastic-5 - Elasticsearch 5 client for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1822214 Fabian Affolter changed: What|Removed |Added Depends On||1821922 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1821922 [Bug 1821922] Review Request: golang-github-olivere-env - Reading environment variables -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822210] New: Review Request: golang-github-olivere-elastic-7 - Elasticsearch 7 client for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1822210 Bug ID: 1822210 Summary: Review Request: golang-github-olivere-elastic-7 - Elasticsearch 7 client for Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-7.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-7-7.0.13-1.fc31.src.rpm Project URL: https://github.com/olivere/elastic Description: Elasticsearch 7 client for Go. Koji scratch build: fails due to missing dependency rpmlint output: $ rpmlint golang-github-olivere-elastic-7-7.0.13-1.fc31.src.rpm golang-github-olivere-elastic-7.src: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-7.src: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-7.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint golang-github-olivere-elastic-7-devel-7.0.13-1.fc31.noarch.rpm golang-github-olivere-elastic-7-devel.noarch: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-7-devel.noarch: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated golang-github-olivere-elastic-7-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/olivere/elastic/v7/.goipath 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821922] Review Request: golang-github-olivere-env - Reading environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1821922 Fabian Affolter changed: What|Removed |Added Blocks||1822210 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822210 [Bug 1822210] Review Request: golang-github-olivere-elastic-7 - Elasticsearch 7 client for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822210] Review Request: golang-github-olivere-elastic-7 - Elasticsearch 7 client for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1822210 Fabian Affolter changed: What|Removed |Added Depends On||1821922 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1821922 [Bug 1821922] Review Request: golang-github-olivere-env - Reading environment variables -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822191] Review Request: golang-gitlab-flimzy-testy - Go testing utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1822191 Fabian Affolter changed: What|Removed |Added Depends On||1822187 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822187 [Bug 1822187] Review Request: golang-github-otiai10-copy - Copy directory recursively -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822187] Review Request: golang-github-otiai10-copy - Copy directory recursively
https://bugzilla.redhat.com/show_bug.cgi?id=1822187 Fabian Affolter changed: What|Removed |Added Blocks||1822191 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822191 [Bug 1822191] Review Request: golang-gitlab-flimzy-testy - Go testing utilities -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822191] New: Review Request: golang-gitlab-flimzy-testy - Go testing utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1822191 Bug ID: 1822191 Summary: Review Request: golang-gitlab-flimzy-testy - Go testing utilities Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-gitlab-flimzy-testy.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-gitlab-flimzy-testy-0.1.1-1.fc31.src.rpm Project URL: https://gitlab.com/flimzy/testy Description: Grab-bag of Go testing utilities. Koji scratch build: fails due to missing dependency rpmlint output: $ rpmlint golang-gitlab-flimzy-testy-0.1.1-1.fc31.src.rpm golang-gitlab-flimzy-testy.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-gitlab-flimzy-testy-devel-0.1.1-1.fc31.noarch.rpm golang-gitlab-flimzy-testy-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/gitlab.com/flimzy/testy/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822187] New: Review Request: golang-github-otiai10-copy - Copy directory recursively
https://bugzilla.redhat.com/show_bug.cgi?id=1822187 Bug ID: 1822187 Summary: Review Request: golang-github-otiai10-copy - Copy directory recursively Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-otiai10-copy.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-otiai10-copy-1.1.1-1.fc31.src.rpm Project URL: https://github.com/otiai10/copy Description: Golang copy directory recursively. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43127649 rpmlint output: $ rpmlint golang-github-otiai10-copy-1.1.1-1.fc31.src.rpm golang-github-otiai10-copy.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-otiai10-copy-devel-1.1.1-1.fc31.noarch.rpm golang-github-otiai10-copy-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/otiai10/copy/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822167] Review Request: golang-github-tylertreat-boomfilters - Probabilistic data structures for processing continuous, unbounded streams
https://bugzilla.redhat.com/show_bug.cgi?id=1822167 Fabian Affolter changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Fabian Affolter --- Sorry, wrong link. Tests do not pass an all platforms. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43126860 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822167] New: Review Request: golang-github-tylertreat-boomfilters - Probabilistic data structures for processing continuous, unbounded streams
https://bugzilla.redhat.com/show_bug.cgi?id=1822167 Bug ID: 1822167 Summary: Review Request: golang-github-tylertreat-boomfilters - Probabilistic data structures for processing continuous, unbounded streams Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-tylertreat-boomfilters.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-tylertreat-boomfilters-0-0.1.20200408git611b3db.fc31.src.rpm Project URL: https://github.com/tylertreat/BoomFilters Description: Probabilistic data structures for processing continuous, unbounded streams. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43126564 rpmlint output: $ rpmlint golang-github-tylertreat-boomfilters-0-0.1.20200408git611b3db.fc31.src.rpm golang-github-tylertreat-boomfilters.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-tylertreat-boomfilters-devel-0-0.1.20200408git611b3db.fc31.noarch.rpm golang-github-tylertreat-boomfilters-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/tylertreat/BoomFilters/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822160] New: Review Request: golang-github-dghubble-sessions - Sessions with a secure cookie Store implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1822160 Bug ID: 1822160 Summary: Review Request: golang-github-dghubble-sessions - Sessions with a secure cookie Store implementation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dghubble-sessions.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dghubble-sessions-0.1.0-1.fc31.src.rpm Project URL: https://github.com/dghubble/sessions Description: Minimalist Go sessions with a secure cookie Store implementation. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43124924 rpmlint output: $ rpmlint golang-github-dghubble-sessions-0.1.0-1.fc31.src.rpm golang-github-dghubble-sessions.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-dghubble-sessions-devel-0.1.0-1.fc31.noarch.rpm golang-github-dghubble-sessions-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dghubble/sessions/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #13 from Fedora Update System --- FEDORA-2020-0348f28a44 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0348f28a44 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822151] New: Review Request: golang-github-dennwc-graphql - Implementation of GraphQL
https://bugzilla.redhat.com/show_bug.cgi?id=1822151 Bug ID: 1822151 Summary: Review Request: golang-github-dennwc-graphql - Implementation of GraphQL Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dennwc-graphql.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dennwc-graphql-0.4.18-1.20200408git12cfed4.fc31.src.rpm Project URL: https://github.com/dennwc/graphql Description: An implementation of GraphQL for Go/Golang. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43124595 rpmlint output: $ rpmlint golang-github-dennwc-graphql-0.4.18-1.20200408git12cfed4.fc31.src.rpm golang-github-dennwc-graphql.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-dennwc-graphql-devel-0.4.18-1.20200408git12cfed4.fc31.noarch.rpm golang-github-dennwc-graphql-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dennwc/graphql/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821691] Review Request: golang-github-kit - Library for microservices
https://bugzilla.redhat.com/show_bug.cgi?id=1821691 Fabian Affolter changed: What|Removed |Added Blocks||1822145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822145 [Bug 1822145] Review Request: golang-github-geziyor - Web crawling & scraping framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822145] Review Request: golang-github-geziyor - Web crawling & scraping framework
https://bugzilla.redhat.com/show_bug.cgi?id=1822145 Fabian Affolter changed: What|Removed |Added Depends On||1822142, 1821419, 1821691, ||1821703, 1822132, 1822107 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1821419 [Bug 1821419] Review Request: golang-github-chromedp-cdproto - Generated commands, types, and events for the Chrome DevTools Protocol domains https://bugzilla.redhat.com/show_bug.cgi?id=1821691 [Bug 1821691] Review Request: golang-github-kit - Library for microservices https://bugzilla.redhat.com/show_bug.cgi?id=1821703 [Bug 1821703] Review Request: golang-github-temoto-robotstxt - Robots.txt exclusion protocol implementation https://bugzilla.redhat.com/show_bug.cgi?id=1822107 [Bug 1822107] Review Request: golang-github-dghubble-twitter - Client library for the Twitter API https://bugzilla.redhat.com/show_bug.cgi?id=1822132 [Bug 1822132] Review Request: golang-github-andreasbriese-bbloom - Fast bit set Bloom filter https://bugzilla.redhat.com/show_bug.cgi?id=1822142 [Bug 1822142] Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822132] Review Request: golang-github-andreasbriese-bbloom - Fast bit set Bloom filter
https://bugzilla.redhat.com/show_bug.cgi?id=1822132 Fabian Affolter changed: What|Removed |Added Blocks||1822145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822145 [Bug 1822145] Review Request: golang-github-geziyor - Web crawling & scraping framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821419] Review Request: golang-github-chromedp-cdproto - Generated commands, types, and events for the Chrome DevTools Protocol domains
https://bugzilla.redhat.com/show_bug.cgi?id=1821419 Fabian Affolter changed: What|Removed |Added Blocks||1822145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822145 [Bug 1822145] Review Request: golang-github-geziyor - Web crawling & scraping framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822142] Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1822142 Fabian Affolter changed: What|Removed |Added Blocks||1822145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822145 [Bug 1822145] Review Request: golang-github-geziyor - Web crawling & scraping framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822107] Review Request: golang-github-dghubble-twitter - Client library for the Twitter API
https://bugzilla.redhat.com/show_bug.cgi?id=1822107 Fabian Affolter changed: What|Removed |Added Blocks||1822145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822145 [Bug 1822145] Review Request: golang-github-geziyor - Web crawling & scraping framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821703] Review Request: golang-github-temoto-robotstxt - Robots.txt exclusion protocol implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1821703 Fabian Affolter changed: What|Removed |Added Blocks||1822145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822145 [Bug 1822145] Review Request: golang-github-geziyor - Web crawling & scraping framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822145] New: Review Request: golang-github-geziyor - Web crawling & scraping framework
https://bugzilla.redhat.com/show_bug.cgi?id=1822145 Bug ID: 1822145 Summary: Review Request: golang-github-geziyor - Web crawling & scraping framework Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-geziyor.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-geziyor-0-0.1.20200406gitcfb16fe.fc31.src.rpm Project URL: https://github.com/geziyor/geziyor Description: Geziyor is a fast web crawling & scraping framework for Go. Supports JS rendering. Koji scratch build: fails due to missing dependencies rpmlint output: $ rpmlint golang-github-geziyor-0-0.1.20200406gitcfb16fe.fc31.src.rpm golang-github-geziyor.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-geziyor-devel-0-0.1.20200406gitcfb16fe.fc31.noarch.rpm golang-github-geziyor-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/geziyor/geziyor/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821746] Review Request: golang-github-gobwas-ws -Tiny WebSocket library
https://bugzilla.redhat.com/show_bug.cgi?id=1821746 Fabian Affolter changed: What|Removed |Added Blocks||1822142 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822142 [Bug 1822142] Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821419] Review Request: golang-github-chromedp-cdproto - Generated commands, types, and events for the Chrome DevTools Protocol domains
https://bugzilla.redhat.com/show_bug.cgi?id=1821419 Fabian Affolter changed: What|Removed |Added Blocks||1822142 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822142 [Bug 1822142] Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822142] Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1822142 Fabian Affolter changed: What|Removed |Added Depends On||1821746, 1821419 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1821419 [Bug 1821419] Review Request: golang-github-chromedp-cdproto - Generated commands, types, and events for the Chrome DevTools Protocol domains https://bugzilla.redhat.com/show_bug.cgi?id=1821746 [Bug 1821746] Review Request: golang-github-gobwas-ws -Tiny WebSocket library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822142] New: Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1822142 Bug ID: 1822142 Summary: Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-chromedp.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-chromedp-0.5.3-1.fc31.src.rpm Project URL: https://github.com/chromedp/chromedp Description: A faster, simpler way to drive browsers supporting the Chrome DevTools Protocol. Koji scratch build: fails due to missing dependencies rpmlint output: $ rpmlint golang-github-chromedp-0.5.3-1.fc31.src.rpm golang-github-chromedp.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-chromedp-devel-0.5.3-1.fc31.noarch.rpm golang-github-chromedp-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/chromedp/chromedp/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822132] New: Review Request: golang-github-andreasbriese-bbloom - Fast bit set Bloom filter
https://bugzilla.redhat.com/show_bug.cgi?id=1822132 Bug ID: 1822132 Summary: Review Request: golang-github-andreasbriese-bbloom - Fast bit set Bloom filter Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-andreasbriese-bbloom.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-andreasbriese-bbloom-0-0.1.20200408git46b345b.fc31.src.rpm Project URL: https://github.com/AndreasBriese/bbloom Description: A fast bit set Bloom filter. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43123258 rpmlint output: $ rpmlint golang-github-andreasbriese-bbloom-0-0.1.20200408git46b345b.fc31.src.rpm golang-github-andreasbriese-bbloom.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-andreasbriese-bbloom-devel-0-0.1.20200408git46b345b.fc31.noarch.rpm golang-github-andreasbriese-bbloom-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/AndreasBriese/bbloom/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #12 from Fedora Update System --- FEDORA-2020-48b58104ed has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-48b58104ed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822106] Review Request: golang-github-dghubble-oauth1 - Go OAuth1 library
https://bugzilla.redhat.com/show_bug.cgi?id=1822106 Fabian Affolter changed: What|Removed |Added Blocks||1822107 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822107 [Bug 1822107] Review Request: golang-github-dghubble-twitter - Client library for the Twitter API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822107] New: Review Request: golang-github-dghubble-twitter - Client library for the Twitter API
https://bugzilla.redhat.com/show_bug.cgi?id=1822107 Bug ID: 1822107 Summary: Review Request: golang-github-dghubble-twitter - Client library for the Twitter API Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dghubble-twitter.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dghubble-twitter-0-0.1.20200408git39e5462.fc31.src.rpm Project URL: https://github.com/dghubble/go-twitter Description: o-twitter is a Go client library for the Twitter API. Koji scratch build: fails due to missing dependencies rpmlint output: $ rpmlint golang-github-dghubble-twitter-0-0.1.20200408git39e5462.fc31.src.rpm golang-github-dghubble-twitter.src: W: invalid-url URL: https://github.com/dghubble/go-twitter/twitter HTTP Error 404: Not Found golang-github-dghubble-twitter.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint golang-github-dghubble-twitter-devel-0-0.1.20200408git39e5462.fc31.noarch.rpm golang-github-dghubble-twitter-devel.noarch: W: invalid-url URL: https://github.com/dghubble/go-twitter/twitter HTTP Error 404: Not Found golang-github-dghubble-twitter-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dghubble/go-twitter/twitter/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822107] Review Request: golang-github-dghubble-twitter - Client library for the Twitter API
https://bugzilla.redhat.com/show_bug.cgi?id=1822107 Fabian Affolter changed: What|Removed |Added Depends On||1822098, 1822106 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822098 [Bug 1822098] Review Request: golang-github-dghubble-sling - Library for creating and sending API requests https://bugzilla.redhat.com/show_bug.cgi?id=1822106 [Bug 1822106] Review Request: golang-github-dghubble-oauth1 - Go OAuth1 library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822098] Review Request: golang-github-dghubble-sling - Library for creating and sending API requests
https://bugzilla.redhat.com/show_bug.cgi?id=1822098 Fabian Affolter changed: What|Removed |Added Blocks||1822107 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1822107 [Bug 1822107] Review Request: golang-github-dghubble-twitter - Client library for the Twitter API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822106] New: Review Request: golang-github-dghubble-oauth1 - Go OAuth1 library
https://bugzilla.redhat.com/show_bug.cgi?id=1822106 Bug ID: 1822106 Summary: Review Request: golang-github-dghubble-oauth1 - Go OAuth1 library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dghubble-oauth1.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dghubble-oauth1-0.6.0-1.fc31.src.rpm Project URL: https://github.com/dghubble/oauth1 Description: The package oauth1 provides a Go implementation of the OAuth 1 spec to allow end-users to authorize a client (i.e. consumer) to access protected resources on his/her behalf. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43121229 rpmlint output: $ rpmlint golang-github-dghubble-oauth1-0.6.0-1.fc31.src.rpm golang-github-dghubble-oauth1.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-dghubble-oauth1-devel-0.6.0-1.fc31.noarch.rpm golang-github-dghubble-oauth1-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dghubble/oauth1/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822098] New: Review Request: golang-github-dghubble-sling - Library for creating and sending API requests
https://bugzilla.redhat.com/show_bug.cgi?id=1822098 Bug ID: 1822098 Summary: Review Request: golang-github-dghubble-sling - Library for creating and sending API requests Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dghubble-sling.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-dghubble-sling-1.3.0-1.fc31.src.rpm Project URL: https://github.com/dghubble/sling Description: A Go HTTP client library for creating and sending API requests. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43120526 rpmlint output: $ rpmlint golang-github-dghubble-sling-1.3.0-1.fc31.src.rpm golang-github-dghubble-sling.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-dghubble-sling-devel-1.3.0-1.fc31.noarch.rpm golang-github-dghubble-sling-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dghubble/sling/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821330] Review Request: python-apypie - Python bindings for Apipie
https://bugzilla.redhat.com/show_bug.cgi?id=1821330 --- Comment #6 from Fabian Affolter --- Otherwise looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821330] Review Request: python-apypie - Python bindings for Apipie
https://bugzilla.redhat.com/show_bug.cgi?id=1821330
--- Comment #5 from Fabian Affolter ---
- "curl https://raw.githubusercontent.com/Apipie/apypie/v%{version}/LICENSE -o
LICENSE"
The license file must be "Source1:" and copied in %prep with something like
"cp -a %{SOURCE1} LICENSE)". I guess that curl would be in the base requirement
but koji doesn't have network access while building packages.
- "%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info"
I would like to suggest to change it to
"%{python3_sitelib}/%{pypi_name}-%{version}-py*.egg-info" otherwise there will
be a build error when Python 3.10 is introduced
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682
Honggang LI changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #30 from Honggang LI ---
The srpm package PASSED review. Set the 'fedora-review+' flag for it.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
honli: PASS
[ ]: Package contains no static executables.
honli: PASS
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
honli: PASS. See next comment.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* GPL (v2)", "Unknown or generated". 19 files
have unknown license. Detailed output of licensecheck in
/home/honli/1814682-rshim/licensecheck.txt
honli: PASS. I had checked all files. Only three files do not have license
tag. rshim-2.0.1/README.md, rshim-2.0.1/man/rshim.8, and
rshim-2.0.1/bootstrap.sh
does not have license tag. It is fine for the first two files as no one
add license tag for such kind of files. rshim-2.0.1/bootstrap.sh is a dummy
bash script. It is better to add a SPDX-License-Identifier in the head of it.
But it is also acceptable to ignore it.
[ ]: License file installed when any subpackage combination is installed.
honli: PASS.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/systemd/system,
/usr/lib/systemd
honli: PASS. Both directories are co-own by many packages.
[ ]: %build honors applicable compiler flags or justifies otherwise.
honli: PASS. Default compiler flags used.
[ ]: Package contains no bundled libraries without FPC exception.
honli: PASS. No bundled library.
[ ]: Changelog in prescribed format.
honli: PASS
[ ]: Sources contain only permissible code or content.
honli: PASS
[ ]: Package contains desktop file if it is a GUI application.
honli: PASS. No desktop file.
[ ]: Development files must be in a -devel package
honli: PASS. No development files.
[ ]: Package uses nothing in %doc for runtime.
honli: PASS.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
honli: PASS
[ ]: Package is named according to the Package Naming Guidelines.
honli: PASS
[ ]: Package does not generate any conflict.
honli: PASS
[ ]: Package obeys FHS, except libexecdir and /usr/target.
honli: PASS
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
honli: PASS
[ ]: Requires correct, justified where necessary.
honli: PASS
[ ]: Spec file is legible and written in American English.
honli: PASS
[ ]: Package contains systemd file(s) if in need.
honli: PASS
[ ]: Useful -debuginfo package or justification otherwise.
honli: PASS
[ ]: Package is not known to require an ExcludeArch tag.
honli: PASS
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
honli: PASS
[ ]: Package complies to the Packaging Guidelines
honli: PASS
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 Honggang LI changed: What|Removed |Added Flags|needinfo?(mschmidt@redhat.c | |om) | --- Comment #29 from Honggang LI --- (In reply to lsun from comment #28) > Michal (and Honggang), > > Any advices what the next step would be? Do I need to provide new version to The package is good. We were waiting for hardware to test the package. Unfortunately, we are unlikely get the hardware after a week waiting. We will skip the test of this package for Fedora Rawhide. Redhat QE will test it for RHEL, when this package get into RHEL. > fix anything? Michal, Honggang mentioned that I need to be added into fedora > packager group (comment 15 above). mschmidt will add you into the packager group. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #11 from Fedora Update System --- FEDORA-2020-f0bfd67c52 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f0bfd67c52 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809700] Review Request: hledger-ui - Curses-style user interface for the hledger accounting tool
https://bugzilla.redhat.com/show_bug.cgi?id=1809700 --- Comment #6 from Fedora Update System --- FEDORA-2020-da08abc6db has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-da08abc6db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
