[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825716



--- Comment #9 from Itamar Reis Peixoto  ---
https://pagure.io/releng/fedora-scm-requests/issue/24426


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825716

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Vasiliy Glazov  ---
Approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/python-pg8000
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD 3-clause "New" or "Revised" License", "Unknown or
 generated". 21 files have unknown license. Detailed output of
 licensecheck in /home/vascom/1825716-python-pg8000/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: 

[Bug 1821120] Review Request: wlogout - wayland based logout menu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821120

Lyes Saadi  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|fed...@lyes.eu




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821120] Review Request: wlogout - wayland based logout menu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821120

Lyes Saadi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821120] Review Request: wlogout - wayland based logout menu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821120

Lyes Saadi  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value



--- Comment #8 from Lyes Saadi  ---
Hi!

So, for now at least, I have Bugzilla permissions!

Could you please send me a final-final-final version of the package :P? I know
that's just an extra "*", but it's a MUST item in Packaging Guidelines: «
Packages must own all directories they put files in »...

I also wanted to thank you for your work and for packaging this program!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823599



--- Comment #15 from Bob Hepple  ---
Thanks for the explanation, Miro. At least it makes sense now.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825716



--- Comment #7 from Itamar Reis Peixoto  ---
Spec URL: https://itamarjp.fedorapeople.org/review/python-pg8000.spec
SRPM URL:
https://itamarjp.fedorapeople.org/review/python-pg8000-1.15.2-1.fc32.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558



--- Comment #17 from Fedora Update System  ---
FEDORA-2020-703f118e1c has been pushed to the Fedora 30 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-703f118e1c \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-703f118e1c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-04-20 22:14:55



--- Comment #16 from Fedora Update System  ---
FEDORA-2020-473d3f7a77 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825716



--- Comment #6 from Itamar Reis Peixoto  ---
(In reply to Vasiliy Glazov from comment #3)
> Issues:
> ===
> - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
>   Note: Package contains %{pythonX_site(lib|arch)}/* in %files
>   See: https://pagure.io/packaging-committee/issue/782

ok, changed to

%{python3_sitelib}/%{srcname}-*.egg-info/
%{python3_sitelib}/%{srcname}


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825716



--- Comment #5 from Vasiliy Glazov  ---
For your choice.

ALso
python3-pg8000.noarch: W: invalid-url URL: http://pythonhosted.org/pg8000/ HTTP
Error 404: Not Found
python3-pg8000.noarch: E: useless-provides python-pg8000
python3-pg8000.noarch: E: useless-provides python38-pg8000


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825716



--- Comment #4 from Itamar Reis Peixoto  ---
(In reply to Vasiliy Glazov from comment #2)
> May be change URL to https://pypi.org/project/pg8000/ ?

I think this one would be better.

http://github.com/tlocke/pg8000/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825716



--- Comment #3 from Vasiliy Glazov  ---
Issues:
===
- Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
  Note: Package contains %{pythonX_site(lib|arch)}/* in %files
  See: https://pagure.io/packaging-committee/issue/782


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825716



--- Comment #2 from Vasiliy Glazov  ---
May be change URL to https://pypi.org/project/pg8000/ ?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825716

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||vasc...@gmail.com
   Assignee|nob...@fedoraproject.org|vasc...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1818670] Review Request: sensu-go - Sensu Go Open Source (Monitoring Program)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1818670

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 CC||domi...@greysector.net



--- Comment #5 from Dominik 'Rathann' Mierzejewski  ---
%define debug_package %{nil} is no-go, a proper debug{info,source} packages
must be generated. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ .

Fedora has Golang specific guidelines at
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ .

Is there any reason why you're not following them?

The empty %check section is useless. Please either run some after-build tests
there or drop it. Golang guidelines mention a %gochecks macro which runs
built-in tests in a standard way.

ExclusiveArch: x86_64 is not justified, please see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support

As for bundling so many build dependencies, this is something that should be
avoided in general:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling .

Please make an effort to unbundle them first. This may require submitting
additional packages for review.

I can sponsor you, but this package requires a bit more work to pass review. It
would also help if you could do a couple of informal reviews of other pending
packages.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1826056] New: Review Request: mesaflash - Configuration and diagnostic tool for Mesa Electronics boards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1826056

Bug ID: 1826056
   Summary: Review Request: mesaflash - Configuration and
diagnostic tool for Mesa Electronics boards
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: dwro...@ertelnet.rybnik.pl
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/mesaflash.spec
SRPM URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/mesaflash-3.3.0-0.3.20200415git84fa463.fc31.src.rpm
Description: Configuration and diagnostic tool for Mesa Electronics
PCI(E)/ETH/EPP/USB/SPI boards.
Fedora Account System Username: dwrobel
Copr build: https://copr.fedorainfracloud.org/coprs/dwrobel/mesaflash/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825361] Review Request: kanshi - Dynamic display configuration for sway

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825361

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #5 from Fedora Update System  ---
FEDORA-2020-e31daa4785 has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-e31daa4785


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1826034] Review Request: cubeb - A cross platform audio library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1826034



--- Comment #2 from Jeremy Newton  ---
(In reply to Jeremy Newton from comment #1)
> Understood. I will proceed with the new package; I've linked the new review
> request bug as FYI.
> 
> After cubeb is accepted and built in rawhide, I'll try to mock something up
> and make a pull request if I can build firefox against the shared cubeb.

Sorry I posted in this the wrong bug see the linked firefox related bug.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1826034] Review Request: cubeb - A cross platform audio library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1826034



--- Comment #1 from Jeremy Newton  ---
Understood. I will proceed with the new package; I've linked the new review
request bug as FYI.

After cubeb is accepted and built in rawhide, I'll try to mock something up and
make a pull request if I can build firefox against the shared cubeb.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1826034] Review Request: cubeb - A cross platform audio library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1826034

Jeremy Newton  changed:

   What|Removed |Added

Summary|Review Request:  -|library




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1826034] Review Request: -

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1826034

Jeremy Newton  changed:

   What|Removed |Added

Link ID||Red Hat Bugzilla 1825485
   Doc Type|--- |If docs needed, set a value




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1826034] New: Review Request: -

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1826034

Bug ID: 1826034
   Summary: Review Request:  - 
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: alexjn...@fastmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://mystro256.fedorapeople.org/cubeb.spec
SRPM URL:
https://mystro256.fedorapeople.org/cubeb-0.2-1.20200409.git9caa5b1.fc31.src.rpm
Description: A cross platform audio library
Fedora Account System Username: mystro256

Notes:
Upstream's newest version is 0.2, which is pretty old (released in 2012). I've
decided to take a git snapshot as the development branch is very active.

As well, right now two packages bundle cubeb: firefox and dolphin-emu.
I maintain dolphin-emu, but I hope this can open a means to unbundle cubeb from
firefox as well if this is practical.
See RHBZ#1825485. If any firefox maintainers see this review requests, please
don't hesistate to comment or request co-maintainership.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971

David Cantrell  changed:

   What|Removed |Added

  Flags||needinfo?(d...@qemfd.net)



--- Comment #14 from David Cantrell  ---
Comments and questions on items requiring manual review.

(In reply to David Cantrell from comment #13)
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> 
> = MUST items =
> 
> C/C++:
> [ ]: Package does not contain kernel modules.

No kernel modules.

> [ ]: Package contains no static executables.

No static executables, but there are static libraries in notcurses-static.

> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
>  other legal requirements as defined in the legal section of Packaging
>  Guidelines.

The software is licensed under the Apache License 2.0, which is approved by
Fedora.  The short name is "ASL 2.0" as noted in the spec file License tag.

> [ ]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "Unknown or generated", "Apache License (v2.0)", "*No
>  copyright* Apache License (v2.0)". 260 files have unknown license.
>  Detailed output of licensecheck in
>  /home/dcantrell/notcurses/licensecheck.txt

All files lack license boilerplate information, but the entire project says it
is licensed under the Apache License 2.0 as noted in the LICENSE file. 
Copyright information is in the COPYRIGHT file.

Upstream is advised to consider adding license information to each source file
either as indicated by the Apache License 2.0 or an SPDX identifier.

> [ ]: License file installed when any subpackage combination is installed.

The license is installed as /usr/share/licenses/notcurses/LICENSE in the
notcurses package.

> [ ]: %build honors applicable compiler flags or justifies otherwise.

The %build section uses the %cmake, %make_build, and %py3_build macros to pull
in applicable compiler flags.

> [ ]: Package contains no bundled libraries without FPC exception.

There are no bundled libraries.

> [ ]: Changelog in prescribed format.

It is.

> [ ]: Sources contain only permissible code or content.

All code and docs are licensed under the Apache License 2.0.  The files in
data/ are unknown.  Need clarification from upstream.

> [ ]: Package contains desktop file if it is a GUI application.

There is no desktop content.

> [ ]: Development files must be in a -devel package

They are.

> [ ]: Package uses nothing in %doc for runtime.

It doesn't.

> [ ]: Package consistently uses macros (instead of hard-coded directory
>  names).

Oh yes, it does.

> [ ]: Package is named according to the Package Naming Guidelines.

It is.

> [ ]: Package does not generate any conflict.

Only awesomeness.

> [ ]: Package obeys FHS, except libexecdir and /usr/target.

It does.

> [ ]: If the package is a rename of another package, proper Obsoletes and
>  Provides are present.

N/A

> [ ]: Requires correct, justified where necessary.

N/A

> [ ]: Spec file is legible and written in American English.

Yep.

> [ ]: Package contains systemd file(s) if in need.

N/A

> [ ]: Useful -debuginfo package or justification otherwise.

There is a useful debuginfo package.

> [ ]: Package is not known to require an ExcludeArch tag.

Correct.

> [ ]: Large documentation must go in a -doc subpackage. Large could be size
>  (~1MB) or number of files.
>  Note: Documentation size is 133120 bytes in 2 files.

/usr/share/doc is 136K, do not need a subpackage

> [ ]: Package complies to the Packaging Guidelines

That's what this review is confirming.

> Python:
> [ ]: Python eggs must not download any dependencies during the build
>  process.

None are.

> [ ]: A package which is used by another package via an egg interface should
>  provide egg info.

There is an egg provided in /usr/lib[64]/pythonX.Y/site-packages/notcurses

> [ ]: Package meets the Packaging Guidelines::Python

It does.

> = SHOULD items =
> 
> Generic:
> [ ]: If the source package does not include license text(s) as a separate
>  file from upstream, the packager SHOULD query upstream to include it.

Need clarification on the files in data/.
Recommend adding license information to each source and doc file.

> [ ]: Final provides and requires are sane (see attachments).

They are.

> [ ]: Fully versioned dependency in subpackages if applicable.
>  Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
>  notcurses-static

Need to add:

Requires: %{name}%{?_isa} = %{version}-%{release}

To the notcurses-static package.

> [ ]: Package functions as described.

Yep.

> [ ]: Latest version is packaged.

Yep.

> [ ]: Package 

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #13 from David Cantrell  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Apache License (v2.0)", "*No
 copyright* Apache License (v2.0)". 260 files have unknown license.
 Detailed output of licensecheck in
 /home/dcantrell/notcurses/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 133120 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
 present.
 Note: Package has .a files: notcurses-static.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
 process.
[ ]: A package which is used by another package via an egg interface should
 provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names 

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
FEDORA-2020-84cb4ece2f has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-84cb4ece2f \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-84cb4ece2f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #12 from David Cantrell  ---
(In reply to Nick Black from comment #10)
> nice catch on the cffi, thanks! i've merged your changes, David, and as soon
> as I've built and verified new packages, I'll have them staged for you.
> 
> With that said, I'm pretty certain things were working for me before. I can
> understand the cffi miss, but I'm surprised your other changes are needed.
> Or are they just better idioms? If the latter, thanks for making me aware of
> them. If the former, please don't feel compelled to worry about it.

If you just build locally using rpmbuild, then things will work fine if you
have a build requirement installed but not explicitly stated in the spec file. 
All Fedora builds are done using mock in clean chroots so the spec file has to
contain enough information to set up the build environment from scratch.

The Python build macros are preferred over direct calls to setup.py because it
will ensure you pick up the Fedora packaging standards for Python stuff and not
have to chase that on your own.  That said, the Fedora macros also change and
you're chasing stuff anyway.  But without %py3_build, the install doesn't work
right in a mock chroot.

I just did a 'mock -r fedora-rawhide-x86_64 --rebuild
notcurses-1.3.2-1.fc32.src.rpm' and it worked fine.  Continuing the review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825777] Review Request: python3-kerberos - A high-level wrapper for Kerberos (GSSAPI) operations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825777

Nils Philippsen  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||nphil...@redhat.com
 Resolution|--- |NOTABUG
Last Closed||2020-04-20 16:02:18



--- Comment #1 from Nils Philippsen  ---
This is no longer needed:
https://pagure.io/fedora-infrastructure/issue/8445#comment-643110


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825779] Review Request: python3-requests-kerberos - A Kerberos authentication handler for python-requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825779

Nils Philippsen  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2020-04-20 16:02:28



--- Comment #2 from Nils Philippsen  ---
This is no longer needed:
https://pagure.io/fedora-infrastructure/issue/8445#comment-643110


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558



--- Comment #14 from Fedora Update System  ---
FEDORA-2020-703f118e1c has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-703f118e1c


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558



--- Comment #13 from Fedora Update System  ---
FEDORA-2020-473d3f7a77 has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-473d3f7a77


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1807365] Review Request: nuspell - Free and open source C++ spell checking library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1807365



--- Comment #11 from Pander  ---
Thanks for packaging, great job!

I'm one of the developers. On April 7th, we have releases version 3.1, please
see https://github.com/nuspell/nuspell/releases/tag/v3.1.0 and update the
package.

For your spec file, please make the following changes:

1) add near the top:
"Requires:  hunspell-en-US"

2) change
"Summary:   Free and open source C++ spell checking library"
into"
"Summary:   Free and open source C++ spell checking library and
command-line tool"

3) change

"Nuspell is a free and open source spell checker library.
It is designed for languages with rich morphology and complex word compounding.
Nuspell is a pure C++ re-implementation of Hunspell."
into
"Nuspell is a free and open source spell checker library and command-line tool.
It is designed for languages with rich morphology and complex word compounding.
Nuspell is a pure C++ implementation supporting Hunspell dictionaries."

4) change
"%license COPYING COPYING.LESSER"
into
"%license COPYING.LESSER"
because the file COPYING in only related to legacy code which not being used in
the build.

Some questions from me:

5) Why do you use "-DCMAKE_BUILD_TYPE=Debug"?

6) If you omit "-DBUILD_TESTING=OFF" then you have to add Catch2 as a build
dependency

See also our Fedora package for 3.1.0 at
https://github.com/nuspell/misc-nuspell/blob/master/packaging/rpm/nuspell.spec
or contact me if you have any questions.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #12 from Fedora Update System  ---
FEDORA-2020-84cb4ece2f has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-84cb4ece2f


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1820723] Review Request: nuspell - A spell checker library and command-line tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1820723

Pander  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2020-04-20 14:55:00



--- Comment #2 from Pander  ---
Thanks. I'm one of the Nuspell developers, but have no intention of joining the
packager group. Our package was just to help start the packaging process. I
will close this issue. Thanks for your message.

*** This bug has been marked as a duplicate of bug 1807365 ***


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1807365] Review Request: nuspell - Free and open source C++ spell checking library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1807365

Pander  changed:

   What|Removed |Added

 CC||pan...@users.sourceforge.ne
   ||t



--- Comment #10 from Pander  ---
*** Bug 1820723 has been marked as a duplicate of this bug. ***


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821120] Review Request: wlogout - wayland based logout menu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821120



--- Comment #7 from Lyes Saadi  ---
Hello Bob,

I see that you changed this:

```
%{_datadir}/zsh/*
%{_datadir}/fish/*
%{_datadir}/bash-completion/*
```

But, according to the guidelines, you were right to own the entire directory:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

Except for that, your package is good to go! But I'm still waiting for my
Bugzilla permissions to be fixed. I'll ask someone else to approve it for me if
that takes a long time...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558



--- Comment #11 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/apostrophe


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1820478] Review Request: php-sebastian-code-unit - Collection of value objects that represent the PHP code units

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1820478

Hirotaka Wakabayashi  changed:

   What|Removed |Added

 CC||hiw...@yahoo.com
   Assignee|nob...@fedoraproject.org|hiw...@yahoo.com
   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Hirotaka Wakabayashi  ---
Here is a successful Koji Scratch Build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=43562902


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1820723] Review Request: nuspell - A spell checker library and command-line tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1820723

Lyes Saadi  changed:

   What|Removed |Added

 CC||fed...@lyes.eu



--- Comment #1 from Lyes Saadi  ---
Hi, it seems that you aren't part of the packager group!

In order to submit packages to Fedora, you need to follow these steps:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers

nuspell is also already packaged for Fedora as well:
https://src.fedoraproject.org/rpms/nuspell
Here is the related Bugzilla ticket (it was opened 2 days after this one):
https://bugzilla.redhat.com/show_bug.cgi?id=1807365

If you wish to take over his package or co-maintain it, you should contact the
current maintainer.

(I am currently temporarily unable to close this ticket for permission issues
in Bugzilla, will do as soon as it is solved.)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821037] Review Request: onednn - Deep Neural Network Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821037

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/onednn.spec
SRPM URL: http://dl.kwizart.net/review/onednn-1.4-1.fc31.src.rpm

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=43562262


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558



--- Comment #10 from Artem  ---
Slightly license description update

https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342551-apostrophe/apostrophe.spec

https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342551-apostrophe/apostrophe-2.2.0.1-3.fc32.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825361] Review Request: kanshi - Dynamic display configuration for sway

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825361



--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/kanshi


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558

Vitaly Zaitsev  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Vitaly Zaitsev  ---
Thanks for the quick fix. LGTM now. Package approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558



--- Comment #8 from Artem  ---
https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342432-apostrophe/apostrophe.spec

https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342432-apostrophe/apostrophe-2.2.0.1-2.fc32.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1814682



--- Comment #48 from Alaa Hleihel (Mellanox)  ---
(In reply to Alaa Hleihel (Mellanox) from comment #37)

> 3. Red Hat needs to enable CONFIG_DEVMEM on aarch64 builds as well (it's the
> only arch that has this config disabled).
> 

Update: enabling CONFIG_DEVMEM is no longer required.
rshim-2.0.3 uses the device resources directly instead of /dev/mem


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1814682



--- Comment #47 from Michal Schmidt  ---
(In reply to lsun from comment #32)
> As for the "systemd-units", it appears to be required by koji. I got some
> failures like below once removed it. So I'll leave it for now (please
> correct me if I am incorrect).
> https://koji.fedoraproject.org/koji/taskinfo?taskID=43163313

OK, in that case leaving a BuildRequires there is acceptable.
Note that the "systemd-units" package was merged into the main "systemd"
package in 2012 (before Fedora 18). Fedora packaging guidelines removed the
last reference to "systemd-units" in 2016, keeping "BuildRequires: systemd" as
the preferred way.

There is another option. You can remove the BR and instead tell your configure
script to not autodetect the systemd units directory, using:
  %configure --with-systemdsystemunitdir=%{_unitdir}
The minor advantage of this would be a smaller buildroot.

Use whatever option you prefer there.

(In reply to lsun from comment #46)
> Spec URL: 
> https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.3/rshim.spec

> Requires: psmisc

Why does the rshim.service use killall in the first place? There is:
> KillMode=process

Why this mode? Do you need child processes to be left running in the cgroup
after the service is stopped?
If yes, commenting on it in the unit file would be nice.

> ExecStop=/usr/bin/killall -SIGKILL rshim

Referencing processes to kill by name is not good. It would kill unrelated
processes with the same name.
Is none of systemd's kill modes suitable for stopping the service without
additional help?
And why SIGKILL? Does it not stop on SIGTERM?

> Requires: kernel-modules-extra

This is always going to be imperfect, because nothing guarantees that the
installed package corresponds to the actually running kernel (different
versions, variants like -debug, custom unpackaged kernels, ...).
There is precedent for depending on kernel-modules-extra in Fedora packages
(usbip, xl2tpd, ...) though.
I would just make it more explicit which module the package needs by instead
using this:

Requires: kmod(cuse.ko)
# Hint for dnf to prefer kernel-modules-extra over kernel-debug-modules-extra:
Suggests: kernel-modules-extra


BTW, is it necessary to call 'system("modprobe cuse");' in src/rshim.c? I would
expect the module to get autoloaded during the call to cuse_lowlevel_setup.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558



--- Comment #7 from Vitaly Zaitsev  ---
Please fix the following rpmlint errors:

> apostrophe.noarch: E: explicit-lib-dependency glib2

Remove glib2 from Requires.

> apostrophe.noarch: E: non-executable-script 
> /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/bibtexparser/bparser.py
>  644 /usr/bin/env python
> apostrophe.noarch: E: non-executable-script 
> /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/bibtexparser/bwriter.py
>  644 /usr/bin/env python
> apostrophe.noarch: E: non-executable-script 
> /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/bibtexparser/customization.py
>  644 /usr/bin/env python
> apostrophe.noarch: E: non-executable-script 
> /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/bibtexparser/latexenc.py
>  644 /usr/bin/env python
> apostrophe.noarch: E: non-executable-script 
> /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/fuzzywuzzy/StringMatcher.py
>  644 /usr/bin/env python
> apostrophe.noarch: E: non-executable-script 
> /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/fuzzywuzzy/fuzz.py 
> 644 /usr/bin/env python
> apostrophe.noarch: E: non-executable-script 
> /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/fuzzywuzzy/process.py
>  644 /usr/bin/env python

Remove shebangs from these files in %prep using find and sed.

> apostrophe.noarch: W: hidden-file-or-dir 
> /usr/lib/python3.8/site-packages/apostrophe/.pylintrc

Remove this file in %prep too.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558

Vitaly Zaitsev  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||vit...@easycoding.org
   Assignee|nob...@fedoraproject.org|vit...@easycoding.org
  Flags||fedora-review?



--- Comment #6 from Vitaly Zaitsev  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
 Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
 publishes 

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #11 from Nick Black  ---
Same locations.

[vps](0) $ sha256sum *
c8cdb0ada6580bf8d9b13ebb4e20a83499b0c4014c0b226d6f21b1f53cdd202c 
notcurses-1.3.2-1.fc32.src.rpm
ed9e2ac283e3465999e93fe6f9df787aba861fb954d3e49646eb6cfcd4ff2282 
notcurses-1.3.2-1.fc32.x86_64.rpm
1a9f75f848d7b59118917ab18286a1efdd1f24e8d4eafa5e83dd57ecdfd4245c 
notcurses-debuginfo-1.3.2-1.fc32.x86_64.rpm
af5346a99a166e7fc68ccca416d17676a9d9ebc19c487660450cdfa4cf039363 
notcurses-debugsource-1.3.2-1.fc32.x86_64.rpm
15a4aa66c12061a6b907335deec9932c2c324a2c8259970ed5ff4d18031908c8 
notcurses-devel-1.3.2-1.fc32.x86_64.rpm
04a9d5065a9d36587cdd10b211674620df53478c688bcd9072f4ae54e196f440 
notcurses-static-1.3.2-1.fc32.x86_64.rpm
9a60b57d6de4db4b8192276d97208d0d2fabcbf751c36d32046441f3105471a9 
python3-notcurses-1.3.2-1.fc32.x86_64.rpm
9d7512addfa4cb8ed6d5f2fcd4128bf851627aca3bfd3353cca07accde2babc7 
python3-notcurses-debuginfo-1.3.2-1.fc32.x86_64.rpm
[vps](0) $


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1734558

Artem  changed:

   What|Removed |Added

Summary|Review Request: uberwriter  |Review Request: apostrophe
   |- Distraction free Markdown |- Distraction free Markdown
   |editor for GNU/Linux made   |editor for GNU/Linux made
   |with GTK+   |with GTK+



--- Comment #5 from Artem  ---
Good news: ported to Meson and renamed to Apostrophe now.

Spec URL:
https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342374-apostrophe/apostrophe.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342374-apostrophe/apostrophe-2.2.0.1-1.fc32.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971

Nick Black  changed:

   What|Removed |Added

  Flags|needinfo?(d...@qemfd.net)   |



--- Comment #10 from Nick Black  ---
nice catch on the cffi, thanks! i've merged your changes, David, and as soon as
I've built and verified new packages, I'll have them staged for you.

With that said, I'm pretty certain things were working for me before. I can
understand the cffi miss, but I'm surprised your other changes are needed. Or
are they just better idioms? If the latter, thanks for making me aware of them.
If the former, please don't feel compelled to worry about it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1824780



--- Comment #8 from Vít Ondruch  ---
(In reply to Fabio Valentini from comment #4)
> (In reply to Fabio Valentini from comment #1)
> > I think you should add "%exclude %{gem_cache}" to the %files section.
> > While it's not mentioned in the packaging guidelines, but this is generated
> > by gem2rpm, and this is what existing rubygem packages do as well.
> > 
> > You also need to own "%dir %{gem_instdir}", otherwise that directory is
> > unowned.
> > 
> > Please fix those two issues before importing the package.
> 
> ↑ I noted this in the review, but apparently Igor didn't see that ...

Neither did I, sorry ;D


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825779] Review Request: python3-requests-kerberos - A Kerberos authentication handler for python-requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825779

Nils Philippsen  changed:

   What|Removed |Added

 CC||nphil...@redhat.com



--- Comment #1 from Nils Philippsen  ---
Note that this package needs python36-kerberos which is under review in bug
#1825777.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825779] New: Review Request: python3-requests-kerberos - A Kerberos authentication handler for python-requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825779

Bug ID: 1825779
   Summary: Review Request: python3-requests-kerberos - A Kerberos
authentication handler for python-requests
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: nphil...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://nphilipp.fedorapeople.org/review/python3-requests-kerberos/python-requests-kerberos.spec
SRPM URL:
https://nphilipp.fedorapeople.org/review/python3-requests-kerberos/python3-requests-kerberos-0.12.0-9.el7.src.rpm
Description: Requests is an HTTP library, written in Python, for human beings.
This library
adds optional Kerberos/GSSAPI authentication support and supports mutual
authentication.
Fedora Account System Username: nphilipp

*This is an EPEL7 only package.*


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825777] New: Review Request: python3-kerberos - A high-level wrapper for Kerberos (GSSAPI) operations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825777

Bug ID: 1825777
   Summary: Review Request: python3-kerberos - A high-level
wrapper for Kerberos (GSSAPI) operations
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: nphil...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://nphilipp.fedorapeople.org/review/python3-kerberos/python3-kerberos.spec
SRPM URL:
https://nphilipp.fedorapeople.org/review/python3-kerberos/python3-kerberos-1.3.0-9.el7.src.rpm
Description: This Python package is a high-level wrapper for Kerberos (GSSAPI)
operations.
The goal is to avoid having to build a module that wraps the entire
Kerberos framework, and instead offer a limited set of functions that do what
is needed for client/server Kerberos authentication based on
.
Fedora Account System Username: nphilipp

*This is an EPEL7 only package.*


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1824780



--- Comment #7 from Igor Gnatenko  ---
Ah, now I see... Will fix it in a bit.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823599



--- Comment #14 from Miro Hrončok  ---
When the software repositories are created, the contents of those file are
scrapped/loaded to a central place and than offered as metadata for e.g. GNOME
software.

You could probably somehow reproduce locally (although I have never actually
tried this and the instructions are not complete):

 1. put the built rpms into an empty directory
 2. run createrpo over them to create a DNF repository
 3. run appstream-builder to extract the appdata
 4. run modifyrepo to merge the appdata to the repo metadata
 5. add a repo file to your system with file:// URL
 6. see GNOME software



However, I don't know all the command line options and switches to use. There
is an easier way. Build the package in https://copr.fedorainfracloud.org/ -> it
will give you a repository with appdata.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1824780



--- Comment #6 from Fabio Valentini  ---
"%dir %{gem_instdir}" needs to be in the main package (not in the -doc
subpackage).

https://src.fedoraproject.org/rpms/rubygem-optimist/blob/master/f/rubygem-optimist.spec#_61


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823599



--- Comment #13 from Bob Hepple  ---
Thanks Alexander and Miro for useful input. I will need a few days to catch up
with this (real life intervenes).

In the meantime and now that we've got metainfo more or less working, do you
know if it's actually used? I tried sway and gnome but they don't appear to
access the file. Nor does dnfdragora. Having totally bogus entries in it does
not appear to upset rpm. So - where is it actually used?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1824780

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|needinfo?(i.gnatenko.brain@ |
   |gmail.com)  |



--- Comment #5 from Igor Gnatenko  ---
> %dir %{gem_instdir}

is in the spec file, no?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1824780

Fabio Valentini  changed:

   What|Removed |Added

  Flags||needinfo?(i.gnatenko.brain@
   ||gmail.com)



--- Comment #4 from Fabio Valentini  ---
(In reply to Fabio Valentini from comment #1)
> I think you should add "%exclude %{gem_cache}" to the %files section.
> While it's not mentioned in the packaging guidelines, but this is generated
> by gem2rpm, and this is what existing rubygem packages do as well.
> 
> You also need to own "%dir %{gem_instdir}", otherwise that directory is
> unowned.
> 
> Please fix those two issues before importing the package.

↑ I noted this in the review, but apparently Igor didn't see that ...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810049

lisa  changed:

   What|Removed |Added

 CC||lisarusse...@gmail.com
  Flags||needinfo?(puntogil@libero.i
   ||t)



--- Comment #104 from lisa  ---
We give specific sponsorship and specialized setup for gadgets like Computers,
Routers, Printers, Tablets, Mobiles and some more. We have profoundly qualified
and professionally prepared experts, to offer consistent and fast technical
support to you at whatever time of the day. To know more about this
Visit our site
https://www.activateespnonroku.com/
https://www.activatefoxsportsgo.com/
https://www.activatenbc.com/
https://www.canon-ijsetup.org/
https://www.espnplusactivate.com/
https://www.mcafee-comactivates.org/
https://www.nbcsportscomactivate.com/
https://www.quickbook-support.net/
https://www.roku-com-links.com/
https://www.roku-comlink.org/
https://www.youtubecomactivates.com/
https://msofficecomsetup.org/
https://www.zonetechsupport.com/garmin-updates/
https://www.zonetechsupport.com/hulu-com-activate/
https://www.zonetechsupport.com/activate-espn-on-roku/
https://www.zonetechsupport.com/activate-starz-on-roku/
https://www.zonetechsupport.com/activate-pbs-on-roku/
https://www.quickssolution.com/espn-com-activate/
https://www.diamumbaiescorts.com/
https://www.mumbai-escorts.org/
https://www.nehaescortsmumbai.in/
https://www.activatetrakttv.com/
https://www.plutotvactivate.org/
https://www.rokucodelink.org/
https://www.zonetechsupport.com/xfinity-com-activate/
https://www.roku-com-links.com/activate-espn/
https://www.espncomactivate.tech/
https://www.roku-com-links.com/hulu-com-activate/
https://www.roku.comactivate.org/
https://www.espn.comactivate.org/
https://www.netflix.comactivate.org/
https://www.hulu.comactivate.org/
https://www.downloadalexaapp.us/
https://www.activatechannel.com/pluto-tv-activate/
https://www.activatechannel.com/trakt-tv-activate/
https://www.activatechannel.com/espn-com-activate/
https://www.activatechannel.com/hulu-com-activate/
https://www.activatechannel.com/youtube-com-activate/
https://www.activatechannel.com/pbs-org-activate/
https://www.activatechannel.com/roku-com-link/
https://www.activatechannel.com/activate-foxsports-com/
https://www.activatechannel.com/nbc-sports-activate/
https://www.activatechannel.com/netflix-com-activate/
https://www.activatechannel.com/tntdrama-com-activate/
https://www.activatechannel.com/crackle-com-activate/
https://mcafee.comactivate.org/
https://zonedesire.com/how-to-download-any-video-from-any-site-on-pc/
https://zonedesire.com/how-to-enable-adobe-flash-player-on-chrome-browser/
https://zonedesire.com/how-to-add-people-on-skype/
https://www.zonedesire.com/how-to-delete-hulu-account/


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1824780

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com



--- Comment #3 from Vít Ondruch  ---
It seems that the package does not own the `%{gem_instdir}` in any way.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823599

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #12 from Miro Hrončok  ---
  %check
  desktop-file-install

Is not good: You should either desktop-file-validate the specfile in %check, or
desktop-file-install (which also validates as a side effect) from %install.
Installing files from %check is dangerous, because in certain circumstances,
%check can be skipped entirely. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage






  sed -i -e 's@lib/gjots2@lib/python%{python3_version}/site-packages/gjots2@g'
setup.py

Why is this actually needed? In what context does this change happen? Please,
add a comment to the spec that explains this.






  %{python3_sitelib}/%{name}-%{version}-py%{python3_version}.egg-info

Consider adding leading slash to ensure this remains a directory.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825681] Review Request: create-fake-rpm - Generate fake (S)RPM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825681



--- Comment #2 from Miroslav Suchý  ---
> This command will always package the latest master

Nope. The command `tito build --tgz --test` will package the latest master.
Without the `--test` tito will package the latest tagged version.

> ... GitHub, which allows you to get a .tar.gz 

Sure. GitHub allows me to do that. The problem is that I (as upstream and rpm
package maintainer) am NOT using this tarball for creating src.rpm.

And if you compare the output of:
 * https://github.com/xsuchy/create-fake-rpm/archive/create-fake-rpm-1-1.tar.gz
 * tito build --tgz
They are binary different - albeit the content is the same. This cause problem
for tools like rpminspect.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org