[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 --- Comment #50 from l...@mellanox.com --- Thanks all for the comments. 2.0.4 has been uploaded trying to solve these issues. Spec URL: https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.4/rshim.spec SRPM URL: https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.4/rshim-2.0.4-1.fc31.src.rpm koji build URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=43638819 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826998] Review Request: python-python-language-server - Python Language Server for the Language Server Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1826998 Vasiliy Glazov changed: What|Removed |Added CC||vasc...@gmail.com --- Comment #2 from Vasiliy Glazov --- Set correct license. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 --- Comment #8 from Vasiliy Glazov --- Add %set_build_flags at top of build section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #13 from Luis Bazan --- Hi Miro -- Renamed Fixed Test added Fixed whitespace Fixed Source Fixed SPEC:https://lbazan.fedorapeople.org/python-jsonfield.spec SRPM:https://lbazan.fedorapeople.org/python-jsonfield-3.1.0-1.fc32.src.rpm koji build --scratch rawhide python-jsonfield-3.1.0-1.fc32.src.rpm Uploading srpm: python-jsonfield-3.1.0-1.fc32.src.rpm [] 100% 00:00:00 21.63 KiB 52.99 KiB/sec Created task: 43670083 Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=43670083 Watching tasks (this may be safely interrupted)... 43670083 build (rawhide, python-jsonfield-3.1.0-1.fc32.src.rpm): free 43670083 build (rawhide, python-jsonfield-3.1.0-1.fc32.src.rpm): free -> open (buildvm-armv7-24.arm.fedoraproject.org) 43670085 rebuildSRPM (noarch): free 43670085 rebuildSRPM (noarch): free -> open (buildvm-armv7-17.arm.fedoraproject.org) 43670085 rebuildSRPM (noarch): open (buildvm-armv7-17.arm.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 43670169 buildArch (python-jsonfield-3.1.0-1.fc33.src.rpm, noarch): free 43670169 buildArch (python-jsonfield-3.1.0-1.fc33.src.rpm, noarch): free -> open (buildvm-armv7-13.arm.fedoraproject.org) 43670169 buildArch (python-jsonfield-3.1.0-1.fc33.src.rpm, noarch): open (buildvm-armv7-13.arm.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 43670083 build (rawhide, python-jsonfield-3.1.0-1.fc32.src.rpm): open (buildvm-armv7-24.arm.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed 43670083 build (rawhide, python-jsonfield-3.1.0-1.fc32.src.rpm) completed successfully Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 Luis Bazan changed: What|Removed |Added Alias||python-jsonfield -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 Luis Bazan changed: What|Removed |Added Summary|Review Request: |Review Request: |python-django-jsonfield - |python-jsonfield - is a |is a reusable model field |reusable model field that |that allows you to store|allows you to store |validated JSON, |validated JSON, |automatically handling |automatically handling |serialization to and from |serialization to and from |the database. |the database. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826998] Review Request: python-python-language-server - Python Language Server for the Language Server Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1826998 Mukundan Ragavan changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Mukundan Ragavan --- I am unable to get the test to work. Open to suggestions. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826998] New: Review Request: python-python-language-server - Python Language Server for the Language Server Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1826998 Bug ID: 1826998 Summary: Review Request: python-python-language-server - Python Language Server for the Language Server Protocol Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: nonamed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/pyls/rnd1/python-python-language-server.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/pyls/rnd1/python-python-language-server-0.31.9-1.fc32.src.rpm Description: A Python implementation of the Language Server Protocol. Fedora Account System Username: nonamedotc koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43666598 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348
--- Comment #7 from david08...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
Is there a good reason to not use the tar.gz from github as source0?
It would contain the source and the tests. The way I understand [1] combined
with [2] is that the not-downloadable source is only acceptable if the source
is not allowed in fedora.
Are there any items in release that are not allowed?
[1]
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Things_To_Check_On_Review
[2]
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#When_Upstream_uses_Prohibited_Code
Typos: 'ultrafast' should be 'ultra fast'. Rest seems to be false-positives.
As configure isn't run, the compiler flags are not set.
Manuals for the binaries would be nice.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GNU General Public
License (v3)", "GPL (v3 or later)", "zlib/libpng license". 40 files
have unknown license. Detailed output of licensecheck in
/home/dave/rpmbuild/review/1824348-bowtie2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: %build honors applicable compiler flags or justifies otherwise.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
The explicit require on python3 doesn't seem to be needed. This
way python3 is listed twice as requirement.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 245760 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #12 from Miro Hrončok --- According to the guidelines, the package name should be python-jsonfield / python3-jsonfield, not python-django-jsonfield / python3-django-jsonfield. It might obsolete/provide python3-django-jsonfield to provide na upgrade path. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950
--- Comment #11 from Miro Hrončok ---
There is lot of trailing whitespace, consider trimming it.
The source is different than in the source url:
https://files.pythonhosted.org/packages/source/j/jsonfield/jsonfield-3.1.0.tar.gz
:
CHECKSUM(SHA256) this package :
83830542a6fcd517cb362a20239c9305a38295319b0476d79ec05b918bca1fad
CHECKSUM(SHA256) upstream package :
7e4e84597de21eeaeeaaa7cc5da08c61c48a9b64d0c446b2d71255d01812887a
diff -r also reports differences
Please, run the upstream testsuite in %check:
%check
PYTHONPATH=%{buildroot}%{python3_sitelib} %{python3} manage.py test
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 david08...@gmail.com changed: What|Removed |Added CC||david08...@gmail.com Assignee|nob...@fedoraproject.org|david08...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822464] Review Request: python-siphash - SipHash in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1822464 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-04-22 23:24:03 --- Comment #11 from Fedora Update System --- FEDORA-2020-9278054aa3 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 Nick Black changed: What|Removed |Added Flags||needinfo?(dcantrell@redhat. ||com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 --- Comment #6 from Jun Aruga --- Thanks for your review! I fixed every items you mentioned, and update the Spec and SRPM URL, and checked the rpmlint and installation and scratch build here again. https://koji.fedoraproject.org/koji/taskinfo?taskID=43660524 Sorry for the 2. %autosetup. You mentioned it for my last simde package's review. And now you had to say repeatedly it for this review too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #10 from Luis Bazan --- SPEC:https://lbazan.fedorapeople.org/python-django-jsonfield.spec SRPM:https://lbazan.fedorapeople.org/python-django-jsonfield-3.1.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #9 from Luis Bazan --- :-) Buildrequires Fixed Suggestions applied. Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950
--- Comment #8 from Miro Hrončok ---
%{python3_sitelib}/%{pypi_name}
%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info
I suggest to replace this with:
%{python3_sitelib}/%{pypi_name}/
%{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/
This ensures:
- future compatibility with Python 3.10
- the build will fail if the path is accidentally not a directory
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #7 from Miro Hrončok --- This is wrong: BuildRequires: python3.8dist(django) >= 2.2 (For example it will break on Fedora 31 or when we update Python to 3.9.) Please keep buildrequiring Python version agnostic python3-django. The "python3.8dist(django)" dependency is generated for runtime (automatically from upstream metadata). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #5 from Luis Bazan --- Hi Miro -- Source Fixed changelog Fixed sitelib Fixed djangoversion Fixed tox/coverage droped Fixed formtools fixed SPEC:https://lbazan.fedorapeople.org/python-django-jsonfield.spec SRPM:https://lbazan.fedorapeople.org/python-django-jsonfield-3.1.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #6 from Luis Bazan --- License change to MIT Fixed Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #4 from Miro Hrončok --- No problemo ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #3 from Luis Bazan --- Ups my mistake! thanks Miro -- Working on it! Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950
--- Comment #2 from Miro Hrončok ---
Spec sanity:
Source0:
https://files.pythonhosted.org/packages/source/%(n=%{pypi_name}; echo
${n:0:1})/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
Please, use %pypi_source,
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi
BuildRequires: python3-tox
BuildRequires: python3-coverage
There is no %check, why does the package need tox and coverage?
Requires: python3-django
Requires: python3-django-formtools
The following requirement is generated automatically, please drop the explicit
one:
python3.8dist(django) >= 2.2
The package does not seem to need formtools,
https://github.com/rpkilby/jsonfield/search?q=formtools_q=formtools
yields nothing. Please drop the (buil)requires or prove me wrong.
%{python3_sitelib}/* is forbidden (well, discouraged), see
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include
* Mon Apr 24 2020 Luis Bazan - 3.1.0-1
- Rebuild
This entry doesn't make much sense.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821120] Review Request: wlogout - wayland based logout menu
https://bugzilla.redhat.com/show_bug.cgi?id=1821120 --- Comment #13 from Fedora Update System --- FEDORA-2020-105f9d6381 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-105f9d6381 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821120] Review Request: wlogout - wayland based logout menu
https://bugzilla.redhat.com/show_bug.cgi?id=1821120 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2020-d755c36129 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d755c36129 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 Luis Bazan changed: What|Removed |Added Blocks||1810731 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1810731 [Bug 1810731] python3-django-post_office fails during test update from f31 to f32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1741624] Review Request: pydeps - Display module dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1741624 --- Comment #9 from Luis Bazan --- Hi team -- SPEC: https://lbazan.fedorapeople.org/pydeps.spec SRPM: https://lbazan.fedorapeople.org/pydeps-1.8.8-1.fc32.src.rpm koji build --scratch rawhide pydeps-1.8.8-1.fc32.src.rpm Uploading srpm: pydeps-1.8.8-1.fc32.src.rpm [] 100% 00:00:01 109.30 KiB 106.83 KiB/sec Created task: 43657268 Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=43657268 Watching tasks (this may be safely interrupted)... 43657268 build (rawhide, pydeps-1.8.8-1.fc32.src.rpm): free 43657268 build (rawhide, pydeps-1.8.8-1.fc32.src.rpm): free -> open (buildvm-armv7-06.arm.fedoraproject.org) 43657287 rebuildSRPM (noarch): open (buildvm-armv7-06.arm.fedoraproject.org) 43657287 rebuildSRPM (noarch): open (buildvm-armv7-06.arm.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 43657418 buildArch (pydeps-1.8.8-1.fc33.src.rpm, noarch): free 43657418 buildArch (pydeps-1.8.8-1.fc33.src.rpm, noarch): free -> open (buildvm-armv7-24.arm.fedoraproject.org) 43657268 build (rawhide, pydeps-1.8.8-1.fc32.src.rpm): open (buildvm-armv7-06.arm.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 43657418 buildArch (pydeps-1.8.8-1.fc33.src.rpm, noarch): open (buildvm-armv7-24.arm.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed 43657268 build (rawhide, pydeps-1.8.8-1.fc32.src.rpm) completed successfully Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 Vasiliy Glazov changed: What|Removed |Added CC||vasc...@gmail.com --- Comment #5 from Vasiliy Glazov --- 1. May be change it %ifnarch x86_64 BuildRequires: simde-devel %endif %ifarch x86_64 BuildRequires: tbb-devel %endif to %ifarch x86_64 BuildRequires: tbb-devel %else BuildRequires: simde-devel %endif 2. Change %setup -q to %autosetup 3. Change sed -i 's/“/"/g' processor_support.h sed -i 's/”/"/g' processor_support.h to sed -e 's/“/"/g' -e 's/”/"/g' -i processor_support.h -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815810] Review Request: python-pg8000 - Pure Python PostgreSQL Driver
https://bugzilla.redhat.com/show_bug.cgi?id=1815810 --- Comment #19 from Fedora Update System --- FEDORA-2020-8bd55aa329 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8bd55aa329 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1741624] Review Request: pydeps - Display module dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1741624 --- Comment #8 from Luis Bazan --- added dependencies pyyaml and pytest let me build again but its better disable the test after next release 1.9.0 https://github.com/thebjorn/pydeps/issues/54 Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815810] Review Request: python-pg8000 - Pure Python PostgreSQL Driver
https://bugzilla.redhat.com/show_bug.cgi?id=1815810 --- Comment #18 from Itamar Reis Peixoto --- https://bodhi.fedoraproject.org/updates/FEDORA-2020-98a167c578 https://koji.fedoraproject.org/koji/buildinfo?buildID=1497248 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825716] Review Request: python-pg8000 - Pure Python PostgreSQL Driver
https://bugzilla.redhat.com/show_bug.cgi?id=1825716 Itamar Reis Peixoto changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-04-22 20:32:04 --- Comment #10 from Itamar Reis Peixoto --- https://bodhi.fedoraproject.org/updates/FEDORA-2020-98a167c578 https://koji.fedoraproject.org/koji/buildinfo?buildID=1497248 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824467] Review Request: freeopcua - Open Source C++ OPC-UA Server and Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=1824467 --- Comment #14 from Fedora Update System --- FEDORA-2020-9a04c41ac9 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9a04c41ac9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9a04c41ac9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826326] Review Request: gnome-shell-extension-bubblemail - GNOME Shell indicator for new and unread mail using Bubblemail
https://bugzilla.redhat.com/show_bug.cgi?id=1826326 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2020-394123e1f0 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-394123e1f0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-394123e1f0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823091] Review Request: python-freeipa - Lightweight FreeIPA client
https://bugzilla.redhat.com/show_bug.cgi?id=1823091 --- Comment #25 from Fedora Update System --- FEDORA-2020-217b6928cc has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-217b6928cc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-217b6928cc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 Luis Bazan changed: What|Removed |Added Blocks||1799928 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1799928 [Bug 1799928] python-django-post_office: FTBFS in Fedora rawhide/f32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #1 from Luis Bazan --- This re-review is to unretire this package: https://pagure.io/releng/issue/9287 Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 Luis Bazan changed: What|Removed |Added Alias||python-django-jsonfield Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] New: Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 Bug ID: 1826950 Summary: Review Request: python-django-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database. Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: bazanlui...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Description: is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database. SPEC:https://lbazan.fedorapeople.org/python-django-jsonfield.spec SRPM:https://lbazan.fedorapeople.org/python-django-jsonfield-3.1.0-1.fc32.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43655907 koji build --scratch rawhide python-django-jsonfield-3.1.0-1.fc32.src.rpm Uploading srpm: python-django-jsonfield-3.1.0-1.fc32.src.rpm [] 100% 00:00:00 21.75 KiB 53.13 KiB/sec Created task: 43655907 Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=43655907 Watching tasks (this may be safely interrupted)... 43655907 build (rawhide, python-django-jsonfield-3.1.0-1.fc32.src.rpm): free 43655907 build (rawhide, python-django-jsonfield-3.1.0-1.fc32.src.rpm): free -> open (buildvm-armv7-20.arm.fedoraproject.org) 43655912 rebuildSRPM (noarch): open (buildvm-armv7-07.arm.fedoraproject.org) 43655980 buildArch (python-django-jsonfield-3.1.0-1.fc33.src.rpm, noarch): free 43655912 rebuildSRPM (noarch): open (buildvm-armv7-07.arm.fedoraproject.org) -> closed 1 free 1 open 1 done 0 failed 43655980 buildArch (python-django-jsonfield-3.1.0-1.fc33.src.rpm, noarch): free -> open (buildvm-19.phx2.fedoraproject.org) 43655980 buildArch (python-django-jsonfield-3.1.0-1.fc33.src.rpm, noarch): open (buildvm-19.phx2.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 43655907 build (rawhide, python-django-jsonfield-3.1.0-1.fc32.src.rpm): open (buildvm-armv7-20.arm.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed 43655907 build (rawhide, python-django-jsonfield-3.1.0-1.fc32.src.rpm) completed successfully -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824467] Review Request: freeopcua - Open Source C++ OPC-UA Server and Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=1824467 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2020-413183128c has been pushed to the Fedora 30 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-413183128c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-413183128c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823091] Review Request: python-freeipa - Lightweight FreeIPA client
https://bugzilla.redhat.com/show_bug.cgi?id=1823091 --- Comment #24 from Fedora Update System --- FEDORA-2020-06730065a6 has been pushed to the Fedora 30 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-06730065a6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-06730065a6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1741624] Review Request: pydeps - Display module dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1741624 --- Comment #7 from Luis Bazan --- Working on it! Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809405] Review Request: python-sumatra - Tool for managing and tracking projects based on numerical simulation and/or analysis, with the aim of supporting reproducible research
https://bugzilla.redhat.com/show_bug.cgi?id=1809405
--- Comment #9 from Ankur Sinha (FranciscoD) ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
^
We'll look into this later.
There are a few issues, but the package isn't quite complete at the moment. So,
we can take
it one issue at a time.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
Looks OK:
$ licensecheck -r . | sed -e '/UNKNOWN/ d' -e '/GENERATED/d'
./LICENSE: BSD 2-clause "Simplified" License
./sumatra/web/static/css/bootstrap.min.css: Expat License
./sumatra/web/static/js/bootstrap.min.js: Expat License
./build/lib/sumatra/web/static/css/bootstrap.min.css: Expat License
./build/lib/sumatra/web/static/js/bootstrap.min.js: Expat License
[?]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/bin(filesystem)
^
Best to list the various binaries instead of owning %{_bindir}. That way, if a
new version includes new binaries, you will know when the build fails.
[?]: Package contains no bundled libraries without FPC exception.
^
Includes some css, js and fonts. We'll need to check where they are and if they
can be unbundled.
[x]: Changelog in prescribed format.
Looks OK
[?]: Sources contain only permissible code or content.
^
Looks OK, but worth double-checking.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
^
No docs have been included. The sources include documentation. Please consider
building them and including them.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[?]: Package is named according to the Package Naming Guidelines.
^
rpmlint picked up on this. One issue seems to be that the pypi name is
"Sumatra" with a capital "S". That may explain why %pypi_source doesn't work.
You'll need to update it to `%pypi_source Sumatra` or define another variable:
%global pretty_name Sumatra
and then use that where needed.
[?]: Package does not generate any conflict.
^
Shouldn't have conflicts, but we'll check this when the package can be
installed.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
^
We'll need to check this when the package installs correctly.
[-]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[?]: Binary eggs must be removed in %prep
Note: Cannot find any
[Bug 1823091] Review Request: python-freeipa - Lightweight FreeIPA client
https://bugzilla.redhat.com/show_bug.cgi?id=1823091 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System --- FEDORA-EPEL-2020-a729ac8728 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-a729ac8728 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809405] Review Request: python-sumatra - Tool for managing and tracking projects based on numerical simulation and/or analysis, with the aim of supporting reproducible research
https://bugzilla.redhat.com/show_bug.cgi?id=1809405 --- Comment #8 from Ankur Sinha (FranciscoD) --- A few issues to start with: - please update the description, - a bunch of rpmlint errors: Rpmlint --- Checking: python3-sumatra-0.7.4-1.fc33.noarch.rpm python-sumatra-0.7.4-1.fc33.src.rpm python3-sumatra.noarch: W: description-shorter-than-summary python3-sumatra.noarch: E: useless-provides python-sumatra python3-sumatra.noarch: E: useless-provides python38-sumatra python3-sumatra.noarch: W: no-documentation python3-sumatra.noarch: E: standard-dir-owned-by-package /usr/bin python3-sumatra.noarch: W: non-executable-in-bin /usr/bin/smt-complete.sh 644 python3-sumatra.noarch: E: script-without-shebang /usr/bin/smt-complete.sh python3-sumatra.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/sumatra/pfi.py 644 /usr/bin/env python python3-sumatra.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/sumatra/tee.py 644 /usr/bin/env python python3-sumatra.noarch: W: no-manual-page-for-binary smt python3-sumatra.noarch: W: no-manual-page-for-binary smtweb python-sumatra.src: W: description-shorter-than-summary python-sumatra.src: W: inconsistent-file-extension sumatra-0.7.4.tar.gz python-sumatra.src: E: invalid-spec-name python-sumatra.src: W: invalid-url Source0: https://files.pythonhosted.org/packages/source/s/sumatra/sumatra-0.7.4.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 7 errors, 8 warnings. - Doesn't install correctly: INFO: installing package(s): /home/asinha/dump/fedora-reviews/1809405-python-sumatra/results/python3-sumatra-0.7.4-1.fc33.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 33 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/asinha/dump/fedora-reviews/1809405-python-sumatra/results/python3-sumatra-0.7.4-1.fc33.noarch.rpm --setopt=tsflags=nocontexts We'll have to look into this. Please look into these while I run the other checks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1741624] Review Request: pydeps - Display module dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1741624 --- Comment #6 from Ankur Sinha (FranciscoD) --- Hrm, the build fails for me in mock: WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox. running egg_info writing pydeps.egg-info/PKG-INFO writing dependency_links to pydeps.egg-info/dependency_links.txt writing entry points to pydeps.egg-info/entry_points.txt writing requirements to pydeps.egg-info/requires.txt writing top-level names to pydeps.egg-info/top_level.txt reading manifest file 'pydeps.egg-info/SOURCES.txt' writing manifest file 'pydeps.egg-info/SOURCES.txt' running build_ext Traceback (most recent call last): File "setup.py", line 36, in setup( File "/usr/lib64/python3.8/distutils/core.py", line 148, in setup dist.run_commands() File "/usr/lib64/python3.8/distutils/dist.py", line 966, in run_commands self.run_command(cmd) File "/usr/lib64/python3.8/distutils/dist.py", line 985, in run_command cmd_obj.run() File "/usr/lib/python3.8/site-packages/setuptools/command/test.py", line 238, in run self.run_tests() File "setup.py", line 31, in run_tests import pytest ModuleNotFoundError: No module named 'pytest' This is a missing BuildRequires here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809974] Review Request: python-cxxfilt - Python interface to c++filt/abi::__cxa_demangle
https://bugzilla.redhat.com/show_bug.cgi?id=1809974 --- Comment #15 from Fedora Update System --- FEDORA-EPEL-2020-412743fe76 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.
https://bugzilla.redhat.com/show_bug.cgi?id=1808552 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2020-b1370a85f0 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b1370a85f0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.
https://bugzilla.redhat.com/show_bug.cgi?id=1808552 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2020-b1370a85f0 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b1370a85f0 --- Comment #12 from Fedora Update System --- FEDORA-2020-761059aa6d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-761059aa6d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.
https://bugzilla.redhat.com/show_bug.cgi?id=1808552 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-numpoly -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1741624] Review Request: pydeps - Display module dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1741624 Luis Bazan changed: What|Removed |Added Flags|needinfo?(bazanluis20@gmail | |.com) | --- Comment #5 from Luis Bazan --- Hi team Name fixed Test fixed Cosmetics Fixed SPEC: https://lbazan.fedorapeople.org/pydeps.spec SRPM: https://lbazan.fedorapeople.org/pydeps-1.8.8-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1741624] Review Request: pydeps - Display module dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1741624 Luis Bazan changed: What|Removed |Added Summary|Review Request: |Review Request: pydeps - |python-pydeps - Display |Display module dependencies |module dependencies | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1741624] Review Request: python-pydeps - Display module dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1741624 Luis Bazan changed: What|Removed |Added Alias||pydeps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.
https://bugzilla.redhat.com/show_bug.cgi?id=1808552 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #9 from Ankur Sinha (FranciscoD) --- Looks good. XXX APPROVED XXX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.
https://bugzilla.redhat.com/show_bug.cgi?id=1808552 Luis Bazan changed: What|Removed |Added Blocks||1786882 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1786882 [Bug 1786882] python-chaospy-3.2.10 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.
https://bugzilla.redhat.com/show_bug.cgi?id=1808552 --- Comment #8 from Luis Bazan --- Test Fixed (thanks Ankur) Source Fixed Spaces and cosmetics Fixed SPEC:https://lbazan.fedorapeople.org/python-numpoly.spec SRPM:https://lbazan.fedorapeople.org/python-numpoly-0.1.16-2.fc32.src.rpm Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.
https://bugzilla.redhat.com/show_bug.cgi?id=1808552
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #7 from Ankur Sinha (FranciscoD) ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in /home/asinha/dump/fedora-
reviews/1808552-python-numpoly/diff.txt
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
^
Please correct this.
- Cosmetic: please use either spaces or tabs, but please do not mix both.
- You can use %pypi_source for Source0?
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_macros
- Tests haven't been run? Please enable them.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 2-clause "Simplified" License", "Unknown or generated". 82
files have unknown license. Detailed output of licensecheck in
/home/asinha/dump/fedora-reviews/1808552-python-
numpoly/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
^
May need sympy, but it isn't listed in the toml file.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
^
Provides dist-info, so should be OK.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
=
[Bug 1118885] Review Request: gsimplecal - Simple GTK calendar
https://bugzilla.redhat.com/show_bug.cgi?id=1118885 --- Comment #10 from Ranjan Maitra --- I think that this packaging is going nowhere. Which is unfortunate because reviewers (in this case me) spend time on providing reviews which are not acted upon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.
https://bugzilla.redhat.com/show_bug.cgi?id=1808552 Luis Bazan changed: What|Removed |Added Flags|needinfo?(bazanluis20@gmail | |.com) | --- Comment #6 from Luis Bazan --- SPEC: https://lbazan.fedorapeople.org/python-numpoly.spec SRPM: https://lbazan.fedorapeople.org/python-numpoly-0.1.16-1.fc32.src.rpm Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1313155] Review Request: gluster-nagios-addons - Plugins to monitor gluster services on hosts
https://bugzilla.redhat.com/show_bug.cgi?id=1313155 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1246719] Review Request: lua-luaprompt - A Lua command prompt with pretty-printing and autocompletion
https://bugzilla.redhat.com/show_bug.cgi?id=1246719 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1294467] Review Request: pidgin-window-merge - plugin for single window mode
https://bugzilla.redhat.com/show_bug.cgi?id=1294467 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||ppi...@redhat.com Fixed In Version||pidgin-window-merge-0.3-5.f ||c22 Resolution|--- |ERRATA Last Closed||2020-04-22 14:56:07 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 687942] Review Request: mysql-sandbox - Quick painless install of side by side MySQL server in isolation
https://bugzilla.redhat.com/show_bug.cgi?id=687942 Petr Pisar changed: What|Removed |Added Blocks|201449 (FE-DEADREVIEW) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node
https://bugzilla.redhat.com/show_bug.cgi?id=1023769 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|jchal...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 687942] Review Request: mysql-sandbox - Quick painless install of side by side MySQL server in isolation
https://bugzilla.redhat.com/show_bug.cgi?id=687942 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|NEW CC||ppi...@redhat.com -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1118885] Review Request: gsimplecal - Simple GTK calendar
https://bugzilla.redhat.com/show_bug.cgi?id=1118885 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Assignee|puiterw...@redhat.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 688546] Review Request: doxygenfilter - A Perl-based input filter for doxygen to allow it to be used with Perl files.
https://bugzilla.redhat.com/show_bug.cgi?id=688546 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||ppi...@redhat.com Resolution|--- |WONTFIX Flags||fedora-review- Last Closed||2020-04-22 14:49:22 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1229704] Review Request: truth - The java truth framework
https://bugzilla.redhat.com/show_bug.cgi?id=1229704 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||ppi...@redhat.com Fixed In Version||truth-0.23-2.fc23 Resolution|--- |CURRENTRELEASE Assignee|nob...@fedoraproject.org|mizde...@redhat.com Last Closed||2020-04-22 14:48:06 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1277271] Review Request: rubygem-algorithms - Useful algorithms and data structures for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1277271 Petr Pisar changed: What|Removed |Added Status|NEW |CLOSED CC||ppi...@redhat.com Fixed In Version||rubygem-algorithms-0.6.1-2. ||fc24 Resolution|--- |CURRENTRELEASE Last Closed||2020-04-22 14:45:48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1203501] Review Request: rubygem-async_sinatra - Sinatra plugin to perform asynchronous responses inside of the Sinatra framework
https://bugzilla.redhat.com/show_bug.cgi?id=1203501 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 982302] Review Request: mod_xslt - Dynamic xsl transformations for apache
https://bugzilla.redhat.com/show_bug.cgi?id=982302 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|NEW CC||ppi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818936] Review Request: perl-Mojolicious-Plugin-OpenAPI - OpenAPI / Swagger plugin for Mojolicious
https://bugzilla.redhat.com/show_bug.cgi?id=1818936 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|MODIFIED Fixed In Version||perl-Mojolicious-Plugin-Ope ||nAPI-3.31-2.fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797367] Review Request: perl-File-LoadLines - Loads the contents of a text file into an array of lines
https://bugzilla.redhat.com/show_bug.cgi?id=1797367 Petr Pisar changed: What|Removed |Added Status|MODIFIED|CLOSED Fixed In Version|perl-File-LoadLines-0.02-4. |perl-File-LoadLines-0.02-4. |fc33|fc31 Resolution|--- |ERRATA Last Closed||2020-04-22 14:38:10 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 Bug 1797362 depends on bug 1797367, which changed state. Bug 1797367 Summary: Review Request: perl-File-LoadLines - Loads the contents of a text file into an array of lines https://bugzilla.redhat.com/show_bug.cgi?id=1797367 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797367] Review Request: perl-File-LoadLines - Loads the contents of a text file into an array of lines
https://bugzilla.redhat.com/show_bug.cgi?id=1797367 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|MODIFIED Fixed In Version||perl-File-LoadLines-0.02-4. ||fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper
https://bugzilla.redhat.com/show_bug.cgi?id=1678623 Petr Pisar changed: What|Removed |Added Flags||needinfo?(dridi.boukelmoune ||@gmail.com) --- Comment #11 from Petr Pisar --- Dridi, if you don't write that you want continue in this review, I will close it as a dead one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 921264] Review Request: weatherspect - ASCII art simulation of current weather
https://bugzilla.redhat.com/show_bug.cgi?id=921264 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |WONTFIX Flags|needinfo?(jruzicka@redhat.c | |om) | Last Closed||2020-04-22 14:32:39 --- Comment #4 from Petr Pisar --- No response from the submitter for two years. Closing this review as a death one. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 757657] Review Request: perl-Wx-Scintilla - Scintilla source code editing component for wxWidgets
https://bugzilla.redhat.com/show_bug.cgi?id=757657 Petr Pisar changed: What|Removed |Added Flags||needinfo?(mmaslano@redhat.c ||om) --- Comment #9 from Petr Pisar --- Do you want to continue in the review? If you don't say yeas, I will close this review as a death one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621
--- Comment #5 from Neil Horman ---
Assuming the above are corrected, this is the result of the review:
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License (v2.0)",
"Apache License (v2.0)", "BSD 2-clause "Simplified" License". 159
files have unknown license. Detailed output of licensecheck in
/home/nhorman/review/review-rmd/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception. <= Can't
bundle golang libraries with go get
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config(missingok) /usr/bin/scripts
%config(missingok) /usr/bin/etc
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[!]: Package obeys FHS, except libexecdir and /usr/target. <= /etc in /usr/bin
(see warnings/errors below)
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary. (missing BuildRequires for
build/run : see above)
[x]: Spec file is legible and written in American English.
[!]: Package contains systemd file(s) if in need. <= you probably want to add
a systemd unit to start rmd
[x]: Useful -debuginfo package or justification otherwise.
[!]: Package is not known to require an ExcludeArch tag. <= Not sure why this
isn't buildable on non-x86 arches
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines <= golang bundling issues
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 --- Comment #1 from Artur Iwicki --- Added a textmode build of the game and split the whole thing into several packages. spec: https://svgames.pl/fedora/gearhead1-1.310-2/gearhead1.spec srpm: https://svgames.pl/fedora/gearhead1-1.310-2/gearhead1-1.310-2.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43642023 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #4 from Neil Horman --- This srpm isn't properly constructed in how it builds the application The Makefile makes several targets (specifically deps and build) which calls the included scripts/deps.sh and scripts/build.sh file Those script files run several go get commands to pull in go libraries from their upstream sources which violates the Fedora golang packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_dependencies The deps script needs to not be run. instead of pulling in those golang libraries, they should be added as dependencies in the spec file: go get github.com/Masterminds/glide => BuildRequires: golang-github-masterminds-glide-devel go get github.com/mh-cbon/go-bin-deb => shouldn't be required for Fedora go get github.com/mh-cbon/go-bin-rpm => Shouldn't be required for Fedora since we're already running rpmbuild You also need to include BuildRequires: go-rpm-macros That will autogenerate requirements for you in the completed rpm Note also that your build.sh script uses git to determine the version/revision/branch/go_version variables. When building an SRPM, you won't be working from within a git repo, but from a source tarball. As such those commands will all fail. It may not be fatal, but the resultant binary will not have proper version information built in. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826736] Review Request: php-composer-semver2 - Semver library version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1826736 Remi Collet changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Remi Collet --- Already reviewed as V1, see bug #1268683 Change from v1 to v2 https://git.remirepo.net/cgit/rpms/php/composer/php-composer-semver2.git/commit/?id=5f1b86a6a5aab9dd5907822750080e00d4a5f7d1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826736] New: Review Request: php-composer-semver2 - Semver library version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1826736 Bug ID: 1826736 Summary: Review Request: php-composer-semver2 - Semver library version 2 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://git.remirepo.net/cgit/rpms/php/composer/php-composer-semver2.git/plain/php-composer-semver2.spec?id=5f1b86a6a5aab9dd5907822750080e00d4a5f7d1 SRPM URL: https://rpms.remirepo.net/SRPMS/php-composer-semver2-2.0.0-1.remi.src.rpm Description: parsing and validation. Originally written as part of composer/composer, now extracted and made available as a stand-alone library. Autoloader: /usr/share/php/Composer/Semver2/autoload.php Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821120] Review Request: wlogout - wayland based logout menu
https://bugzilla.redhat.com/show_bug.cgi?id=1821120 --- Comment #11 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wlogout -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826355] Review Request: python-dicttoxml - Simple library to convert a Python dictionary or other native data type into a valid XML string.
https://bugzilla.redhat.com/show_bug.cgi?id=1826355 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-dicttoxml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #3 from Neil Horman --- Spec URL: https://raw.githubusercontent.com/arunprabhu123/rmd/master/rmd.spec SRPM URL: https://github.com/arunprabhu123/rmd/blob/master/rmd-1.0-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 --- Comment #2 from Neil Horman --- I'll start this review today. Just FYI, when we are done, and the package is integrated, I'll add you as a co-maintainer, but I expect that you will be the responsible party for ongoing maintenence and updates, correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 Neil Horman changed: What|Removed |Added CC||nhor...@redhat.com Assignee|nob...@fedoraproject.org|nhor...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 Neil Horman changed: What|Removed |Added Blocks||1531160 CC||krishnan.raghu...@intel.com --- Comment #1 from Neil Horman --- *** Bug 1536230 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1536230] Review Request: rmd - User-space daemon for resource management (RMD)
https://bugzilla.redhat.com/show_bug.cgi?id=1536230 Neil Horman changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed|2019-05-28 19:03:20 |2020-04-22 12:20:49 --- Comment #11 from Neil Horman --- *** This bug has been marked as a duplicate of bug 1826621 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682
--- Comment #49 from l...@mellanox.com ---
Thanks Michal for the comments. Please see my response below.
(In reply to Michal Schmidt from comment #47)
> (In reply to lsun from comment #32)
> > As for the "systemd-units", it appears to be required by koji. I got some
> > failures like below once removed it. So I'll leave it for now (please
> > correct me if I am incorrect).
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=43163313
>
> OK, in that case leaving a BuildRequires there is acceptable.
> Note that the "systemd-units" package was merged into the main "systemd"
> package in 2012 (before Fedora 18). Fedora packaging guidelines removed the
> last reference to "systemd-units" in 2016, keeping "BuildRequires: systemd"
> as the preferred way.
>
> There is another option. You can remove the BR and instead tell your
> configure script to not autodetect the systemd units directory, using:
> %configure --with-systemdsystemunitdir=%{_unitdir}
> The minor advantage of this would be a smaller buildroot.
>
> Use whatever option you prefer there.
Will update in next post and use "BuildRequires: systemd" as suggested.
>
> (In reply to lsun from comment #46)
> > Spec URL:
> > https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.3/rshim.spec
>
> > Requires: psmisc
>
> Why does the rshim.service use killall in the first place? There is:
> > KillMode=process
>
> Why this mode? Do you need child processes to be left running in the cgroup
> after the service is stopped?
> If yes, commenting on it in the unit file would be nice.
It's a copy/paste error. I would like to stop all processes when service stops.
>
> > ExecStop=/usr/bin/killall -SIGKILL rshim
>
> Referencing processes to kill by name is not good. It would kill unrelated
> processes with the same name.
> Is none of systemd's kill modes suitable for stopping the service without
> additional help?
> And why SIGKILL? Does it not stop on SIGTERM?
Will update in next posted version with the following:
- Remove the "Requires: psmisc"
- Remove "ExecStop".
- Use "KillMode=control-group"
- Support SIGTERM
[Service]
Restart=always
Type=forking
ExecStart=-/usr/sbin/rshim $OPTIONS
KillMode=control-group
>
> > Requires: kernel-modules-extra
>
> This is always going to be imperfect, because nothing guarantees that the
> installed package corresponds to the actually running kernel (different
> versions, variants like -debug, custom unpackaged kernels, ...).
> There is precedent for depending on kernel-modules-extra in Fedora packages
> (usbip, xl2tpd, ...) though.
> I would just make it more explicit which module the package needs by instead
> using this:
>
> Requires: kmod(cuse.ko)
> # Hint for dnf to prefer kernel-modules-extra over
> kernel-debug-modules-extra:
> Suggests: kernel-modules-extra
Will update in next posted version as suggested:
Requires: kmod(cuse.ko)
Suggests: kernel-modules-extra
>
>
> BTW, is it necessary to call 'system("modprobe cuse");' in src/rshim.c? I
> would expect the module to get autoloaded during the call to
> cuse_lowlevel_setup.
It seems not loading 'cuse' automatically.
Below is what I got on CentOS-7 when calling cuse_lowlevel_setup() with cuse
not loaded.
"cuse: device not found, try 'modprobe cuse' first".
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748233] Review Request: pgloader - Data loading tool for PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1748233 Lukas Javorsky changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Last Closed||2020-04-22 11:40:03 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748233] Review Request: pgloader - Data loading tool for PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1748233 --- Comment #8 from Lukas Javorsky --- Sorry for late update. Upstream won't change the bundled libraries, so after a talk with msuchy, we've agreed on not to package this one. It would be really difficult to watch every bundle, after every upstream's update. This BZ can be closed now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826326] Review Request: gnome-shell-extension-bubblemail - GNOME Shell indicator for new and unread mail using Bubblemail
https://bugzilla.redhat.com/show_bug.cgi?id=1826326 --- Comment #12 from Alexander Ploumistos --- (In reply to Till Hofmann from comment #11) > > One more comment on this: Please try to avoid Epochs to fix the versioning. > Epochs should only be used as a last ressort. > Instead, you could just fix the versioning downstream (e.g., 0.8.1 instead > of 0.81) should it ever become necessary. I'm well aware, the wording in the guidelines has conditioned me to dread epochs. I was prepared to resort to some hackery with the numbers, but upstream said that they will indeed switch to semantic versioning for both bubblemail and the extension. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 ArunPrabhu Vijayan changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://github.com/arunprabhu123/rmd/blob/master/rmd.spec SRPM URL: https://github.com/arunprabhu123/rmd/blob/master/rmd-1.0-1.fc30.src.rpm Description of problem: Resource Management Daemon (RMD) is a system daemon running on generic Linux platforms. The purpose of this daemon is to provide a central uniform interface portal for hardware resource management tasks on x86 platforms. Fedora Account System Username: avijayan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826621] New: Review Request: RMD - Resource Manager Deamon
https://bugzilla.redhat.com/show_bug.cgi?id=1826621 Bug ID: 1826621 Summary: Review Request: RMD - Resource Manager Deamon Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: arunprabhu.vija...@intel.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://github.com/arunprabhu123/rmd/blob/master/rmd.spec SRPM URL: https://github.com/arunprabhu123/rmd/blob/master/rmd-1.0-1.fc30.src.rpm Description of problem: Resource Management Daemon (RMD) is a system daemon running on generic Linux platforms. The purpose of this daemon is to provide a central uniform interface portal for hardware resource management tasks on x86 platforms. Fedora Account System Username: avijayan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826326] Review Request: gnome-shell-extension-bubblemail - GNOME Shell indicator for new and unread mail using Bubblemail
https://bugzilla.redhat.com/show_bug.cgi?id=1826326 --- Comment #11 from Till Hofmann --- (In reply to Alexander Ploumistos from comment #5) > Well, the only packaged version is the one I am submitting now and hopefully > the next one will be a 1.x release. Upstream has been very cooperative and > we've spent the past weeks debugging Bubblemail together, so I'm fairly > confident they will revise the versioning scheme. Should they get carried > away and publish e.g. a 0.8 release, I will have to resort to an Epoch > directive, or wait for the revision. One more comment on this: Please try to avoid Epochs to fix the versioning. Epochs should only be used as a last ressort. Instead, you could just fix the versioning downstream (e.g., 0.8.1 instead of 0.81) should it ever become necessary. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824467] Review Request: freeopcua - Open Source C++ OPC-UA Server and Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=1824467 --- Comment #12 from Fedora Update System --- FEDORA-2020-bebc4c1ff7 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-bebc4c1ff7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
