[Bug 1795360] Review Request: dhcpd-pools - ISC dhcpd lease analysis and reporting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1795360



--- Comment #20 from Fedora Update System  ---
FEDORA-2020-edc99fcaa0 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830870] Review Request: wdisplays - GUI display configurator for wlroots compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830870



--- Comment #5 from Lyes Saadi  ---
Hi!

Thank you for your quick answer!

Did you forget to add hicolor-icon-theme or is there a reason why you prefer
not adding it?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172



--- Comment #9 from Bob Hepple  ---
Thanks Vasily!

I'll request the repo now etc etc

:-)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831308] Review Request: python-sshtunnel - Pure python SSH tunnels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831308



--- Comment #2 from Itamar Reis Peixoto  ---
https://pagure.io/releng/fedora-scm-requests/issue/24759


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830870] Review Request: wdisplays - GUI display configurator for wlroots compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830870

Bob Hepple  changed:

   What|Removed |Added

  Flags|needinfo?(bob.hepple@gmail. |
   |com)|



--- Comment #4 from Bob Hepple  ---
Thanks Lyes,

The point about desktop-file-install is indeed a surprise. I've implemented
that instead of the patch, as suggested.

I decided to go with the Conflicts: stanza after all. I still feel the urge to
use 'Requires:' but I'll try and study my way clear of that!

SPEC URL:
https://download.copr.fedorainfracloud.org/results/wef/wdisplays/fedora-31-x86_64/01367291-wdisplays/wdisplays.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/wef/wdisplays/fedora-31-x86_64/01367291-wdisplays/wdisplays-0.9-0.3.20200504git0faafdc.fc31.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825560] Review Request: setzer - LaTeX editor written in Python with Gtk

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825560

Lyes Saadi  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Lyes Saadi  ---
Update to 0.2.5

Spec URL: https://lyessaadi.fedorapeople.org/setzer/setzer.spec

SRPM URL: https://lyessaadi.fedorapeople.org/setzer/setzer-0.2.5-1.fc33.src.rpm

Copr Build:
https://copr.fedorainfracloud.org/coprs/lyessaadi/setzer/build/1367253/
Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=4401 (nice
ID, btw)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172



--- Comment #7 from Vasiliy Glazov  ---
You should ask upstream about adding to it changes you maked in patches.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Vasiliy Glazov  ---
Approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Expat License", "NTP License (legal
 disclaimer)". 17 files have unknown license. Detailed output of
 licensecheck in /home/vascom/1821172-wl-gammactl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Sources are verified with gpgverify first in %prep if upstream
 publishes 

[Bug 1831308] Review Request: python-sshtunnel - Pure python SSH tunnels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831308

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||vasc...@gmail.com
   Assignee|nob...@fedoraproject.org|vasc...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830870] Review Request: wdisplays - GUI display configurator for wlroots compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830870

Lyes Saadi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|fed...@lyes.eu
  Flags||fedora-review?
   ||needinfo?(bob.hepple@gmail.
   ||com)



--- Comment #3 from Lyes Saadi  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
===
- Remove the .fc31 and .fc31.wef from the release.
- Add hicolor-icon-theme dependency.
- Use desktop-file-install to modify the spec file. This is, to my own
  surprise, a MUST item. This should work:
  desktop-file-install --remove-key=Version \
  --set-icon=wdisplays \
  --set-key=Terminal --set-value=false \
  --add-category=Settings --add-category=HardwareSettings \
  --dir=%{buildroot}/%{_datadir}/applications \
  %{_target_platform}/resources/com.github.cyclopsian.%{name}.desktop

  « desktop-file-install MUST be used if the package does not install the
  file or there are changes desired to the .desktop file (such as
  add/removing categories, etc). »

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Expat License", "Unknown or generated", "NTP License (legal
 disclaimer)". 21 files have unknown license. Detailed output of
 licensecheck in
 /home/lyes/Documents/reviews/1830870-wdisplays/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
 Note: This will be resolved 
 Note: Dirs in package are owned also by:
 /usr/share/icons/hicolor(kgraphviewer, pdfmod, freedroidrpg, wesnoth-
 data, qmmp, fedora-logos, redeclipse, vacuum-im, massif-visualizer,
 mono-tools, tuxanci, xchm, qtl866, hicolor-icon-theme, android-file-
 transfer, autokey-common, qucs, nedit),
 /usr/share/icons/hicolor/scalable(pdfmod, eom, freedroidrpg, qmmp,
 fedora-logos, keepassx, dxf2gcode, massif-visualizer, tuxanci, qtl866,
 hicolor-icon-theme, autokey-common, qucs, lxqt-powermanagement),
 /usr/share/icons/hicolor/scalable/apps(pdfmod, eom, freedroidrpg,
 qmmp, fedora-logos, keepassx, dxf2gcode, massif-visualizer, tuxanci,
 gtatool-gui, qtl866, hicolor-icon-theme, autokey-common, qucs)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
 Note: Remove the .fc31 and .fc31.wef from the release.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
 Note: Add hicolor-icon-theme.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other 

[Bug 1831308] Review Request: python-sshtunnel - Pure python SSH tunnels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831308

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Vasiliy Glazov  ---
Approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Expat License", "Unknown or generated". 19 files have unknown
 license. Detailed output of licensecheck in
 /home/vascom/1831308-python-sshtunnel/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
 Note: gpgverify is not used.
[x]: Description and summary sections in the package 

[Bug 1795360] Review Request: dhcpd-pools - ISC dhcpd lease analysis and reporting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1795360

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-05-05 03:13:33



--- Comment #19 from Fedora Update System  ---
FEDORA-2020-c3c6deda56 has been pushed to the Fedora 30 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831347] New: Review Request: We10X-icon-theme - Icon theme inspired by Microsoft Windows 10 aesthetic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831347

Bug ID: 1831347
   Summary: Review Request: We10X-icon-theme - Icon theme inspired
by Microsoft Windows 10 aesthetic
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@svgames.pl
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



spec:
https://svgames.pl/fedora/We10X-icon-theme-0-1.20200504git4b95b047/We10X-icon-theme.spec
srpm:
https://svgames.pl/fedora/We10X-icon-theme-0-1.20200504git4b95b047/We10X-icon-theme-0-1.20200504git4b95b047.fc32.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=44107954

Description: We10X is a colorful icon theme reminiscent of the Microsoft
Windows 10 aesthetic. Comes in a regular and dark variant. 

Fedora Account System Username: suve


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172



--- Comment #6 from Bob Hepple  ---
I should have used desktop-file-install ... so here's another build:

SPEC URL:
https://download.copr.fedorainfracloud.org/results/wef/wl-gammactl/fedora-31-x86_64/01367021-wl-gammactl/wl-gammactl.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/wef/wl-gammactl/fedora-31-x86_64/01367021-wl-gammactl/wl-gammactl-0.1-0.4.20200406git611846c.fc31.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830870] Review Request: wdisplays - GUI display configurator for wlroots compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830870



--- Comment #2 from Bob Hepple  ---
Thanks Lyes!

I also removed the . in the release number after 'git' on re-reading the
guidelines.

And I added -q to %setup to stop rpmlint complaining.

Here's the new build:

SPEC URL:
https://download.copr.fedorainfracloud.org/results/wef/wdisplays/fedora-31-x86_64/01367015-wdisplays/wdisplays.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/wef/wdisplays/fedora-31-x86_64/01367015-wdisplays/wdisplays-0.9-0.2.20200504git0faafdc.fc31.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830712] Review Request: kronometer - A simple KDE stopwatch application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830712

Andrea Perotti  changed:

   What|Removed |Added

  Flags||needinfo?(projects.rg@smart
   ||.ms)



--- Comment #4 from Andrea Perotti  ---
Updated according the comments above:

Spec URL:
https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/andreamtp/kronometer/fedora-rawhide-x86_64/01366326-kronometer/kronometer-2.2.3-1.fc33.src.rpm


Kronometer is a stopwatch application. Kronometer is free software and it's
released under the GPLv2 license.
Fedora Account System Username: andreamtp

I was looking for a stopwatch for KDE and found kronometer was missing in
Fedora, so I've packaged.
I've already done some packaging for persona use, but this is my rpm for
Fedora.

COPR builds of the packages:
https://copr.fedorainfracloud.org/coprs/andreamtp/kronometer/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172



--- Comment #5 from Bob Hepple  ---
Thanks Artur & Vasily!

Here's a new build:

SPEC URL:
https://download.copr.fedorainfracloud.org/results/wef/wl-gammactl/fedora-31-x86_64/01367004-wl-gammactl/wl-gammactl.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/wef/wl-gammactl/fedora-31-x86_64/01367004-wl-gammactl/wl-gammactl-0.1-0.3.20200406git611846c.fc31.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1433784] Review Request: nodejs-nodemon - Simple monitor script for use during development of a node.js app

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433784

Zuzana Svetlikova  changed:

   What|Removed |Added

  Flags|needinfo?(zsvetlik@redhat.c |
   |om) |



--- Comment #5 from Zuzana Svetlikova  ---
I'll try to look at it this week.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1433784] Review Request: nodejs-nodemon - Simple monitor script for use during development of a node.js app

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433784

Zuzana Svetlikova  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|zsvet...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830310] Review Request: rust-pipe - Synchronous Read/Write memory pipe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830310



--- Comment #7 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-pipe


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831106] Review Request: rust-readwrite - Combine Read and Write into a single Read+Write object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831106



--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-readwrite


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831106] Review Request: rust-readwrite - Combine Read and Write into a single Read+Write object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831106



--- Comment #5 from Robert Fairley  ---
SCM repo requested: https://pagure.io/releng/fedora-scm-requests/issue/24756


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830310] Review Request: rust-pipe - Synchronous Read/Write memory pipe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830310



--- Comment #6 from Robert Fairley  ---
SCM repo requested: https://pagure.io/releng/fedora-scm-requests/issue/24757


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831106] Review Request: rust-readwrite - Combine Read and Write into a single Read+Write object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831106

Dusty Mabe  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Dusty Mabe  ---
package LGTM


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831106] Review Request: rust-readwrite - Combine Read and Write into a single Read+Write object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831106



--- Comment #3 from Dusty Mabe  ---
> = MUST items =

> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
>  other legal requirements as defined in the legal section of Packaging
>  Guidelines.

PASS: dual license of MIT + Apache

> [ ]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "Unknown or generated", "Expat License". 6 files have unknown
>  license. Detailed output of licensecheck in
>  /home/vagrant/1831106-rust-readwrite/licensecheck.txt

PASS: `License:MIT or ASL 2.0`


> [ ]: License file installed when any subpackage combination is installed.

PASS: all subpackages require main devel package.

> [ ]: If the package is under multiple licenses, the licensing breakdown
>  must be documented in the spec.

Not Applicable: the package is not dual licensed

> [ ]: %build honors applicable compiler flags or justifies otherwise.
> [ ]: Package contains no bundled libraries without FPC exception.
> [ ]: Changelog in prescribed format.
> [ ]: Sources contain only permissible code or content.
> [ ]: Package contains desktop file if it is a GUI application.
> [ ]: Development files must be in a -devel package
> [ ]: Package uses nothing in %doc for runtime.
> [ ]: Package consistently uses macros (instead of hard-coded directory
>  names).
> [ ]: Package is named according to the Package Naming Guidelines.
> [ ]: Package does not generate any conflict.
> [ ]: Package obeys FHS, except libexecdir and /usr/target.
> [ ]: If the package is a rename of another package, proper Obsoletes and
>  Provides are present.
> [ ]: Requires correct, justified where necessary.
> [ ]: Spec file is legible and written in American English.
> [ ]: Package contains systemd file(s) if in need.
> [ ]: Package is not known to require an ExcludeArch tag.
> [ ]: Large documentation must go in a -doc subpackage. Large could be size
>  (~1MB) or number of files.
>  Note: Documentation size is 10240 bytes in 1 files.
> [ ]: Package complies to the Packaging Guidelines


All of the above either pass or are not applicable.


> [x]: Package successfully compiles and builds into binary rpms on at least
>  one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
>  Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
>  license(s) in its own file, then that file, containing the text of the
>  license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package must own all directories that it creates.
> [x]: Package does not own files or directories owned by other packages.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>  beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package must not depend on deprecated() packages.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>  work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
>  provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
>  %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local

> = SHOULD items =

> Generic:
> [ ]: If the source package does not include license text(s) as a separate
>  file from upstream, the packager SHOULD query upstream to include it.

PASS: the files are provided in the toplevel of the repo:
https://github.com/vi/readwrite

> [ ]: Final provides and requires are sane (see attachments).
> [ ]: Fully versioned dependency in subpackages if applicable.
>  Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
>  readwrite-devel , rust-readwrite+default-devel , rust-
>  readwrite+futures-devel , rust-readwrite+tokio-devel , rust-
>  readwrite+tokio-io-devel
> [ ]: Package functions as described.
> [ ]: Latest version is packaged.
> [ ]: Package does not include license text files separate from upstream.
> [ ]: Sources are verified with gpgverify first in %prep if upstream
>  publishes signatures.
>  Note: gpgverify is not used.
> [ ]: Description and summary sections in the package spec file contains
>  translations for supported Non-English languages, if available.
> [ ]: %check 

[Bug 1830310] Review Request: rust-pipe - Synchronous Read/Write memory pipe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830310

Dusty Mabe  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Dusty Mabe  ---
Along with rust-readwrite everything installs now.

Package LGTM.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831106] Review Request: rust-readwrite - Combine Read and Write into a single Read+Write object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831106

Dusty Mabe  changed:

   What|Removed |Added

 CC||dustym...@redhat.com
   Assignee|nob...@fedoraproject.org|dustym...@redhat.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831308] New: Review Request: python-sshtunnel - Pure python SSH tunnels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831308

Bug ID: 1831308
   Summary: Review Request: python-sshtunnel - Pure python SSH
tunnels
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ita...@ispbrasil.com.br
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://itamarjp.fedorapeople.org/review/python-sshtunnel.spec
SRPM URL:
https://itamarjp.fedorapeople.org/review/python-sshtunnel-0.1.5-1.fc32.src.rpm

Description: Pure python SSH tunnels

Fedora Account System Username: itamarjp


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1811775] Review Request: rubygem-semantic_puppet - Useful tools for working with Semantic Versions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1811775



--- Comment #10 from Terje Røsten  ---
Package  rubygem-semantic_puppet is

 APPROVED


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1811775] Review Request: rubygem-semantic_puppet - Useful tools for working with Semantic Versions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1811775

Terje Røsten  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Terje Røsten  ---
Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1811775] Review Request: rubygem-semantic_puppet - Useful tools for working with Semantic Versions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1811775

Terje Røsten  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830870] Review Request: wdisplays - GUI display configurator for wlroots compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830870

Lyes Saadi  changed:

   What|Removed |Added

 CC||fed...@lyes.eu
   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Lyes Saadi  ---
Hi!

> Requires: pkgconfig(wlroots) >= 0.7

This is not needed, the package should work with any Wayland compositor
according to upstream. And that will require wlroots-devel. If you just want to
make sure that the user's wlroots version will be superior to 0.7.0, use
Conflicts instead:

> Conflicts: wlroots < 0.7.0

This is an acceptable usage of conflicts, see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_optional_functionality


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1828101

Lyes Saadi  changed:

   What|Removed |Added

 CC||fed...@lyes.eu



--- Comment #1 from Lyes Saadi  ---
Hi!

This is just a question, not a review, but why aren't the locale files
recompiled (using update-and-compile-translations.sh?) and why isn't there a
%find_lang?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1814682



--- Comment #55 from l...@mellanox.com ---
Michal, thanks for adding me packager group! 

I tried to do "fedpkg request-repo ...", but got rejected. It complained that
this bugzilla hasn't been approved yet.

Do you need to approve this one first? Or any further comments or advice what
the next step would be? 

Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830220] Review Request (Unretiring): tilda - A Gtk based drop down terminal for Linux and Unix

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830220



--- Comment #6 from hannes  ---
Thanks for the quick review, requested the necessary stuff from release
engineering and I hope it will be back in fedora 32 soon. :-)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830220] Review Request (Unretiring): tilda - A Gtk based drop down terminal for Linux and Unix

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830220

Lyes Saadi  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Lyes Saadi  ---
Thank you for that!

Package approved!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1828205



--- Comment #15 from David Cantrell  ---
If a review is already in progress by someone else, please make sure it is ok
to jump in.  I wasted a lot of time today because you had already commented
here.  I assigned the review to myself because I was handling it.

(In reply to Vitaly Zaitsev from comment #14)
> > I needed to do this to name the package doctest-devel. I see that in #6 you 
> > suggest renaming it doctest. Please see comments #1--#3 where this is 
> > discussed. Your recommendation appears to contradict the advice given me by 
> > David Cantrell.
> 
> He gave you the wrong recommendation. The upstream name is doctest, so you
> must use it as the name of package.

I never said to rename the package to 'doctest-devel', I'm not sure where
anyone is getting this.

> The main package will not produce any output, all logic will be moved to
> -devel subpackage.
> 
> Read this:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_packaging_header_only_libraries
> 
> > I believe that without this line, I got an error during "make install". 
> > I'll test with your change and see, but this was only added due to a need 
> > for it.
> 
> Just take my SPEC file. It builds absolutely fine and follow all Fedora
> guidelines.
> 
> > It was my understanding that Ninja is faster for *rebuilds*, not initial 
> > builds. I'll go ahead and run with both and see if the timings are 
> > different.
> 
> Make is a legacy, ancient tool. Ninja is much more better. It has no issues
> with special characters and generate beautiful output.

These comments are subjective and an opinion.  The package maintainer is free
to use tools they prefer.  Many projects offer multiple ways to build and if
the package maintainer wants to use one method of another, that's fine.  The
reviewer can advise on common best practices but the requirement is not that a
packager must use specific tools, but rather that the packaged output conforms
to agreed upon packaging guidelines.

> > I'm using an arched package.
> 
> Good. This line was for the reviewer.

The package in question delivers metadata.  My original understanding was that
this was not architecture specific, but as later discovered it encodes
arch-specific library paths in those files which now makes it arch-specific.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830220] Review Request (Unretiring): tilda - A Gtk based drop down terminal for Linux and Unix

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830220

hannes  changed:

   What|Removed |Added

  Flags|needinfo?(johannes.lips@goo |
   |glemail.com)|



--- Comment #4 from hannes  ---
Ok, did just that and I hope I didn't forget anything. Didn't increase the
release tag, since no proper build occured.

Spec URL: https://hannes.fedorapeople.org/tilda.spec
SRPM URL: https://hannes.fedorapeople.org/tilda-1.5.1-1.fc31.src.rpm

rpmlint tilda.spec 
tilda.spec:24: W: unversioned-explicit-provides bundled(eggaccelerators)
tilda.spec:25: W: unversioned-explicit-provides bundled(xerror)
tilda.spec:27: W: unversioned-explicit-provides bundled(tomboykeybinder)
0 packages and 1 specfiles checked; 0 errors, 3 warnings.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831106] Review Request: rust-readwrite - Combine Read and Write into a single Read+Write object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831106



--- Comment #2 from Robert Fairley  ---
New spec/SRPM for version 0.1.2 which was published, including the license
files.

Spec URL:
https://rfairley.fedorapeople.org/package-review/rust-readwrite/rust-readwrite.spec
SRPM URL:
https://rfairley.fedorapeople.org/package-review/rust-readwrite-0.1.2-1.fc33.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1811775] Review Request: rubygem-semantic_puppet - Useful tools for working with Semantic Versions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1811775



--- Comment #8 from Breno  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01366544-rubygem-semantic_puppet/rubygem-semantic_puppet.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01366544-rubygem-semantic_puppet/rubygem-semantic_puppet-1.0.2-1.el8.src.rpm
Description: Tools used by Puppet to parse, validate, and compare Semantic
Versions and
Version Ranges and to query and resolve module dependencies.
Fedora Account System Username: brandfbb

I've just made some updates in the spec file.

Hi Terje Røsten,

As for the specific rubygem packages' guidelines, it is required to keep the
name as is in the UPSTREAM [1].
I updated the changelog as requested.

Thanks.

1
https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_naming_guidelines


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831106] Review Request: rust-readwrite - Combine Read and Write into a single Read+Write object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831106



--- Comment #1 from Robert Fairley  ---
Sorry for not uploading before, also the patch to the source referenced in the
specfile:
https://rfairley.fedorapeople.org/package-review/0001-Add-LICENSE-files-1.patch


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830310] Review Request: rust-pipe - Synchronous Read/Write memory pipe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830310



--- Comment #4 from Robert Fairley  ---
(In reply to Dusty Mabe from comment #3)
> > Package Review
> > ==
> 
> > Legend:
> > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> > [ ] = Manual review needed
> 
> 
> > Issues:
> > ===
> > - Package installs properly.
> >   Note: Installation errors (see attachment)
> >   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
> 
> Can't install:
> 
> Error: 
>  Problem 1: conflicting requests
>   - nothing provides (crate(readwrite/default) >= 0.1.1 with
> crate(readwrite/default) < 0.2.0) needed by
> rust-pipe+bidirectional-devel-0.2.0-1.fc33.noarch
>  Problem 2: conflicting requests
>   - nothing provides (crate(readwrite/default) >= 0.1.1 with
> crate(readwrite/default) < 0.2.0) needed by
> rust-pipe+readwrite-devel-0.2.0-1.fc33.noarch
> 

Now opened: https://bugzilla.redhat.com/show_bug.cgi?id=1831106
With `rust-readwrite` installed, these two features requiring `readwrite` now
install successfully.

> > - If (and only if) the source package includes the text of the license(s)
> >   in its own file, then that file, containing the text of the license(s)
> >   for the package is included in %license.
> >   Note: License file COPYING is not marked as %license
> >   See: https://docs.fedoraproject.org/en-US/packaging-
> >   guidelines/LicensingGuidelines/#_license_text
> 
> Let's add a `%license` pointing at the  COPYING file.
> 

+1 - `%license COPYING` is now added to the specfile.

> > Rpmlint
> > ---
> > Checking: rust-pipe-devel-0.2.0-1.fc33.noarch.rpm
> >   rust-pipe+default-devel-0.2.0-1.fc33.noarch.rpm
> >   rust-pipe+bidirectional-devel-0.2.0-1.fc33.noarch.rpm
> >   rust-pipe+readwrite-devel-0.2.0-1.fc33.noarch.rpm
> >   rust-pipe+unstable-doc-cfg-devel-0.2.0-1.fc33.noarch.rpm
> >   rust-pipe-0.2.0-1.fc33.src.rpm
> > rust-pipe-devel.noarch: W: invalid-url URL: https://crates.io/crates/pipe 
> > HTTP Error 404: Not Found
> > rust-pipe-devel.noarch: W: hidden-file-or-dir 
> > /usr/share/cargo/registry/pipe-0.2.0/.cargo-checksum.json
> > rust-pipe+default-devel.noarch: W: invalid-url URL: 
> > https://crates.io/crates/pipe HTTP Error 404: Not Found
> > rust-pipe+default-devel.noarch: W: no-documentation
> > rust-pipe+bidirectional-devel.noarch: W: invalid-url URL: 
> > https://crates.io/crates/pipe HTTP Error 404: Not Found
> > rust-pipe+bidirectional-devel.noarch: W: no-documentation
> > rust-pipe+readwrite-devel.noarch: W: spelling-error %description -l en_US 
> > readwrite -> read write, read-write, rewrite
> > rust-pipe+readwrite-devel.noarch: W: invalid-url URL: 
> > https://crates.io/crates/pipe HTTP Error 404: Not Found
> > rust-pipe+readwrite-devel.noarch: W: no-documentation
> > rust-pipe+unstable-doc-cfg-devel.noarch: W: invalid-url URL: 
> > https://crates.io/crates/pipe HTTP Error 404: Not Found
> > rust-pipe+unstable-doc-cfg-devel.noarch: W: no-documentation
> > rust-pipe.src: W: invalid-url URL: https://crates.io/crates/pipe HTTP Error 
> > 404: Not Found
> > 6 packages and 0 specfiles checked; 0 errors, 12 warnings.
> 
> I'm not sure why it's saying https://crates.io/crates/pipe is an invalid URL
> because it's working for me.
> I would ingnore the no-documentation warning.
> I wonder if we can do something about the hidden-file-or-dir warning.

The hidden-file-or-dir warning seems to come up when using the default macros -
I think this could be addressed in
https://src.fedoraproject.org/rpms/rust-srpm-macros (maybe to avoid packaging
the file altogether as it seems to
apply only to vendored rust deps, or exclude it from the hidden-file-or-dir
check). Will take a look into this.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822847] Review Request: vl-gothic-fonts - Japanese TrueType fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822847



--- Comment #5 from Nicolas Mailhot  ---
This review cycle does not reflect reality.

When the review is done as fedora-review+, the rest of the work  is
requester-side, not reviewer-side
When the review is done as fedora-review-, again the fixing work is
requester-side, not reviewer-side

Practically, unless the requester is available to act on the review result at
once, no reviewer is going to commit following the result of the review months
if not years later (yes some of those are *that* old).

Thus, the only state during which it is correct to assign stuff on the
reviewer, is when the reviewer has taken the review but not finished it yet
(fedora-review?). The rest of the time the only person that can make things
move forward is the requester.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831106] New: Review Request: rust-readwrite - Combine Read and Write into a single Read+Write object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831106

Bug ID: 1831106
   Summary: Review Request: rust-readwrite - Combine Read and
Write into a single Read+Write object
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rfair...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://rfairley.fedorapeople.org/package-review/rust-readwrite.spec
SRPM URL:
https://rfairley.fedorapeople.org/package-review/rust-readwrite-0.1.1-1.fc33.src.rpm
Description: Combine Read and Write into a single Read+Write object.
Fedora Account System Username: rfairley

This package is needed to install the `readwrite` and `bidirectional` features
of `rust-pipe`: https://bugzilla.redhat.com/show_bug.cgi?id=1830310

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=44093411


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830220] Review Request (Unretiring): tilda - A Gtk based drop down terminal for Linux and Unix

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830220



--- Comment #3 from Lyes Saadi  ---
Hello!

In this section of the guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling

> All packages whose upstreams have no mechanism to build against system
> libraries MAY opt to carry bundled libraries, but if they do, they MUST
> include an indication of what they bundle. This provides a mechanism for
> locating libraries with bundled code which can, for example, assist in
> locating packages which may have particular security vulnerabilities.
> 
> To indicate an instance of bundling, first determine the name and version of
> the bundled library:
> 
> - If the bundled package also exists separately in the distribution, use the
> name of that package. Otherwise consult the Naming Guidelines to determine an
> appropriate name for the library as if it were entering the distribution as a
> separate package.
> 
> - Use the Versioning Guidelines to determine an appropriate version for the
> library, if possible. If the library has been forked from an upstream, use the
> upstream version that was most recently merged in or rebased onto, or the 
> version
> the original library carried at the time of the fork.
> 
> Then at an appropriate place in your spec, add Provides: bundled() = 
> 
> where  and  are the name and version you determined above. 
> If it
> was not possible to determine a version, use Provides: bundled() 
> instead.
> 
> In addition to indicating bundling in this manner, packages whose upstreams 
> have no
> mechanism to build against system libraries must be contacted publicly about 
> a path to
> supporting system libraries. If upstream refuses, this must be recorded in 
> the spec file,
> either in comments placed adjacent to the Provides: above, or in an 
> additional file
> checked into the SCM and referenced by a comment placed adjacent to the 
> Provides: above.

So, a "Provide" for each bundled libraries and the addition of the MIT License
(tomboykeybinder.c) with a comment indicating the license of each bundled
libraries is enough to get the package approved ;)!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830220] Review Request (Unretiring): tilda - A Gtk based drop down terminal for Linux and Unix

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830220



--- Comment #2 from hannes  ---
Thank you for the review. I've opened an upstream ticket regarding the two
bundled libraries and will follow up on the issue as soon as I get some
answers. If I understand correctly, the bundled libraries are the reason for
the additional MIT license, correct?
I've now also updated the package to the latest version 1.5.1:
Spec URL: https://hannes.fedorapeople.org/tilda.spec
SRPM URL: https://hannes.fedorapeople.org/tilda-1.5.1-1.fc31.src.rpm
Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44090953

And the upstream issue is at https://github.com/lanoxx/tilda/issues/416

Thanks
hannes


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822847] Review Request: vl-gothic-fonts - Japanese TrueType fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822847



--- Comment #4 from Petr Pisar  ---
A review has a life cycle. When someone stars reviewing a package, he should
assign the bug to himself, change the status to assigned and set fedora-review
flag to "?". Once a package is approved, the bug report keeps assigned to the
reviewer and when the submitter builds the package, the submitter closed the
bug or attaches is it to a Bodhi updates so that the bug report gets closed.

Recently, a review status listing
 for updated to reflect and
enforce the review life cycle. So I'm going through a list of reviews in an
inconsistent state and correcting them. My change in the review was exactly one
of the corrections. Nothing particular against this package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831072] New: Review Request: google-auth-httplib2 - An httplib2 transport for google-auth

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831072

Bug ID: 1831072
   Summary: Review Request: google-auth-httplib2 - An httplib2
transport for google-auth
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: gw...@protonmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Description:
httplib has lots of problems such as lack of threadsafety and insecure usage
of TLS. Using it is highly discouraged. This library is intended to help
existing users of oauth2client migrate to google-auth.

SPEC:
https://fedorapeople.org/~limb/review/google-auth-httplib2/google-auth-httplib2.spec
SRPM:
https://fedorapeople.org/~limb/review/google-auth-httplib2/google-auth-httplib2-0.0.3-1.fc32.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831072] Review Request: google-auth-httplib2 - An httplib2 transport for google-auth

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831072

Gwyn Ciesla  changed:

   What|Removed |Added

 Blocks||1670214





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1670214
[Bug 1670214] google-api-python-client-1.8.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1773719

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822847] Review Request: vl-gothic-fonts - Japanese TrueType fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822847



--- Comment #3 from Nicolas Mailhot  ---
Hi Petr,

Do you mean anything particular in changing the assignation of this issue, or
is it a side-effect of the tool you use to add yourself in CC?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1744570] Review Request: pg_repack - PostgreSQL extension which lets you remove bloat from tables and indexes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1744570



--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/pg_repack


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1828205



--- Comment #14 from Vitaly Zaitsev  ---
> I needed to do this to name the package doctest-devel. I see that in #6 you 
> suggest renaming it doctest. Please see comments #1--#3 where this is 
> discussed. Your recommendation appears to contradict the advice given me by 
> David Cantrell.

He gave you the wrong recommendation. The upstream name is doctest, so you must
use it as the name of package.

The main package will not produce any output, all logic will be moved to -devel
subpackage.

Read this:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries

> I believe that without this line, I got an error during "make install". I'll 
> test with your change and see, but this was only added due to a need for it.

Just take my SPEC file. It builds absolutely fine and follow all Fedora
guidelines.

> It was my understanding that Ninja is faster for *rebuilds*, not initial 
> builds. I'll go ahead and run with both and see if the timings are different.

Make is a legacy, ancient tool. Ninja is much more better. It has no issues
with special characters and generate beautiful output.

> I'm using an arched package.

Good. This line was for the reviewer.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #47 from Nick Black  ---
That's what I thought, but
https://admin.fedoraproject.org/accounts/user/view/dcantrell indicates that
you're at "User" level in Fedora Packager GIT Commit Group, and you need to be
"Sponsor" there, right? If I'm misunderstanding, could you defend your sacred
honor at https://pagure.io/releng/fedora-scm-requests/issue/24741?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #46 from David Cantrell  ---
Yes, I am.  I have been for some time.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1825183] Review Request: hanamin-fonts - Japanese Mincho-typeface TrueType font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1825183

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|nicolas.mail...@laposte.net




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1773717] Review Request: golang-github-haproxytech-models - HAProxy Go structs for API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1773717

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1773718] Review Request: golang-github-haproxytech-config-parser - HAProxy configuration parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1773718

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1826621] Review Request: RMD - Resource Manager Deamon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1826621

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821497] Review Request: -

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821497

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|nicolas.mail...@laposte.net




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822847] Review Request: vl-gothic-fonts - Japanese TrueType fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822847

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|nicolas.mail...@laposte.net




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #45 from Nick Black  ---
Hrmm. @dcantrell, you're in the packager group, right? I thought you were (and
https://admin.fedoraproject.org/accounts/user/view/dcantrell?_csrf_token=d323ae14bb4130fa5ae8456ee1aa5c6fa055d492
agrees, AFAICT), but I'm getting pushback:
https://pagure.io/releng/fedora-scm-requests/issue/24741


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1027541] Review Request: cb2bib - A tool for extracting bibliographic reference s

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1027541

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1086378] Review Request: geard - CLI client for installing Docker images as containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1086378
Bug 1086378 depends on bug 1023769, which changed state.

Bug 1023769 Summary: Review Request: golang-github-goerlang-dist - An 
implementation of Erlang node
https://bugzilla.redhat.com/show_bug.cgi?id=1023769

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1023776] Review Request: eclus - An Erlang Port Mapping Daemon service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023776
Bug 1023776 depends on bug 1023769, which changed state.

Bug 1023769 Summary: Review Request: golang-github-goerlang-dist - An 
implementation of Erlang node
https://bugzilla.redhat.com/show_bug.cgi?id=1023769

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(lemen...@gmail.co |
   |m)  |
Last Closed||2020-05-04 13:35:00



--- Comment #7 from Petr Pisar  ---
No response from the submitter in last 4 years. I will close this review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1820850] Review Request: golang-github-jpillora-tld - TLD parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1820850

Jakub Čajka  changed:

   What|Removed |Added

 Blocks||1820915





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1820915
[Bug 1820915] Review Request: bettercap - Tool for 802.11, BLE/Ethernet
reconnaissance and MITM attacks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1820915] Review Request: bettercap - Tool for 802.11, BLE/Ethernet reconnaissance and MITM attacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1820915

Jakub Čajka  changed:

   What|Removed |Added

 Depends On||1820850



--- Comment #5 from Jakub Čajka  ---
FYI I have tried to build the bettercap using the original srpms(and its deps)
and it fails for me on missing libnetfilter_queue-devel(assuming from the build
log and I think it should be pulled in via golang-github-chifflier-nfqueue, but
the devel package doesn't have the requires) and missing package
golang-github-jpillora-tld(added the review in to the dependend BZ, I assume it
got forgotten).



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1820850
[Bug 1820850] Review Request: golang-github-jpillora-tld - TLD parser
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1708161] Review Request: python-testfixtures - A collection of helpers and mock objects for unit tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1708161

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||ppi...@redhat.com
   Assignee|zebo...@gmail.com   |nob...@fedoraproject.org



--- Comment #8 from Petr Pisar  ---
I don't Robert-André does the review. He only posted a comment a year ago and
never responded. I will unassign this bug report and anybody comfortable with
performing the review can do it properly (assign it himself, change the status
to ASSIGNED, and set the fedora-review flag to 
"?").


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822561] Review Request: wget2 - the successor of GNU Wget, a file and recursive website downloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822561

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823319] Review Request: python-django-pglocks - Context managers for advisory locks for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823319

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1773716

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821393] Review Request: pagure-cli - Pagure client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821393

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1047497] Review Request: otcl - MIT Object Tcl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047497

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1744570] Review Request: pg_repack - PostgreSQL extension which lets you remove bloat from tables and indexes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1744570

Matej Mužila  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1828205



--- Comment #13 from Nick Black  ---
Hi Vitaly, thanks for the review!

> Are you still interested in this package? If not, I will take it for myself.

I last commented on it two days ago, and my sponsor has yet to reply. I have
not lost interest in it over the weekend, no.

> > Source2:https://nick-black.com/dankamongmen.gpg
> 1. You cannot use your own GPG signatures. You should verify tarballs
> **only** if upstream provide valid signed tarballs. The doctest upstream
> don't do this => you must not check anything.

Removed both these lines. Removed gnupg from BuildRequires.

> > %setup -q -n doctest-%{version}
> 2. Replace by %autosetup.

I needed to do this to name the package doctest-devel. I see that in #6 you
suggest renaming it doctest. Please see comments #1--#3 where this is
discussed. Your recommendation appears to contradict the advice given me by
David Cantrell.

> > mkdir -p %{buildroot}/%{_docdir}/doctest
> 3. Remove this row and use only %doc directive.

I believe that without this line, I got an error during "make install". I'll
test with your change and see, but this was only added due to a need for it.

> 4. Also I suggest to use ninja instead of legacy makefiles:
> %prep
> %autosetup -p1
> mkdir -p %{_target_platform}
> 
> %build
> pushd %{_target_platform}
> %cmake -G Ninja \
> -DCMAKE_BUILD_TYPE=Release \
> -DDOCTEST_WITH_MAIN_IN_STATIC_LIB:BOOL=OFF \
> -DDOCTEST_WITH_TESTS:BOOL=ON \
> ..
> popd
> %ninja_build -C %{_target_platform}

It was my understanding that Ninja is faster for *rebuilds*, not initial
builds. I'll go ahead and run with both and see if the timings are different.

> 5. Enable tests:
> 
> %check
> pushd %{_target_platform}
> ctest --output-on-failure
> popd

Good call. Done.

> You must use arched package to verify that all tests will pass on all
> architectures.

I'm using an arched package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830933] Review Request: python-masscan - Python module to interact with masscan

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830933

Fabian Affolter  changed:

   What|Removed |Added

 Blocks||563471 (FE-SECLAB)
   Doc Type|--- |If docs needed, set a value





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=563471
[Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830933] New: Review Request: python-masscan - Python module to interact with masscan

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830933

Bug ID: 1830933
   Summary: Review Request: python-masscan - Python module to
interact with masscan
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@fabian-affolter.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-masscan.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-masscan-0.1.6-1.fc31.src.rpm

Project URL: https://github.com/MyKings/python-masscan

Description:
python-masscan is a python library which helps in using masscan port scanner.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=44082782

rpmlint output:
$ rpmlint python-masscan-0.1.6-1.fc31.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint python3-masscan-0.1.6-1.fc31.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Fedora Account System Username: fab


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1828205



--- Comment #12 from Vitaly Zaitsev  ---
> Name:   doctest-devel

6. Name must be doctest.

> Source1:
> https://raw.githubusercontent.com/dankamongmen/fedora-lady/master/%{version}.tar.gz.asc

7. Must be removed as does not belongs to upstream.

> %{gpgverify} --keyring='%{SOURCE2}' --signature='%{SOURCE1}' 
> --data='%{SOURCE0}'

8. Must be removed.

9. Add devel subpackage:

%package devel
Summary: Development files for %{name}
Provides: %{name}-static%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release}
Provides: %{name}%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release}
Requires: libstdc++-devel%{?_isa}

%description devel
%{summary}.

%files devel
%doc README.md CHANGELOG.md CONTRIBUTING.md
%license LICENSE.txt
%{_includedir}/%{name}/
%{_libdir}/cmake/%{name}/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #44 from Nick Black  ---
fedpkg request issued, https://pagure.io/releng/fedora-scm-requests/issue/24741


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1828205

Vitaly Zaitsev  changed:

   What|Removed |Added

 CC||vit...@easycoding.org



--- Comment #11 from Vitaly Zaitsev  ---
Are you still interested in this package? If not, I will take it for myself. I
need this package ASAP to build another as a strict dependency.

> Source2:https://nick-black.com/dankamongmen.gpg

1. You cannot use your own GPG signatures. You should verify tarballs **only**
if upstream provide valid signed tarballs. The doctest upstream don't do this
=> you must not check anything.

> %setup -q -n doctest-%{version}

2. Replace by %autosetup.

> mkdir -p %{buildroot}/%{_docdir}/doctest

3. Remove this row and use only %doc directive.

4. Also I suggest to use ninja instead of legacy makefiles:

%prep
%autosetup -p1
mkdir -p %{_target_platform}

%build
pushd %{_target_platform}
%cmake -G Ninja \
-DCMAKE_BUILD_TYPE=Release \
-DDOCTEST_WITH_MAIN_IN_STATIC_LIB:BOOL=OFF \
-DDOCTEST_WITH_TESTS:BOOL=ON \
..
popd
%ninja_build -C %{_target_platform}

%install
%ninja_install -C %{_target_platform}

Check my SPEC:
https://raw.githubusercontent.com/EasyCoding/doctest/master/doctest.spec

5. Enable tests:

%check
pushd %{_target_platform}
ctest --output-on-failure
popd

> I don't see why cmake can't also read /usr/share/cmake in addition to 
> /usr/lib/cmake but I guess I shouldn't be surprised.

You must use arched package to verify that all tests will pass on all
architectures.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1744570] Review Request: pg_repack - PostgreSQL extension which lets you remove bloat from tables and indexes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1744570

Filip Januš  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172



--- Comment #4 from Artur Iwicki  ---
Oops, sorry, I somehow missed the second comment with new links.

>Release:  0.2.20200406git.%{shortcommit}%{?dist}
Remove the dot between "git" and the commit hash.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

>Patch0:   wl-gammactl-remove-git.patch
The patch name is a bit confusing. Maybe add a comment above that says
something like "don't use git to automatically pull wlr-protocols".


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172

Artur Iwicki  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #3 from Artur Iwicki  ---
Both the spec and the SRPM links give me a 404 Not Found.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1433784] Review Request: nodejs-nodemon - Simple monitor script for use during development of a node.js app

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433784

Honza Horak  changed:

   What|Removed |Added

 CC||jsta...@redhat.com,
   ||zsvet...@redhat.com
  Flags||needinfo?(zsvetlik@redhat.c
   ||om)



--- Comment #4 from Honza Horak  ---
Zuzka, Jan, would anybody from you be so kind and do a review for this? It's
really bad that we ship nodemon in RHEL and not have it in Fedora.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1433784] Review Request: nodejs-nodemon - Simple monitor script for use during development of a node.js app

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433784

Honza Horak  changed:

   What|Removed |Added

  Flags||needinfo?(jsta...@redhat.co
   ||m)




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #2 from Vasiliy Glazov  ---
You should add desktop file.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172

Vasiliy Glazov  changed:

   What|Removed |Added

 CC||vasc...@gmail.com
   Assignee|nob...@fedoraproject.org|vasc...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1828813



--- Comment #27 from Fedora Update System  ---
FEDORA-2020-d59e8c5198 has been pushed to the Fedora 30 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing
--advisory=FEDORA-2020-d59e8c5198`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-d59e8c5198

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830870] New: Review Request: wdisplays - GUI display configurator for wlroots compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830870

Bug ID: 1830870
   Summary: Review Request: wdisplays - GUI display configurator
for wlroots compositors
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: bob.hep...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://download.copr.fedorainfracloud.org/results/wef/wdisplays/fedora-31-x86_64/01366107-wdisplays/wdisplays.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/wef/wdisplays/fedora-31-x86_64/01366107-wdisplays/wdisplays-0.9-0.1.20200504git.0faafdc.fc31.src.rpm
Description: 

wdisplays is a graphical application for configuring displays in
Wayland compositors. It borrows some code from kanshi. It should work
in any compositor that implements the
wlr-output-management-unstable-v1 protocol, including sway. The goal
of this project is to allow precise adjustment of display settings in
kiosks, digital signage, and other elaborate multi-monitor setups.

Fedora Account System Username: wef


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823599



--- Comment #26 from Bob Hepple  ---
Thanks everyone!!

I've kicked off the un-retire process.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org