[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #48 from Nick Black --- Just refreshing this bug -- @dcantrell still appears to be "User" rather than "Sponsor", but I understand that he's initiated the promo process. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827887] Review Request: mingw-biblesync - A Cross-platform library for sharing Bible navigation
https://bugzilla.redhat.com/show_bug.cgi?id=1827887 --- Comment #14 from Fedora Update System --- FEDORA-2020-d752e3b411 has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825681] Review Request: create-fake-rpm - Generate fake (S)RPM
https://bugzilla.redhat.com/show_bug.cgi?id=1825681 --- Comment #22 from Fedora Update System --- FEDORA-2020-94b86b8f5b has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827887] Review Request: mingw-biblesync - A Cross-platform library for sharing Bible navigation
https://bugzilla.redhat.com/show_bug.cgi?id=1827887 --- Comment #13 from Fedora Update System --- FEDORA-2020-d80df47a6f has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825681] Review Request: create-fake-rpm - Generate fake (S)RPM
https://bugzilla.redhat.com/show_bug.cgi?id=1825681 --- Comment #21 from Fedora Update System --- FEDORA-2020-9d5dfb64d6 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 --- Comment #26 from Fedora Update System --- FEDORA-2020-28f36b7cca has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827948] Review Request: python-spyking-circus - Fast and scalable spike sorting of large-scale extracellular recordings
https://bugzilla.redhat.com/show_bug.cgi?id=1827948 --- Comment #15 from Fedora Update System --- FEDORA-2020-f7314234a8 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831981] New: Review Request: xdg-desktop-portal-wlr - xdg-desktop-portal backend for wlroots
https://bugzilla.redhat.com/show_bug.cgi?id=1831981 Bug ID: 1831981 Summary: Review Request: xdg-desktop-portal-wlr - xdg-desktop-portal backend for wlroots Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: alebast...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01368037-xdg-desktop-portal-wlr/xdg-desktop-portal-wlr.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01368037-xdg-desktop-portal-wlr/xdg-desktop-portal-wlr-0.1.0-0.1.fc33.src.rpm COPR URL: https://copr.fedorainfracloud.org/coprs/alebastr/sway-extras/ Description: xdg-desktop-portal backend for wlroots. This project seeks to add support for the screenshot, screencast, and possibly remote-desktop xdg-desktop-portal interfaces for wlroots based compositors. Fedora Account System Username: alebastr As usual, Release will be set to 1 for dist-git import. I'm keeping it at 0.x to make upgrade from copr to official package painless. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827887] Review Request: mingw-biblesync - A Cross-platform library for sharing Bible navigation
https://bugzilla.redhat.com/show_bug.cgi?id=1827887 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-06 03:07:33 --- Comment #12 from Fedora Update System --- FEDORA-2020-3c66ece950 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825681] Review Request: create-fake-rpm - Generate fake (S)RPM
https://bugzilla.redhat.com/show_bug.cgi?id=1825681 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-06 03:07:29 --- Comment #20 from Fedora Update System --- FEDORA-2020-d8c9d1d028 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826950] Review Request: python-jsonfield - is a reusable model field that allows you to store validated JSON, automatically handling serialization to and from the database.
https://bugzilla.redhat.com/show_bug.cgi?id=1826950 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-06 03:07:34 --- Comment #25 from Fedora Update System --- FEDORA-2020-120aea1636 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827948] Review Request: python-spyking-circus - Fast and scalable spike sorting of large-scale extracellular recordings
https://bugzilla.redhat.com/show_bug.cgi?id=1827948 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-06 03:07:25 --- Comment #14 from Fedora Update System --- FEDORA-2020-14db45aad6 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827901] Review Request: zswap-cli - Command-line tool to control zswap options
https://bugzilla.redhat.com/show_bug.cgi?id=1827901 --- Comment #7 from Fedora Update System --- FEDORA-2020-75d218e536 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1821172 --- Comment #14 from Fedora Update System --- FEDORA-2020-4875486129 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-4875486129 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4875486129 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree
https://bugzilla.redhat.com/show_bug.cgi?id=1823599 --- Comment #30 from Fedora Update System --- FEDORA-2020-e75c278601 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e75c278601 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e75c278601 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822509] Review Request: lavalauncher - a simple launcher for Wayland
https://bugzilla.redhat.com/show_bug.cgi?id=1822509
Lyes Saadi changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags||fedora-review+
--- Comment #5 from Lyes Saadi ---
Package approved, on the first try! Sorry again for my error...
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Please add a comment explaining why there shouldn't be a desktop file.
- 1.7.0 is released.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "NTP License (legal disclaimer)", "GPL
(v3)". 8 files have unknown license. Detailed output of licensecheck
in /home/lyes/Documents/reviews/1822509-lavalauncher/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
Note: Should not in this case. Please add a comment explaining why.
Note: This entry is also misleading -_-'.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
Note: 1.7.0 released.
[x]: Package does not include license text files separate from upstream.
[Bug 1822509] Review Request: lavalauncher - a simple launcher for Wayland
https://bugzilla.redhat.com/show_bug.cgi?id=1822509 Lyes Saadi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|fed...@lyes.eu --- Comment #4 from Lyes Saadi --- Hi, Bob! Read my last comment, it was an error on my part, sorry again for that -_-'! fedora-review had a misleading entry, and I didn't check enough before sending the comment... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree
https://bugzilla.redhat.com/show_bug.cgi?id=1823599 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #29 from Fedora Update System --- FEDORA-2020-19e53d3ab0 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-19e53d3ab0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-19e53d3ab0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1821172 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2020-9ffbca5825 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9ffbca5825 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9ffbca5825 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831308] Review Request: python-sshtunnel - Pure python SSH tunnels
https://bugzilla.redhat.com/show_bug.cgi?id=1831308 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2020-7029a187e9 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-7029a187e9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7029a187e9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822509] Review Request: lavalauncher - a simple launcher for Wayland
https://bugzilla.redhat.com/show_bug.cgi?id=1822509 --- Comment #3 from Bob Hepple --- Hi Lyes, I agree, there is no point having a .desktop file as it relies completely on command line options to operate eg lavalauncher -b /usr/share/icons/hicolor/scalable/apps/org.gnome.Terminal.svg gnome-terminal -b ... We could _force_ it to use a .desktop file like xfce4-appfinder's with something like this: [Desktop Entry] Version=1.0 Exec=lavalauncher-wrapper StartupNotify=true Terminal=false Type=Application Categories=Utility; Name=Application Finder and script up lavalauncher-wrapper to look for configurations in the first of: ~/.config/lavalauncher/config /etc/lavalauncher/config with the latter provided by the package then run it with lavalauncher $(cat $CONFIG_FILE) ... at least it would avoid going to the committee. But honestly, I have no idea what to put in the /etc config file to be universally useful and I think it's properly against the point of lavalauncher. And just because I _can_ do that does not mean that I _should_ do it!!! There are precedents for this - eg rofi and wofi etc are GUI applications (also application launchers) but do not have .desktop files. zenity too. On balance, I agree with you and I definitely do not want to put a desktop file in there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 --- Comment #58 from l...@mellanox.com --- [lsun@fedora ~]$ fedpkg -v request-repo rshim 1814682 https://pagure.io/releng/fedora-scm-requests/issue/24793 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 --- Comment #57 from l...@mellanox.com --- This was the issue that was rejected. https://pagure.io/releng/fedora-scm-requests/issue/24679 It said "The review is not approved by the assignee of the Bugzilla bug". I just submitted a new request: https://pagure.io/releng/fedora-scm-requests/issue/24793 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822509] Review Request: lavalauncher - a simple launcher for Wayland
https://bugzilla.redhat.com/show_bug.cgi?id=1822509
--- Comment #2 from Lyes Saadi ---
Wait!
After more reading, that is actually not needed, sorry for the error, a comment
is enough:
> MUST: Packages containing GUI applications must include a %{name}.desktop
> file, and that file must be properly installed with desktop-file-install in
> the %install section. If you feel that your packaged GUI application does not
> need a .desktop file, you must put a comment in the spec file with your
> explanation.
The Guidelines could have been clearer on that.
Sorry again, I will procede to the review as soon as I finish the form :)!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822509] Review Request: lavalauncher - a simple launcher for Wayland
https://bugzilla.redhat.com/show_bug.cgi?id=1822509 Lyes Saadi changed: What|Removed |Added CC||fed...@lyes.eu Doc Type|--- |If docs needed, set a value --- Comment #1 from Lyes Saadi --- Hi Bob! Yes, I also think about reviewing this package :P! But I stumbled upon a weird rule (Yes! Another time :P!): > If a package contains a GUI application, then it needs to also include a > properly installed .desktop file. For the purposes of these guidelines, a GUI > application is defined as any application which draws an X window and runs > from within that window. (Yes it says X window, but I imagine it also applies to a Wayland window :P) I am a bit confused by this and I shouldn't think a desktop file should be added... for the obvious reason that lavalauncher needs arguments to be passed so it works. So I got back to the beginnings of the Guidelines: > The Packaging Guidelines are a collection of common issues and the severity > that should be placed on them. While these guidelines should not be ignored, > they should also not be blindly followed. If you think that your package > should > be exempt from part of the Guidelines, please bring the issue to the Fedora > Packaging Committee[1]. > Where the language "must", "is required to" or "needs to" is used, the > packager > may deviate from the guideline only with approval from the packaging > committee. > Please follow the procedure at the Packaging Committee[2] page for making > these > requests. [1]: https://pagure.io/packaging-committee [2]: https://fedoraproject.org/wiki/Packaging_Committee#Bringing_Issues_to_the_Committee So, what do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1821172 --- Comment #12 from Fedora Update System --- FEDORA-2020-9ffbca5825 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9ffbca5825 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1821172 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #11 from Fedora Update System --- FEDORA-2020-4875486129 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4875486129 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree
https://bugzilla.redhat.com/show_bug.cgi?id=1823599 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #27 from Fedora Update System --- FEDORA-2020-19e53d3ab0 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-19e53d3ab0 --- Comment #28 from Fedora Update System --- FEDORA-2020-e75c278601 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e75c278601 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821393] Review Request: pagure-cli - Pagure client
https://bugzilla.redhat.com/show_bug.cgi?id=1821393 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Neal Gompa --- Review notes: Package was generated by cabal-rpm, simplifying the review considerably. * Package is named appropriately * Package follows packaging guidelines * Package follows Haskell guidelines * Package builds and installs * No serious issues from rpmlint * Changelog entry is not a real person - Please fix this on import PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1678619] Review Request: config - The GNU config.guess and config.sub scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1678619 Dridi Boukelmoune changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Last Closed||2020-05-05 21:32:15 --- Comment #5 from Dridi Boukelmoune --- As suggested by Neal, one could instead make the redhat-rpm-config symlink those files where dpkg tooling is expecting them. I think it was needed by dpkg's support for autotools-based projects but I unfortunately no longer have the bandwidth to work on this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1678626] Review Request: sbuild - Tool for building Debian binary packages from Debian sources
https://bugzilla.redhat.com/show_bug.cgi?id=1678626 Dridi Boukelmoune changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Last Closed||2020-05-05 21:29:11 --- Comment #3 from Dridi Boukelmoune --- I unfortunately no longer have the bandwidth to work on sbuild. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1615641] Review Request: compliance-masonry - Security Documentation Builder
https://bugzilla.redhat.com/show_bug.cgi?id=1615641 PnT Account Manager changed: What|Removed |Added Assignee|swe...@redhat.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818945] Review Request: lib3mf - Implementation of the 3D Manufacturing Format file standard
https://bugzilla.redhat.com/show_bug.cgi?id=1818945 --- Comment #9 from Fedora Update System --- FEDORA-2020-6e5fe0249d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5fe0249d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819148] Review Request: act - Automatic Component Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1819148 --- Comment #9 from Fedora Update System --- FEDORA-2020-6e5fe0249d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6e5fe0249d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205 --- Comment #17 from David Cantrell --- (In reply to Vitaly Zaitsev from comment #16) > > If a review is already in progress by someone else, please make sure it is > > ok to jump in. I wasted a lot of time today because you had already > > commented here. I assigned the review to myself because I was handling it. > > I'm not taking this review to myself. Sorry about this. I just need this > package in repositories ASAP. Understood. I am working through this with the packager as quickly as possible. The packager is also a new Fedora contributor, so we are also working through the various Fedora processes and such. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 Jun Aruga changed: What|Removed |Added Status|NEW |MODIFIED Fixed In Version||bowtie2-2.4.1-1.fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819148] Review Request: act - Automatic Component Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1819148 --- Comment #8 from Fedora Update System --- FEDORA-EPEL-2020-6ecb9adca3 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6ecb9adca3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818945] Review Request: lib3mf - Implementation of the 3D Manufacturing Format file standard
https://bugzilla.redhat.com/show_bug.cgi?id=1818945 --- Comment #8 from Fedora Update System --- FEDORA-EPEL-2020-6ecb9adca3 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6ecb9adca3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 --- Comment #13 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/bowtie2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 --- Comment #12 from Jun Aruga --- Hi David, Thanks for your review! I removed the 'Requires: python3', and update above Spec and SRPM URLs, and confirmed the /usr/bin/python3 requirement is still exists. ``` sh-5.0# rpm -qR bowtie2 /usr/bin/perl /usr/bin/python3 ``` You might have to change this ticket's status from NEW to POST or ASSIGNED for the repository to be created. Now I am requesting bowtie2 dist-git repository. And we will see the result. ``` $ fedpkg request-repo bowtie2 1824348 https://pagure.io/releng/fedora-scm-requests/issue/24782 ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819148] Review Request: act - Automatic Component Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1819148 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-EPEL-2020-6ecb9adca3 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6ecb9adca3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818945] Review Request: lib3mf - Implementation of the 3D Manufacturing Format file standard
https://bugzilla.redhat.com/show_bug.cgi?id=1818945 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-EPEL-2020-6ecb9adca3 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6ecb9adca3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818945] Review Request: lib3mf - Implementation of the 3D Manufacturing Format file standard
https://bugzilla.redhat.com/show_bug.cgi?id=1818945 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/lib3mf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819148] Review Request: act - Automatic Component Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1819148 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/act -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818945] Review Request: lib3mf - Implementation of the 3D Manufacturing Format file standard
https://bugzilla.redhat.com/show_bug.cgi?id=1818945
Dennis Gilmore changed:
What|Removed |Added
CC||dgilm...@redhat.com
Assignee|nob...@fedoraproject.org|dgilm...@redhat.com
Flags||fedora-review+
--- Comment #5 from Dennis Gilmore ---
Approved
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if
[Bug 1813957] Review Request: python-APScheduler - In-process task scheduler with Cron-like capabilities
https://bugzilla.redhat.com/show_bug.cgi?id=1813957 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-05 13:46:25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812905] Review Request: python-fb-re2 - python-fb-re2 is a Python extension that wraps Google's RE2 regular
https://bugzilla.redhat.com/show_bug.cgi?id=1812905 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-05 13:45:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812857] Review Request: python-ws4py - WebSocket client and server library
https://bugzilla.redhat.com/show_bug.cgi?id=1812857 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-05 13:45:25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812124] Review Request: python-sphinxcontrib-openapi - OpenAPI spec renderer for Sphinx
https://bugzilla.redhat.com/show_bug.cgi?id=1812124 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-05 13:45:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819148] Review Request: act - Automatic Component Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1819148
Dennis Gilmore changed:
What|Removed |Added
CC||dgilm...@redhat.com
Assignee|nob...@fedoraproject.org|dgilm...@redhat.com
Flags||fedora-review+
--- Comment #5 from Dennis Gilmore ---
Approved
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]:
[Bug 1831308] Review Request: python-sshtunnel - Pure python SSH tunnels
https://bugzilla.redhat.com/show_bug.cgi?id=1831308 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-7029a187e9 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7029a187e9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830870] Review Request: wdisplays - GUI display configurator for wlroots compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1830870
Lyes Saadi changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #7 from Lyes Saadi ---
Package approved :D!
Sorry for my late answer, I was sleeping...
Just for good form (as some element weren't evaluated, as I was waiting for
others to be fixed in order to pass):
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Expat License", "Unknown or generated", "NTP License (legal
disclaimer)". 21 files have unknown license. Detailed output of
licensecheck in
/home/lyes/Documents/reviews/1830870-wdisplays/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: hicolor-icon-theme is required.
Note: Dirs in package are owned also by:
/usr/share/icons/hicolor(fedora-logos, autokey-common, mono-tools,
massif-visualizer, tuxanci, pdfmod, freedroidrpg, android-file-
transfer, vacuum-im, kgraphviewer, qtl866, redeclipse, qucs, xchm,
hicolor-icon-theme, qmmp, nedit, wesnoth-data),
/usr/share/icons/hicolor/scalable(fedora-logos, autokey-common, eom,
dxf2gcode, lxqt-powermanagement, massif-visualizer, keepassx, tuxanci,
freedroidrpg, qtl866, qucs, hicolor-icon-theme, qmmp, pdfmod),
/usr/share/icons/hicolor/scalable/apps(fedora-logos, autokey-common,
eom, dxf2gcode, massif-visualizer, tuxanci, keepassx, freedroidrpg,
gtatool-gui, qtl866, qucs, hicolor-icon-theme, qmmp, pdfmod)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 --- Comment #56 from Michal Schmidt --- The "fedora-review" flag is already set to "+" and it should be the only flag that matters for this purpose. Please try again, double-check that the Bugzilla number is correct. If it still does not work, try it with verbose output and paste here the output: fedpkg -v request-repo rshim 1814682 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830086] Review Request: git-pw - Git-Patchwork integration tool
https://bugzilla.redhat.com/show_bug.cgi?id=1830086 --- Comment #2 from Stephen Finucane --- Thanks. Updated version pushed. https://raw.githubusercontent.com/getpatchwork/git-pw/master/rpm/git-pw.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813648] Review Request: golang-github-saracen-walker - Walker is a faster, parallel version, of filepath.Walk
https://bugzilla.redhat.com/show_bug.cgi?id=1813648 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-saracen-walker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1821172 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wl-gammactl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831308] Review Request: python-sshtunnel - Pure python SSH tunnels
https://bugzilla.redhat.com/show_bug.cgi?id=1831308 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sshtunnel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831602] New: Review Request: spectrographic - Turn an image into sound
https://bugzilla.redhat.com/show_bug.cgi?id=1831602 Bug ID: 1831602 Summary: Review Request: spectrographic - Turn an image into sound Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@svgames.pl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora spec: https://svgames.pl/fedora/spectrographic-0.9.3-1/spectrographic.spec srpm: https://svgames.pl/fedora/spectrographic-0.9.3-1/spectrographic-0.9.3-1.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=44116124 Description: A tool that allows to uurn any image into a sound whose spectrogram looks like the original image. Fedora Account System Username: suve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830712] Review Request: kronometer - A simple KDE stopwatch application
https://bugzilla.redhat.com/show_bug.cgi?id=1830712 Raphael Groner changed: What|Removed |Added Flags|needinfo?(projects.rg@smart | |.ms)| --- Comment #5 from Raphael Groner --- As I'm asked, I can't sponsor you because I'm not in the sponsors group. You need to look for another mentor with the relevant responsibilities. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] New: Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 Bug ID: 1831578 Summary: Review Request: luv-icon-theme - Flat, but complex, icon theme Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@svgames.pl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora spec: https://svgames.pl/fedora/luv-icon-theme-0.4.9.31-1.20200504git6f0fb464/luv-icon-theme.spec srpm: https://svgames.pl/fedora/luv-icon-theme-0.4.9.31-1.20200504git6f0fb464/luv-icon-theme-0.4.9.31-1.20200504git6f0fb464.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=44115739 Description: Lüv is the spiritual successor to Flattr, a flat but complex icon theme. It also comes with 6 different wallpapers to use alongside the icons. Fedora Account System Username: suve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816301] Review Request: openfoam - computational fluid dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=1816301
--- Comment #16 from david08...@gmail.com ---
Why would put them in /usr/lib/openfoam, rather then in /usr/lib/?
That would be much nicer, imho, as if you only have one openfoam, it is not
unnecessarily one level deeper.
Besides that, you MUST not install in /usr/lib. Header files need to go to
%{_includedir}/openfoamVER, libs go to %{_libdir}/openfoamVER etc.
See [1] for the specific directories.
If you want to put them in openfoam/openfoamVER/ rather then directly
openfoamVER, then there are two options, create a package openfoam-filesystyem
that owns the shared openfoam/ directories.
The other one is co-owning, as you mentioned. See [2] for more on directory
ownership.
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/
[2]
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205 --- Comment #16 from Vitaly Zaitsev --- > If a review is already in progress by someone else, please make sure it is ok > to jump in. I wasted a lot of time today because you had already commented > here. I assigned the review to myself because I was handling it. I'm not taking this review to myself. Sorry about this. I just need this package in repositories ASAP. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1795360] Review Request: dhcpd-pools - ISC dhcpd lease analysis and reporting
https://bugzilla.redhat.com/show_bug.cgi?id=1795360 --- Comment #21 from Fedora Update System --- FEDORA-2020-a7ab46634f has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 david08...@gmail.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #11 from david08...@gmail.com --- There is still an explicit 'Requires: python3' in line 16. This isn't needed, rpm automagically adds a requirement for /usr/bin/python3. Sorry, I should have copied it to the beginning. However, this is only a minor issue, so package is approved. Don't forget to open bugz for the excluded arches, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830870] Review Request: wdisplays - GUI display configurator for wlroots compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1830870 --- Comment #6 from Bob Hepple --- Hrmph! Excessive haste on my behalf, sorry about that! SPEC URL: https://download.copr.fedorainfracloud.org/results/wef/wdisplays/fedora-31-x86_64/01367381-wdisplays/wdisplays.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/wdisplays/fedora-31-x86_64/01367381-wdisplays/wdisplays-0.9-0.4.20200504git0faafdc.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
