[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744

Mathieu Bridon  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-01-15 16:40:40



--- Comment #9 from Mathieu Bridon  ---
Package built in Rawhide and Fedora 25, closing.

Thanks Haikel for the review, and Jon for the admin process!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-resumable-urlretrieve

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Haïkel Guémar  ---
Please request upstream to add license file in tarball for next releases.
Package approved.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 15 files have unknown license. Detailed
 output of licensecheck in /home/hguemar/1302744-python-resumable-
 urlretrieve/licensecheck.txt
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.6/site-packages,
 /usr/lib/python3.6
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python3-resumable-urlretrieve (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744



--- Comment #6 from Mathieu Bridon  ---
Port is now randomized in the latest upstream release, here's the new package.

Spec URL:
https://bochecha.fedorapeople.org/packages/python-resumable-urlretrieve.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-resumable-urlretrieve-0.1.3-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744



--- Comment #5 from Haïkel Guémar  ---
Used port is PORT + 1, so 8001 according code.
8001 is used on my local machine by weechat but it'd better to randomize port
(and check if it's unused before running tests)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744



--- Comment #4 from Haïkel Guémar  ---
Tests fails in mock as it tries to bind a socket already in use, if you silence
them, build's ok. 
Failing test is test_norange

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744
Bug 1302744 depends on bug 1385223, which changed state.

Bug 1385223 Summary: Review Request: python-rangehttpserver - SimpleHTTPServer 
with support for Range requests
https://bugzilla.redhat.com/show_bug.cgi?id=1385223

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744

Haïkel Guémar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||karlthe...@gmail.com
   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744

Mathieu Bridon  changed:

   What|Removed |Added

 Blocks||1385237




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385237
[Bug 1385237] Review Request: python-pythonz-bd - Manage python
installations in your system
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744



--- Comment #3 from Mathieu Bridon  ---
Here's a new version of the package for review, now that python-rangehttpserver
has been approved.

Spec URL:
https://bochecha.fedorapeople.org/packages/python-resumable-urlretrieve.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-resumable-urlretrieve-0.1.2-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744

Mathieu Bridon  changed:

   What|Removed |Added

 Depends On||1385223




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385223
[Bug 1385223] Review Request: python-rangehttpserver - SimpleHTTPServer
with support for Range requests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744



--- Comment #1 from Mathieu Bridon  ---
As hguemar found on IRC, the Spec URL had a typo, here's the correct info.

---

Spec URL:
https://bochecha.fedorapeople.org/packages/python-resumable-urlretrieve.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-resumable-urlretrieve-0.1.1-1.fc23.src.rpm

Description:
Small library to fetch files over HTTP and resuming their download.

Fedora Account System Username: bochecha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744



--- Comment #2 from Mathieu Bridon  ---
hguemar found we seem to be missing a few requirements here, the
requirements.txt file contains:

  requests==2.7.0
  py==1.4.30
  pytest==2.7.3
 
https://github.com/danvk/RangeHTTPServer/tarball/ebb5c5d7af44b3279bdd4b57ddf3093eec3e8794#egg=rangehttpserver
 
https://github.com/JukkaL/mypy/tarball/dcff596be878798fbd43af7b50d95c3eed7ebbc1#egg=mypy-lang

The first one, requests, is already a Requires/BuildRequires in the spec file,
though I didn't specify the version.

The next one, py, is not used at all. It is a dependency of pytest though,
which makes me think this requirements.txt file was generated with "pip
freeze", rather than carefully curated by the author. Which means the versioned
dependencies are probably "whatever was in the virtualenv" rather that trueliy
required versions.

The next one, pytest, is required for the unit tests. As such, I should
definitely add it as a BuildRequires.

And the last one, mypy, is the typing thing from Python 3.5, for older Python
versions. Since I'm only planning on pushing this package in Rawhide, which has
Python 3.5, then this dependency is unnecessary.

Finally, there is the case of rangehttpserver, which is required for the tests,
and therefore should be a BuildRequires.

In summary, I need to add to this package:

  BuildRequires: python3-pytest
  BuildRequires: python3-rangehttpserver

And then change %check to be:

  %check
  py.test-3

I'm going to submit a new Spec/SRPM that does just that.

Unfortunately, rangehttpserver isn't in Fedora yet, so I'll need to submit a
new review request for it.

And in addition, it is not compatible with Python 3 yet:
https://github.com/danvk/RangeHTTPServer/pull/12

So I guess we can leave this review request for the time being, until I get it
all settled.

Sorry for the trouble, and thanks hguemar for the quick comments on IRC!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review