https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Dennis Chen changed:
What|Removed |Added
Blocks||177841 (FE-NEEDSPONSOR)
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
--- Comment #78 from
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |MODIFIED
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #77 from Fedora Update System ---
swift-lang-4.2-0.32.20180703git107e307.fc28 has been submitted as an update to
Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a6771080d7
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
--- Comment #76 from
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #75 from Fedora Update System ---
swift-lang-4.2-0.30.20180709gitd9561d9.fc28 has been submitted as an update to
Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0ef0cca109
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED|MODIFIED
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #74 from Mohan Boddu ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/swift-lang
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Tom Stellard changed:
What|Removed |Added
Assignee|hobbes1...@gmail.com|tstel...@redhat.com
--- Comment #73
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #72 from Ron Olson ---
Hey Tom, Mohan in #fedora-releng asked if you would explicitly acknowledge
you're okay with this review:
[10:33:35] <+mboddu> tachoknight: I hit "The review is not approved by
the assignee of the Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Tom Stellard changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #71 from
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #70 from Ron Olson ---
Made a new build from the July 5th sources. If it complicates things at this
point I'll hold off on any new builds.
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #69 from Ron Olson ---
Okay, I fixed the issues. Thanks for reviewing this Tom, I feel like I've
learned a lot and I think the package is far better than when we started.
Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #68 from Tom Stellard ---
Below is the full review report. I've listed two items in the issues section
that should be fixed before this request gets approved, but otherwise this
package looks good.
Package Review
==
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #67 from Ron Olson ---
I checked the regex and your change seems to do the trick, thanks!
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.27.20180704gitf56a941.fc28.src.rpm for Fedora 28:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #66 from Tom Stellard ---
The lldb shared objects are versioned e.g. liblldb.so.6.0.0, so the regex you
are using to filter the provides does not match them. I think you can fix this
by dropping the $ or by adding .* after so.
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #65 from Ron Olson ---
Okay, the Swift run-time libs are in their own package, removed the 'which'
buildrequires, and filtered the lldb libraries.
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #64 from Tom Stellard ---
This looks better now. Just a few more things that the fedora-review tool
caught:
- Drop BuildRequires: which
-+ Filter Provdes for liblldb*
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #63 from Ron Olson ---
Whoops, sorry about that. Fixed now.
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.25.20180702gitc2e1567.fc28.src.rpm for Fedora 28:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #62 from Tom Stellard ---
There are still headers in /usr/include/lldb with the latest build, can you
remove these.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #61 from Ron Olson ---
Nope, I removed the headers; they are not necessary for runtime.
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.24.20180701git6079032.fc28.src.rpm for Fedora 28:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #60 from Tom Stellard ---
(In reply to Ron Olson from comment #59)
> I cleaned up the lldb stuff, but the headers in /usr/lib/swift/clang/include
> are indeed necessary; they're used when importing a module (e.g. Glibc,
>
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #59 from Ron Olson ---
I cleaned up the lldb stuff, but the headers in /usr/lib/swift/clang/include
are indeed necessary; they're used when importing a module (e.g. Glibc,
Foundation, Dispatch) into a Swift program.
Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #58 from Tom Stellard ---
- Does swift need all the lldb headers that are installed?
- Are the clang headers in /usr/lib/swift/clang/include still necessary now
that we are using system clang?
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #57 from Ron Olson ---
Updated to the 2018-06-28 build:
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.21.20180628git9f8f2a1.fc28.src.rpm for Fedora 28:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #56 from Ron Olson ---
Swift doesn't use python, but lldb does.
According to
https://forums.swift.org/t/thoughts-on-python-3-for-swifts-lldb/14098/2 they
seem to do no testing of python3.
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #55 from Tom Stellard ---
Is python2 required or can swift use python3?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #54 from Ron Olson ---
Updated to the 2018-06-26 build:
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.20.20180626gitbe3b9a7.fc28.src.rpm for Fedora 28:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #53 from Ron Olson ---
I asked over on the Swift Forums
(https://forums.swift.org/t/building-swift-toolchain-using-gcc/13686/9) and the
two member of the core team that I've chatted with indicate that the
system-provided clang is
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #52 from Tom Stellard ---
According to a discussion I had on #llvm, we should be able to build swift with
system clang and possibly even system gcc. It is Fedora policy to build with
gcc if upstream supports it[1], so I think we
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #51 from Ron Olson ---
Updated to the 2018-06-12 build:
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM swift-lang-4.2-0.19.20180612gitbb9532c.fc29.src.rpm for Fedora 29:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #50 from Ron Olson ---
> Could we use system ninja instead of building it with system clang?
Yep, that worked well; I added ninja in the %buildrequires section, removed the
source file, and added a patch to disable the Swift
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #49 from Tom Stellard ---
(In reply to Ron Olson from comment #48)
> No, Swift is built using a special version of clang that has additional
> Swift-specific stuff added to it: https://swift.org/source-code/ under
> Cloned
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #48 from Ron Olson ---
No, Swift is built using a special version of clang that has additional
Swift-specific stuff added to it: https://swift.org/source-code/ under Cloned
Repositories.
System clang is used, though, for building
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #47 from Tom Stellard ---
(In reply to Ron Olson from comment #42)
> Hope that helped clear it up; was very confusing to me at first (especially
> when the LLVM toolchain versions matched between what was installable and
> what
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Tom Stellard changed:
What|Removed |Added
Flags|needinfo?(tstellar@redhat.c |needinfo+
|om)
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Richard Shaw changed:
What|Removed |Added
Flags||needinfo?(tstellar@redhat.c
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #44 from Ron Olson ---
Did the session log help? The clang that Swift builds is just for building
Swift, and then uses the installed clang for building Swift-based binaries.
--
You are receiving this mail because:
You are on the
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #43 from Ron Olson ---
Updated to the 2018-06-02 build:
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.13.20180602gitadad0f5.fc28.src.rpm for Fedora 28:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #42 from Ron Olson ---
Hope that helped clear it up; was very confusing to me at first (especially
when the LLVM toolchain versions matched between what was installable and what
was built just for bootstrapping).
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #41 from Ron Olson ---
Swift does have its own clang for building itself, but it uses the system clang
for compiling Swift code. Here's a session capture that illustrates this:
[rolson@thinky swift-source]$
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #40 from Tom Stellard ---
(In reply to Ron Olson from comment #38)
> You mean a build requirement for Swift itself? The Swift toolchain uses it
> post-installation to build a Swift-based binary.
Can you
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #39 from Richard Shaw ---
Oh, and no need to supply source RPMs for each release, they're typically
universal unless you have hardcoded customizations that are different between
them.
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #38 from Ron Olson ---
You mean a build requirement for Swift itself? The Swift toolchain uses it
post-installation to build a Swift-based binary.
--
You are receiving this mail because:
You are on the CC
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #37 from Tom Stellard ---
(In reply to Ron Olson from comment #36)
> Clang does the actual compilation of Swift code into a binary.
If it's only a build requirement, then you can drop
Requires: clang
--
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #36 from Ron Olson ---
Clang does the actual compilation of Swift code into a binary.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #35 from Tom Stellard ---
Why does swift Require: clang ?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #34 from Richard Shaw ---
Nope! Just been busy lately... I'll shoot to get started today but will likely
be after the holiday weekend before I get it done.
--
You are receiving this mail because:
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #33 from Ron Olson ---
Is there anything else I need to do? The package has been working for me quite
well on my machines; I use Swift more on Fedora than I do on a Mac. ;)
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #32 from Ron Olson ---
Updated to the 2018-05-20 build:
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.10.20180520gitbb77484.fc28.src.rpm for Fedora 27:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #31 from Ron Olson ---
Updated to the 2018-05-08 build:
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.8.20180508git0e6d867.fc27.src.rpm for Fedora 27:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #30 from Ron Olson ---
Updated to the 2018-05-02 build (first cut from the Swift master branch for
what will be the actual 4.2 release):
Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #29 from Ron Olson ---
Updated to the 2018-04-22 build:
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.6.20180422git5030d38 for Fedora 27:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #28 from Ron Olson ---
Updated for Fedora 28 (will be included in builds going forward):
SRPM 4.2-0.5.20180418gitac06163 for Fedora 28:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #27 from Ron Olson ---
Updated to the 2018-04-16 build:
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
SRPM 4.2-0.5.20180418gitac06163 for Fedora 27:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #26 from Ron Olson ---
I've made all of Tom's changes. The static libraries are internal compiler
libraries.
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #25 from Tom Stellard ---
A few other things that the review tool caught:
- BuildRequires: python-devel -> python2-devel or python3-devel
- Need %license LICENSE.txt in %files
- The static libraries in
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #24 from Ron Olson ---
Sure thing!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #23 from Tom Stellard ---
(In reply to Ron Olson from comment #22)
> Swift is very sensitive to the location of all parts of its toolchain; "lib"
> is hard-coded in some way or another across all the projects
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #22 from Ron Olson ---
Swift is very sensitive to the location of all parts of its toolchain; "lib" is
hard-coded in some way or another across all the projects that make up the
Swift toolchain. The past
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #21 from Tom Stellard ---
Why are libraries installed to /usr/lib instead of %{_libdir}?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #20 from Richard Shaw ---
Just got back from a very cold and wet Boy Scout camping trip. Will check it
out when I recover :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #19 from Ron Olson ---
Updated to Swift 4.2:
Spec URL: https://tachoknight.fedorapeople.org/swift-lang/swift-lang.spec
4.2-20180411git537a846 for Fedora 27:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #18 from Ron Olson ---
As an update, Swift 4.1 was released yesterday but does not include any of my
pull requests. Looking through their blog I found out that the final cut from
master was actually several
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #17 from Ron Olson ---
Hey Richard, thanks for the feedback. My responses to each of your points:
1: Will do
2: Will do
3: Will investigate and will do if possible
4: Swift builds and requires its own
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #16 from Richard Shaw ---
I forgot to post the links to the guidelines...
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
and
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Richard Shaw changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #14 from Ron Olson ---
I've updated the spec file and generated two new rpm files to take into account
a bug fix that I submitted to Apple and they merged:
https://github.com/apple/swift/pull/14589. This
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Ron Olson changed:
What|Removed |Added
Whiteboard|NotReady|
--- Comment #13
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #12 from Neal Gompa ---
Ron, that's perfectly fine.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #11 from Ron Olson ---
I believe I've resolved all the known outstanding issues and have updated the
spec and RPMs at https://tachoknight.fedorapeople.org/swift-lang/. 4.1 is still
not released; would it be
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #10 from Ron Olson ---
Well, I asked on the LLDB board on the Swift forums and it seems pretty certain
that Swift must include its own copy of LLDB:
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #9 from Ron Olson ---
(In reply to Ron Olson from comment #8)
> I've been playing around with a downloaded copy of Swift in conjunction with
> an installed copy of lldb and I believe that the swift binary is
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #8 from Ron Olson ---
I've been playing around with a downloaded copy of Swift in conjunction with an
installed copy of lldb and I believe that the swift binary is explicitly
looking for lldb in the same
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #7 from Ron Olson ---
There's an issue with excluding LLDB from being installed as part of the Swift
package, the one that is already available in Fedora does not know about Swift
(of course), but that makes
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #6 from Ron Olson ---
I figured out how to exclude LLDB from the rpm, but running the REPL brings up
this message:
*** You are running Swift's integrated REPL, ***
*** intended for compiler and stdlib
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #5 from Ron Olson ---
Figured out the issue with the Koji job dying: One of the sub-projects uses
rsync instead of cp and it wasn't listed in the BRs and apparently rsync is not
installed by default...?
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #4 from Ron Olson ---
Yep, I realized I needed to explicitly limit the architectures. I have limited
it to only x86_64, added the pod2man dependency, reorganized the %prep section,
and it builds on my
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #3 from Robert-André Mauchin ---
- Please split your BR on multiple lines.
- It seems you're missing a /usr/bin/pod2man dependency, provided by
perl-podlators.
CMake Error at
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Neal Gompa changed:
What|Removed |Added
CC||ngomp...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
--- Comment #1 from Ron Olson ---
The current released version of Swift (4.0.3) does not have the patches
necessary to build on Fedora, so I'm using the latest snapshot that does build
correctly. Chatting on IRC, the
https://bugzilla.redhat.com/show_bug.cgi?id=1536780
Ron Olson changed:
What|Removed |Added
Hardware|All |x86_64
--
You
83 matches
Mail list logo