[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064



--- Comment #13 from Fedora Update System  ---
python-pymdown-extensions-6.3-2.fc31 has been pushed to the Fedora 31 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2020-03-11 01:09:30 |2020-03-16 20:38:40



--- Comment #12 from Fedora Update System  ---
python-pymdown-extensions-6.3-2.fc32 has been pushed to the Fedora 32 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064



--- Comment #11 from Fedora Update System  ---
python-pymdown-extensions-6.3-2.fc31 has been pushed to the Fedora 31 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-e92ea0d732

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
python-pymdown-extensions-6.3-2.fc32 has been pushed to the Fedora 32 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-81e6a95df2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #8 from Fedora Update System  ---
FEDORA-2020-e92ea0d732 has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-e92ea0d732

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064



--- Comment #9 from Fedora Update System  ---
FEDORA-2020-81e6a95df2 has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-81e6a95df2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064

Robin Lee  changed:

   What|Removed |Added

 Status|CLOSED  |POST
 Resolution|CURRENTRELEASE  |---
  Flags|needinfo?(robinlee.sysu@gma |
   |il.com) |
   Keywords||Reopened



--- Comment #7 from Robin Lee  ---
I got it. I will import the package through normal procedure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064

Stephen Gallagher  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
  Flags|needinfo?(sgallagh@redhat.c |needinfo?(robinlee.sysu@gma
   |om) |il.com)
Last Closed||2020-03-11 01:09:30



--- Comment #6 from Stephen Gallagher  ---
(In reply to Robin Lee from comment #5)
> I found this package is never imported and I recently need this package.
> I am happy to co-maintain this package and have updated it to latest version:
> 
> Spec URL:
> https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-
> rawhide-x86_64/01297640-python-pymdown-extensions/python-pymdown-extensions.
> spec
> SRPM URL:
> https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-
> rawhide-x86_64/01297640-python-pymdown-extensions/python-pymdown-extensions-
> 6.3-1.fc33.src.rpm
> 
> My FAS ID is 'cheeselee'.

It was in fact imported, but it was only included in a module stream and not
the distribution at large. (I only needed it as a dependency for Review Board
at the time). I forgot to close this ticket though.

I just handed ownership of the package over to you. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064

Robin Lee  changed:

   What|Removed |Added

 CC||robinlee.s...@gmail.com
  Flags||needinfo?(sgallagh@redhat.c
   ||om)



--- Comment #5 from Robin Lee  ---
I found this package is never imported and I recently need this package.
I am happy to co-maintain this package and have updated it to latest version:

Spec URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01297640-python-pymdown-extensions/python-pymdown-extensions.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01297640-python-pymdown-extensions/python-pymdown-extensions-6.3-1.fc33.src.rpm

My FAS ID is 'cheeselee'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pymdown-extensions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064



--- Comment #2 from Stephen Gallagher  ---
Thanks for the review!

Spec URL:
https://sgallagh.fedorapeople.org/packagereview/python-pymdown-extensions/python-pymdown-extensions.spec

SRPM URL:
https://sgallagh.fedorapeople.org/packagereview/python-pymdown-extensions/python-pymdown-extensions-3.5-4.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1566064] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1566064

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Parts of the code is BSD:

BSD (unspecified)
-
pymdown-extensions-3.5/pymdownx/extrarawhtml.py
pymdown-extensions-3.5/pymdownx/highlight.py
pymdown-extensions-3.5/pymdownx/superfences.py

   - Add it to the License: field and add a comment explaining the license
breakdown.


 - "MIT License" is not a valid license shorthand, it should just be "MIT"

License:MIT and BSD



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (unspecified)", "Unknown or
 generated", "MIT/X11 (BSD like) BSD (unspecified)". 217 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-pymdown-extensions/review-python-
 pymdown-extensions/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations