[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819

Pawel Stolowski  changed:

   What|Removed |Added

  Flags|needinfo?(stolowski@gmail.c |
   |om) |



--- Comment #15 from Pawel Stolowski  ---
I’m no longer interested in packaging this software, closing the ticket.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1567819
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

needinfo canceled: [Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Pawel Stolowski  has canceled Package Review
's request for Pawel Stolowski
's needinfo:
Bug 1567819: Review Request: golang-github-pilebones-go-udev - Simple udev
implementation in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #15 from Pawel Stolowski  ---
I’m no longer interested in packaging this software, closing the ticket.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819

Pawel Stolowski  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2022-09-16 15:00:56




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1567819
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819

Didik Supriadi  changed:

   What|Removed |Added

 Whiteboard||NotReady
 CC||didiksupriad...@gmail.com



--- Comment #13 from Didik Supriadi  ---
SPEC and SRPM's urls have been expired


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

needinfo canceled: [Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Neal Gompa
's needinfo:
Bug 1567819: Review Request: golang-github-pilebones-go-udev - Simple udev
implementation in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #12 from Package Review 
---
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #10 from Robert-André Mauchin  ---
(In reply to Pawel Stolowski from comment #9)
> (In reply to Neal Gompa from comment #8)
> > @Pawel, before I approve this review and sponsor you into the maintainers
> > group, I'd like you to do five non-binding reviews of other packages in the
> > review queue[1], to demonstrate your understanding of the Fedora Packaging
> > Guidelines.
> 
> My first review: https://bugzilla.redhat.com/show_bug.cgi?id=1575452

Try this one: https://bugzilla.redhat.com/show_bug.cgi?id=1636111

Please post the review here, not in the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #9 from Pawel Stolowski  ---
(In reply to Neal Gompa from comment #8)
> @Pawel, before I approve this review and sponsor you into the maintainers
> group, I'd like you to do five non-binding reviews of other packages in the
> review queue[1], to demonstrate your understanding of the Fedora Packaging
> Guidelines.

My first review: https://bugzilla.redhat.com/show_bug.cgi?id=1575452

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #8 from Neal Gompa  ---
@Pawel, before I approve this review and sponsor you into the maintainers
group, I'd like you to do five non-binding reviews of other packages in the
review queue[1], to demonstrate your understanding of the Fedora Packaging
Guidelines.

You can find review requests here:
https://fedoraproject.org/PackageReviewStatus/NEW.html

Note that the page is in chronological order, so you'll want to scroll to the
bottom of the page and pick five from there, as those are recent review
requests.

[1]:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Show_Your_Expertise_by_Commenting_on_other_Review_Requests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #7 from Neal Gompa  ---
Review notes:

> [x]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/share/gocode/src,
>  /usr/share/gocode, /usr/share/gocode/src/github.com

This is normal for gofed generated packages, so I'm giving a pass on this. And
I expect this to be corrected with 3.0 spec format in the future. Also, at
least a couple of those are owned by the golang stack itself, I believe.

> [x]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "Unknown or generated". 11 files have unknown license. Detailed
>  output of licensecheck in /home/makerpm/1567819-golang-github-
>  pilebones-go-udev/licensecheck.txt

This is caused by none of the golang files actually having license headers.
Sadly, this appears to be the norm in Go libraries (even though it's a bad idea
with how people do vendoring), so I'm going to consider the license file as
sufficient.

> golang-github-pilebones-go-udev.x86_64: E: no-binary

This is not terribly surprising, and I'm okay with ignoring this, since it's a
false positive with how Go libraries are packaged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #6 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 11 files have unknown license. Detailed
 output of licensecheck in /home/makerpm/1567819-golang-github-
 pilebones-go-udev/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
 github-pilebones-go-udev-devel , golang-github-pilebones-go-udev-unit-
 test-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, 

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819

Neal Gompa  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #5 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #4 from Robert-André Mauchin  ---
Yeah the macro only works for F28 and above. If you need support for older
Fedora, it won't work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #3 from Pawel Stolowski  ---
UPDATE: since I need to support F26 with this package and the new-style macros
are not available there, I'd like to request the old-style approach for the
spec:

https://copr-be.cloud.fedoraproject.org/results/pstolowski/go-udev/fedora-26-x86_64/00742537-golang-github-pilebones-go-udev/golang-github-pilebones-go-udev.spec
https://copr-be.cloud.fedoraproject.org/results/pstolowski/go-udev/fedora-26-x86_64/00742537-golang-github-pilebones-go-udev/golang-github-pilebones-go-udev-0-0.1.git02dfd8e.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819



--- Comment #2 from Pawel Stolowski  ---
(In reply to Robert-André Mauchin from comment #1)
> we've revamped the way to do Golang packaging. See examples here:
> https://eclipseo.fedorapeople.org/golang/
> 
> Read new guidelenes here: https://fedoraproject.org/wiki/More_Go_packaging
> 

Ok, I've reworked it to use the above guidelines. The package builds locally
for me on fc27, but fails to build on copr against fc27 and rawhide - it
doesn't understand %gometa tag there. Nb, locally it was also unhappy about
%{gofindfilter}, so I had to avoid this macro as well. Other than it builds
fine here, only fails on copr... I'm a little bit lost now, can you advise how
to proceed further with it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1567819] Review Request: golang-github-pilebones-go-udev - Simple udev implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1567819

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
Summary|Review Request: go-udev |Review Request:
   |package |golang-github-pilebones-go-
   ||udev - Simple udev
   ||implementation in Golang



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org