[Bug 1591111] Review Request: perl-Hash-AutoHash - Object-oriented access to real and tied hashes

2018-06-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=159

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Hash-AutoHash-1.17-1.f
   ||c29
 Resolution|--- |RAWHIDE
Last Closed||2018-06-14 09:40:25



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository. I removed the duplicate build
requirements.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LKACLCOEG6JJ5GWK5EXQWBSWLTARQ7J3/


[Bug 1591111] Review Request: perl-Hash-AutoHash - Object-oriented access to real and tied hashes

2018-06-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=159
Bug 159 depends on bug 1591109, which changed state.

Bug 1591109 Summary: Review Request: perl-Tie-Hash-MultiValue - Store multiple 
values per key
https://bugzilla.redhat.com/show_bug.cgi?id=1591109

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/UFGCTCD3TB4BKJ35AAOIBMLTEZWBVOUA/


[Bug 1591111] Review Request: perl-Hash-AutoHash - Object-oriented access to real and tied hashes

2018-06-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=159



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Hash-AutoHash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SB2JFCNC4MT5RMXEST6UKYS7LQ3O3HTC/


[Bug 1591111] Review Request: perl-Hash-AutoHash - Object-oriented access to real and tied hashes

2018-06-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=159

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please remove duplicity from build-requires
- List::MoreUtils
- Scalar::Util

$ rpm -qp --requires perl-Hash-AutoHash-1.17-1.fc29.noarch.rpm | sort | uniq -c
  1 perl(Carp) >= 1.2
  1 perl(List::MoreUtils) >= 0.33
  1 perl(:MODULE_COMPAT_5.26.2)
  1 perl(Scalar::Util)
  1 perl(strict)
  1 perl(Tie::Hash) >= 1.04
  1 perl(Tie::ToObject) >= 0.03
  1 perl(vars)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Hash-AutoHash-1.17-1.fc29.noarch.rpm | sort | uniq -c
  1 perl(Hash::AutoHash) = 1.17
  1 perl-Hash-AutoHash = 1.17-1.fc29
  1 perl(Hash::AutoHash::alias)
  1 perl(Hash::AutoHash::helper)
Binary provides are Ok.

$ rpmlint ./perl-Hash-AutoHash*
perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US AsObject ->
As Object, As-object, Object
perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US Inflator ->
Inflation, Infiltrator, Inhalator
perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US OpenStruct
-> Reconstruct, Construct
perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US AutoAccessor
-> Accessorize
perl-Hash-AutoHash.src: W: spelling-error %description -l en_US AsObject -> As
Object, As-object, Object
perl-Hash-AutoHash.src: W: spelling-error %description -l en_US Inflator ->
Inflation, Infiltrator, Inhalator
perl-Hash-AutoHash.src: W: spelling-error %description -l en_US OpenStruct ->
Reconstruct, Construct
perl-Hash-AutoHash.src: W: spelling-error %description -l en_US AutoAccessor ->
Accessorize
2 packages and 1 specfiles checked; 0 errors, 8 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SV6W7ZV4CWJ6HLQTKVHKGTO7JKNQB7RA/


[Bug 1591111] Review Request: perl-Hash-AutoHash - Object-oriented access to real and tied hashes

2018-06-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=159

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1591116




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1591116
[Bug 1591116] Review Request: perl-Hash-AutoHash-Args - Object-oriented
processing of keyword-based argument lists
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/QVGS2PEH3QJWBCLC5SMEKIDVUIF6DAT2/


[Bug 1591111] Review Request: perl-Hash-AutoHash - Object-oriented access to real and tied hashes

2018-06-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=159

Petr Pisar  changed:

   What|Removed |Added

 Depends On||1591109




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1591109
[Bug 1591109] Review Request: perl-Tie-Hash-MultiValue - Store multiple
values per key
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NB4AETXM2NVVH7X72MJCVCUP4JWYRL6E/