[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 Felix Schwarz changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |DUPLICATE Last Closed||2019-10-25 19:50:03 --- Comment #14 from Felix Schwarz --- review request in bug 1765322 was approved therefore I'm closing this duplicate issue. @Eric: If you are interested ping me so I can add you as co-maintainer. *** This bug has been marked as a duplicate of bug 1765322 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 --- Comment #13 from Felix Schwarz --- new review request: bug 1765322 zebob.m: If you could approve the new review request, this would be highly appreciated. brouhaha: I'm still interested in co-maintaining this with you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 --- Comment #12 from Felix Schwarz --- Eric: Are you aware that the review will expire in a few days? pagure will require a re-review if the review is older than 6 weeks (IIRC). If you don't manage to import the package until then I think I'll go ahead and create a separate review request but that would be much more work for everyone... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 Felix Schwarz changed: What|Removed |Added Flags||needinfo?(space...@gmail.co ||m) --- Comment #11 from Felix Schwarz --- Eric: Are you still interested in maintaining this package? I don't want to "take your package away" but I'd like to get this package into Fedora as it blocks cairosvg and weasyprint. As this package got reviewed successfully I think it is not wise to create a new review request (with an identical spec file) but I'm out of ideas on how to move forward. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 --- Comment #10 from Felix Schwarz --- (In reply to Robert-André Mauchin from comment #9) > > "- Maybe you could use "python3-cssselect2" as package name?" > > No. The python guidelines are clear this needs to be a subpackage. You are right - sorry for the noise. > Sorry for the dealy I missed the mails. Thank you for all your review work :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #9 from Robert-André Mauchin --- > "- Maybe you could use "python3-cssselect2" as package name?" No. The python guidelines are clear this needs to be a subpackage. Sorry for the dealy I missed the mails. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 --- Comment #8 from Felix Schwarz --- I'll wait a few more days to give Robert-André a chance to respond but I have two more comments: - Maybe you could use "python3-cssselect2" as package name? That way we can get rid of a useless subpackage. Not a strict requirement I guess. - Test code is packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 Felix Schwarz changed: What|Removed |Added Blocks||1475749 --- Comment #7 from Felix Schwarz --- Robert-André: If you are still interested in this review, please proceed. Otherwise I'll try to get this over the finish line. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1475749 [Bug 1475749] weasyprint 0.45 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 Felix Schwarz changed: What|Removed |Added Blocks||1331947 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1331947 [Bug 1331947] python-cairosvg-2.4.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 --- Comment #6 from Eric Smith --- The requested changes were made on May 2 (comment 5). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 --- Comment #5 from Eric Smith --- Spec URL: https://fedorapeople.org/~brouhaha/python-cssselect2/python-cssselect2.spec SRPM URL: https://fedorapeople.org/~brouhaha/python-cssselect2/python-cssselect2-0.2.1-3.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #4 from Robert-André Mauchin ---
- Missing python provides macro:
%package -n python3-%{srcname}
Summary:%{summary}
%{?python_provide:%python_provide %{py3_prefix}-cssselect2}
- Requires should go under the pyshon3 subpackage:
%package -n python3-%{srcname}
Summary:%{summary}
%{?python_provide:%python_provide %{py3_prefix}-cssselect2}
Requires: %{py3_prefix}-webencodings
Requires: %{py3_prefix}-tinycss2
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "*No copyright* BSD (unspecified)", "BSD (unspecified)". 19
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/python-cssselect2/review-python-
cssselect2/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 --- Comment #3 from Felix Schwarz --- just fyi: correct link to SRPM is https://fedorapeople.org/~brouhaha/python-cssselect2/python-cssselect2-0.2.1-2.fc30.src.rpm I can do a review this week - if someone else is faster, please just go ahead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 --- Comment #2 from Eric Smith --- BuildRequires and Requires added. Spec URL: https://fedorapeople.org/~brouhaha/python-cssselect2/python-cssselect2.spec SRPM URL: https://fedorapeople.org/~brouhaha/python-cssselect2/python-cssselect2-0.2.1-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917
Felix Schwarz changed:
What|Removed |Added
CC||fschw...@fedoraproject.org
--- Comment #1 from Felix Schwarz ---
The package does not build for me in mock.
You need at least these build requires:
BuildRequires: %{py3_prefix}-pytest
BuildRequires: %{py3_prefix}-pytest-cov
# required for testing
BuildRequires: %{py3_prefix}-webencodings
BuildRequires: %{py3_prefix}-tinycss2
Also I think cssselect2 requires tinycss2 and webencodings also at runtime.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
