[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #19 from Fedora Update System --- qownnotes-1.8.4-7.20190810git0302b2c.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-08-21 01:04:28 --- Comment #18 from Fedora Update System --- qownnotes-1.8.4-7.20190810git0302b2c.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #17 from Fedora Update System --- qownnotes-1.8.4-7.20190810git0302b2c.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5b91f967e7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System --- qownnotes-1.8.4-7.20190810git0302b2c.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b412934ded -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #15 from Fedora Update System --- FEDORA-2019-b412934ded has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b412934ded -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #14 from Fedora Update System --- FEDORA-2019-5b91f967e7 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5b91f967e7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 Thomas Moschny changed: What|Removed |Added CC||thomas.mosc...@gmx.de --- Comment #13 from Thomas Moschny --- You really should not bundle an old botan version, that opens the door for security problems. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qownnotes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #11 from Artem --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/01001213-qownnotes/qownnotes.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/01001213-qownnotes/qownnotes-1.8.4-7.20190810git0302b2c.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838
Vasiliy Glazov changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from Vasiliy Glazov ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v2)", "GNU General Public License
(v2)", "BSD (unspecified)", "GPL (v2 or later)", "Apache License
(v2.0)", "ISC License", "Expat License", "BSD 3-clause "New" or
"Revised" License", "*No copyright* BSD (unspecified)", "GPL (v3 or
later)", "GPL (v3)", "GNU Lesser General Public License (v2.1)", "BSD
3-clause "New" or "Revised" License GPL (v3.0)". 840 files have
unknown license. Detailed output of licensecheck in
/home/vascom/1739838-qownnotes/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/qt5,
/usr/share/qt5/translations
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does no
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #9 from Artem --- > Large data in /usr/share should live in a noarch subpackage if package is > arched. > Note: Arch-ed rpms have a total of 7526400 bytes in /usr/share Now witch separate translation because of this. And other packaging fixes. Spec URL: https://atim.fedorapeople.org/for-review/qownnotes.spec SRPM URL: https://atim.fedorapeople.org/for-review/qownnotes-1.8.4-6.20190810git0302b2c.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #8 from Artem --- License quick fix. Spec URL: https://atim.fedorapeople.org/for-review/qownnotes.spec SRPM URL: https://atim.fedorapeople.org/for-review/qownnotes-1.8.4-6.20190810git0302b2c.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #7 from Artem --- Fixed. Please check. Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00998387-qownnotes/qownnotes.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00998387-qownnotes/qownnotes-1.8.4-5.20190810git0302b2c.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #6 from Vasiliy Glazov --- Need to change flto=$(nproc) to flto=auto for repeatable builds on different cpus. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #5 from Artem --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00998072-qownnotes/qownnotes.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00998072-qownnotes/qownnotes-1.8.4-4.20190810git0302b2c.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #4 from Artem --- Also i managed to build this for Fedora Rawhide as well. Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00997989-qownnotes/qownnotes.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00997989-qownnotes/qownnotes-1.8.4-3.20190810git0302b2c.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #3 from Artem --- Filed a bug about 'botan': - https://bugzilla.redhat.com/show_bug.cgi?id=1740310 - https://github.com/pbek/QOwnNotes/issues/1263 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 --- Comment #2 from Artem --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00997842-qownnotes/qownnotes.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/qownnotes/fedora-30-x86_64/00997842-qownnotes/qownnotes-1.8.4-2.20190810git0302b2c.fc30.src.rpm (In reply to Vasiliy Glazov from comment #1) > DEBUG util.py:585: BUILDSTDERR: Error: > DEBUG util.py:585: BUILDSTDERR: Problem: cannot install the best candidate > for the job > DEBUG util.py:585: BUILDSTDERR: - nothing provides compat-openssl10-devel > needed by botan-devel-1.10.17-13.fc31.x86_64 > DEBUG util.py:587: (try to add '--skip-broken' to skip uninstallable > packages or '--nobest' to use not only best candidate packages) This happens only on Rawhide. Need to investigate this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 Vasiliy Glazov changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739838] Review Request: qownnotes - Plain-text file markdown note taking with Nextcloud integration
https://bugzilla.redhat.com/show_bug.cgi?id=1739838 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED CC||vasc...@gmail.com Assignee|nob...@fedoraproject.org|vasc...@gmail.com --- Comment #1 from Vasiliy Glazov --- DEBUG util.py:585: BUILDSTDERR: Error: DEBUG util.py:585: BUILDSTDERR: Problem: cannot install the best candidate for the job DEBUG util.py:585: BUILDSTDERR: - nothing provides compat-openssl10-devel needed by botan-devel-1.10.17-13.fc31.x86_64 DEBUG util.py:587: (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) 1. Change cmake BR to cmake3. And macro %cmake to %cmake3. 2. Change BR qt5-qtbase-devel to cmake(Qt5). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
