[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-09-26 00:01:59 --- Comment #12 from Fedora Update System --- golang-github-gobuffalo-packr-2.6.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Bug 1744144 depends on bug 1744085, which changed state. Bug 1744085 Summary: Review Request: golang-github-gobuffalo-logger - Common logging interface for the Buffalo ecosystem https://bugzilla.redhat.com/show_bug.cgi?id=1744085 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Bug 1744144 depends on bug 1744087, which changed state. Bug 1744087 Summary: Review Request: golang-github-gobuffalo-packd - Gobuffalo/packr interfaces https://bugzilla.redhat.com/show_bug.cgi?id=1744087 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- golang-github-gobuffalo-packr-2.6.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8154a87b30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2019-8154a87b30 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8154a87b30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gobuffalo-packr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Elliott Sales de Andrade changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Elliott Sales de Andrade --- Looks good now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 --- Comment #7 from Robert-André Mauchin --- Most packages have been imported. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 --- Comment #6 from Elliott Sales de Andrade --- Please import your other reviews; the scratch builds for the other approved packages have been garbage collected. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 --- Comment #5 from Robert-André Mauchin --- (In reply to Robert-André Mauchin from comment #4) > Splitted the package in 2 with: > > %global goipaths0 github.com/gobuffalo/packr > %global goipathsex0 github.com/gobuffalo/packr/v2 > %global goipaths1 github.com/gobuffalo/packr/v2 > > And asked upstream about the license: > https://github.com/gobuffalo/packr/issues/239 ASL 2.0 confirmed as error: https://github.com/gobuffalo/packr/issues/239#issuecomment-530470138 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 --- Comment #4 from Robert-André Mauchin --- Splitted the package in 2 with: %global goipaths0 github.com/gobuffalo/packr %global goipathsex0 github.com/gobuffalo/packr/v2 %global goipaths1 github.com/gobuffalo/packr/v2 And asked upstream about the license: https://github.com/gobuffalo/packr/issues/239 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 --- Comment #3 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gobuffalo-packr.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gobuffalo-packr-2.6.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||quantum.anal...@gmail.com
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review?
--- Comment #2 from Elliott Sales de Andrade ---
Latest version is 2.6.0.
One file appears to be ASL 2.0, which may have been an accident and you might
want to report that upstream.
This is actually a correctly implemented v2 with it contained in a separate
subdirectory. This means your -devel package actually provides both v1 (no
suffix) and v2 import paths, and go.mods, etc.. I'm not sure if that means they
should be placed into their own separate subpackages. It shold provide two
golang-ipath, I think.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated", "Expat
License", "Apache License (v2.0)". 163 files have unknown license.
Detailed output of licensecheck in
1744144-golang-github-gobuffalo-packr/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 16 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Robert-André Mauchin changed: What|Removed |Added Blocks||1744287 ||(golang-mongodb-mongo-drive ||r) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1744287 [Bug 1744287] Review Request: golang-mongodb-mongo-driver - Go driver for MongoDB -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Robert-André Mauchin changed: What|Removed |Added Depends On||1744087 ||(golang-github-gobuffalo-pa ||ckd), 1744085 ||(golang-github-gobuffalo-lo ||gger) --- Comment #1 from Robert-André Mauchin --- COPR build: https://copr.fedorainfracloud.org/coprs/build/1011605 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1744085 [Bug 1744085] Review Request: golang-github-gobuffalo-logger - Common logging interface for the Buffalo ecosystem https://bugzilla.redhat.com/show_bug.cgi?id=1744087 [Bug 1744087] Review Request: golang-github-gobuffalo-packd - Gobuffalo/packr interfaces -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
