https://bugzilla.redhat.com/show_bug.cgi?id=1787069
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED|ON_QA
--- Comment #16 from
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #15 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/ddnet
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #14 from Michael ---
Updated spec file:
Spec URL:
https://raw.githubusercontent.com/ElXreno/ddnet/d793394035fd23d1966afdb8069cd6225aa1baef/ddnet.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #13 from Artem ---
(In reply to Vasiliy Glazov from comment #12)
> 2. Change %{optflags} -flto
> to
> %{optflags} -flto=auto
This will makes non reproducible builds. Don't do this and don't push with
'auto' in repos.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
Vasiliy Glazov changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
Vasiliy Glazov changed:
What|Removed |Added
CC||vasc...@gmail.com
--- Comment #12
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #11 from Michael ---
Oh yes, I missed this. Thank you for your review and your help!
Spec URL:
https://raw.githubusercontent.com/ElXreno/ddnet/042238f5c09be3f1cc9d099a29634d04c2a3/ddnet.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
Artem changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from Artem
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #9 from Michael ---
Spec URL:
https://raw.githubusercontent.com/ElXreno/ddnet/443e001a8d1ee20c985123ece1718cd31086a23f/ddnet.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/1107/40051107/ddnet-12.8.1-6.fc31.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #8 from Michael ---
Thanks for your patch. I applied it.
Also, now I can provide ddnet without bundled md5 and json-parser (thanks
upstream for help with it, issue url: [1]).
[1] https://github.com/ddnet/ddnet/issues/2022
--
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #7 from Artem ---
> Also json-parser is bundled, but I think it's temporarily because json-parser
> package
in Fedora repos doesn't provide json.c file, but it requires for proper build.
'json-parser' available in Fedora repos.
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #6 from Artem ---
Created attachment 1649026
--> https://bugzilla.redhat.com/attachment.cgi?id=1649026=edit
spec file
LGTM. Few minor issues:
* Please add license breakdown explanation. See example [1] spec file.
[1]
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #5 from Michael ---
Spec URL:
https://raw.githubusercontent.com/ElXreno/ddnet/db03b62a57571259181d03cc6727a2c46858d386/ddnet.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/684/40010684/ddnet-12.8.1-5.fc31.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #4 from Michael ---
1. Ok. Now all devel packages now uses pkgconfig besides pnglite-devel.
2. Fixed and now available in upstream.
3. Probably no, because libmysqlcppconn is not available in Fedora repos,
and it not works with
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #3 from Artem ---
8. Try to delete whole 'src/engine/external/' in '%prep' to be sure that
nothing is bundled here.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
--- Comment #2 from Artem ---
5. The license should be probably:
zlib and CC-BY-SA and ASL 2.0 and MIT and Public Domain and BSD
Please explaining the multiple licensing breakdown in spec file
https://bugzilla.redhat.com/show_bug.cgi?id=1787069
Artem changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
18 matches
Mail list logo
