[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 Bug 1803942 depends on bug 1802803, which changed state. Bug 1802803 Summary: Review Request: dotnet3.1 - .NET Core Runtime and SDK https://bugzilla.redhat.com/show_bug.cgi?id=1802803 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 Omair Majid changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-03-04 18:21:42 --- Comment #13 from Omair Majid --- Built in rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2020-18534af280 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dotnet-build-reference-packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #11 from Neal Gompa --- This is taken care of. Congratulations on becoming an official Fedora packager, Radka! Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 Michael Cronenworth changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #10 from Michael Cronenworth --- I just noticed you need to be sponsored. Let's get that going. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 Radka Janek changed: What|Removed |Added Comment #9 is|1 |0 private|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942
Michael Cronenworth changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #8 from Michael Cronenworth ---
Thanks. One final issue. The date in the changelog needs adjustment.
dotnet-build-reference-packages.spec: E: specfile-error warning: bogus date in
%changelog: Tue Feb 19 2020 Radka Janekova -
0-2.20200108git9cc7dad
0 packages and 1 specfiles checked; 1 errors, 0 warnings.
I think you meant 'Wed Feb 19 2020'. I'll pass the review, but fix it before
importing.
This review is PASSED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Note: See rpmlint output
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/profile.d,
/usr/lib64/dotnet
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 --- Comment #7 from Radka Janek --- Oh good catch. Updated in the same location: Spec URL: https://rhea.fedorapeople.org/package-review/dotnet-build-reference-packages/dotnet-build-reference-packages.spec SRPM URL: https://rhea.fedorapeople.org/package-review/dotnet-build-reference-packages/dotnet-build-reference-packages-0-2.20200108git9cc7dad.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 --- Comment #6 from Michael Cronenworth --- Closer. Thanks. Can you also adjust your changelog entries? The version formatting needs an adjustment. - 02.20200108git9cc7dad + 0-2.20200108git9cc7dad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 --- Comment #5 from Radka Janek --- That's great, discovered other things that needed fixing. Both up here now: Spec URL: https://rhea.fedorapeople.org/package-review/dotnet-build-reference-packages/dotnet-build-reference-packages.spec SRPM URL: https://rhea.fedorapeople.org/package-review/dotnet-build-reference-packages/dotnet-build-reference-packages-0-2.20200108git9cc7dad.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 --- Comment #4 from Michael Cronenworth --- I hate being pedantic, but could you post a new spec and SRPM link in a new comment? I see that the OP spec URL is updated, but the SRPM needs to be regenerated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 --- Comment #3 from Radka Janek --- Indeed it's missing, and that should now be there, thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 Michael Cronenworth changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|m...@cchtml.com Flags||fedora-review? --- Comment #2 from Michael Cronenworth --- I only see one issue so far: No license text is included. Can you add a %license LICENSE.txt line? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 Omair Majid changed: What|Removed |Added CC||oma...@redhat.com --- Comment #1 from Omair Majid --- *** Bug 1802785 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 Radka Janek changed: What|Removed |Added Depends On||1802803 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1802803 [Bug 1802803] Review Request: dotnet3.1 - .NET Core Runtime and SDK -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
