[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 Brandon Perkins changed: What|Removed |Added CC||thomas.mosc...@gmx.de --- Comment #7 from Brandon Perkins --- *** Bug 1331958 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:19 --- Comment #6 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-dustinkirkland-petname -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 Brandon Perkins changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 Ryan O'Hara changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511
--- Comment #4 from Ryan O'Hara ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in
/home/rohara/1833511-golang-github-dustinkirkland-
petname/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
All good.
[ ]: Package does not own files or directories owned by other packages.
* snip *
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
All good.
[ ]: Package contains desktop file if it is a GUI application.
N/A
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
All good.
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-dustinkirkland-petname-devel
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
All above seem fine. Might want to check if the dataplaneapi packages that
depend on this need stricter version requirements
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
N/A
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
Looks fine.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 Ryan O'Hara changed: What|Removed |Added Assignee|nob...@fedoraproject.org|roh...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511
--- Comment #3 from Brandon Perkins ---
In my own review of fedora-review package, I didn't notice much. There were no
failures.
> = MUST items =
>
> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
License : ASL 2.0
$ rpm -qL golang-github-dustinkirkland-petname
/usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE
$ head -5 /usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/
> [ ]: License field in the package spec file matches the actual license.
$ licensecheck /usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE
/usr/share/licenses/golang-github-dustinkirkland-petname/LICENSE: *No
copyright* Apache License (v2.0)
> [ ]: License file installed when any subpackage combination is installed.
See discussion at https://bugzilla.redhat.com/show_bug.cgi?id=1773720#c10
> [ ]: Package does not own files or directories owned by other packages.
> Note: Dirs in package are owned also by:
> /usr/share/gocode/src/github.com
All go packages "own" this directory
> [ ]: %build honors applicable compiler flags or justifies otherwise.
> [ ]: Package contains no bundled libraries without FPC exception.
> [ ]: Changelog in prescribed format.
> [ ]: Sources contain only permissible code or content.
All okay
> [ ]: Package contains desktop file if it is a GUI application.
N/A
> [ ]: Development files must be in a -devel package
> [ ]: Package uses nothing in %doc for runtime.
> [ ]: Package consistently uses macros (instead of hard-coded directory
> names).
> [ ]: Package is named according to the Package Naming Guidelines.
> [ ]: Package does not generate any conflict.
> [ ]: Package obeys FHS, except libexecdir and /usr/target.
> [ ]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
> [ ]: Requires correct, justified where necessary.
> [ ]: Spec file is legible and written in American English.
All okay
> [ ]: Package contains systemd file(s) if in need.
N/A
> [ ]: Useful -debuginfo package or justification otherwise.
> [ ]: Package is not known to require an ExcludeArch tag.
Both okay
> [ ]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 40960 bytes in 4 files.
Not needed
> [ ]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
> one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
> Note: There are rpmlint messages (see attachment).
Checking:
golang-github-dustinkirkland-petname-debuginfo-0-0.1.20200508git8e5a1ed.fc33.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> [x]: If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package must own all directories that it creates.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package must not depend on deprecated() packages.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
> work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
> provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
> %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
>
> = SHOULD items =
>
> Generic:
> [ ]: If the source package does not include license text(s) as a separate
> file from upstream, the packager SHOULD query upstream to include it.
$ tar -tvzf
SOURCES/golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667.tar.gz
golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667/LICENSE
-rw-rw-r-- root/root 11358 2019-11-29 16:52
golang-petname-8e5a1ed0cff0384869564ec1c086c6467a025667/LICENSE
> [ ]: Final provides and requires are sane (see attachments).
Okay
> [ ]: Fully versioned dependency in
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 --- Comment #2 from Brandon Perkins --- Besides the -devel package being generated and producing a dataplaneapi build, I've also verified the binary and man page shipped with this package: $ man petname | head golang-petname(1) golang-petname golang-petname(1) NAME golang-petname - utility to generate "pet names", consisting of a random combination of adverbs, an adjective, and a proper name SYNOPSIS golang-petname [-w|--words INT] [-s|--separator STR] OPTIONS $ petname warm-mink $ petname --words 1 guinea $ petname --words 3 slowly-helpful-lamb $ petname --words 4 adversely-painfully-driving-quetzal $ petname --separator ":" eternal:insect $ petname --separator "" --words 3 nationallyelegantstarling -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 --- Comment #1 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-dustinkirkland-petname.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-32-x86_64/01373678-golang-github-dustinkirkland-petname/golang-github-dustinkirkland-petname-0-0.1.20200508git8e5a1ed.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 Brandon Perkins changed: What|Removed |Added Priority|unspecified |medium CC||roh...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1833511 Brandon Perkins changed: What|Removed |Added Blocks||1773720, 177841 ||(FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=1773720 [Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
