[Bug 1851596] Review Request: ghc-HsYAML - Pure Haskell YAML 1.2 parser
https://bugzilla.redhat.com/show_bug.cgi?id=1851596 Jens Petersen changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2020-08-23 06:57:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851596] Review Request: ghc-HsYAML - Pure Haskell YAML 1.2 parser
https://bugzilla.redhat.com/show_bug.cgi?id=1851596 Jens Petersen changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||ghc-HsYAML-0.1.2.0-1.fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851596] Review Request: ghc-HsYAML - Pure Haskell YAML 1.2 parser
https://bugzilla.redhat.com/show_bug.cgi?id=1851596 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-HsYAML -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851596] Review Request: ghc-HsYAML - Pure Haskell YAML 1.2 parser
https://bugzilla.redhat.com/show_bug.cgi?id=1851596 --- Comment #4 from Jens Petersen --- Thanks a lot, Robert-André! (In reply to Robert-André Mauchin from comment #2) > - Latest version seems to be 0.2.1.0, any particular reason to package an > old version? Good point - I think I prepared the package earlier with an older version. Let me update to 0.2.1.0 after importing: I am working on updating all the packages now too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851596] Review Request: ghc-HsYAML - Pure Haskell YAML 1.2 parser
https://bugzilla.redhat.com/show_bug.cgi?id=1851596 --- Comment #3 from Jens Petersen --- Thank you for the review https://pagure.io/releng/fedora-scm-requests/issue/26698 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1851596] Review Request: ghc-HsYAML - Pure Haskell YAML 1.2 parser
https://bugzilla.redhat.com/show_bug.cgi?id=1851596
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #2 from Robert-André Mauchin ---
- Latest version seems to be 0.2.1.0, any particular reason to package an old
version?
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License". 14
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/ghc-HsYAML/review-ghc-
HsYAML/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/doc/ghc(ghc-
compiler, ghc-uri-encode-doc, ghc-cborg-doc, ghc-geniplate-mirror-doc,
ghc-aeson-better-errors-doc, ghc-dns-doc, ghc-time-manager-doc, ghc-
murmur-hash-doc, ghc-EdisonAPI-doc, ghc-http2-doc, ghc-parsers-doc,
ghc-EdisonCore-doc, ghc-Agda-doc), /usr/share/doc/ghc/html(ghc-
compiler, ghc-uri-encode-doc, ghc-cborg-doc, ghc-geniplate-mirror-doc,
ghc-aeson-better-errors-doc, ghc-dns-doc, ghc-time-manager-doc, ghc-
murmur-hash-doc, ghc-EdisonAPI-doc, ghc-http2-doc, ghc-parsers-doc,
ghc-EdisonCore-doc, ghc-Agda-doc),
/usr/share/doc/ghc/html/libraries(ghc-compiler, ghc-uri-encode-doc,
ghc-cborg-doc, ghc-geniplate-mirror-doc, ghc-aeson-better-errors-doc,
ghc-dns-doc, ghc-time-manager-doc, ghc-murmur-hash-doc, ghc-EdisonAPI-
doc, ghc-http2-doc, ghc-parsers-doc, ghc-EdisonCore-doc, ghc-Agda-
doc), /usr/share/doc/ghc/html/libraries/HsYAML-0.1.2.0(ghc-HsYAML-
doc), /usr/share/doc/ghc/html/libraries/HsYAML-0.1.2.0/src(ghc-HsYAML-
doc)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates
[Bug 1851596] Review Request: ghc-HsYAML - Pure Haskell YAML 1.2 parser
https://bugzilla.redhat.com/show_bug.cgi?id=1851596 --- Comment #1 from Jens Petersen --- Needed for pandoc, also via doctemplates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
