[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion working copies and repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1856556 Mat Booth changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-20 17:07:58 --- Comment #3 from Mat Booth --- (In reply to Robert-André Mauchin from comment #2) > > Package approved, please fix the aforementioned issue before import. > Of course, see commit https://src.fedoraproject.org/rpms/svnkit/c/76821d3d905a0587d955e168e08ceafb6fb75f84 Thanks for the review, rawhide build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1544232 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion working copies and repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1856556 Bug 1856556 depends on bug 1856553, which changed state. Bug 1856553 Summary: Review Request: jsch-agent-proxy - Proxy to ssh-agent and Pageant in Java https://bugzilla.redhat.com/show_bug.cgi?id=1856553 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion working copies and repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1856556 Bug 1856556 depends on bug 1856557, which changed state. Bug 1856557 Summary: Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java https://bugzilla.redhat.com/show_bug.cgi?id=1856557 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion working copies and repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1856556
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #2 from Robert-André Mauchin ---
- HTTPS required for Maven:
Source1:
https://repo1.maven.org/maven2/org/tmatesoft/svnkit/svnkit/%{version}/svnkit-%{version}.pom
Source2:
https://repo1.maven.org/maven2/org/tmatesoft/svnkit/svnkit-cli/%{version}/svnkit-cli-%{version}.pom
Source3:
https://repo1.maven.org/maven2/org/tmatesoft/svnkit/svnkit-javahl16/%{version}/svnkit-javahl16-%{version}.pom
Otherwise it returns error 501:
501 HTTPS Required.
Use https://repo1.maven.org/maven2/
More information at https://links.sonatype.com/central/501-https-required
Package approved, please fix the aforementioned issue before import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "Apache License 1.1", "BSD 3-clause "New" or "Revised"
License GNU Lesser General Public License", "GPL (v2)", "*No
copyright* GNU Lesser General Public License", "Apache License 2.0",
"GNU Lesser General Public License", "*No copyright* Apache License
2.0", "Public domain Apache License 2.0". 1495 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/svnkit/review-svnkit/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager
[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion working copies and repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1856556 Mat Booth changed: What|Removed |Added Link ID||Fedora Pagure ||releng/issue/9599 --- Comment #1 from Mat Booth --- This is a re-review for unretirement: https://pagure.io/releng/issue/9599 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856556] Review Request: svnkit - Pure Java library to manage Subversion working copies and repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1856556 Mat Booth changed: What|Removed |Added Depends On||1856553, 1856557 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1856553 [Bug 1856553] Review Request: jsch-agent-proxy - Proxy to ssh-agent and Pageant in Java https://bugzilla.redhat.com/show_bug.cgi?id=1856557 [Bug 1856557] Review Request: trilead-ssh2 - SSH-2 protocol implementation in pure Java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
