[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(lemen...@gmail.co |
   |m)  |
Last Closed||2020-05-04 13:35:00



--- Comment #7 from Petr Pisar  ---
No response from the submitter in last 4 years. I will close this review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|jchal...@redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Jan Chaloupka  changed:

   What|Removed |Added

 CC||jchal...@redhat.com,
   ||lemen...@gmail.com
  Flags||needinfo?(lemen...@gmail.co
   ||m)



--- Comment #6 from Jan Chaloupka  ---
Hi Peter,

what was this review intended for? Do you still need it?

Jan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

   Assignee|mario.blaetterm...@gmail.co |nob...@fedoraproject.org
   |m   |



--- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com ---
Sorry, I don't have the time to continue here anymore. Lifting the assignment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 CC|mario.blaetterm...@gmail.co |
   |m   |
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769
Bug 1023769 depends on bug 1010713, which changed state.

Bug 1010713 Summary: create and own %{_datadir}/gocode and 
%{_datadir}/gocode/src
https://bugzilla.redhat.com/show_bug.cgi?id=1010713

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769



--- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com ---
As far as I can see, the problem with the multiple folder ownerships has been
solved in bug #1010713. Can we proceed here (and in bug #1023771)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Lokesh Mandvekar l...@redhat.com changed:

   What|Removed |Added

 Blocks||1086378




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1086378
[Bug 1086378] Review Request: geard - Tool for installing Docker images as
containers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Depends On||1010713




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1010713
[Bug 1010713] create and own %{_datadir}/gocode and %{_datadir}/gocode/src
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Lokesh Mandvekar l...@redhat.com changed:

   What|Removed |Added

 CC||l...@redhat.com



--- Comment #3 from Lokesh Mandvekar l...@redhat.com ---
Hi Peter, Mario:

(In reply to Mario Blättermann from comment #2)


 golang-github-goerlang-dist.spec: I: checking-url
 https://github.com/goerlang/dist/archive/
 453dec63ea12c128128f9d91b11a82dd570119a0.tar.gz (timeout 10 seconds)
 2 packages and 1 specfiles checked; 0 errors, 3 warnings.
 

This might work better for source url:
Source0:
https://%{import_path}/archive/%{commit}/%{realname}-%{shortcommit}.tar.gz
...as in the already existing golang-* packages


 I'm not really happy with the folder ownerships. It seems all your
 golang-github-goerlang-* packages own the folder path
 /usr/share/gocode/src/github.com/goerlang. Well, we have some cases where
 packages may do so, for example for gtk-doc. But in this early state of
 packaging, you could create a dummy package named
 golang-github-goerlang-filesystem which owns this folder. I assume the
 arch-dependent packages in Fedora =19 and EPEL =7 use the same folder, so
 there we couldn't get any problems with.

Just to make sure everyone's on the same page, I'm mentioning Matt Miller's
comment here: https://bugzilla.redhat.com/show_bug.cgi?id=1001300#c24 . I guess
if something new gets decided over here, we'll have to make similar changes to
the existing golang-* packages too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mario.blaetterm...@gmail.co
   ||m
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review?



--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com ---
Taking this for a full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769



--- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6114012

$ rpmlint -i -v *golang-github-goerlang-dist.src: I: checking
golang-github-goerlang-dist.src: I: checking-url
https://github.com/goerlang/dist (timeout 10 seconds)
golang-github-goerlang-dist.src:5: W: mixed-use-of-spaces-and-tabs (spaces:
line 5, tab: line 1)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

golang-github-goerlang-dist.src: I: checking-url
https://github.com/goerlang/dist/archive/453dec63ea12c128128f9d91b11a82dd570119a0.tar.gz
(timeout 10 seconds)
golang-github-goerlang-dist-devel.noarch: I: checking
golang-github-goerlang-dist-devel.noarch: W: summary-ended-with-dot C An
implementation of Erlang node.
Summary ends with a dot.

golang-github-goerlang-dist-devel.noarch: I: checking-url
https://github.com/goerlang/dist (timeout 10 seconds)
golang-github-goerlang-dist.spec:5: W: mixed-use-of-spaces-and-tabs (spaces:
line 5, tab: line 1)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

golang-github-goerlang-dist.spec: I: checking-url
https://github.com/goerlang/dist/archive/453dec63ea12c128128f9d91b11a82dd570119a0.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 3 warnings.


There's one rather cosmetic problem in your spec file. I suggest to use spaces,
this way the spec file looks the same in all text editors, regardless of the
configured tab width.

I'm not really happy with the folder ownerships. It seems all your
golang-github-goerlang-* packages own the folder path
/usr/share/gocode/src/github.com/goerlang. Well, we have some cases where
packages may do so, for example for gtk-doc. But in this early state of
packaging, you could create a dummy package named
golang-github-goerlang-filesystem which owns this folder. I assume the
arch-dependent packages in Fedora =19 and EPEL =7 use the same folder, so
there we couldn't get any problems with.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Blocks||1023776




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1023776
[Bug 1023776] Review Request: eclus - An Erlang Port Mapping Daemon service
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review