[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||capstats-0.21-1.fc20 Resolution|--- |ERRATA Last Closed|2014-06-26 10:30:22 |2014-09-12 10:29:22 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- capstats-0.21-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- capstats-0.21-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- capstats-0.21-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/capstats-0.21-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 --- Comment #10 from Fabian Affolter m...@fabian-affolter.ch --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Fabian Affolter m...@fabian-affolter.ch --- New Package SCM Request === Package Name: capstats Short Description: A command-line tool collecting packet statistics Owners: fab Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|echevemas...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640
Eduardo Echeverria echevemas...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|fedora-review? |fedora-review+
--- Comment #9 from Eduardo Echeverria echevemas...@gmail.com ---
See the diff between the spec an srpm, Please send the patches to the upstream.
Consider this Approved
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/echevemaster/1113640-capstats/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added CC||echevemas...@gmail.com --- Comment #8 from Eduardo Echeverria echevemas...@gmail.com --- Chris, I have Fabian here in Flock, he is asking to me for make this review, Are you agreed with it? or do you want follow the review.? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|i...@cicku.me |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|i...@cicku.me -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Alias||capstats -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added Blocks||979726 (bro) --- Comment #7 from Robin Lee robinlee.s...@gmail.com --- *** Bug 1113641 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=979726 [Bug 979726] bro 2.3 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2014-06-26 10:30:22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 --- Comment #1 from Christopher Meng i...@cicku.me --- *** Bug 1113625 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|CLOSED |NEW CC||i...@cicku.me Resolution|NOTABUG |--- Keywords||Reopened -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 --- Comment #2 from Christopher Meng i...@cicku.me --- What's the rationale of BR cmake then use autoconf? ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com --- Comment #3 from Parag AN(पराग) panem...@gmail.com --- cicku, Always give first priority to the first filed bug/review. So, package review should be done in bug 1113625 and not in bug 1113640 , bug 1113641. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 --- Comment #4 from Christopher Meng i...@cicku.me --- (In reply to Parag AN(पराग) from comment #3) cicku, Always give first priority to the first filed bug/review. So, package review should be done in bug 1113625 and not in bug 1113640 , bug 1113641. LOL. That first one bug 1113625 contains nothing, and this is actually the first one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 --- Comment #5 from Parag AN(पराग) panem...@gmail.com --- In that case bug 1113641 contains more information then ;-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113640] Review Request: capstats - A command-line tool collecting packet statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1113640 --- Comment #6 from Fabian Affolter m...@fabian-affolter.ch --- My connection was pretty bad when I filled the review request. Thanks to back and forth I ended with a couple of bugs. I decided to go with the latest one. (In reply to Christopher Meng from comment #2) What's the rationale of BR cmake then use autoconf? ;) The bro guys switched to cmake for most of their components. configure is used to set options for cmake and the Makefile is a wrapper for it. This is nice for a default installation because people who are not familiar with cmake can just run configure/make/make install. But for packaging their way requires some patching to outsmart the build system that treat configure like it is from an autotools project. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
