[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024

Steve Traylen  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2017-05-31 05:19:56



--- Comment #6 from Steve Traylen  ---
So old, can't remember by why I wanted it. Apologies for the lack of response.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024
Bug 1116024 depends on bug 1116021, which changed state.

Bug 1116021 Summary: Review Request:  rubygem-ruby-prof - a fast ruby profiler
https://bugzilla.redhat.com/show_bug.cgi?id=1116021

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024



--- Comment #5 from Troy Dawson  ---
I'm dropping being a reviewer of this package, and I recommend it be closed
incase someone else wants to create this package.  There has been too long
without any response from the original packager.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024

Troy Dawson  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC|tdaw...@redhat.com  |
   Assignee|tdaw...@redhat.com  |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024



--- Comment #3 from Upstream Release Monitoring 
 ---
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
for f22-candidate and
git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024



--- Comment #4 from Troy Dawson  ---
Well that's weird.  I wonder why doing a scratch build of a different package
would show up here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024

Troy Dawson  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tdaw...@redhat.com
   Assignee|nob...@fedoraproject.org|tdaw...@redhat.com



--- Comment #2 from Troy Dawson  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Not the latest version (0.0.18)

- License file LICENSE.txt is marked as %doc instead of %license
  See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

- Package installs properly.
-- This is because this requires rubygem-ruby-prov (#1116021)
-- There isn't a rule that says you can't work on seveal packages at once. 
Let's see if we can get them both into fedora at the same time.
-- So, I would still pass this, as long at it looks like the dependency is
moving along.

- There is no %check section
-- This would require packages that are not yet in fedora
--- rubygem-turn (not really needed.  Dependency can be removed with 
 sed -i '/require.*turn/ s/^/#/' test/test_helper.rb
--- rubygem-elasticsearch-extentions (#1116030)
-- Since this is a *should* I would pass this without the %check section, but I
would highly encourage you to add the %check when the dependencies are in
fedora.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[-]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license 

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024



--- Comment #1 from Steve Traylen steve.tray...@cern.ch ---
Update reflecting comments in other elasticsearch reviews.

Spec URL:
http://cern.ch/straylen/rpms/rubygem-elasticsearch-extensions/rubygem-elasticsearch-extensions.spec
SRPM URL:
http://cern.ch/straylen/rpms/rubygem-elasticsearch-extensions/rubygem-elasticsearch-extensions-0.0.15-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024
Bug 1116024 depends on bug 1116018, which changed state.

Bug 1116018 Summary: Review Request:  rubygem-ansi - ruby ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1116018

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024

Steve Traylen steve.tray...@cern.ch changed:

   What|Removed |Added

 Depends On||1116021, 1116018




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1116018
[Bug 1116018] Review Request:  rubygem-ansi - ruby ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1116021
[Bug 1116021] Review Request:  rubygem-ruby-prof - a fast ruby profiler
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review