[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Ben Rosser  changed:

   What|Removed |Added

 CC||i...@cicku.me



--- Comment #20 from Ben Rosser  ---
*** Bug 1266011 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GJSNTMFRRTXLJKLK5EKQT3GT56H227X7/

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Richard W.M. Jones  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-08-29 16:09:00



--- Comment #19 from Richard W.M. Jones  ---
https://koji.fedoraproject.org/koji/taskinfo?taskID=21534688

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #18 from Richard W.M. Jones  ---
https://pagure.io/releng/issue/7003

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #17 from Richard W.M. Jones  ---
Thanks Gwyn.  I'm still waiting for permissions to propagate so
I can push to the repo, but in the meantime here is a scratch build
for testing purposes:

https://koji.fedoraproject.org/koji/taskinfo?taskID=21526932

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #16 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ocaml-re

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #15 from Richard W.M. Jones  ---
https://pagure.io/releng/fedora-scm-requests/issue/596

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Richard W.M. Jones  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #14 from Richard W.M. Jones  ---
All the issues found and fixed in the original package review
remain fixed in the update package in comment 11, therefore
I'm approving this again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Richard W.M. Jones  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #13 from Richard W.M. Jones  ---
Grumble ..

$ fedrepo-req -t 1174036 ocaml-re
Error: The Bugzilla ticket's review was approved over 60 days ago

I will give the new package in comment 11 and quick re-review ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Richard W.M. Jones  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|rjo...@redhat.com
  Flags|needinfo?(j...@recoil.org)   |
   |needinfo?(j...@recoil.org)   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
  Flags||needinfo?(j...@recoil.org)



--- Comment #12 from Robert-André Mauchin  ---
> Submitter not responding
>
>When the submitter of a review ticket has not responded to comments for 
> one month, a comment is added to the ticket indicating that the review is 
> stalled and that a response is needed soon.
>If there is no response within one week, the ticket is closed with 
> resolution NOTABUG, and the fedora-review flag is set to the empty value.
>The bug may be set as blocking FE-DEADREVIEW. The intention is to close 
> the bug so that it can be submitted by someone else in a separate bug, and 
> also to make it easy to find bugs closed in this way. 
>
>If the bug is resubmitted by someone else, it is also reasonable to change the 
>resolution on the closed bug to DUPLICATE and mark it as a duplicate of the 
>new bug so that reviewers of the new ticket can easily find the work that was 
>done on the old one.


Jon Ludlam, could you please create the repo and build the package since it has
been accepted? Otherwise, we'll mark this as a dead review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Ben Rosser  changed:

   What|Removed |Added

 Blocks||1486068




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1486068
[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing
distribution packages and dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Ben Rosser  changed:

   What|Removed |Added

 CC||rosser@gmail.com



--- Comment #11 from Ben Rosser  ---
Since the package review was approved, it was proposed on the devel list that
this just get imported.

However, the spec and SRPM are no longer available from the links above, and
there have been several new releases of ocaml-re since 2015. (Also, I needed a
build of ocaml-re to start looking at ocaml-dose, another opam dependency).

I grabbed a copy of the spec from Jon's copr repository:
http://copr-dist-git.fedorainfracloud.org/cgit/jonludlam/opam/ocaml-re.git/plain/ocaml-re.spec?h=f23,
and updated the version to 1.7.1.

I had to make a minor modification or two to get it to build from that version
of the spec; there's (now?) a configure script upstream, which I just invoked
directly. However the documentation gets put in the wrong place
(%{buildroot}%{_docdir}/re rather than .../ocaml-re), so I remove it in
%install and install it manually.

Otherwise, I made no changes to Jon's package.

Spec URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-re.spec
SRPM URL:
https://tc01.fedorapeople.org/ocaml/opam/ocaml-re-1.7.1-1.fc26.src.rpm

I can open a new review, if you'd prefer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||j...@recoil.org
  Flags||needinfo?(j...@recoil.org)



--- Comment #10 from Igor Gnatenko  ---
still not in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #9 from Jon Ludlam  ---
New upstream release:

Spec URL: http://www.recoil.org/~jon/ocaml-re.spec
SRPM URL: http://www.recoil.org/~jon/ocaml-re-1.4.1-1.fc23.src.rpm

and Koji build as per previous comment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #8 from Upstream Release Monitoring 
 ---
jonludlam's scratch build of ocaml-re-1.4.1-1.fc23.src.rpm for f23 completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11536753

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #5 from Richard W.M. Jones rjo...@redhat.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 LGPL (v2.1 or later), Unknown or generated. 22 files have unknown
 license. Detailed output of licensecheck in /home/rjones/1174036-ocaml-
 re/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: %build honors applicable compiler flags or justifies otherwise.

Consider replacing 'make' with 'make %{?_smp_mflags}' (assuming
that works).

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.

Ocaml:
[x]: This should never happen

RWMJ - I have no idea what this means.  fedora-review is broken.

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: Uses parallel make %{?_smp_mflags} macro.

See comment above.

[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ocaml-re-
 devel

You probably need to add %{?_isa} as described.

[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Richard W.M. Jones rjo...@redhat.com changed:

   What|Removed |Added

 QA Contact|extras...@fedoraproject.org |rjo...@redhat.com
  Flags||fedora-review+



--- Comment #6 from Richard W.M. Jones rjo...@redhat.com ---
This package is APPROVED by rjones, but please check the items
mentioned in the review above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #7 from Jon Ludlam j...@recoil.org ---
Thanks again Richard. Looks like the make %{?_smp_mflags} change breaks the
build. It works for the latest git version, so we can put it in if we upgrade.
I had a quick look through the git log to see if there was an obvious change
that fixed it, but I couldn't immediately see it. I've fixed the {isa} thing
though.

Spec URL: http://www.recoil.org/~jon/ocaml-re.spec
SRPM URL: http://www.recoil.org/~jon/ocaml-re-1.2.2-4.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #4 from Jon Ludlam j...@recoil.org ---
Thanks Richard. Fixed those two.

Spec URL: http://www.recoil.org/~jon/ocaml-re.spec
SRPM URL: http://www.recoil.org/~jon/ocaml-re-1.2.2-3.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Richard W.M. Jones rjo...@redhat.com changed:

   What|Removed |Added

 Blocks||1185099




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1185099
[Bug 1185099] Review Request: opam - A source-based package manager for
OCaml
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Richard W.M. Jones rjo...@redhat.com changed:

   What|Removed |Added

 CC||rjo...@redhat.com



--- Comment #3 from Richard W.M. Jones rjo...@redhat.com ---
Usually better for patches to be '*.patch' since it makes it
clearer what the file is when looking at the git repo.

You probably don't need a newline after %description.  Not sure
what rpm does - whether it ignores it or adds whitespace to the
rpm header.

Rest looks fine to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #1 from Robin Lee robinlee.s...@gmail.com ---
*** Bug 1174035 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036



--- Comment #2 from Robin Lee robinlee.s...@gmail.com ---
*** Bug 1174039 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1174036

Robin Lee robinlee.s...@gmail.com changed:

   What|Removed |Added

 CC||robinlee.s...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review