[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||javawriter-2.5.1-1.fc22 Resolution|--- |ERRATA Last Closed||2015-04-21 14:37:41 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- javawriter-2.5.1-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- javawriter-2.5.1-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 --- Comment #7 from Patrick Uiterwijk puiterw...@redhat.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 Patrick Uiterwijk puiterw...@redhat.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- javawriter-2.5.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/javawriter-2.5.1-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 --- Comment #5 from gil cattaneo punto...@libero.it --- (In reply to Raphael Groner from comment #4) - Are you really sure to rename this package in Fedora to javawriter in contrast to the upstream name javapoet? How can it be found with the classic name as guessed from upstream? Okay, I can see the recent github releases are named javawriter. Maybe we should use the younger fork of google. [?]: Package is named according to the Package Naming Guidelines. the library was originally appointed javawriter and recently has been renamed javapoet. the two libraries are incompatible. the fork of google dagger (https://github.com/google/dagger) uses as you said their fork javawriter ... for me ... a crap ... until i prefer to use the original (Square) release for me there aren't contrast with upstream Square's Javawriter This is a fork of Square's Javapoet intended as a staging ground for changes originating from inside google. While it may vary from Square's, the intention is that all changes end up merged into to Square's repository, and that this fork will only vary temporarily while change is in process. Generally, unless you are depending on features not yet merged you should depend on square's version. We have no plans to do releases, though this fork will publish snapshots on successful merges. https://github.com/google/javapoet/blob/master/README.md For now i prefer use the Square library and not have - Include also %doc CONTRIBUTING.md into %files cause this file tells to sign a special contract about copyright etc. to be allowed for contribution at upstream. Done Maven: [?]: If package contains pom.xml files install it (including depmaps) even when building with ant == Can not check magical maven logic. listed in .mfiles* [?]: %check is present and all tests pass. == Could those test/**/*Test.java files be used to run a short test? Why is it broken? The all test suite use fest-assert-core:2.0M8 and i tried to remove some files but at the end not have one valid *Test.java file for this scope # Unavailable test deps: org.easytesting:fest-assert-core:2.0M8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946
Raphael Groner projects...@smart.ms changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Raphael Groner projects...@smart.ms ---
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
Note: Cannot find LICENSE.txt in rpm(s)
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
== OK cause of %license LICENSE.txt, but warning that this will not work for
EPEL and Fedora 20!
- Are you really sure to rename this package in Fedora to javawriter in
contrast to the upstream name javapoet? How can it be found with the classic
name as guessed from upstream? Okay, I can see the recent github releases are
named javawriter. Maybe we should use the younger fork of google.
Square's Javawriter
This is a fork of Square's Javapoet intended as a staging ground for changes
originating from inside google. While it may vary from Square's, the
intention
is that all changes end up merged into to Square's repository, and that this
fork will only vary temporarily while change is in process. Generally, unless
you are depending on features not yet merged you should depend on square's
version. We have no plans to do releases, though this fork will publish
snapshots on successful merges.
https://github.com/google/javapoet/blob/master/README.md
- Include also %doc CONTRIBUTING.md into %files cause this file tells to sign a
special contract about copyright etc. to be allowed for contribution at
upstream.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 6 files have unknown license. Detailed output of
licensecheck in /home/builder/fedora-
review/1207946-javawriter/licensecheck.txt
== OK. But two files without embedded license text, maybe report that as an
upstream issue.
== The javadoc script is not redistributed and other is test stuff.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[?]: Package is named according to the Package Naming Guidelines.
== Please try to confirm with upstream to use the fork name, see my comment
above.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from gil cattaneo punto...@libero.it --- Thanks! New Package SCM Request === Package Name: javawriter Short Description: A Java API for generating .java source files Upstream URL: https://github.com/square/javapoet Owners: gil Branches: f22 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 gil cattaneo punto...@libero.it changed: What|Removed |Added Summary|Review Request: javapoet - |Review Request: javawriter |A Java API for generating |- A Java API for generating |.java source files |.java source files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 --- Comment #3 from gil cattaneo punto...@libero.it --- Spec URL: https://gil.fedorapeople.org/javawriter.spec SRPM URL: https://gil.fedorapeople.org/javawriter-2.5.1-1.fc20.src.rpm - revert previous changes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 Raphael Groner projects...@smart.ms changed: What|Removed |Added Status|NEW |ASSIGNED CC||projects...@smart.ms Assignee|nob...@fedoraproject.org|projects...@smart.ms Flags||fedora-review? --- Comment #1 from Raphael Groner projects...@smart.ms --- Taken. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1207946] Review Request: javawriter - A Java API for generating .java source files
https://bugzilla.redhat.com/show_bug.cgi?id=1207946 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1207948 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1207948 [Bug 1207948] Review Request: dagger - A fast dependency injector for Android and Java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
