[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394



--- Comment #12 from Fedora Update System  ---
python-pytest-watch-4.1.0-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-08-22 12:52:54



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394



--- Comment #11 from Fedora Update System  ---
python-pytest-watch-4.1.0-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394
Bug 1360394 depends on bug 1360383, which changed state.

Bug 1360383 Summary: python-watchdog is missing some requires
https://bugzilla.redhat.com/show_bug.cgi?id=1360383

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394



--- Comment #10 from Fedora Update System  ---
python-pytest-watch-4.1.0-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7631bdb73b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
python-pytest-watch-4.1.0-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a4fbc7e0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394



--- Comment #8 from Fedora Update System  ---
python-pytest-watch-4.1.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a4fbc7e0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394



--- Comment #7 from Fedora Update System  ---
python-pytest-watch-4.1.0-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7631bdb73b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394



--- Comment #6 from Fedora Update System  ---
python-pytest-watch-4.1.0-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9f52d32bb1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pytest-watch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394



--- Comment #4 from Julien Enselme  ---
Thanks for the review.

> You can change it to R: python-watchdog, until python-watchdog is updated.

Will do.

> I'd recommend asking for co-maintainership on python-watchdog

Done. Working on an update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Package is APPROVED.

It currently fails to install because of the python2-watchdog missing
dependency. You can change it to R: python-watchdog, until python-watchdog is
updated.

I'd recommend asking for co-maintainership on python-watchdog. That package
requires a major update: %py3dir usage should be removed, a new version is out,
tests should be enabled because the PR to package them was merged, the spec
file should be cleaned up, etc. I'm sure pingou wouldn't mind the help :), and
it'll be useful in the future since python-pytest-watch and python-watchdog are
closely related.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394



--- Comment #2 from Julien Enselme  ---
- Remove usage of uneeded %%sum macro
- Correct symlink order
- Don't remove upstream egg-info

> Scripts are symlinked in the opposite way to what should be

Thanks for pointing that out.

SPEC URL: http://dl.jujens.eu/SPECS/python-pytest-watch.spec
SRPM URL: http://dl.jujens.eu/SRPMS/python-pytest-watch-4.1.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360394] Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360394

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
 Depends On||1360383
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Again, %sum macro is not necessary.

Again, .egg-info doesn't have to be deleted.

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ provides/requires/buildrequires look OK
  (apart from missing python-watchdog)
+ %python_provide macro is used
+ modern python packaging template is used
+ no scriptlets present or necessary

Scripts are symlinked in the opposite way to what should be:
IS: ptw ← ptw-2 ← ptw-2.7
SHOULD BE: ptw → ptw-2 → ptw-2.7
(See /usr/bin/py.test* for an example.)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1360383
[Bug 1360383] python-watchdog is missing some requires
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org