[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659
Bug 1361659 depends on bug 1369102, which changed state.

Bug 1369102 Summary: vdsm violates FHS with /rhev
https://bugzilla.redhat.com/show_bug.cgi?id=1369102

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |WONTFIX




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #39 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Petr Pisar from comment #38)
> (In reply to Petr Pisar from comment #37)
> > Because you removed fedora-review? flag on 2016-09-08

I actually removed fedora-review+ and set fedora-review?, because the package
should not have passed review and was removed.

> I misread the history. Nevertheless your last action on this review as on
> 2016-10-03.

Correct. There were no updates from the submitter since then. I guess we can
close this and let it be resubmitted with a new package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #38 from Petr Pisar  ---
(In reply to Petr Pisar from comment #37)
> Because you removed fedora-review? flag on 2016-09-08

I misread the history. Nevertheless your last action on this review as on
2016-10-03.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Petr Pisar  changed:

   What|Removed |Added

  Flags|needinfo?(ppi...@redhat.com |
   |)   |



--- Comment #37 from Petr Pisar  ---
Because you removed fedora-review? flag on 2016-09-08, and a status of this bug
was changed to NEW on 2020-05-26. A package under review has to have all these
three properties synchronized. Otherwise the review bug falls into an
inconsistent state and that break automation tools that operators over the
reviews. After reading a history of hit bug, I got an impression that nobody
works on this review. If this is not true, you can assign it to yourself, set
fedora-review flag to ?, and move the state into ASSIGNED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

  Flags||needinfo?(ppi...@redhat.com
   ||)



--- Comment #36 from Dominik 'Rathann' Mierzejewski  ---
@Petr, why have you removed my assignment to this review request?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Assignee|domi...@greysector.net  |nob...@fedoraproject.org
  Flags|fedora-review?  |




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #35 from Nir Soffer  ---
That would be awesome Neal!

Let's discuss this in de...@ovirt.org. Feel free to ping me on #vdsm on
freenode.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com



--- Comment #34 from Neal Gompa  ---
I may be able to. I'll need some help getting started with all this, but I
personally would prefer to run oVirt on Fedora rather than CentOS...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Nir Soffer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW



--- Comment #33 from Nir Soffer  ---
Yaniv is not active in the project in the several years.
We need a contributor that can take the Fedora packaging and maintain it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659
Bug 1361659 depends on bug 1260743, which changed state.

Bug 1260743 Summary: [RFE] Move /rhev to a more standard location
https://bugzilla.redhat.com/show_bug.cgi?id=1260743

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DEFERRED




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659
Bug 1361659 depends on bug 1260743, which changed state.

Bug 1260743 Summary: [RFE] Move /rhev to a more standard location
https://bugzilla.redhat.com/show_bug.cgi?id=1260743

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|WONTFIX |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659
Bug 1361659 depends on bug 1260743, which changed state.

Bug 1260743 Summary: [RFE] Move /rhev to a more standard location
https://bugzilla.redhat.com/show_bug.cgi?id=1260743

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Yaniv Bronhaim  changed:

   What|Removed |Added

  Flags|needinfo?(ybronhei@redhat.c |
   |om) |



--- Comment #32 from Yaniv Bronhaim  ---
maybe someone else can pick it up for now. if you wait for me it might take
awhile..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Sandro Bonazzola  changed:

   What|Removed |Added

  Flags||needinfo?(ybronhei@redhat.c
   ||om)



--- Comment #31 from Sandro Bonazzola  ---
I've seen Peter Robinson pushed an update:
https://koji.fedoraproject.org/koji/buildinfo?buildID=795888

With 4.19.3 being released upstream, I think this is a good time to re-visit
this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Yaniv Bronhaim  changed:

   What|Removed |Added

  Flags|needinfo?(ybronhei@redhat.c |
   |om) |



--- Comment #30 from Yaniv Bronhaim  ---
currently nobody works on it. we plan to re-visit it and finish the review in
later versions. please update the bug status if needed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 CC||ybron...@redhat.com
  Flags||needinfo?(ybronhei@redhat.c
   ||om)



--- Comment #29 from Dominik 'Rathann' Mierzejewski  ---
Ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|domi...@greysector.net
  Flags|fedora-review+  |



--- Comment #28 from Dominik 'Rathann' Mierzejewski  ---
Sure thing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Douglas Schilling Landgraf  changed:

   What|Removed |Added

 Status|ON_QA   |NEW



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Douglas Schilling Landgraf  changed:

   What|Removed |Added

   Assignee|dougsl...@redhat.com|nob...@fedoraproject.org
  Flags|needinfo?(dougsland@redhat. |
   |com)|
   |needinfo?(dougsland@redhat. |
   |com)|



--- Comment #27 from Douglas Schilling Landgraf  ---
Reseting Assignee, Dominik might want to continue from here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #26 from Dominik 'Rathann' Mierzejewski  ---
Some additional nits:

Python subpackage (%package python) is named incorrectly (it should be %package
-n python2-vdsm).

%changelog is not in the prescribed format.

Why are you packaging tests?

The proliferation of subpackages is quite concerning. Please explain why it
doesn't make sense to merge all subpackages that do not bring in additional
dependencies into the main package, namely:
api
hook-allocate_net
hook-checkimages
hook-checkips
hook-diskunmap
hook-ethtool-options
hook-extnet
hook-extra-ipv4-addrs
hook-fakesriov
hook-fakevmstats
hook-faqemu
hook-floppy
hook-hugepages
hook-ipv6
hook-isolatedprivatevlan
hook-macbind
hook-macspoof
hook-nestedvt
hook-noipspoof
hook-numa
hook-openstacknet
hook-pincpu
hook-promisc
hook-qemucmdline
hook-qos
hook-scratchpad
hook-smbios
hook-spiceoptions
hook-vmdisk
hook-vmfex/hook-vmfex-dev (why do they conflict?)
xmlrpc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #25 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Yaniv Bronhaim from comment #2)
[...]
> >>vdsm.spec:768: E: hardcoded-library-path in 
> >>%{buildroot}/usr/lib/systemd/systemd-vdsmd
> vdsm.spec:769: E: hardcoded-library-path in
> %{buildroot}/usr/lib/systemd/system-preset/85-vdsmd.preset
> vdsm.spec:904: E: hardcoded-library-path in /usr/lib/systemd/systemd-vdsmd
> vdsm.spec:905: E: hardcoded-library-path in
> /usr/lib/systemd/system-preset/85-vdsmd.preset
> 
> Using %{_libdir} now

Please note that there's no /usr/lib64/systemd, so using %{_libdir} is actually
wrong in this case.

> >>vdsm.spec: W: invalid-url Source0: vdsm-4.18.999.tar.gz
> 
> Changed to https://bronhaim.fedorapeople.org/%{vdsm_name}-%{version}.tar.gz
> and I'll upload the tar there

Is there no upstream project with releases for this? Having a source without an
URL is acceptable if justified. A method of obtaining the source tarball should
be provided in a comment or a tarball generation script should be provided.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #24 from Dominik 'Rathann' Mierzejewski  ---
Speaking just for myself now, I note that this package should not have passed
review for other reasons as well.

1. rpmlint errors and warnings were not addressed at all. I can see some of
them being noted, but they're not fixed in the package.
2. Debug package is disabled with a wrong justification. It doesn't matter that
the main package is only a metapackage, binary debuginfo from all subpackages
will be collected into vdsm-debuginfo automatically. If all subpackages are
noarch, then just BuildArch: noarch in the main package is enough and should be
removed from all subpackages.
3. ExclusiveArch is not explained (and you should use ExcludeArch: instead
unless it's well-justified).
4. Obsolete BR: systemd-units.
5. Unexplained %ifarch x86_64 in line 127.
6. Unexplained Conflicts: in line 275.

And that's after a quick look at the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #23 from Dominik 'Rathann' Mierzejewski  ---
FESCo discussed this during the last meeting and we request that vdsm be
untagged from all branches and a re-review performed. The FHS violation must be
corrected before it will be permitted back into Fedora:

https://meetbot.fedoraproject.org/fedora-meeting/2016-09-02/fesco.2016-09-02-16.11.log.html#l-414

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659
Bug 1361659 depends on bug 1369102, which changed state.

Bug 1369102 Summary: vdsm violates FHS with /rhev
https://bugzilla.redhat.com/show_bug.cgi?id=1369102

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|DUPLICATE   |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #22 from Fedora Update System  ---
vdsm-4.18.999-440.git0bb7717.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Nir Soffer  changed:

   What|Removed |Added

  Flags||needinfo?(dougsland@redhat.
   ||com)



--- Comment #21 from Nir Soffer  ---
(In reply to Douglas Schilling Landgraf from comment #7)
> #2 Use %{?_smp_mflags}
> make %{?_smp_mflags} DESTDIR=%{buildroot} install

I tested this on my laptop:

 $ for i in `seq 10`; do rm -rf /home/nsoffer/tmp/root/*; /usr/bin/time -f %E
make -j4 DESTDIR=/home/nsoffer/tmp/root install 2>&1 | tail -n 1; done
 0:04.02
 0:04.05
 0:04.05
 0:04.11
 0:03.93
 0:03.94
 0:03.91
 0:04.05
 0:03.97
 0:04.01

 $ for i in `seq 10`; do rm -rf /home/nsoffer/tmp/root/*; /usr/bin/time -f %E
make DESTDIR=/home/nsoffer/tmp/root install 2>&1 | tail -n 1; done
 0:04.19
 0:04.31
 0:04.21
 0:04.48
 0:04.34
 0:04.20
 0:04.27
 0:04.49
 0:04.26
 0:04.40

I don't see any significant improvement, but I see risk of races
during install, so I don' think this is a good idea.

 $ for i in `seq 10`; do make clean >/dev/null 2>&1; /usr/bin/time -f %E make
-j4 2>&1 | tail -n 1; done
 0:01.06
 0:01.04
 0:01.08
 0:01.22
 0:01.07
 0:01.06
 0:01.10
 0:01.13
 0:01.08
 0:01.21

 $ for i in `seq 10`; do make clean >/dev/null 2>&1; /usr/bin/time -f %E make
2>&1 | tail -n 1; done
 0:01.50
 0:01.99
 0:01.95
 0:01.87
 0:01.84
 0:01.88
 0:01.75
 0:02.11
 0:01.77
 0:01.71

This is significantly faster, but it save less then a second,
so I don't think we should use it.

This also breaks when updating the spec, so it requires more
debugging if we do want this sub-second improvement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Nir Soffer  changed:

   What|Removed |Added

 CC||nsof...@redhat.com
  Flags||needinfo?(dougsland@redhat.
   ||com)



--- Comment #20 from Nir Soffer  ---
(In reply to Douglas Schilling Landgraf from comment #17)
> There is a depends bug, moving back to assign.

We cannot fix this bug for 4.0, as this break backward compatibility.

For example, existing setup (e.g. ovirt-3.6) with running vms is using /rhev/*
for all disks:

/rhev/data-center/pool-id/domain-id/images/image-id/volume-id

During live migrating to a host running new version (e.g. ovirt-4.0), a new
vm is started on the destination host, using the same configuration as the old
vm, meaning the path to the disk will be the same.

If we move /rhev to the proper location (e.g. /run/vdsm/data-center), live vm
migration from older hosts will not be possible. Same issue exists when live
migrating vms from new version using /run/vdsm ot old version using /rhev.

So this change will require stopping running vms and starting them on hosts
using different disk location. This may be a big problem for users, so it is 
not possible to change in 4.0.

For the next major version, we plan to dynamically change the path to the disks
during migration, enabling migration from old version using /rhev to new
version
using /run/vdsm. Since this is a very risky change, there is no way we can do
this in a stable version (4.0). Only critical fixes are allowed in 4.0.

I think we should remove the dependency on bug 1260743.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #19 from Fedora Update System  ---
vdsm-4.18.999-440.git0bb7717.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4df131ccd3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #18 from Douglas Schilling Landgraf  ---
Yaniv, please work on this issue or/and open a ticket in fesco to see their
opinion about an exception.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Douglas Schilling Landgraf  changed:

   What|Removed |Added

 Status|MODIFIED|ASSIGNED



--- Comment #17 from Douglas Schilling Landgraf  ---
There is a depends bug, moving back to assign.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659
Bug 1361659 depends on bug 1369102, which changed state.

Bug 1369102 Summary: vdsm violates FHS with /rhev
https://bugzilla.redhat.com/show_bug.cgi?id=1369102

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Yaniv Bronhaim  changed:

   What|Removed |Added

 Depends On||1260743




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1260743
[Bug 1260743] [RFE] Move /rhev to a more standard location
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #16 from Fedora Update System  ---
vdsm-4.18.999-440.git0bb7717.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4df131ccd3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Neal Gompa  changed:

   What|Removed |Added

 Depends On||1369102




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1369102
[Bug 1369102] vdsm violates FHS with /rhev
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Jon Ciesla  changed:

   What|Removed |Added

  Flags|needinfo?(limburgher@gmail. |
   |com)|



--- Comment #15 from Jon Ciesla  ---
As package admin you can request the branch in pkgdb and it will be created.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
vdsm-4.18.999-440.git0bb7717.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-91ab48b87c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Yaniv Bronhaim  changed:

   What|Removed |Added

 CC||limburg...@gmail.com
 Blocks||1368675
  Flags||needinfo?(limburgher@gmail.
   ||com)



--- Comment #13 from Yaniv Bronhaim  ---
Can you help with f25 branch as well?


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368675
[Bug 1368675] No package  vdsm for F25
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #12 from Fedora Update System  ---
vdsm-4.18.999-440.git0bb7717.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-91ab48b87c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #11 from Yaniv Bronhaim  ---
New Package SCM Request
===
Package Name: VDSM
Short Description: VDSM service is required by a oVirt to manage Linux hosts.
VDSM manages and monitors the host's storage, memory and networks as well as
virtual machine creation, other host administration tasks, statistics
gathering, and log collection.
Owners: bronhaim
Branches: f23 f24 f25
InitialCC: dougsland

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Douglas Schilling Landgraf  changed:

   What|Removed |Added

External Bug ID||oVirt gerrit 62164
  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Douglas Schilling Landgraf  ---
Package re-approved.

This package has been in Fedora for long time and current maintainers are
responsive. Unfortunately, it got retired because one of dep. package was
broken. Additionally, VDSM is very important for the oVirt ecosystem. 

* I see some false positive in rpmlint, as example, %dir statement has been
  used and still complains about dir used but not owned.
* rpmlint complains about explicit-lib-dependency but such package doesn't get
installed if removed from spec.
* wrong-script-interpreter even using /usr/bin/env python
* Incorrect spelling-error warning

Additional item, patch sent to upstream:
Please remove deprecated:
  BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)

* My final suggestion, use jenkins job to run fedora-review tool weekly and
keep the eye on it to find improvements needed, deprecated keys, warnings or
errors.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD
 like)", "PSF (v2;)", "*No copyright* GPL (v2 or later)", "GPL (v2)".
 106 files have unknown license. Detailed output of licensecheck in
 /home/fedora/vdsm/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package requires other packages for directories it uses.
 Note: No known owner of /rhev, /usr/share/vdsm/storage/sdm,
 /usr/lib64/udev/rules.d, /usr/lib64/udev, /usr/lib64/systemd,
 /etc/vdsm/logrotate, /usr/lib/python2.7/site-packages/sos,
 /usr/lib/python2.7/site-packages/sos/plugins, /etc/libvirt/hooks,
 /usr/share/vdsm/storage/sdm/api, /usr/lib64/systemd/system-preset,
 /etc/systemd/system/libvirtd.service.d, /usr/lib/python2.7/site-
 packages/api
[X]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/libexec/vdsm,
 /usr/libexec/vdsm/hooks/before_vm_destroy, /etc/cron.hourly,
 /usr/libexec/vdsm/hooks/after_vm_start,
 /usr/share/vdsm/storage/sdm/api, /etc/libvirt/hooks,
 /usr/libexec/vdsm/hooks/before_vm_migrate_destination,
 /usr/libexec/vdsm/hooks,
 /usr/libexec/vdsm/hooks/before_vm_migrate_source,
 /usr/libexec/vdsm/hooks/after_nic_hotunplug, /usr/lib64/systemd
 /system-preset, /usr/share/vdsm/storage/sdm,
 /etc/systemd/system/libvirtd.service.d, /usr/lib64/systemd,
 /etc/modprobe.d, /etc/vdsm/logrotate,
 /usr/libexec/vdsm/hooks/after_nic_hotplug,
 /usr/libexec/vdsm/hooks/after_device_destroy,
 /usr/share/polkit-1/rules.d, /rhev, /usr/lib64/udev/rules.d,
 /usr/lib/python2.7/site-packages/vdsm/gluster, /etc/sudoers.d,
 /usr/libexec/vdsm/hooks/before_nic_hotplug, /usr/lib/systemd/system,
 /etc/libvirt/nwfilter, /etc/libvirt, /usr/lib/systemd,
 /usr/libexec/vdsm/hooks/after_device_create,
 /usr/libexec/vdsm/hooks/before_device_migrate_destination,
 /usr/libexec/vdsm/hooks/before_device_create,
 /usr/libexec/vdsm/hooks/before_vm_dehibernate,
 /usr/libexec/vdsm/hooks/after_network_setup, /usr/lib/python2.7/site-
 packages/api, /usr/libexec/vdsm/hooks/after_vm_destroy,
 /usr/lib/python2.7/site-packages/sos, /usr/lib64/udev,
 /usr/lib/python2.7/site-packages/sos/plugins,
 /usr/libexec/vdsm/hooks/before_vm_start,
 /usr/libexec/vdsm/hooks/after_device_migrate_destination
[X]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /etc/modprobe.d(kmod)
[X]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[X]: Each %files section contains %defattr if rpm < 4.4
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not 

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #5 from Yaniv Bronhaim  ---
There was an error because of the "rm -rf %{buildroot}" removal 
The following works:
Spec URL: bronhaim.fedorapeople.org/vdsm.spec
SRPM URL: vdsm-4.18.999-380.git4ffbc97.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Yaniv Bronhaim  changed:

   What|Removed |Added

  Flags||needinfo?(dougsland@redhat.
   ||com)



--- Comment #4 from Yaniv Bronhaim  ---
Spec URL: bronhaim.fedorapeople.org/vdsm.spec
SRPM URL: vdsm-4.18.999-338.gitccb9928.fc23.src.rpm


(In reply to Douglas Schilling Landgraf from comment #3)
> 
> 
> $ make tests is failing, fedora-review is failing...

for now I commented out the make tests

> 
> $ whereis python
> python: /usr/bin/python3.5 /usr/bin/python /usr/bin/python2.7-config
> /usr/bin/python2.7 /usr/bin/python3.5m /usr/lib/python3.5 /usr/lib/python2.7
> /usr/lib64/python3.5 /usr/lib64/python2.7 /usr/include/python2.7
> /usr/include/python3.5m /usr/share/man/man1/python.1.gz
> 
> 
> make  check-local
> make[3]: Entering directory '/home/fedora/vdsm/upstream/vdsm-4.18.999/tests'
> *** Running tests.  To skip this step place NOSE_EXCLUDE=.* ***
> *** into your environment.  Do not submit untested code!***
> ../tests/run_tests_local.sh  crossImportsTests.py
> ../tests/run_tests_local.sh: line 14: /usr/local/bin/python: No such file or
> directory
> Makefile:1291: recipe for target 'check-local' failed
> make[3]: *** [check-local] Error 127
> make[3]: Leaving directory '/home/fedora/vdsm/upstream/vdsm-4.18.999/tests'
> Makefile:1141: recipe for target 'check-am' failed
> make[2]: *** [check-am] Error 2
> make[2]: Leaving directory '/home/fedora/vdsm/upstream/vdsm-4.18.999/tests'
> Makefile:993: recipe for target 'check-recursive' failed
> make[1]: *** [check-recursive] Error 1
> make[1]: Leaving directory '/home/fedora/vdsm/upstream/vdsm-4.18.999/tests'
> Makefile:1017: recipe for target 'tests' failed
> make: *** [tests] Error 2
> 
> =
> 
> Additional comments:
> 
> * You can remove the lines below because it's deprecated/obsolete:
>  rm -rf %{buildroot}
>  %defattr(-, root, root, -)
> 

removed 

> * Update the changelog everything you update the spec

This is the upstream code, but I'll start to maintain this change-log as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #3 from Douglas Schilling Landgraf  ---



$ make tests is failing, fedora-review is failing...

$ whereis python
python: /usr/bin/python3.5 /usr/bin/python /usr/bin/python2.7-config
/usr/bin/python2.7 /usr/bin/python3.5m /usr/lib/python3.5 /usr/lib/python2.7
/usr/lib64/python3.5 /usr/lib64/python2.7 /usr/include/python2.7
/usr/include/python3.5m /usr/share/man/man1/python.1.gz


make  check-local
make[3]: Entering directory '/home/fedora/vdsm/upstream/vdsm-4.18.999/tests'
*** Running tests.  To skip this step place NOSE_EXCLUDE=.* ***
*** into your environment.  Do not submit untested code!***
../tests/run_tests_local.sh  crossImportsTests.py
../tests/run_tests_local.sh: line 14: /usr/local/bin/python: No such file or
directory
Makefile:1291: recipe for target 'check-local' failed
make[3]: *** [check-local] Error 127
make[3]: Leaving directory '/home/fedora/vdsm/upstream/vdsm-4.18.999/tests'
Makefile:1141: recipe for target 'check-am' failed
make[2]: *** [check-am] Error 2
make[2]: Leaving directory '/home/fedora/vdsm/upstream/vdsm-4.18.999/tests'
Makefile:993: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/home/fedora/vdsm/upstream/vdsm-4.18.999/tests'
Makefile:1017: recipe for target 'tests' failed
make: *** [tests] Error 2

=

Additional comments:

* You can remove the lines below because it's deprecated/obsolete:
 rm -rf %{buildroot}
 %defattr(-, root, root, -)

* Update the changelog everything you update the spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Douglas Schilling Landgraf  changed:

   What|Removed |Added

External Bug ID||oVirt gerrit 61384
  Flags|needinfo?(dougsland@redhat. |
   |com)|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

automat...@ovirt.org changed:

   What|Removed |Added

External Bug ID||oVirt gerrit 61844



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Yaniv Bronhaim  changed:

   What|Removed |Added

  Flags||needinfo?(dougsland@redhat.
   ||com)



--- Comment #2 from Yaniv Bronhaim  ---
New: Using master branch, so the output tar and src.rpm version is different
than the one specified in the description

See my comments inline below

Spec URL: bronhaim.fedorapeople.org/vdsm.spec
SRPM URL: vdsm-4.18.999-338.gite4625d3.fc23.src.rpm


(In reply to Douglas Schilling Landgraf from comment #1)
> Hi Yaniv,
> 
> fedora-review initially shared below, could you please review the following?
> 
> - All build dependencies are listed in BuildRequires, except for any that
>   are listed in the exceptions section of Packaging Guidelines.

I believe that all our build requirements are listed accordingly - do you see
something specific that relates to exceptions section? 

>   Note: These BR are not needed: rpm-build

It was added by purpose as it was needed in https://gerrit.ovirt.org/#/c/7955/

> 
> - Uses parallel make %{?_smp_mflags} macro.

For some reason the make fails with -j4 flag :\ still trying to understand why,
so for now I still don't use the macro.

> 
> - Do not use config for tmpfilesdir (%config(noreplace)
> %{_tmpfilesdir}/%{vdsm_name}.conf)
> %{_tmpfilesdir} expands to %{_prefix}/lib/tmpfiles.d which is the location
> that the package's default tmpfile creation scripts should install into.
> %{_tmpfilesdir}/%{name}.conf is not marked as a %config file because it is
> not supposed to be edited by administrators. Administrators can override the
> package's %{name}.conf by placing an identically named file in
> /etc/tmpfiles.d/, but this should very rarely be needed. 
> 

Removed %config(noreplace) from this file which is not needed

> The requires of python-devel must be updated
> - Package contains BR: python2-devel or python3-devel

Require specifically python2-devel - we don't need python3-devel for now

> 
> - Try to reduce the number of output of rpmlint

The warnings we have are:

>> vdsm.spec:159: W: unversioned-explicit-obsoletes %{name}-infra

Added >= 4.16.0 where it was first introduced 

>>vdsm.spec:768: E: hardcoded-library-path in 
>>%{buildroot}/usr/lib/systemd/systemd-vdsmd
vdsm.spec:769: E: hardcoded-library-path in
%{buildroot}/usr/lib/systemd/system-preset/85-vdsmd.preset
vdsm.spec:904: E: hardcoded-library-path in /usr/lib/systemd/systemd-vdsmd
vdsm.spec:905: E: hardcoded-library-path in
/usr/lib/systemd/system-preset/85-vdsmd.preset

Using %{_libdir} now

>>vdsm.spec: W: invalid-url Source0: vdsm-4.18.999.tar.gz

Changed to https://bronhaim.fedorapeople.org/%{vdsm_name}-%{version}.tar.gz and
I'll upload the tar there

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Douglas Schilling Landgraf  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



--- Comment #1 from Douglas Schilling Landgraf  ---
Hi Yaniv,

fedora-review initially shared below, could you please review the following?

- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: rpm-build

- Uses parallel make %{?_smp_mflags} macro.

- Do not use config for tmpfilesdir (%config(noreplace)
%{_tmpfilesdir}/%{vdsm_name}.conf)

%{_tmpfilesdir} expands to %{_prefix}/lib/tmpfiles.d which is the location that
the package's default tmpfile creation scripts should install into.
%{_tmpfilesdir}/%{name}.conf is not marked as a %config file because it is not
supposed to be edited by administrators. Administrators can override the
package's %{name}.conf by placing an identically named file in
/etc/tmpfiles.d/, but this should very rarely be needed. 

The requires of python-devel must be updated
- Package contains BR: python2-devel or python3-devel

- Try to reduce the number of output of rpmlint

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Douglas Schilling Landgraf  changed:

   What|Removed |Added

 CC||dougsl...@redhat.com
   Assignee|nob...@fedoraproject.org|dougsl...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org