[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603

Matthias Runge  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2020-01-02 04:33:58



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603

Matthias Runge  changed:

   What|Removed |Added

  Flags||needinfo?(d...@redhat.com)



--- Comment #11 from Matthias Runge  ---
Did you go to the step of getting the package added to fedora?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags||fedora-review+



--- Comment #10 from Haïkel Guémar  ---
Approved.

See notes for details.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

=> This point was tested manually and will be fixed after we import
https://bugzilla.redhat.com/show_bug.cgi?id=1364607



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 19 files have
 unknown license. Detailed output of licensecheck in
 /home/haikel/1364603-python-XStatic-Angular-Schema-
 Form/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603



--- Comment #9 from David Moreau Simard  ---
Spec URL:
https://raw.githubusercontent.com/dmsimard/python-XStatic-Angular-Schema-Form-distgit/master/python-XStatic-Angular-Schema-Form.spec
SRPM URL:
https://github.com/dmsimard/python-XStatic-Angular-Schema-Form-distgit/raw/master/python-XStatic-Angular-Schema-Form-0.8.13.0-1.fc24.src.rpm
Description: Angular-Schema-Form JavaScript library packaged for setuptools
(easy_install) / pip.

Generate forms from JSON schemas using AngularJS.
Fedora Account System Username: dmsimard

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=15178436

Note: This last update adds Requires: on three dependencies, of which two are
in-flight with ongoing reviews in:
- python-XStatic-tv4: https://bugzilla.redhat.com/show_bug.cgi?id=1364620
- python-XStatic-objectpath:
https://bugzilla.redhat.com/show_bug.cgi?id=1364607

The dependencies are expressed here:
https://github.com/json-schema-form/angular-schema-form/blob/59e4e2c8d0c50ffb5d65671f28225a53e691bb24/package.json#L21
angular-sanitize is embedded in angular and is met by python-XStatic-Angular.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603



--- Comment #8 from David Moreau Simard  ---
Note: I will update this review shortly -- we identified that
angular-schema-form has runtime dependencies that need to be expressed in the
spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603



--- Comment #7 from Matthias Runge  ---
xstatic is just a wrapper for static libraries. Thus I'd name the package the
wrapped library the same as the library name (or js-angular-schema-form in this
case).
Idea is, if someone will package up js-angular-schema-form from source, you
could just drop the subpackage.

python-xstatic-fontawesome-fonts provides just the wrapper, where the font
package already provides the pieces we needed, thus the font package was added
as dependency.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603



--- Comment #6 from David Moreau Simard  ---
Spec URL:
https://raw.githubusercontent.com/dmsimard/python-XStatic-Angular-Schema-Form-distgit/master/python-XStatic-Angular-Schema-Form.spec
SRPM URL:
https://github.com/dmsimard/python-XStatic-Angular-Schema-Form-distgit/raw/master/python-XStatic-Angular-Schema-Form-0.8.13.0-1.fc24.src.rpm
Description: Angular-Schema-Form JavaScript library packaged for setuptools
(easy_install) / pip.

Generate forms from JSON schemas using AngularJS.
Fedora Account System Username: dmsimard

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=15158879

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603



--- Comment #5 from David Moreau Simard  ---
Hi Haïkel,

1) ack
2) indeed, done and will update spec and src rpm for this and the other two
xstatic package reviews in progress.
3) I compared an existing package (python-XStatic-D3) and it looks like the
files are installed in the same place, especially considering the snippet you
linked.

See attachment [1] for comparison.

[1]: https://bugzilla.redhat.com/attachment.cgi?id=1188213

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603



--- Comment #4 from David Moreau Simard  ---
Created attachment 1188213
  --> https://bugzilla.redhat.com/attachment.cgi?id=1188213=edit
python-XStatic-D3 vs python-XStatic-Angular-Schema-Form

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603



--- Comment #3 from Haïkel Guémar  ---
* To respect guidelines the "xstatic-angular-schema-form-common" should be
renamed as js-%{pypi_name}.
https://fedoraproject.org/wiki/Packaging:JavaScript#Naming_Guidelines
But as it may conflict with a future package for this library -rationale behing
the previous XStatic packages-, it's ok.

* You should version requires on the js library subpackage
Requires:   xstatic-angular-schema-form-common = %{version}-%{release}

The XStatic package has been tested with a specific version, so you'd want to
tie them together so that if you upgrade
python-xstatic-angular-schemar-form-common, it also upgrades the js subpackage.

* keep the data subdirectory in the install path of the js library, it is
actually part of the "API". As you see, Horizon is picking it up at a very
specific location. By relocating it, you'll just break Horizon at runtime.
https://github.com/openstack/horizon/blob/216e67371764ca329a73d63c6d187283b01db067/horizon/karma.conf.js#L87

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603

Haïkel Guémar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||177841 (FE-NEEDSPONSOR)
   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com



--- Comment #2 from Haïkel Guémar  ---
I'll be sponsoring David, reviews are welcome.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603



--- Comment #1 from David Moreau Simard  ---
Spec URL:
https://raw.githubusercontent.com/dmsimard/python-XStatic-Angular-Schema-Form-distgit/master/python-XStatic-Angular-Schema-Form.spec
SRPM URL:
https://github.com/dmsimard/python-XStatic-Angular-Schema-Form-distgit/raw/master/python-XStatic-Angular-Schema-Form-0.8.13.0-1.fc24.src.rpm
Description: Angular-Schema-Form JavaScript library packaged for setuptools
(easy_install) / pip.

Generate forms from JSON schemas using AngularJS.
Fedora Account System Username: dmsimard

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=15147366

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364603

David Moreau Simard  changed:

   What|Removed |Added

 Blocks||1329341 (RDO-NEWTON)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329341
[Bug 1329341] Tracker: Blockers and Review requests for new RDO Newton
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org