[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #14 from Fedora Update System  ---
fwknop-gui-1.3-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #13 from Fedora Update System  ---
fwknop-gui-1.3-2.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-08-19 15:53:55



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #12 from Fedora Update System  ---
fwknop-gui-1.3-2.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #11 from Fedora Update System  ---
fwknop-gui-1.3-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-85b83e5cb8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #10 from Fedora Update System  ---
fwknop-gui-1.3-2.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a9d855e173

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
fwknop-gui-1.3-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e554dd98df

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #8 from Fedora Update System  ---
fwknop-gui-1.3-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a9d855e173

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #7 from Fedora Update System  ---
fwknop-gui-1.3-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-85b83e5cb8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #6 from Fedora Update System  ---
fwknop-gui-1.3-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e554dd98df

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/fwknop-gui

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745



--- Comment #4 from Jakub Jelen  ---
Thank you for reminder. I also completely missed the dist. Current SRPM and
specs, just for the completeness:

Spec URL: https://jjelen.fedorapeople.org/fwknop-gui.spec
SRPM URL: https://jjelen.fedorapeople.org/fwknop-gui-1.3-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365745] Review Request: fwknop-gui - GUI client for Fwknop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365745

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
Summary|Review Request: fwknop-gui  |Review Request: fwknop-gui
   |- a cross platform gui that |- GUI client for Fwknop
   |can save and send knocks to |
   |a server running fwknopd|
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Igor Gnatenko  ---
you missed to address:
> desktop-file-validate %{buildroot}%{_datadir}/applications/fwknop-gui.desktop
> appstream-util validate-relax --nonet 
> %{buildroot}/%{_datadir}/appdata/*.appdata.xml
1. drop "/" after %{buildroot}
2. replace "fwknop-gui" with "%{name}"
3. Move to separate %check section

Also I completely forgot:
> Release: 2
it must be 2%{?dist}

Others looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org