[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-10-08 22:49:08 |2016-11-28 01:18:07



--- Comment #23 from Fedora Update System  ---
gasnet-1.28.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #22 from Fedora Update System  ---
gasnet-1.28.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b706f067d3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #21 from Orion Poplawski  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #20 from Fedora Update System  ---
gasnet-1.28.0-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b706f067d3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #19 from Christoph Junghans  ---
(In reply to Orion Poplawski from comment #17)
> Could you build this for EPEL7?  It mostly builds fine - though I see static
> libs installed when I build locally.
I have no access to the epel7 branch.

This is the error:
+ g++ -shared -Wl,-soname=libammpi-1.28.0.so -Wl,--as-needed -Wl,-z,defs
-Wl,-z,relro -Wl,--rpath-link=. -Wl,--whole-archive
/builddir/build/BUILDROOT/gasnet-1.28.0-1.el7.ppc64le//usr/lib64/mpich/lib/libammpi.a
-Wl,--no-whole-archive -L//usr/lib64/mpich/lib -lmpi -o
/builddir/build/BUILDROOT/gasnet-1.28.0-1.el7.ppc64le//usr/lib64/mpich/lib/libammpi-1.28.0.so
/usr/bin/ld: cannot find -lmpi
collect2: error: ld returned 1 exit status

No idea why that would fail, as MPI_LIB=/usr/lib64/mpich/lib, is there not
libmpi in /usr/lib64/mpich/lib on ppc64le?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #18 from Orion Poplawski  ---
scratch build - https://koji.fedoraproject.org/koji/taskinfo?taskID=16353531

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com



--- Comment #17 from Orion Poplawski  ---
Could you build this for EPEL7?  It mostly builds fine - though I see static
libs installed when I build locally.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #16 from Fedora Update System  ---
gasnet-1.26.4-5.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-08 22:49:08



--- Comment #15 from Fedora Update System  ---
gasnet-1.26.4-5.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #14 from Fedora Update System  ---
gasnet-1.26.4-5.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c3ddd3e289

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #13 from Fedora Update System  ---
gasnet-1.26.4-5.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2927fa727d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #12 from Fedora Update System  ---
gasnet-1.26.4-3.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c3ddd3e289

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #11 from Fedora Update System  ---
gasnet-1.26.4-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2927fa727d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gasnet

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #9 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (3 clause)", "Unknown or generated".
 370 files have unknown license. Detailed output of licensecheck in
 /home/gil/1375744-gasnet/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/valgrind(valgrind-
 devel, valgrind-openmpi, valgrind)
[?]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 317440 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
 Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
 echo $version)) missing?

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gasnet-
 common , gasnet-openmpi , gasnet-mpich , gasnet-devel , gasnet-doc ,
 gasnet-debuginfo
[x]: Package functions as 

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #8 from Christoph Junghans  ---
(In reply to gil cattaneo from comment #7)
> Issues:
> 
> [?]: Package contains the mandatory BuildRequires and Requires:.
>  Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
>  echo $version)) missing?
> for gasnet_trace.pl
Fixed.

> 
> unused-direct-shlib-dependency and undefined-non-weak-symbol should be fixes
> replacing "-shared" with "-Wl,--as-needed"
Added, but there most of the errors are due to the fact MPI_LIB is not in
LD_LIBRARY_PATH, e.g. libgasnet-mpi* is linked against libammpi and libammpi
against libmpi, but all of them live in MPI_LIB and hence cannot be found by
rpmlint.

> 
> NON blocking issues:
> [!]: Latest version is packaged.
>  Is available: gasnet-1.27.5, gasnet-1.28.0-rc1
They haven't officially released it yet (see https://gasnet.lbl.gov/) so let's
stick to 1.26.4 for now.

Spec URL:
https://raw.githubusercontent.com/junghans/fedora-review/master/gasnet/gasnet.spec
SRPM URL:
https://github.com/junghans/fedora-review/raw/master/gasnet/gasnet-1.26.4-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #7 from gil cattaneo  ---
Issues:

[?]: Package contains the mandatory BuildRequires and Requires:.
 Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
 echo $version)) missing?
for gasnet_trace.pl

unused-direct-shlib-dependency and undefined-non-weak-symbol should be fixes
replacing "-shared" with "-Wl,--as-needed"

NON blocking issues:
[!]: Latest version is packaged.
 Is available: gasnet-1.27.5, gasnet-1.28.0-rc1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #6 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
 IGNORE

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (3 clause)", "Unknown or generated".
 370 files have unknown license. Detailed output of licensecheck in
 /home/gil/1375744-gasnet/licensecheck.txt
[?]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/valgrind(valgrind-
 devel, valgrind-openmpi, valgrind)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 317440 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[?]: Package contains the mandatory BuildRequires and Requires:.
 Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
 echo $version)) missing?

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the 

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #5 from Christoph Junghans  ---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15755514

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #4 from Christoph Junghans  ---
(In reply to gil cattaneo from comment #1)
> can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1290337 for me?
Java is not my expertise, but I try.

(In reply to gil cattaneo from comment #2)
> Build fails, seem missing a BRs:
> + popd
> + pushd mpich
> + '%{_mpich_load}'
> /var/tmp/rpm-tmp.RY5bU3: line 106: fg: no job control
> errore: Stato d'uscita errato da /var/tmp/rpm-tmp.RY5bU3 (%build)
> Stato d'uscita errato da /var/tmp/rpm-tmp.RY5bU3 (%build)
> Child return code was: 1
> EXCEPTION: [Error()]
Fixed

(In reply to gil cattaneo from comment #3)
> and before continue, please use for "Requires" this sintax "%{?_isa} =
> %{version}-%{release}"
Fixed

Spec URL:
https://raw.githubusercontent.com/junghans/fedora-review/master/gasnet/gasnet.spec
SRPM URL:
https://github.com/junghans/fedora-review/raw/master/gasnet/gasnet-1.26.4-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #3 from gil cattaneo  ---
and before continue, please use for "Requires" this sintax "%{?_isa} =
%{version}-%{release}"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #2 from gil cattaneo  ---
Build fails, seem missing a BRs:
+ popd
+ pushd mpich
+ '%{_mpich_load}'
/var/tmp/rpm-tmp.RY5bU3: line 106: fg: no job control
errore: Stato d'uscita errato da /var/tmp/rpm-tmp.RY5bU3 (%build)
Stato d'uscita errato da /var/tmp/rpm-tmp.RY5bU3 (%build)
Child return code was: 1
EXCEPTION: [Error()]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



--- Comment #1 from gil cattaneo  ---
can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1290337 for me?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org