[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|---

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #17 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-can -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #16 from Peter Robinson --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #15) > /usr/lib/python3.7/site-packages/test/ → please either move this under > /usr/lib/python3.7/site-packages/can/, > or remove from the package.

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|POST Flags|

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #14 from Peter Robinson --- Updated for review and to latest 3.3.1 upstream release. Dropped the py2 sub-package too. SPEC: as above SRPM: https://pbrobinson.fedorapeople.org/python-can-3.3.1-1.fc30.src.rpm koji:

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #13 from Fabian Affolter --- Thanks guys. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #12 from Peter Robinson --- I'll review and update, apologies I missed there was something awaiting me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #11 from Zbigniew Jędrzejewski-Szmek --- ... or if Peter wants to pick up the packaging, that'd be great of course too. Sorry, I shouldn't have discounted this possibility. tl;dr: I'm happy to finish either this review or a new

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- As of comment #8, there were outstanding dependency issues. I think it'd be fine to close this one as dead review, and simply open a new review. Feel free to assign me as reviewer. -- You

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #9 from Fabian Affolter --- I need python-can for another package. It would be nice if we could go on with the review. BTW, the latest release 3.3.1 [1]. [1] https://github.com/hardbyte/python-can/releases -- You are

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 Fabian Affolter changed: What|Removed |Added Alias||python-can -- You are receiving

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #8 from Zbigniew Jędrzejewski-Szmek --- (In reply to Peter Robinson from comment #7) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #6) > > License and Provides is fixed, but not Requires and the

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #7 from Peter Robinson --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #6) > License and Provides is fixed, but not Requires and the shebang lines. The shebang I was going to report upstream and

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- License and Provides is fixed, but not Requires and the shebang lines. python2-can.noarch: E: wrong-script-interpreter

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 --- Comment #5 from Peter Robinson --- Fixed the typo in requires and the license (I think I got that from the PyPi site). I'll report the lint issues upstream. SPEC: same SRPM:

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

https://bugzilla.redhat.com/show_bug.cgi?id=1376783 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Summary|Review Request: python-can: |Review