[Bug 1377812] Review Request: python-sphinxcontrib-blockdiag - Sphinx " blockdiag" extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377812

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-26 20:34:08



--- Comment #5 from Fedora Update System  ---
python-sphinxcontrib-blockdiag-1.5.5-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377812] Review Request: python-sphinxcontrib-blockdiag - Sphinx " blockdiag" extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377812

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-sphinxcontrib-blockdiag-1.5.5-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0b335cd52

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377812] Review Request: python-sphinxcontrib-blockdiag - Sphinx " blockdiag" extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377812



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-sphinxcontrib-blockdiag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377812] Review Request: python-sphinxcontrib-blockdiag - Sphinx " blockdiag" extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377812



--- Comment #2 from Javier Peña  ---
Thanks for the review. I'll fix versions on BuildRequires when uploading the
package.

About tests, I tried to enable them, but they need some stuff that is not
included in the source tarball
(https://github.com/blockdiag/sphinxcontrib-blockdiag/tree/master/tests/docs).
I've opened https://github.com/blockdiag/sphinxcontrib-blockdiag/issues/8 to
track this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377812] Review Request: python-sphinxcontrib-blockdiag - Sphinx " blockdiag" extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377812

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Parag AN(पराग)  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Suggestions:
1) You may want to drop versioned BuildRequires or Requires, they should be
working from the existing packaged dependency versions.

2) Try to enable %check for both the subpackages.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "*No copyright* BSD", "Unknown or generated".
 12 files have unknown license. Detailed output of licensecheck in
 /home/parag/1377812-python-sphinxcontrib-blockdiag/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.5/site-
 packages/sphinxcontrib(python3-sphinxcontrib-programoutput, python3
 -sphinxcontrib-fulltoc, python3-sphinxcontrib-spelling, python3
 -sphinxcontrib-issuetracker, python3-sphinxcontrib-bibtex),
 /usr/lib/python2.7/site-packages/sphinxcontrib(python2-sphinxcontrib-
 spelling, python2-sphinxcontrib-programoutput, python2-sphinxcontrib-
 bibtex, python-sphinxcontrib-cheeseshop, python-sphinxcontrib-
 httpdomain, python2-sphinxcontrib-fulltoc, python-sphinxcontrib-
 adadomain, python-sphinxcontrib-issuetracker), /usr/lib/python3.5
 /site-packages/sphinxcontrib/__pycache__(python3-sphinxcontrib-
 programoutput, python3-sphinxcontrib-seqdiag, python3-sphinxcontrib-
 fulltoc)

This looks fine as all these are independent extensions that are getting
installed under /usr/lib/pythonx.x/site-packages/sphinxcontrib

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[Bug 1377812] Review Request: python-sphinxcontrib-blockdiag - Sphinx " blockdiag" extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377812

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org