[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #19 from Fedora Update System  ---
kf5-kirigami-1.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #18 from Fedora Update System  ---
kf5-kirigami-1.1.0-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-09-30 11:51:44 |2016-10-08 22:52:19



--- Comment #17 from Fedora Update System  ---
kf5-kirigami-1.1.0-3.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



--- Comment #16 from Fedora Update System  ---
kf5-kirigami-1.1.0-3.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa4b40fb1e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-09-23 10:04:56 |2016-09-30 11:51:44



--- Comment #15 from Fedora Update System  ---
kf5-kirigami-1.1.0-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #14 from Fedora Update System  ---
kf5-kirigami-1.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-eaa3b46f02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #13 from Fedora Update System  ---
kf5-kirigami-1.1.0-1.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9960e5ece0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #12 from Fedora Update System  ---
kf5-kirigami-1.1.0-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-14fe6f3939

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #11 from Fedora Update System  ---
kf5-kirigami-1.1.0-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa4b40fb1e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Markus S.  changed:

   What|Removed |Added

 CC||kamika...@web.de



--- Comment #10 from Markus S.  ---
Forgo 1.0 and jump directly to 1.1:
https://www.kde.org/announcements/kirigami-1.1.php
https://techbase.kde.org/Kirigami

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #9 from Fedora Update System  ---
kf5-kirigami-1.0.2-2.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-14fe6f3939

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #8 from Fedora Update System  ---
kf5-kirigami-1.0.2-2.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9960e5ece0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #7 from Fedora Update System  ---
kf5-kirigami-1.0.2-2.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa4b40fb1e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-09-23 10:04:56



--- Comment #6 from Rex Dieter  ---
imported, thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-kirigami

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fl@sh  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Fl@sh  ---
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #3 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-kirigami.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kf5/kf5-kirigami-1.0.2-2.fc24.src.rpm

%changelog
* Fri Sep 23 2016 Rex Dieter  - 1.0.2-2
- refresh spec/srpm for review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fl@sh  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|alex.mail.1...@gmail.com



--- Comment #2 from Fl@sh  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages// << scratch build is present
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or
 generated". 46 files have unknown license. Detailed output of
 licensecheck in /home/Flash/Downloads/review-
 kf5-kirigami/licensecheck.txt // << used common LGPLv2 license
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
 Note: Using prebuilt rpms.// << scratch build is present
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 901120 bytes in 66 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.

= SHOULD items =

Generic:
[x]: Reviewer should test that the package builds in mock.
 // << scratch build is present
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and 

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fl@sh  changed:

   What|Removed |Added

 CC||alex.mail.1...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Rex Dieter  changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)
  Alias||kf5-kirigami



--- Comment #1 from Rex Dieter  ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15750229

# rpmlint
kf5-kirigami.x86_64: W: no-documentation
kf5-kirigami-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-kirigami-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 4 warnings.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org