[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432

Alec Leamas  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2017-02-08 08:10:29



--- Comment #10 from Alec Leamas  ---
Closing as per policy for stalled reviews. I'm open to resurrect it.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432



--- Comment #9 from Alec Leamas  ---
This review has been stalled for too long. Could you please provide som
feedback here?

Just to be clear: this is the first step in the stalled reviews policy handling

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432



--- Comment #8 from Alec Leamas  ---
Ping?!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432



--- Comment #7 from Alec Leamas  ---
Hm... note that the bundling guidelines have changed [1], bottom line is that
you are not required to unbundle if the bundled code isn't packaged already.  
For example, I'd think twice before unbundling some of this python code. The
alternative is to bundle it properly with a virtual Provides: etc.

From a review standpoint I'm mostly concerned with the fonts and large,
standard javascript libraries such as jquery and react; I think these should
unbundled. I'm also surprised that the installation code doesn't minify the
javascript libs. Here are examples of react (again) which is 650k, this is  a
lot to download in a webpage. It should be minified in production, preferably
in a patch which could be upstreamed. The proper solution would be to use some
bundling tool like webpack or so, but this is probably beyond the scope of
packaging.

I'm also concerned with the licenses. The list produced by fedora-review is a
good starter for a working license break-down.


[1]
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432



--- Comment #6 from Björn "besser82" Esser  ---
(In reply to Alec Leamas from comment #5)
> Some initial remarks, before going into the review:
> 
>- I see all sorts of licenses in the code: Apache, BSD, GPLv3, MIT... can
> you review this? The LGPLv3 for everything doesn't seem OK.
>   - Here seems to be some bundled, minified javascript libraries such as
> react. Please refer to https://fedoraproject.org/wiki/Packaging:JavaScript. 
> 
> Here is also things like (./odoo/addons/l10n_cr/__init__.py:)

Yeah, I found a lot of stuff to unbundle: fonts, js, python-code  :/


> At top;
> # Part of Odoo. See LICENSE file for full copyright and licensing details.
> 
> line 8-9
> #First author: Carlos Vásquez 
> (ClearCorp S.A.)
> #Copyright (c) 2010-TODAY ClearCorp S.A. (http://clearcorp.co.cr). All
> rights reserved
> 
> To me, this doesn't make sense. It looks like the author has claimed all
> rights, and published under a MIT license. And then odoo has pasted there
> own license on top, more or less hijacking the code. I am not a lawyer, but
> this looks fishy. Thoughts?

For the MIT-License it is fine this way, since this license explicitly allows
relicensing / sublicensing.  See fulltext: https://opensource.org/licenses/MIT

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432



--- Comment #5 from Alec Leamas  ---
Some initial remarks, before going into the review:

   - I see all sorts of licenses in the code: Apache, BSD, GPLv3, MIT... can
you review this? The LGPLv3 for everything doesn't seem OK.
  - Here seems to be some bundled, minified javascript libraries such as react.
Please refer to https://fedoraproject.org/wiki/Packaging:JavaScript. 

Here is also things like (./odoo/addons/l10n_cr/__init__.py:)

At top;
# Part of Odoo. See LICENSE file for full copyright and licensing details.

line 8-9
#First author: Carlos Vásquez  (ClearCorp
S.A.)
#Copyright (c) 2010-TODAY ClearCorp S.A. (http://clearcorp.co.cr). All
rights reserved

To me, this doesn't make sense. It looks like the author has claimed all
rights, and published under a MIT license. And then odoo has pasted there own
license on top, more or less hijacking the code. I am not a lawyer, but this
looks fishy. Thoughts?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432

Alec Leamas  changed:

   What|Removed |Added

 CC||leamas.a...@gmail.com
   Assignee|nob...@fedoraproject.org|leamas.a...@gmail.com



--- Comment #4 from Alec Leamas  ---
Being the responsible for the predecessor (which should have been orphaned long
time ago) this is my duty.  WIll look into into it on a few days.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432



--- Comment #3 from Björn "besser82" Esser  ---
Updated package:

  Dependencies have fully landed in fc25 and Rawhide.


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=16211714


Urls:

  Spec URL:  https://besser82.fedorapeople.org/review/odoo.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/odoo-10.0.20161026-0.1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432
Bug 1379432 depends on bug 1379421, which changed state.

Bug 1379421 Summary: Review Request: python-psycogreen - Psycopg2 integration 
with co-routine libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1379421

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432
Bug 1379432 depends on bug 1379421, which changed state.

Bug 1379421 Summary: Review Request: python-psycogreen - Psycopg2 integration 
with co-routine libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1379421

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432
Bug 1379432 depends on bug 1379421, which changed state.

Bug 1379421 Summary: Review Request: python-psycogreen - Psycopg2 integration 
with co-routine libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1379421

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432
Bug 1379432 depends on bug 1380671, which changed state.

Bug 1380671 Summary: Review Request: python-jcconv - JapaneseCharacterCONVerter
https://bugzilla.redhat.com/show_bug.cgi?id=1380671

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432



--- Comment #2 from Björn "besser82" Esser  ---
Updated package:

Urls:

  Spec URL:  https://besser82.fedorapeople.org/review/odoo.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/odoo-9.0c.20161003-0.1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432

Björn "besser82" Esser  changed:

   What|Removed |Added

 Depends On||1380671 (python-jcconv)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1380671
[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432



--- Comment #1 from Björn "besser82" Esser  ---
Correct urls:

  Spec URL:  https://besser82.fedorapeople.org/review/odoo.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/odoo-9.0c.20160923-0.1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432

Björn "besser82" Esser  changed:

   What|Removed |Added

 Depends On||1379421 (python-psycogreen)
  Alias||odoo




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1379421
[Bug 1379421] Review Request: python-psycogreen - Psycopg2 integration with
co-routine libraries
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org