[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917

Fedora Update System  changed:

   What|Removed |Added

 Resolution|NEXTRELEASE |ERRATA



--- Comment #11 from Fedora Update System  ---
python-pykwalify-1.7.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #10 from Fedora Update System  ---
python-pykwalify-1.7.0-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-7dae6fb5b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #9 from Fedora Update System  ---
python-pykwalify-1.7.0-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-7dae6fb5b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-12-22 02:47:14



--- Comment #8 from Parag AN(पराग)  ---
Let's close this. These updates are there in testing repository for more than
an year now. Package maintainer should take some action on this update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #7 from Fedora Update System  ---
python-pykwalify-1.5.1-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-dcca303252

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #6 from Fedora Update System  ---
python-pykwalify-1.5.1-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-186d414a86

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #5 from Fedora Update System  ---
python-pykwalify-1.5.1-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-82627c71d1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pykwalify

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Parag AN(पराग)  ---
Looks good.
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #2 from Chandan Kumar  ---
Hello Parag,

Thanks for the review.
Here is the updated
SPEC: https://chandankumar.fedorapeople.org/python-pykwalify.spec
SRPM:
https://chandankumar.fedorapeople.org/python-pykwalify-1.5.1-2.fc24.src.rpm
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16104193

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #1 from Parag AN(पराग)  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
1) Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

==> We have only PyYAML and not python-PyYAML, fix Requires: this for
python2-pykwalify

   Do not write any versions for Requires: lines. Packages in that particular
release should resolve dependencies.

2) Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/doc/python2-pykwalify/README.md
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

==> Remove tests/files/README.md from both the packages, tests files are not
getting installed so don't install its README.md

3) Remove egg-info in %prep end section as below to fix rpmlint errors.
rm -rf *.egg-info

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "JSON MIT/X11 (BSD like)", "Unknown or generated". 110 files
 have unknown license. Detailed output of licensecheck in
 /home/parag/Downloads/1384917-python-pykwalify/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: 

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org