[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-10 12:02:10



--- Comment #12 from Fedora Update System  ---
golang-github-PuerkitoBio-purell-1.1.0-5.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
golang-github-PuerkitoBio-purell-1.1.0-5.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4ebaa73819

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576



--- Comment #10 from Fedora Update System  ---
golang-github-PuerkitoBio-purell-1.1.0-5.fc26 has been submitted as an update
to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4ebaa73819

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576
Bug 1394576 depends on bug 1206883, which changed state.

Bug 1206883 Summary: Review Request: golang-github-PuerkitoBio-urlesc - Package 
urlesc implements query escaping as per RFC 3986.
https://bugzilla.redhat.com/show_bug.cgi?id=1206883

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-PuerkitoBio-purell

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576



--- Comment #8 from Athos Ribeiro  ---
OK! I will do that before building it.

Thank you for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576



--- Comment #7 from Fabio Valentini  ---
One additional nitpick, not a blocker but "nice to have": Please include the
%commit and %shortcommit definitions produced by gofed (according to the used
git tag) in the ".spec header" - this is used by automatic golang tooling for
version tracking.

%global commit 0bcb03f4b4d0a9428594752bd2a3b9aa0a9d4bd4
%global shortcommit %(c=%{commit}; echo ${c:0:7})

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Fabio Valentini  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Fabio Valentini  ---
Looks good to me now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576



--- Comment #5 from Athos Ribeiro  ---
1) Fixed

2 and 3 were changes from another version which I forgot to remove. Both are
fixed now
4) Fixed

Spec URL:
https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell.spec

SRPM URL:
https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell-1.1.0-4.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576



--- Comment #4 from Fabio Valentini  ---
Initial comments:

1) You can remove the empty %if-%endif block in the -unit-test-devel package
section (at lines 77-80).

2) You are simply disabling one of the tests - have you reported the failing
test upstream? Maybe this can be fixed upstream so you can run all tests for
this package.

3) What does the GOPATH definition in line 136 mean? I don't see the Godeps
directory in the source tarball. Is this there by mistake?

4) You can use the following Source URL to avoid ugly hackery:
https://%{provider_prefix}/archive/v%{version}/%{name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Fabio Valentini  changed:

   What|Removed |Added

 CC||decatho...@gmail.com
   Assignee|nob...@fedoraproject.org|decatho...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Fabio Valentini  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Athos Ribeiro  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |golang-github-PuerkitoBio-p |golang-github-PuerkitoBio-p
   |urell - Purell is a tiny Go |urell - Tiny Go library to
   |library to normalize URLs   |normalize URLs



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org