[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-08-28 18:35:53



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #9 from Elliott Sales de Andrade  ---
Shouldn't this be closed as complete?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

Mukundan Ragavan  changed:

   What|Removed |Added

 Blocks||1382527




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1382527
[Bug 1382527] broken dependency in rawhide
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-ipykernel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #7 from Paulo Andrade  ---
  Many thanks for the review!

  I noticed I forgot your recommendation:

[?]: Packages should try to preserve timestamps of original installed
 files.
 cp -favr docs/_build/html %{buildroot}%{_docdir}/%{name}

I will fix it as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #6 from Paulo Andrade  ---
  Added issue upstream about files without license
information:
https://github.com/ipython/ipykernel/issues/216

  Changed to use parallel make to build docs.

  Looks like an rpmlint issue, the python2 and python3
packages are owners of /usr/share/doc/python-ipykernel

  Use suggested/proper Source0 format.

  I am afraid %check right now cannot be enabled. But
I could create a temporary package, to be retired shortly,
to make %check work. If I recall correctly, debian is
creating some sagemath-$pkgname, so, I could create a
sagemath-ipython (to be retired when updating ipython),
but I believe it is not a good idea to have short-lived
packages.

Spec URL: https://pcpa.fedorapeople.org/python-ipykernel.spec
SRPM URL: https://pcpa.fedorapeople.org/python-ipykernel-4.5.2-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #3 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 61 files have unknown
 license. Detailed output of licensecheck in /home/gil/1406958-python-
 ipykernel/licensecheck.txt

The following source files are without license headers:

ipykernel-4.5.2/ipykernel/__init__.py
ipykernel-4.5.2/ipykernel/_main.py
ipykernel-4.5.2/ipykernel/_version.py
ipykernel-4.5.2/ipykernel/datapub.py
ipykernel-4.5.2/ipykernel/embed.py
ipykernel-4.5.2/ipykernel/ipkernel.py
ipykernel-4.5.2/ipykernel/log.py
ipykernel-4.5.2/ipykernel/comm/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/constants.py
ipykernel-4.5.2/ipykernel/inprocess/tests/__init__.py
ipykernel-4.5.2/ipykernel/pylab/__init__.py
ipykernel-4.5.2/ipykernel/tests/test_pickleutil.py
ipykernel-4.5.2/ipykernel/tests/test_start_kernel.py

ipykernel-4.5.2/docs/conf.py
ipykernel-4.5.2/examples/embedding/inprocess_qtconsole.py
ipykernel-4.5.2/examples/embedding/inprocess_terminal.py
ipykernel-4.5.2/examples/embedding/internal_ipkernel.py
ipykernel-4.5.2/examples/embedding/ipkernel_qtapp.py
ipykernel-4.5.2/examples/embedding/ipkernel_wxapp.py

Please, ask to upstream to confirm the licensing of code and/or content/s, and
add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[x]: License file installed when any subpackage combination is installed.
[?]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/python-ipykernel,
 /usr/lib/python3.6/site-packages, /usr/lib/python3.6
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/python-
 ipykernel, /usr/lib/python3.6/site-packages, /usr/lib/python3.6

  /usr/share/doc/python-ipykernel

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 6 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: 

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #4 from gil cattaneo  ---
Issues:

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 61 files have unknown
 license. Detailed output of licensecheck in /home/gil/1406958-python-
 ipykernel/licensecheck.txt

The following source files are without license headers:

ipykernel-4.5.2/ipykernel/__init__.py
ipykernel-4.5.2/ipykernel/_main.py
ipykernel-4.5.2/ipykernel/_version.py
ipykernel-4.5.2/ipykernel/datapub.py
ipykernel-4.5.2/ipykernel/embed.py
ipykernel-4.5.2/ipykernel/ipkernel.py
ipykernel-4.5.2/ipykernel/log.py
ipykernel-4.5.2/ipykernel/comm/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/constants.py
ipykernel-4.5.2/ipykernel/inprocess/tests/__init__.py
ipykernel-4.5.2/ipykernel/pylab/__init__.py
ipykernel-4.5.2/ipykernel/tests/test_pickleutil.py
ipykernel-4.5.2/ipykernel/tests/test_start_kernel.py

ipykernel-4.5.2/docs/conf.py
ipykernel-4.5.2/examples/embedding/inprocess_qtconsole.py
ipykernel-4.5.2/examples/embedding/inprocess_terminal.py
ipykernel-4.5.2/examples/embedding/internal_ipkernel.py
ipykernel-4.5.2/examples/embedding/ipkernel_qtapp.py
ipykernel-4.5.2/examples/embedding/ipkernel_wxapp.py

Please, ask to upstream to confirm the licensing of code and/or content/s, and
add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[?]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/python-ipykernel,
 /usr/lib/python3.6/site-packages, /usr/lib/python3.6
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/python-
 ipykernel, /usr/lib/python3.6/site-packages, /usr/lib/python3.6

  /usr/share/doc/python-ipykernel


[!]: Uses parallel make %{?_smp_mflags} macro.

 make html >> make %{?_smp_mflags} html


[!]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
 files.
 cp -favr docs/_build/html %{buildroot}%{_docdir}/%{name}

Please; use:
Source0:   
https://github.com/ipython/%{modname}/archive/%{version}/%{modname}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #5 from gil cattaneo  ---
(In reply to gil cattaneo from comment #4)
> Issues:
> 
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "BSD (3 clause)", "Unknown or generated". 61 files have unknown
>  license. Detailed output of licensecheck in /home/gil/1406958-python-
>  ipykernel/licensecheck.txt
> 
> The following source files are without license headers:
> 
> ipykernel-4.5.2/ipykernel/__init__.py
> ipykernel-4.5.2/ipykernel/_main.py
> ipykernel-4.5.2/ipykernel/_version.py
> ipykernel-4.5.2/ipykernel/datapub.py
> ipykernel-4.5.2/ipykernel/embed.py
> ipykernel-4.5.2/ipykernel/ipkernel.py
> ipykernel-4.5.2/ipykernel/log.py
> ipykernel-4.5.2/ipykernel/comm/__init__.py
> ipykernel-4.5.2/ipykernel/inprocess/__init__.py
> ipykernel-4.5.2/ipykernel/inprocess/constants.py
> ipykernel-4.5.2/ipykernel/inprocess/tests/__init__.py
> ipykernel-4.5.2/ipykernel/pylab/__init__.py
> ipykernel-4.5.2/ipykernel/tests/test_pickleutil.py
> ipykernel-4.5.2/ipykernel/tests/test_start_kernel.py
> 
> ipykernel-4.5.2/docs/conf.py
> ipykernel-4.5.2/examples/embedding/inprocess_qtconsole.py
> ipykernel-4.5.2/examples/embedding/inprocess_terminal.py
> ipykernel-4.5.2/examples/embedding/internal_ipkernel.py
> ipykernel-4.5.2/examples/embedding/ipkernel_qtapp.py
> ipykernel-4.5.2/examples/embedding/ipkernel_wxapp.py
> 
> Please, ask to upstream to confirm the licensing of code and/or content/s,
> and add license headers
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#License_Clarification

Most of the code use this license header:
# Copyright (c) IPython Development Team.
# Distributed under the terms of the Modified BSD License.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

gil cattaneo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #2 from Paulo Andrade  ---
Thanks for the initial review.

  Updated to 4.5.2.

  Corrected removal of not necessary files.

  As a note, %check will not work currently. This is a minimal
update, that would really also require updating ipython, but
is enough to have a functional sagemath 7.4 package, that will
at first be the unique package using it. I requested ipython
update at https://bugzilla.redhat.com/show_bug.cgi?id=1408250
  The package will work with sagemath 7.4 because sagemath
7.4, in my still WIP package, will bundle ipython 5.

Spec URL: https://pcpa.fedorapeople.org/python-ipykernel.spec
SRPM URL: https://pcpa.fedorapeople.org/python-ipykernel-4.5.2-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
Is available a new release 4.5.2
https://github.com/ipython/ipykernel/tags
Please, consider upgrading

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org