[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851



--- Comment #10 from Fedora Update System  ---
xplayer-plparser-1.0.2-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-09 23:54:58



--- Comment #9 from Fedora Update System  ---
xplayer-plparser-1.0.2-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851



--- Comment #8 from Fedora Update System  ---
xplayer-plparser-1.0.2-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef33e1ec72

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
xplayer-plparser-1.0.2-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-590fc86e51

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851



--- Comment #5 from Fedora Update System  ---
xplayer-plparser-1.0.2-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-590fc86e51

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851



--- Comment #6 from Fedora Update System  ---
xplayer-plparser-1.0.2-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef33e1ec72

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

leigh scott  changed:

   What|Removed |Added

 Blocks|1424871 (xplayer)   |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1424871
[Bug 1424871] Review Request: xplayer - A generic Media Player
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/xplayer-plparser

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

leigh scott  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co
   ||m
  Flags||fedora-review+



--- Comment #3 from leigh scott  ---
Approved

Please fix ownership for (when you import)

%doc %{_datadir}/gtk-doc

change it to

%doc %{_datadir}/gtk-doc/html/%{name}



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL", "GPL (v2 or later)", "Unknown or generated", "MIT/X11
 (BSD like)", "LGPL (v2 or later)", "FSF All Permissive", "GPL (v2)".
 194 files have unknown license. Detailed output of licensecheck in
 /home/leigh/Desktop/1424851-xplayer-plparser/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/girepository-1.0,
 /usr/share/gir-1.0
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/gtk-doc(gnome-
 desktop3-devel, libgnome-keyring-devel, libsecret-devel, gcr-devel,
 polkit-docs, p11-kit-devel, libpeas-devel, harfbuzz-devel,
 libcanberra-devel, json-glib-devel, clutter-gst3-devel, libgdata-
 devel, gnome-bluetooth-libs-devel, gtk-doc), /usr/share/gtk-doc/html
 (gnome-desktop3-devel, libgnome-keyring-devel, libsecret-devel, gcr-
 devel, polkit-docs, p11-kit-devel, libpeas-devel, harfbuzz-devel,
 libcanberra-devel, json-glib-devel, clutter-gst3-devel, libgdata-
 devel, gnome-bluetooth-libs-devel, gtk-doc)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 163840 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: 

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851



--- Comment #2 from Björn "besser82" Esser  ---
(In reply to leigh scott from comment #1)
> .typelib should be moved from -devel to main
> 
> /usr/lib64/girepository-1.0/XplayerPlParser-1.0.typelib
> 
> 
> .gir should be moved from main to -devel
> 
> /usr/share/gir-1.0/XplayerPlParser-1.0.gir

Fixed in updated package.


> These can be removed as gnome-common requires them
> 
> BuildRequires:autoconf
> BuildRequires:automake
> BuildRequires:gettext

Explicit BRs don't hurt, I think…


> Please change this from
> 
> NOCONFIGURE=1 %{_bindir}/gnome-autogen.sh
> 
> 
> to (the commands aren't equal and miss a required macro).
> 
> NOCONFIGURE=1 ./autogen.sh

Well, it doesn't change the result of the build.  Using ./autogen.sh is just
needed for out-of-tree builds…

***

Updated package:

Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/xplayer-plparser.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/xplayer-plparser-1.0.2-0.2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@googlemail.co
   ||m



--- Comment #1 from leigh scott  ---
.typelib should be moved from -devel to main

/usr/lib64/girepository-1.0/XplayerPlParser-1.0.typelib


.gir should be moved from main to -devel

/usr/share/gir-1.0/XplayerPlParser-1.0.gir


These can be removed as gnome-common requires them

BuildRequires:autoconf
BuildRequires:automake
BuildRequires:gettext


Please change this from

NOCONFIGURE=1 %{_bindir}/gnome-autogen.sh


to (the commands aren't equal and miss a required macro).

NOCONFIGURE=1 ./autogen.sh

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1424871 (xplayer)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1424871
[Bug 1424871] Review Request: xplayer - A generic Media Player
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1359390
  Alias||xplayer-plparser




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1359390
[Bug 1359390] Cinnamon X-apps
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org