[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-03 12:09:09



--- Comment #11 from Fedora Update System  ---
nodejs-finalhandler-1.0.0-3.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860
Bug 1424860 depends on bug 1424859, which changed state.

Bug 1424859 Summary: Review Request: nodejs-encodeurl - Encode a URL to a 
percent-encoded form
https://bugzilla.redhat.com/show_bug.cgi?id=1424859

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
nodejs-finalhandler-1.0.0-3.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-defe185ad1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860



--- Comment #9 from Fedora Update System  ---
nodejs-finalhandler-1.0.0-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-defe185ad1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-finalhandler

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Piotr Popieluch  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review+



--- Comment #7 from Piotr Popieluch  ---
looks good besides the two point mentioned before, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860



--- Comment #6 from Piotr Popieluch  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 11 files have
 unknown license. Detailed output of licensecheck in /home/piotr
 /fedora-scm/1424860-nodejs-finalhandler/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[!]: Spec file according to URL is the same as in SRPM.
 Note: Spec file as given by url is not the same as in SRPM (see
 attached diff).
 See: (this test has no URL)
[x]: Rpmlint is 

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Piotr Popieluch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #5 from Piotr Popieluch  ---
[!]: Spec file according to URL is the same as in SRPM.
 Note: Spec file as given by url is not the same as in SRPM (see
 attached diff).
 See: (this test has no URL)


Github source URL does not match the guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags

Source0:https://github.com/pillarjs/finalhandler/archive/v%{version}.tar.gz

should be:

Source0: 
https://github.com/pillarjs/finalhandler/archive/v%{version}/%{npm_name}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860



--- Comment #4 from Zuzana Svetlikova  ---
Rebuilt with updated spec:
Spec URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-finalhandler/nodejs-finalhandler.spec
SRPM URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-finalhandler/nodejs-finalhandler-1.0.0-3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860
Bug 1424860 depends on bug 1424859, which changed state.

Bug 1424859 Summary: Review Request: nodejs-encodeurl - Encode a URL to a 
percent-encoded form
https://bugzilla.redhat.com/show_bug.cgi?id=1424859

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860



--- Comment #3 from Piotr Popieluch  ---
any progress?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860
Bug 1424860 depends on bug 1424859, which changed state.

Bug 1424859 Summary: Review Request: nodejs-encodeurl - Encode a URL to a 
percent-encoded form
https://bugzilla.redhat.com/show_bug.cgi?id=1424859

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Piotr Popieluch  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
  Flags||fedora-review-



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Piotr Popieluch  changed:

   What|Removed |Added

 CC||piotr1...@gmail.com



--- Comment #2 from Piotr Popieluch  ---
Missing test br: encodeurl

+ /usr/bin/node -e 'require("./")'
module.js:471
throw err;
^
Error: Cannot find module 'encodeurl'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object.
(/builddir/build/BUILD/finalhandler-1.0.0/index.js:15:17)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
error: Bad exit status from /var/tmp/rpm-tmp.PplufQ (%check)
Bad exit status from /var/tmp/rpm-tmp.PplufQ (%check)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860



--- Comment #1 from Zuzana Svetlikova  ---
Rebuilt with updated spec:
Spec URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-finalhandler/nodejs-finalhandler.spec
SRPM URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-finalhandler/nodejs-finalhandler-1.0.0-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Zuzana Svetlikova  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews),
   ||1094699
 Depends On||1424859




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1094699
[Bug 1094699] nodejs-connect-3.6.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1424859
[Bug 1424859] Review Request: nodejs-encodeurl - Encode a URL to a
percent-encoded form
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org