[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #15 from Fedora Update System  ---
xplayer-1.4.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #14 from Fedora Update System  ---
xplayer-1.4.0-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-09 17:26:00



--- Comment #13 from Fedora Update System  ---
xplayer-1.4.0-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #12 from Fedora Update System  ---
xplayer-1.4.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2f93cdc6a1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #11 from Fedora Update System  ---
xplayer-1.4.0-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-51634ca8db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
xplayer-1.4.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fabcd7db7d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #8 from Fedora Update System  ---
xplayer-1.4.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2f93cdc6a1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #9 from Fedora Update System  ---
xplayer-1.4.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-51634ca8db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #7 from Fedora Update System  ---
xplayer-1.4.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fabcd7db7d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/xplayer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871

leigh scott  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co
   ||m
  Flags||fedora-review+



--- Comment #5 from leigh scott  ---
Approved, please fix the gtkdoc directory ownership when you import.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/lib/.build-
  id/ec/ff2586055a416a013007c299a680fe9ee3fcc9
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
- glib-compile-schemas is run in %postun and %posttrans if package has
  *.gschema.xml files.
  Note: gschema file(s) in xplayer
  See:
  http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1064960 bytes in 4 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in xplayer
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or
 generated", "MIT/X11 (BSD like)", "MPL (v1.1) GPL (v2 or later) or
 LGPL (v2.1 or later)", "*No copyright* GPL (v2 or later)", "GPL (v2 or
 later) (with incorrect FSF address)", "BSD (3 clause)", "LGPL (v2.1 or
 later)", "FSF All Permissive", "GPL (v2)", "GPL (v2 or later) LGPL".
 355 files have unknown license. Detailed output of licensecheck in
 /home/leigh/Desktop/1424871-xplayer/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/help/pl, /usr/share/help/pa

 It's someone elses job to own it!, so why should we care?


[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/help/fi,
 /usr/share/help/uk, /usr/share/help/de, /usr/share/help/da,
 /usr/share/help/sv, /usr/share/help/fr, /usr/share/help/pl,
 /usr/share/help/C, /usr/share/help/zh_HK, /usr/share/help/ja,
 /usr/share/help/es, /usr/share/help/eu, /usr/share/help/ca,
 /usr/share/help/pa, /usr/share/help/el, /usr/share/help/en_GB,
 /usr/share/help/gl, /usr/share/help/ro, /usr/share/help/pt_BR,
 /usr/share/help/oc, /usr/share/help/it, /usr/share/help/sl,
 /usr/share/help/zh_TW, /usr/share/help/te, /usr/share/help/cs,
 /usr/share/help/bg, /usr/share/help/ru, /usr/share/help/zh_CN


 It's someone elses job to own it!, so why should we care?

[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/gtk-doc(gnome-
 desktop3-devel, libcanberra-devel, libgnome-keyring-devel,
 libxklavier-devel, exo-devel, libgtop2-devel, gcr-devel, polkit-docs,
 p11-kit-devel, libpeas-devel, harfbuzz-devel, libsecret-devel, json-
 glib-devel, clutter-gst3-devel, libxfce4util-devel, libgdata-devel,
 libgweather-devel, gnome-bluetooth-libs-devel, gtk-doc, gtkimageview-
 devel), /usr/share/gtk-doc/html(gnome-desktop3-devel, libcanberra-
 devel, libgnome-keyring-devel, libxklavier-devel, exo-devel,
 libgtop2-devel, gcr-devel, polkit-docs, p11-kit-devel, 

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #4 from Björn "besser82" Esser  ---
Fixed FTBFS / Updated package:

***

Koji Build:

  https://koji.fedoraproject.org/koji/taskinfo?taskID=19421664


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/xplayer.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/xplayer-1.4.0-0.1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #3 from Björn "besser82" Esser  ---
Fixed FTBFS / Updated package:

***

Koji Build:

  https://koji.fedoraproject.org/koji/taskinfo?taskID=19419697


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/xplayer.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/xplayer-1.4.0-0.1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871



--- Comment #2 from leigh scott  ---
Bump!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871

leigh scott  changed:

   What|Removed |Added

 Depends On|1424851 (xplayer-plparser)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1424851
[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@googlemail.co
   ||m



--- Comment #1 from leigh scott  ---
Your srpm fails to build.

checking for intltool >= 0.25...
  testing intltoolize... not found.
***Error***: You must have intltool >= 0.25 installed
  to build xplayer.  Download the appropriate package for
  from your distribution or get the source tarball at
http://ftp.gnome.org/pub/GNOME/sources/intltool/
RPM build errors:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1359390
 Depends On||1424851 (xplayer-plparser)
  Alias||xplayer




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1359390
[Bug 1359390] Cinnamon X-apps
https://bugzilla.redhat.com/show_bug.cgi?id=1424851
[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org